From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.4138.1597493260884253995 for ; Sat, 15 Aug 2020 05:07:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=axTEEArF; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) IronPort-SDR: pfVDkiBm7yPqRAYfTqbadoD618l5QEuo6G1rHjqNWFY4IUK56EV5q6lL3MhqMBlEIC1wJCxlvz +k9Y/wwuKv2A== X-IronPort-AV: E=McAfee;i="6000,8403,9713"; a="142361615" X-IronPort-AV: E=Sophos;i="5.76,316,1592895600"; d="scan'208";a="142361615" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2020 05:07:39 -0700 IronPort-SDR: nPjhZzOUIWLOY2r46dDeZz0Kk461ITQ1VKGojRtU/20TnTx7jg+gesXcZU2OT8Ez0hxoxgpxxA rKbi7uZxMpPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,316,1592895600"; d="scan'208";a="291981215" Received: from unknown (HELO fmsmsx605.amr.corp.intel.com) ([10.18.84.215]) by orsmga003.jf.intel.com with ESMTP; 15 Aug 2020 05:07:39 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sat, 15 Aug 2020 05:07:39 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sat, 15 Aug 2020 05:07:39 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 15 Aug 2020 05:07:38 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 15 Aug 2020 05:07:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a+MFpn8n8LWY8ZbUQHf701HOaDcoKxtBtokLGRCv/ITGuEvoJMoPQi+lUt0zCw0yUYzOHWWMoQDIk2GSGaEaO47sq4J29fxUkyX3tVK+VzMpvDMV5YKa6nSfe1FDY8yYj3P/UDLHFxU9MAuUwjSVtH55h0+15MdEoR2x+/qJfaOukhiW22/4K3lyp2WnkHZfebELXQLW9Y7TVIbjbVAJ5i732g20W6hOZRKzx03vZBavLmTEVjPziaTvURu7kxZ4TuHlhI9XCcyr6DRj25nzL3Uy2G8mBha4Zg/iNL1gtTIRae7aoWlz6ME+xNFr69/y0kMWDozQFtxPdPiTPuvdbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y5A6X0Asu3uoB1wpyATp3i2ODrDqV/cmE9n/GCoKelI=; b=i96SPkgAjtZqvVCfhxTiKMAt9tyGqzKOTlkq+B+5XhNfeGFpg26nxP7ykKXtPfWm4osThUAojJYA1bpuckWUFcjZTTYYGtwaxpvr7dyghID34jbl10b8HO2h0RlFrbgsVI0aGbp5mSOyNvlQ22G5NvZyLEDyFStQShPFuUOmMRmgQVgosAT8dru6iruYS/KTCaSYMm5f8JnZe/O5puPO0mXCgblY/XHUHkwfUFflm76hWdEbkmqEv84l/JnTUledRUeAmH2U8KbXBZI6knn6WihYn3LR5qsOotiJXctv94tp+bL98a7GTihWbf/sunZDgpRVWNzEcnSjOOfNrp9mRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y5A6X0Asu3uoB1wpyATp3i2ODrDqV/cmE9n/GCoKelI=; b=axTEEArFts36zfkgYQSFl6u9uP8Oq1nOtVFjytQYJX4BlY2AmfhvSbSM9/s27cl4uGjsnEhqOCuWAlqs4DZG5cc0z/kkQeCEMAQ0XEtUN1I0wQRgB1ExyOWCGfilo4Y4Pw0qJysTtRwcZ/OBSOEoy8qfJb+fpQRzX4rRHiW2Ejo= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR1101MB2199.namprd11.prod.outlook.com (2603:10b6:910:1a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.22; Sat, 15 Aug 2020 12:07:37 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::163:9209:a92d:812]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::163:9209:a92d:812%6]) with mapi id 15.20.3283.024; Sat, 15 Aug 2020 12:07:37 +0000 From: "Yao, Jiewen" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , "Chiu, Chasel" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH v3 0/8] Need add a FSP binary measurement Thread-Topic: [PATCH v3 0/8] Need add a FSP binary measurement Thread-Index: AQHWcgSnec7iLDTdaUmDUCVpKGQ8uak5FMSg Date: Sat, 15 Aug 2020 12:07:37 +0000 Message-ID: References: <20200814063159.2477-1-qi1.zhang@intel.com> In-Reply-To: <20200814063159.2477-1-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjA2M2ZlMzktOGZlOC00ODkyLThmNzMtZDcwODc1MTdiYmRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZk9tNDJPV2xCVjlzWDUxS0czc1d3QmxlNVJvd3JMNVBIMHRvVmJcL2xwdmxFWHFYWkYrSDVvRlwvN1ZJRFh4RVI2In0= x-ctpclassification: CTP_NT dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.195] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1ea1d29c-d093-44bd-7a55-08d84113cd67 x-ms-traffictypediagnostic: CY4PR1101MB2199: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VZG4Lz1VO92eg+za3kaywzsxBqNgMDjMUlZRvYubKxrHeaSVd+ZIZSyOp2hoITBbpm+bkLib3P2XL8F35HYu8iK4K1+Hgw6upniJcD621kRYLZQKuu1N3GGpluIfLrXIA7bpL4ZVU14GoLWcu0iQQX90KGR9ACVnDtZk24KF1NhxzZu/Zlgp7/qEpLlzHHOUvryIa/UpBjnmYwg6jQ1VM+T8VTnM4o5eH9GPBMiGjeMWGaV6+/g08U8JnSKQiiN1CVgjkpddWPfGTCVqI0z10EMUtseiEU/N8RsvjoEQM1ERvTJsRfhOPLprjABkDXXRNSKwBuMjvpCuRKDlcFiyzRxXnulS3TKfqY4tNk34uWbX8yWv3F4jvaUhrgewY9wU4dO4NC4zKOfw1PaYvTahVg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(376002)(396003)(346002)(136003)(19627235002)(66556008)(66476007)(5660300002)(64756008)(2906002)(76116006)(52536014)(8936002)(66946007)(66446008)(8676002)(54906003)(186003)(966005)(83380400001)(71200400001)(6506007)(53546011)(33656002)(4326008)(7696005)(316002)(478600001)(86362001)(110136005)(107886003)(26005)(55016002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: jWom8fkfa8jEudCmPJFpQgAzFvAsS6QlXsz00VUrp/pMgvzl3zuDhBJKv01k01SyDv8duGM4dyNguw8fiRQfM4WVK4XOvfifQm0r75K3UvjeAfUbFrBasWg4fIcA4Mk7hRX3dJq6S6LKAkJdy6GX9APlHjsdfm51/jVFO6ulJakFiGD8ay+D2yDHEdXR24fwTlMvowhlZXzTI5R9Xj4grW2wQvx/1xq5rsGebIW3Z2UY+V+/dnLVA2S8JerylG1lhfHYP07sKLGcRd88QZZWClKNVhCsBLuSfR7QuPPwuHAfgxV0aeXSu6nEtUC0lolrQTrBtI1BWGsEGLyYW9a6kfGgA2Ud3wKqe5mOw30lciNRsiQniwWgYJ3W12c85vhNsGreIa2idi9YHFAKxMGQdT+oeZ9pDNYFG+zTUqOiWPmpwxwASm5kG7BmT+2yjn1Ukj3/X34UcWvhLhAhBxAoOW3/d/zc1VisiKYds/knnUMJFZqlTGo5bqqVZTREhHnkr1wIGBX+kHa++V6zoOTvcgHmKBTE3q1rloiLIou/smwhJFB51xgs4VpG32ZPOd5IV5vWF6hlhN4R/cybzxZR9s18RFbFEGIwTDcPfbUbV3iMV1s3Nal3R0Jpgsg/B+lxGbnfqxuVGbsfpyOzmr2sEg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea1d29c-d093-44bd-7a55-08d84113cd67 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Aug 2020 12:07:37.8590 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eMBvPdj4hjo71A+rbz2iswYbbgl+5E/YBmqtGQCzseDDBfhvF7/d4mw2pEJ1Ba8l8ihsa5qbIJAFNh5wZnan9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2199 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Qi Thanks for the update. The name FvEventLogRecordLib is confusing. It is more than Fv. Maybe we can rename it to TcgEventLogRecordLib ? With naming change, the series reviewed-by: Jiewen Yao Thank you Yao Jiewen > -----Original Message----- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Wu, Hao A ; Chi= u, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v3 0/8] Need add a FSP binary measurement >=20 > v3 change: > add a new lib FvEventLogRecordLib for gerneric code. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2376 >=20 > The EDKII BIOS calls FSP API in FSP Wrapper Pkg. > This FSP code need to be measured into TPM. >=20 > We need add a generic module in FSP Wrapper Pkg code to measure: > 1) FSP-T, FSP-M, FSP-S in API mode. > 2) FSP-T in Dispatch-mode. The FSP-M and FSP-S will be reported > as standard FV and they will be measured by TCG-PEI. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Qi Zhang >=20 > Jiewen Yao (4): > IntelFsp2WrapperPkg/FspMeasurementLib: Add header file. > IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib. > IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement. > IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and > PcdFspMeasurementConfig. >=20 > Qi Zhang (4): > SecurityPkg/FvEventLogRecordLib: add new lib for firmware measurement > SecurityPkg/dsc: add FvEventLogRecordLib > SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY > IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib >=20 > .../FspmWrapperPeim/FspmWrapperPeim.c | 90 ++++++- > .../FspmWrapperPeim/FspmWrapperPeim.inf | 20 +- > .../FspsWrapperPeim/FspsWrapperPeim.c | 86 +++++- > .../FspsWrapperPeim/FspsWrapperPeim.inf | 27 +- > .../Include/Library/FspMeasurementLib.h | 39 +++ > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 17 ++ > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 10 +- > .../BaseFspMeasurementLib.inf | 54 ++++ > .../BaseFspMeasurementLib/FspMeasurementLib.c | 248 ++++++++++++++++++ > .../Include/Library/FvEventLogRecordLib.h | 97 +++++++ > SecurityPkg/Include/Ppi/Tcg.h | 5 + > .../FvEventLogRecordLib/FvEventLogRecordLib.c | 197 ++++++++++++++ > .../FvEventLogRecordLib.inf | 40 +++ > .../FvEventLogRecordLib.uni | 17 ++ > SecurityPkg/SecurityPkg.dec | 3 + > SecurityPkg/SecurityPkg.dsc | 2 + > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 12 +- > 17 files changed, 939 insertions(+), 25 deletions(-) > create mode 100644 > IntelFsp2WrapperPkg/Include/Library/FspMeasurementLib.h > create mode 100644 > IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLi > b.inf > create mode 100644 > IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c > create mode 100644 SecurityPkg/Include/Library/FvEventLogRecordLib.h > create mode 100644 > SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.c > create mode 100644 > SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.inf > create mode 100644 > SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.uni >=20 > -- > 2.26.2.windows.1