From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH V2 5/7] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support
Date: Tue, 27 Oct 2020 02:53:42 +0000 [thread overview]
Message-ID: <CY4PR11MB1288B06F771CB63020C18FED8C160@CY4PR11MB1288.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201027024300.21100-6-zhichao.gao@intel.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Tuesday, October 27, 2020 10:43 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>
> Subject: [PATCH V2 5/7] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3027
>
> Remove the deprecated SHA1 support of Hash2DxeCrypto
> driver.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 1 -
> SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> index 50a6157bd9..c1c0470be9 100644
> --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c
> @@ -120,7 +120,6 @@ typedef struct {
> } EFI_HASH_INFO;
>
> EFI_HASH_INFO mHashInfo[] = {
> - {&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2),
> Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final },
> {&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2),
> Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final },
> {&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2),
> Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final },
> {&gEfiHashAlgorithmSha512Guid, sizeof(EFI_SHA512_HASH2),
> Sha512GetContextSize, Sha512Init, Sha512Update, Sha512Final },
> diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
> b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
> index a65943056a..6a456ed2a6 100644
> --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
> +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf
> @@ -44,7 +44,6 @@
> UefiLib
>
> [Guids]
> - gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUID
> gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUID
> gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUID
> gEfiHashAlgorithmSha512Guid ## CONSUMES ## GUID
> --
> 2.21.0.windows.1
next prev parent reply other threads:[~2020-10-27 2:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 2:42 [PATCH V2 0/7] Disable the deprecated MD5 and SHA1 support Gao, Zhichao
2020-10-27 2:42 ` [PATCH V2 1/7] NetworkPkg/Defines: Make iSCSI disable as default Gao, Zhichao
2020-10-27 10:47 ` Laszlo Ersek
2020-10-29 2:34 ` Gao, Zhichao
2020-11-02 15:14 ` Laszlo Ersek
2020-10-27 2:42 ` [PATCH V2 2/7] NetworkPkg: Enable MD5 while enable iSCSI Gao, Zhichao
2020-10-27 2:42 ` [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Gao, Zhichao
2020-10-27 2:53 ` Yao, Jiewen
2020-10-27 2:42 ` [PATCH V2 4/7] MdePkg/dec: Remove the MD5 GUID Gao, Zhichao
2020-10-30 1:20 ` 回复: [edk2-devel] " gaoliming
2020-10-27 2:42 ` [PATCH V2 5/7] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Gao, Zhichao
2020-10-27 2:53 ` Yao, Jiewen [this message]
2020-10-27 2:42 ` [PATCH V2 6/7] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 Gao, Zhichao
2020-10-27 2:53 ` Yao, Jiewen
2020-10-27 2:43 ` [PATCH V2 7/7] CryptoPkg: Make the MD5 disable as default for security Gao, Zhichao
2020-10-27 2:53 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1288B06F771CB63020C18FED8C160@CY4PR11MB1288.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox