From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.8475.1603767227597844340 for ; Mon, 26 Oct 2020 19:53:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=vOIvoYq7; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jiewen.yao@intel.com) IronPort-SDR: c9WuBE4oL7yMzuPTxOj2W6iYVZOEbHI1SUYi4hJ3V7UkQwySQDQ1aoB38HsjpmZwh8yaWSu0I8 Y8Tx8tnnOniA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="168144576" X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="168144576" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 19:53:46 -0700 IronPort-SDR: Upips1Yse6k1BOayvEmHiHhQDN5cnoGD0kZ4uWLFwoVdJkMOO6VOYdyB+zdyna07WAPtO+tpRf WoU8LpGL1cZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="350355731" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2020 19:53:46 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 19:53:46 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 19:53:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 26 Oct 2020 19:53:45 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 26 Oct 2020 19:53:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nSmUQ3nYGiWf7M+70qEcz2JFSMhcFG5ZeFdE1BM6YxYD7k7nc5ushTB1wQiqGajYkITKJjVje6KoUU7qYSCm7sUMEsSxVt+wDth/DctCFAhC1F6F6VI/ViH1yDZIgSygsOcscDmc1qw7D66IWYyxCQYE2KKXuzMIMVQE+PFQaNVPDQVgM9eCN3t401TIFjoFYed1LRLjx74QrsTffHoyXN0FhPAGtjG7wSfCYbfT+2A7IWfPm7optFlQyvIjAIwbvVOyiBFaCvWVKEYm0rZWOwZZfW+CLqi6kBXqpetCfSJXio2sOoVBieB36XfVZ3zI9JMlsOVwxrg10kYyt1+HbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oz2lbaApnBncfNAhVGzq7qZNJu2mC3sdIuJThjVLjok=; b=UvoS9NrIuxAiaxrzLqW6BbeHbgmPlExz1oKN3nM/BRNpiZc9U3ycJbO30AbeONzO5hKDyfqtw9t0fe3cRz5BBVQX5qmzLAxFo9lclUYIgKlTIUMREYUGYFtU7xkNojFgMJis1FHmg07PWe9nzBX3aU6ESMdJ5MlaTid+GRyHuwoc43jIybk61IdyDKVuZwwZ1V7gPzDnyFrMh0YQMRKVuf8/BeQUpr3EUe4LKZBqOHD8h4X2qQFHzsqemu06587pl6Vtm0Nj5xYQ+O9hCARZvbBiw0aFfktQWY3Jo6x3I7NdeoRZ3aeRNef7ABvLzMHaOnHSk0K/z9BLQQkM0ZITuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oz2lbaApnBncfNAhVGzq7qZNJu2mC3sdIuJThjVLjok=; b=vOIvoYq7S3tJNLWffZuXLKfNkjv7tmo5wLC2aJPptyjUu1XQMmHGqpUL/PbqUw90cQ9m1+ID4rQO13VdUlzmxGc437dsHl4KVBaVVDahSsdVPFRjT1UgdR/4+QyNXkEqlnRA0mSVkz6ZeCYwjYVfrTjmt8LxEFPJZhLGNUVt0/A= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR1101MB2166.namprd11.prod.outlook.com (2603:10b6:910:1e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Tue, 27 Oct 2020 02:53:42 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::8948:caa4:ca1a:23ac]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::8948:caa4:ca1a:23ac%10]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 02:53:42 +0000 From: "Yao, Jiewen" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [PATCH V2 5/7] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Thread-Topic: [PATCH V2 5/7] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Thread-Index: AQHWrAr17yMIWrMyfk6h4T2roUHabqmqwKdA Date: Tue, 27 Oct 2020 02:53:42 +0000 Message-ID: References: <20201027024300.21100-1-zhichao.gao@intel.com> <20201027024300.21100-6-zhichao.gao@intel.com> In-Reply-To: <20201027024300.21100-6-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.195] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d7a2c92-20fb-40cb-ad24-08d87a238396 x-ms-traffictypediagnostic: CY4PR1101MB2166: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A34iM/tnWUNtNY6323cUH6cqQ4abNuk3kylDIe3cSHyzrYtgXZg3o+MJIKGLMDu2bWNB9A00/fkaQuDIYgexb+cfcg3q1XJKLJVjHam/WjT41aOIvhoUvAIhZbcwOX1ZyGXAwoPAFYGCSK2kxAUrzF7LBpmUEyzIMJ515Z9p4GfLi/9zacki3w9tTHc24w+HiPXfPzUDZCE5Acr6jG2xCnDkPPc70eyXPfwSOhg6+6qVIApG7uIy1MUqCR5A3udyb6lj5+idtBXnUn90jw/ytTlxhJ5f9BKMRbsU0Zro14aNCPUB/93L/trRVm7k03b/MsyTZLp+6tkaHCnq4yt0DlfA+f7NwBoMdwlNasgVuMlPqy93r3fpHiWodyElEySojh+BThDdeHrc2S/+MeXByQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(39860400002)(346002)(136003)(366004)(66946007)(7696005)(966005)(316002)(4326008)(64756008)(110136005)(76116006)(66446008)(55016002)(71200400001)(66476007)(107886003)(66556008)(9686003)(8936002)(15650500001)(5660300002)(52536014)(6506007)(33656002)(2906002)(86362001)(8676002)(83380400001)(186003)(53546011)(478600001)(26005)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 1mHPY8am2n82a1vuyqhbTglGwG6vW7EqYhvUnVRpfEWOi7DOnU1SGQoMmR3/bXY0vzhhgc6SW5GLgsQYv8avqxfOYvp2E9okRFt/x/vwg9AJb54cwwSZAkM+5Bu6xuAynNUenuzQQIPi3ePhu/5IrsMuADti58o5uMfWqChTlkZvASlQC9a2y6Ehu6ipni8Ll6keMgMgi3okVItejtCmKQdJTB7KfzWMf1bxMeXZW2BM3iCoavbWc9j128X2Jv3xXcC6digglywMtJaAigp5TqYt2hdGxMfm+7YmM2yB8ZZabu5pEoVozV59HadfidFWkudtIYZi4NpW1t2sbTP7JNrBx+Ofskn3cGm3ds3LpxhnT1iPonPkJE5JL5Xgif5VUhllq6CpdwrVqTg3FhGbW8R+499DCIJnyMPcrl5Ij5Rt7uXcJlHXyGHfAcjjEx4ILkcql9Wz2Vgu4lcNG2j/oY2tAF4tBEC33MQpVCjdncfhsKfyWnzNQEspubYIwgMYe7l1epIQZHgs0xuQhJjsEbeT7GmC+yxN2lJOS6inBagiVrTAboJ+mWpSaWCGL+4xZajRR9gc+PE6SMfUDP/M1fN9Lx6TWHjgYAl/AI3MqkcR3TrJba8MmLf8iAz4frix2xDlsv6yLnvwz6BDk9yQ9Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d7a2c92-20fb-40cb-ad24-08d87a238396 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 02:53:42.2269 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YbiLELqgWQExuGtdWPRenYphsu8331i6j4tuQr1KwuxB9h5k1ZRnurcygdDkH+ja9ntXGvzxgeGN5FeBkQtJEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2166 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, October 27, 2020 10:43 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > > Subject: [PATCH V2 5/7] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3027 >=20 > Remove the deprecated SHA1 support of Hash2DxeCrypto > driver. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Signed-off-by: Zhichao Gao > --- > SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c | 1 - > SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf | 1 - > 2 files changed, 2 deletions(-) >=20 > diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > index 50a6157bd9..c1c0470be9 100644 > --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c > @@ -120,7 +120,6 @@ typedef struct { > } EFI_HASH_INFO; >=20 > EFI_HASH_INFO mHashInfo[] =3D { > - {&gEfiHashAlgorithmSha1Guid, sizeof(EFI_SHA1_HASH2), > Sha1GetContextSize, Sha1Init, Sha1Update, Sha1Final }, > {&gEfiHashAlgorithmSha256Guid, sizeof(EFI_SHA256_HASH2), > Sha256GetContextSize, Sha256Init, Sha256Update, Sha256Final }, > {&gEfiHashAlgorithmSha384Guid, sizeof(EFI_SHA384_HASH2), > Sha384GetContextSize, Sha384Init, Sha384Update, Sha384Final }, > {&gEfiHashAlgorithmSha512Guid, sizeof(EFI_SHA512_HASH2), > Sha512GetContextSize, Sha512Init, Sha512Update, Sha512Final }, > diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > index a65943056a..6a456ed2a6 100644 > --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.inf > @@ -44,7 +44,6 @@ > UefiLib >=20 > [Guids] > - gEfiHashAlgorithmSha1Guid ## CONSUMES ## GUI= D > gEfiHashAlgorithmSha256Guid ## CONSUMES ## GUI= D > gEfiHashAlgorithmSha384Guid ## CONSUMES ## GUI= D > gEfiHashAlgorithmSha512Guid ## CONSUMES ## GUI= D > -- > 2.21.0.windows.1