From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.39708.1609114466246114504 for ; Sun, 27 Dec 2020 16:14:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=pF93XBrf; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jiewen.yao@intel.com) IronPort-SDR: QDb0sGuP/tkAvODpPiHAh2Hxjyu5uGxN+PjC/OOr1jZguInx28u2ENmEfZofHsKUGPq5x5RdMZ QN8QnAcOcSgA== X-IronPort-AV: E=McAfee;i="6000,8403,9847"; a="155537174" X-IronPort-AV: E=Sophos;i="5.78,453,1599548400"; d="scan'208";a="155537174" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Dec 2020 16:14:25 -0800 IronPort-SDR: WM6LJGYCRnrbaq9H14LWsoL3m5oj18VK9nJFiEV5tWmBn0I1iFDB0Z6yxErQ3A0r7103cPJ9A3 0Zm7ratTxdNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,453,1599548400"; d="scan'208";a="494156111" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 27 Dec 2020 16:14:25 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 27 Dec 2020 16:14:24 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 27 Dec 2020 16:14:24 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 27 Dec 2020 16:14:24 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 27 Dec 2020 16:14:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNOmzNSaxtQZ6DuxmaYk8QbMjv7CXG70wkdHzr8OXxgfyy1dp+vkLxW1BqcmMYNzpl9doZBilX1QZsb2opTHAINeIRBxC2sAqE+c+Dh0JpMRK1n1dvaly7HvACAojnrnpLTVleq6UUUgFq8jGc7NytZ4ThBdAPBKVddfYEy3GP/CmZSrXFDT/AlrsY4ljz8Xkck9lFRHvGgOoJgt+3iTgcUEfRjimAkKkJ6seHETJ1FOk5sRwnFCHQZwxqwMcKIjAWFj9WGZphhJFWe0qJW3hmAnVF/1fX+v4EAfnnbhJe1aqUhuvpYH0PTqAxF0LqF7IBvjfoHb2zA41gDwOXqYVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kqldxBs6ADRS00T75/dBSFCuGTdAOgQ2pX+rKYIHd3M=; b=Ndxo++P0PngUOYZTGGA8AWRO3x3eJiCn24TmFtibJBD2igRbOAddpTbkDwG9C3vh6nL3vRcNCvBrCvGrxRuK7ilr50caW4N4i35jscIL8WlOfgNES55raf3yG/1z9pMXBIZA2+rG+PZlCOEK6wqQ21s2q3D6xangThxQMVk5zk8NnEsSB+HuE3NE93GXtq7xLTpS3jUZLjP+BJYPesVjY2maEogzVT3IrZquWnHGdk/9Ys+rv3i5wxILwvMPXq/tXGf++QRY+jNbFIuJqd7MoIuqTcGOJgBVXp7dwpeJmw6YoX6BK8a/blDlc2RzlAWGYbju6LAYHa5o11+phA5bQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kqldxBs6ADRS00T75/dBSFCuGTdAOgQ2pX+rKYIHd3M=; b=pF93XBrfBcHM+MsNkB/l4Q7q1CPUkOFgDnuvMttKe5LObL5YYFp8ovB0Aprm8M2bTM+OWZpbicdNEwR95+7RlFFSsBxiRt2ghLxY8rzBmD6JC3OKfJI4yhFpwyMMN23zhoBrDNJfA7Q4GpLwzltUoKqBAVN40rWk9KnpQwg4OEE= Received: from CY4PR11MB1288.namprd11.prod.outlook.com (2603:10b6:903:23::8) by CY4PR11MB1990.namprd11.prod.outlook.com (2603:10b6:903:25::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Mon, 28 Dec 2020 00:14:02 +0000 Received: from CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::e058:fd5a:28d8:2b17]) by CY4PR11MB1288.namprd11.prod.outlook.com ([fe80::e058:fd5a:28d8:2b17%12]) with mapi id 15.20.3700.031; Mon, 28 Dec 2020 00:14:02 +0000 From: "Yao, Jiewen" To: Kun Qin , "devel@edk2.groups.io" CC: Ard Biesheuvel , Sami Mujawar , Supreeth Venkatesh Subject: Re: [PATCH v1 03/15] StandaloneMmPkg: StandaloneMmCoreMemoryAllocationLib: Fix compiler warning Thread-Topic: [PATCH v1 03/15] StandaloneMmPkg: StandaloneMmCoreMemoryAllocationLib: Fix compiler warning Thread-Index: AQHW1W6y1cvHFVteR0acvKNYfnqdWqoLsZZQ Date: Mon, 28 Dec 2020 00:14:02 +0000 Message-ID: References: <20201218185011.1366-1-kun.q@outlook.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: outlook.com; dkim=none (message not signed) header.d=none;outlook.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 796679e4-c6ec-45fa-e621-08d8aac57b72 x-ms-traffictypediagnostic: CY4PR11MB1990: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:983; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NHKu5+HUVcT9maSpwkItj5QEy1/CfWhbze0NWeBrUvGVMwf/nD7m7O1TcC4jinwIA9F/2pLa1m07fmqEsSRSVAZcShli8OH0iZKV/8HP5TwSuf2mipJm+6oLXu8+/KjnFLu/j0s69Jz943bHxNEvcC3DH+mcIvT2n0X18Ol8g2j9pJqqgFJ9QheS+PhbkwGyGRuI/xg1zTLVxkMRhtMtYKAbLb2vOqSB4toCLDNmKIMWGF4DpH/UjLh0CRSt03Gn2YdwCFda5+g4ppE318iVA1/5t6N4cHOfgeLgBOFB546h7L4jJ1FDa+4un0lk6eThIBqYkYPz6KhiSCktlAq9Lz8vL8VS6uX0ut9WIv6cpvyzb1gUk8gm8hWbKHS57aa4a5hlp0c/6SPo9AUUWX7oIA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1288.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(33656002)(52536014)(55016002)(71200400001)(66446008)(316002)(186003)(110136005)(9686003)(66946007)(76116006)(66476007)(66556008)(83380400001)(53546011)(2906002)(4326008)(8676002)(5660300002)(6506007)(64756008)(26005)(54906003)(86362001)(7696005)(478600001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?gWgiE4EVOkPLySCaLhf5o1Oc8pH8dvFlLKJNYym/QcX5ZLJZfeD6zTLvnW3e?= =?us-ascii?Q?ESdedm0TW2RHkhPfYPsXq/U8wyNG8VY13sowbtGJCK+8jP2Lga4rQdFSmQAQ?= =?us-ascii?Q?F7yx78TapL5igUEGHZwUrVsPut05+rOYS3y8Ojln92yLN0E8LWGx0xUjLiVi?= =?us-ascii?Q?6BQr3EQNmFu+/PzvuLjnnBPVFEGQeWiWv3IiWFatMfs3dbg6q0M0J9yAltsJ?= =?us-ascii?Q?xD9BziHUSg9PjglHIJrt1+cpenD6N2yjCk6IHk9tAMTcgQDPni27pGsgJmgf?= =?us-ascii?Q?2QhFgYS+vB5RPhTwe2/dBa4kcB0KhkqucGEcduZBVKLJBwvZd+SqA13nowSy?= =?us-ascii?Q?GaQZqzjyGxXaF8DhVSxn7YKQmeKZS8S3krMjGAj8ddpiZ/8yCGL7EWMqAxef?= =?us-ascii?Q?Iqlp5L+uMqg/xX1MIMivv2Qt0myLecTH/n1u4D0yehSf2wXty1/Drsffa/PM?= =?us-ascii?Q?Q9q6Ad2UsvaYYif5tT7wmUlliRun71v/UP6TkhfDo6XtFmLE+PM7jFk658Rf?= =?us-ascii?Q?32NNQk9YIl0K2CeqFFjvIG+qfzKtAExVB363yn9o8aC663Vex4OsHL685DLK?= =?us-ascii?Q?Z2vRTtRFb3Sm5XG1WEYPk/JACQnm50nPYJH7HXGasbhR2hSr0s28MjE2ZlAr?= =?us-ascii?Q?qv0UNWxHgWhD2ddmgfmS+HzPBVEJwS07gec+yzXRYHEPK0XzvDpPqvC433S0?= =?us-ascii?Q?1igIpNrPvhfVyDKKOCt8laKQCPhvJRFfp3EKlIsmhbmRnKMAA3PO6GtqfS/v?= =?us-ascii?Q?/KuDjzqW7KRHaThus/c3w4yuoDhtQlGyzZm18HdlKYMJu473+0WDKNPbXVD6?= =?us-ascii?Q?8esvZ88mXZdQoweAiFVelbBXvgZwN9RJCkFF8Yh/k2WSdYQMaWEEI16n8gu/?= =?us-ascii?Q?xiGMZDbxurKpgR1rIzqeTqiWmWPxIgVrgcu9lCDpXXUGBTAWGOWDCInr6RWY?= =?us-ascii?Q?0S7fYJ5lsEYa0SyECep3c/fdppKuMDqnmqZaLQFq4MU=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1288.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 796679e4-c6ec-45fa-e621-08d8aac57b72 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2020 00:14:02.8422 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CTFiJWLMLXuQ2MEPt0CE8FccuenkmqM7FxQNqEfvm0uWGrT5Ht6P1KPUAdsz9MNY12JIoA0ddUkOvRXM2+INUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1990 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Since below code is using (UINTN)MmramRangeCount, MmInitializeMemoryServices ((UINTN)MmramRangeCount, (VOID *)(UINTN)MmramRan= ges); I recommend to UINTN for MmramRangeCount, and use (UINTN) cast. > -----Original Message----- > From: Kun Qin > Sent: Saturday, December 19, 2020 2:50 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar > ; Yao, Jiewen ; Supreeth > Venkatesh > Subject: [PATCH v1 03/15] StandaloneMmPkg: > StandaloneMmCoreMemoryAllocationLib: Fix compiler warning >=20 > Assigning MmramRangeCount from MmCorePrivate (UINT64) to local > variable > MmramRangeCount (UINT32) will cause compilation failure due to "warning > C4244: '=3D': conversion from 'UINT64' to 'UINT32', possible loss of data= ". > This changes defines local MmramRangeCount as UINT64 type. >=20 > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh >=20 > Signed-off-by: Kun Qin > --- >=20 > StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Stan > daloneMmCoreMemoryAllocationLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Sta > ndaloneMmCoreMemoryAllocationLib.c > b/StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Sta > ndaloneMmCoreMemoryAllocationLib.c > index eb3d772e18c5..798d546a2037 100644 > --- > a/StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Sta > ndaloneMmCoreMemoryAllocationLib.c > +++ > b/StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/Sta > ndaloneMmCoreMemoryAllocationLib.c > @@ -841,7 +841,7 @@ MemoryAllocationLibConstructor ( > VOID *HobStart; > EFI_MMRAM_HOB_DESCRIPTOR_BLOCK *MmramRangesHobData; > EFI_MMRAM_DESCRIPTOR *MmramRanges; > - UINT32 MmramRangeCount; > + UINT64 MmramRangeCount; > EFI_HOB_GUID_TYPE *MmramRangesHob; >=20 > HobStart =3D GetHobList (); > -- > 2.28.0.windows.1