From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.2339.1588841603570813872 for ; Thu, 07 May 2020 01:53:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ihf0S1nW; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: dandan.bi@intel.com) IronPort-SDR: 0mELw+IPihzT5dNqVzYJUaMYs6RnYYUJJPFn0KqpgX94tPdKzn3jPA0hs7nN/pfYbOYOLj1CTC V7pOMEPC3wUA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 01:53:23 -0700 IronPort-SDR: ngWFj4jzaEsByLfu5lc6WmWi2TXMIvvqGUWbEa0NgEuVNRZi5/xyKUNNerptAWrrMecG88Qvk+ hiP/yyEkozmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,363,1583222400"; d="scan'208";a="407559406" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 07 May 2020 01:53:21 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 01:52:38 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 01:52:35 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.50) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 01:52:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mx0lPUkZUE6F6186ystmzVWf2RetfRHfx9QzA43M1umLnLVE91SDRPFqQCxqWi2IBz8yCRmEcDN3rXpnGZgmnfHuq8D5u6PaCWKHblUgN5V99DRFby7j9tyhwTXXGBa/JF2sv/rnxzP4YfXIfiDUKWA0mD0AImQxKJ2kWrxojDRqZY/V2w7uZR1/jtM2jhYz/KRgcdwumDjg6Ss3CZC/ndTAA/7+9mMEWK64pPOySaNQB4DIRZzh/mIGImeQvAyo6jQSlttgwD2Cl6AjCivvc7TvjYpREjjqVgY7/p80LeVedLmrRmD5EgCYciPU8ZI1rpmpgfwWYESH8rQHnDbbLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vp6DllavBu/rxNzaTyGmWCiOfcz9l0PHa5gOZNvkLN4=; b=n0hPMHu9wlUfhMCaCsXTP6srdH9/6N8wdhAEmDYZW4BYM2tG3NHbjyCBgWvkjoDsZTIN0+6qWyI9JYcT1/b+RF5UX9XGbcSB2gL7eNGx+nGdxCvSPpwQT6OzjpQUCPRap76o9556D5diElqNHe/MSXfNh2Vb+K2bTPaQH0rRA3SUqig0L8WfusR62ckxTOSPuB3IybyYS6plr5Vqu79HDiYJjoQ6kFGGYwCZdym/EOpU1rm6E/iQ69KhTpJyANuaNVbpLbDaIjd1Gz+ByQt8VvtFRIAt3FwuVF3zJ6DqUcFrQ4juImWtHulvpiZoMNu5ka0BtRiNGmAf1x3iosuHag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vp6DllavBu/rxNzaTyGmWCiOfcz9l0PHa5gOZNvkLN4=; b=ihf0S1nWmbpDeULlddzBjL8nomZpOEAiWhzheTzWnyvygX0wRv3tRLxZHBKkO09o7cLRedaxy4ghPohC6gqGSqcGIaSOGE2HaEUMCSpzZoyQJwe8nrboHa4QumFKYF5TbOahPm2hhx4JWxLLgPcJXMzw8pCz4eecgZpXh9vCpG4= Received: from CY4PR11MB1477.namprd11.prod.outlook.com (2603:10b6:910:b::20) by CY4PR11MB1704.namprd11.prod.outlook.com (2603:10b6:903:29::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.27; Thu, 7 May 2020 08:52:29 +0000 Received: from CY4PR11MB1477.namprd11.prod.outlook.com ([fe80::d5d3:ff0c:74ad:4702]) by CY4PR11MB1477.namprd11.prod.outlook.com ([fe80::d5d3:ff0c:74ad:4702%5]) with mapi id 15.20.2958.034; Thu, 7 May 2020 08:52:29 +0000 From: "Dandan Bi" To: Abdul Lateef Attar , "devel@edk2.groups.io" CC: "Dong, Eric" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption. Thread-Topic: [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption. Thread-Index: AQHWFuH++8YTEXpYSkSvcLypmLv8n6ica3bA Date: Thu, 7 May 2020 08:52:28 +0000 Message-ID: References: <20200420070555.23046-1-abdul@marvell.com> In-Reply-To: <20200420070555.23046-1-abdul@marvell.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41b3c5e2-b78a-4424-b102-08d7f263f90c x-ms-traffictypediagnostic: CY4PR11MB1704: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:510; x-forefront-prvs: 03965EFC76 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mPjAD61GUFTtiCgU4/z/i7yh80rzgjZK/wlTNrLcsAezl20bTdjfqkCFjB+JHqwjv6pt3hu9T6B3IRN6kKVoiiMmLtZnxcUeHlW/riXZVw2cagK3VXBfthUllbtFxk8HuQz2mYYc2nl0O1X7ekjdxxEokJul1m5nTwt10sUbQjqiP0Lg0IhdGWzxCMGy3SkZQ1eaqD/gKsJLGqUud05IOYPUdHToSOyyeRiNJMOA7yi8/0lUfzKT3qUMCzdBCzw000r5Y+myK2oBwXwede3jHm2d9xDC2n/ilJjv2E/RnFVcUgKk2j4GsOx0hH04k8VrLoh96QhTF629k0gVB26MYK0Wxf+3WkHp9tx1Ixu9kuVdKiCMbYSWOGDejqFxGdpO7S0XTHuicS8EseGKz6YQJPeUucJn1zlgWoxGrIkz5ZTV7MGoZTnqGj/gaL7HJooE4O69t7mUKdzdH7T6IbXi3AJT17yzjuHiGeRqEdmPJJ1GjkmwR4dGmxJZFs9AuOCXIczLyonrmlHG7GIo4/IaHw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1477.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(376002)(396003)(136003)(346002)(39860400002)(366004)(33430700001)(107886003)(110136005)(8676002)(52536014)(53546011)(86362001)(66446008)(478600001)(64756008)(33656002)(71200400001)(66476007)(83290400001)(4326008)(83310400001)(83300400001)(66556008)(6506007)(83320400001)(83280400001)(66946007)(8936002)(54906003)(2906002)(55016002)(5660300002)(7696005)(186003)(26005)(33440700001)(76116006)(9686003)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: aksDuEE5A66HAnp0XNSDX9biMVCX2CtPADNMiqTi5AK3ffJSxa2OgwqQQTrw/1MJxn/O7NjMtvoCAqm6x0RHcIJItM++ghq/eI4NesdVY5KcTmbp7LPqq8jJRpFmfMG5Isj6Yjs0p7C6xFwu1Pq73vsa+AFmUWeORowuTaQCZYyPaV3rZ20a1OMCKFT0N6nghqy9hVoz0LuThvoBNVU3Hp0N9AbvFucKZDVVzmhUKQ91U2v0h6mnV2JoAJnCoWoCbYHfhQhbSZq9rA3/m4iEMqltyTuDucFz1qxk5Z/PM3EGma0Ycvei3+/YDVDjptkidYLChDKGwcRMKtxcpXanxv5rvswcJuW3jShYBiaaBPVp3WWDVlAyQXS5Cf3L2QDnqw4cKnwZZR+KvxG0bdV/58phKdUMYzTFhMCDbkG8YvYA9mqhpQo5ihcYW+Hwxpp7764Ck2LKlBS9Ifhu+mTrft7HJbeCM1SaA78VLTuNXBzOLf23A2fA39MvJTCk1+XRprqzYfZBd1oFiNE3ni/IFSgkl/7FuPUqR+pVano7+JWl32aawqhEoDO9iUg7aEAmA+GoxO1vCj5pW9kEoU3OKGbWivLNqtHJSghrkx9bG8l9YVW22qpsfCatq+QaTkltxB3lZXQLSpCXArO0a/oBSR7ryQADmRSicD2OYYZFxDRjl44xEn0wtft7WwbR2PSuP7F08c3MRKrxAihPS+NemgF2beibzKQAZtEUOW59o7SNlYnSc8tzZ86yIFJyxW0CAHJiBMyqqzv4DQM1INtYIyXFVFV+arbr84AwQbTTWvM= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 41b3c5e2-b78a-4424-b102-08d7f263f90c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 08:52:28.9647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xyurVtlhMa2jYm+sbmw5G086zMvSxhpTB0zl2qGX9VSjELuv1NLUWsO+wjJ7DC2W6sPkQCG6xJ4GCnkTn2KMiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1704 Return-Path: dandan.bi@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: Abdul Lateef Attar > Sent: Monday, April 20, 2020 3:06 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric ; > Wang, Jian J ; Wu, Hao A ; > Abdul Lateef Attar > Subject: [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption. >=20 > Its been observed that in MenuManagerMenuApp when user selects a > different BootOption using Up/Down key, the current Cursor position is no= t > chaning. > Still points to the old BootOption. >=20 > This changes first dispalys/redraws the old BootOption followed by new > BootOption. Doing so will make current cursor pointing to the user select= ed > BootOption. >=20 > Signed-off-by: Abdul Lateef Attar > --- > .../BootManagerMenuApp/BootManagerMenu.c | 22 +++++++++++--- > -------- > 1 file changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git > a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu. > c > b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu. > c > index 34d4089a55..9e729074ec 100644 > --- > a/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu. > c > +++ > b/MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenu. > c > @@ -451,20 +451,10 @@ BootMenuSelectItem ( > } >=20 > // > - // Print want to select item > - // > - FirstItem =3D BootMenuData->ScrollBarControl.FirstItem; > - gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | > EFI_BACKGROUND_BLACK); > - String =3D HiiGetString (gStringPackHandle, BootMenuData- > >PtrTokens[WantSelectItem], NULL); > - PrintCol =3D StartCol + 1; > - PrintRow =3D StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem - > FirstItem; > - PrintStringAt (PrintCol, PrintRow, String); > - FreePool (String); > - > - // > // if Want Select and selected item isn't the same and doesn't re-draw > selectable > // items, clear select item > // > + FirstItem =3D BootMenuData->ScrollBarControl.FirstItem; > if (WantSelectItem !=3D BootMenuData->SelectItem && !RePaintItems) { > gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | > EFI_BACKGROUND_BLUE); > String =3D HiiGetString (gStringPackHandle, BootMenuData- > >PtrTokens[BootMenuData->SelectItem], NULL); @@ -474,6 +464,16 @@ > BootMenuSelectItem ( > FreePool (String); > } >=20 > + // > + // Print want to select item > + // > + gST->ConOut->SetAttribute (gST->ConOut, EFI_WHITE | > + EFI_BACKGROUND_BLACK); String =3D HiiGetString (gStringPackHandle, > + BootMenuData->PtrTokens[WantSelectItem], NULL); PrintCol =3D StartCol > + + 1; PrintRow =3D StartRow + TITLE_TOKEN_COUNT + 2 + WantSelectItem - > + FirstItem; PrintStringAt (PrintCol, PrintRow, String); FreePool > + (String); > + > gST->ConOut->SetAttribute (gST->ConOut, SavedAttribute); > BootMenuData->SelectItem =3D WantSelectItem; > return EFI_SUCCESS; > -- > 2.11.0