From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.4852.1596070831903455549 for ; Wed, 29 Jul 2020 18:00:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ffP72+Nf; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) IronPort-SDR: +RIbEPfy0aW//GBd4a/IqwxBE2GUFEN9P6OGZ2gpnTWOiA7i3MllgQ1R603YX4X6npgb/LrKZT J2i+XqR7WY5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9697"; a="131589282" X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="131589282" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jul 2020 18:00:30 -0700 IronPort-SDR: exyoKAhV769z79uv9u9EQ5Hv4zhvmdBzO+F3lCoBbZnwFh4iENCMwI7m63QuH49PnW7tO4MoK4 HVTrCYqYODYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,412,1589266800"; d="scan'208";a="365012253" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga001.jf.intel.com with ESMTP; 29 Jul 2020 18:00:30 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jul 2020 18:00:30 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX161.amr.corp.intel.com (10.22.240.84) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jul 2020 18:00:30 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jul 2020 18:00:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SUyAjk6kthmZ+jJOtrfOD1/E4pKB9YWIUq1rlSvQMH/pjRSe3D+kvXD4wz0OcXiVeEZnZ61znpn7OgozZrsNhJhmNWMKNmTU70wsRi06fgaS6wTDdzN2WRAzWlvgM1HF1RbnhJ3bocsq91La7Ktl6PGv/9YmBVuhsucn5U3nXUeREgfFI+clA/WPoXMEmZqQ3T2bEuEpzWl7UAdgq9ZUukDk8Oc2paeVXDqekwHrrLM5aAtwBs8lw2wJ6F25+lf2yVk0aWwePc9o+UoxJRiVFGOzfRI3gaNk6n1K8d5F/1XlQg7KtxbWzW8OjqddI+gXXm7pQ94vrlCdajU9N157Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEkmoNHXQ7UTxZN6itWRv9Ax8dV+Gqe0D3F6G+9iVII=; b=cs/rj9zmQC9wbe4tuFYKeHsSjKD3BloKbyV/8bNixU94I/OwWHUoc2ZOsDdBkBsrUv76IQwAzMYcwacbPkKoEl/TRZuSenVSUUfWHU4aHOHNBk8yCCJsb3QpKkzRQGtSYCgt8pbd+oc21QZJER7T2qnxBAr79LUM764+wiIQ2msZajDRlfQgi6gdwYICTNZUkpmqnvxPkV/gZY+qCWK3PiJG4GC7YAwiO73YKqDupeuIl1HEq7VySNOaCdH0gJ0lNfZ097m9KprF5x2ICf58nwcTF3d5yImEGZJU88dnr6Gm9T1VEpBbS7zOzIVX2MOwYtl/xGUGxPGts9RC8jxqMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEkmoNHXQ7UTxZN6itWRv9Ax8dV+Gqe0D3F6G+9iVII=; b=ffP72+NfVBGnxMlz7eXQrSfRztOzpb0IjXUUw+MjvMCzW2w04NrYtLFLe4tU84XWpvYhfS40D2Lq/6Yd4D4SDKnjWxyDa7HMY71yYRm66Ql4YT3tNfBcnzyc/leC03ve1Wz6Li3PIcTMmy6SMHh8K4oEwACw4Jazwr0hGCxovzk= Received: from CY4PR11MB1526.namprd11.prod.outlook.com (2603:10b6:910:7::10) by CY4PR11MB1349.namprd11.prod.outlook.com (2603:10b6:903:30::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.24; Thu, 30 Jul 2020 00:59:34 +0000 Received: from CY4PR11MB1526.namprd11.prod.outlook.com ([fe80::f8c4:711:84e3:4c97]) by CY4PR11MB1526.namprd11.prod.outlook.com ([fe80::f8c4:711:84e3:4c97%4]) with mapi id 15.20.3216.034; Thu, 30 Jul 2020 00:59:34 +0000 From: "Liming Gao" To: "devel@edk2.groups.io" , "afish@apple.com" , Laszlo Ersek CC: "Kinney, Michael D" , "Zhang, Shenglei" , Sean Brogan , "Bret Barkelew" , "Dong, Eric" , "Gao, Zhichao" , "Yao, Jiewen" , Chao Zhang , "Justen, Jordan L" , Maciej Rabeda , "Wu, Jiaxin" , "Fu, Siyuan" , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Lu, XiaoyuX" , "Ard Biesheuvel" , Leif Lindholm Subject: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci Thread-Topic: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci Thread-Index: AQHWXnEGADvncrYqckiGkA7tbZLG9akdsjSAgAAaFqCAAAcXgIAAgwMAgABkoQCAAJ+MwA== Date: Thu, 30 Jul 2020 00:59:33 +0000 Message-ID: References: <20200720083709.17264-1-shenglei.zhang@intel.com> <42dff41e-b38a-cd08-2ed1-35d83385dfac@redhat.com> <61060829-B0CA-41EA-97D7-A1AF8B0D1FCD@apple.com> In-Reply-To: <61060829-B0CA-41EA-97D7-A1AF8B0D1FCD@apple.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e8cac03-1bb0-4a94-da4f-08d83423d2f0 x-ms-traffictypediagnostic: CY4PR11MB1349: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Querj/1NDXESjYjR0/FSQ7+PDcx5MwfR74+YICZY3eb7GEoYqh9HfQTLvXtiLv0eXUvl8RbGHb+Liy6EthR/o43oHxlCKCT71EJFaok9YdO5EuQDl8Z4MC5YEyNgnpd8DDclpDP3jS8st6st1ploXk/K5LWPzWfInZWu7J9d1wJRSe5jjEbxmm7pHZZ0MQkw23mZKTgXeKMh6VWlc2DCWZoIvQkzDLx/39n93xlI3mkexUptpXS3n91LFpx4GFM/KiblaSU0fuTbXGW2I10P7wDIYu4KVUgWxvzrLufhkOHUpt7ZmfJVUEada4b9xAIOxzFgE3MjF2qpg5nHkZ5TvZNVn6Wn6V6pIij+wl/yIkECsvCRaz2gL+TL9WwW2Hz4NPQFtAD79MIhvweC0DFSAg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1526.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39860400002)(346002)(366004)(136003)(376002)(966005)(110136005)(5660300002)(86362001)(54906003)(316002)(2906002)(83380400001)(8936002)(71200400001)(4326008)(8676002)(55016002)(66556008)(186003)(33656002)(7696005)(66946007)(66446008)(64756008)(76116006)(66476007)(26005)(53546011)(6506007)(52536014)(478600001)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: tWB2LH3u+KIGc0GYlf5KAGOnv72k2+reQT8XaY+IDaUHlPRwsLJ63SnpjuSV9rM+TqJ8jY95BvZAWff7/ukCYSXbMTx239Cm+ABLsAVpZ3Qq2agoQMrBEbUQ6mzUUWPL7XLVnTwMdUbk27ueImxbXrbDelfwDBuMDnHYJEVTHvcuvaE7Jn2Xe3nRKgYc634XiX04H/AZvcE6eoSxU7FDSa++V+bqmanUJ3FK43dAf7OmlPNbyOeyLDi6KlrtnCvTlNRHvI4Pfr4tN9FTAlRRGTxHAwl/G9NOgtI1USaob1CFS2k37PtaF3RjUFGx6MJFN6/a9dH/SkMbxUaPaXbsnj+QJg2HaJqhr5mviiqvvOgKGhijtL82wfLGYsrk7p02nr7q1mi5BNMm0tFzRaGIloYKu1oCsxk1U8MEtr8JNZ42RGwEGavzfdT+my+k4uo+INEWubMMSIKeLuDe4kgskNoBmg59MIRgx8cLLA8H6SAn8tVUQeMM8oqQ05YNcOwd MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1526.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e8cac03-1bb0-4a94-da4f-08d83423d2f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2020 00:59:33.8795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s2Tf2ZrFhhS9cwOWINPEmapPm/mGIezigAewHgUNR7bwN+U8P/YUPV5YaiQQnk9S/w+w4FqX27jUbk6l5DDv4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1349 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable -----Original Message----- From: devel@edk2.groups.io On Behalf Of Andrew Fish= via groups.io Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B29=1B$BF|=1B(B 23:22 To: edk2-devel-groups-io ; Laszlo Ersek Cc: Kinney, Michael D ; Gao, Liming ; Zhang, Shenglei ; Sean Brogan ; Bret Barkelew ; Dong, = Eric ; Gao, Zhichao ; Yao, Jiew= en ; Chao Zhang ; Justen, Jor= dan L ; Maciej Rabeda ; Wu, Jiaxin ; Fu, Siyuan ; = Wang, Jian J ; Wu, Hao A ; Ni, R= ay ; Lu, XiaoyuX ; Ard Biesheuvel <= ard.biesheuvel@arm.com>; Leif Lindholm Subject: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open = ci > On Jul 29, 2020, at 2:21 AM, Laszlo Ersek wrote: >=20 > On 07/29/20 03:32, Kinney, Michael D wrote: >> Hi Liming, >>=20 >> There are exception to PatchCheck as well for line endings and tabs. >>=20 >> Seems like a similar problem, and a single CI plugin could support=20 >> all these cases. >=20 > The exceptions for LicenseCheck are individual files that package=20 > maintainers (and contributors too) could customize. The primary use=20 > case is permitting generated files to have no SPDX tag at all.=20 > PatchCheck does not have a customizable exception list; it only=20 > considers general rules that apply to the whole tree. >=20 > I did suggest "@file: generated" as a general marker for generated=20 > files (which would opt them out of SPDX enforcement), here: > . >=20 This sounds like a good plan for any file generated by the edk2. [Liming] I agree this is a good suggestion. This requires all generated fi= les to follow this rule.=20 The first step is to enable LicenseCheck plugin (the patch has passed revi= ew and ready for merge, https://edk2.groups.io/g/devel/message/63447).=20 Then, package maintainers can add the exception files. Next, we can contin= ue to enhance LicenseCheck.=20 Thanks Liming Thanks, Andrew Fish > I'm equally happy with an IgnoreFiles stanza in=20 > "OvmfPkg/OvmfPkg.ci.yaml", or a marker like "@file: generated" in some= =20 > files under OvmfPkg. What's important to me is that we can control and= =20 > update the license checks for OvmfPkg/ files with OvmfPkg/ patches.=20 > That is, in case we need to tweak the license check for some OvmfPkg/=20 > file, the corresponding patch should need OvmfPkg maintainer approval *o= nly*. > Adding exceptions to PatchCheck has been difficult, as (a) it affects=20 > all of edk2, (b) technically it needs to pass BaseTools review. >=20 > With the license check, I'm happy to have the mechanism under=20 > BaseTools and/or CI, but the policy should be per package. Again my=20 > sole motivation at this time is generated files that we need to check=20 > in for whatever reason. >=20 > Thanks! > Laszlo >=20 >=20 >=20 >=20