* [platforms: PATCH 1/1] Marvell/Drivers: MvFvbDxe: Switch to PcdSet64S
@ 2020-07-30 16:06 Marcin Wojtas
2020-07-31 1:53 ` [edk2-devel] " Liming Gao
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Wojtas @ 2020-07-30 16:06 UTC (permalink / raw)
To: devel; +Cc: leif, ard.biesheuvel, mw, jsd, nadavh, kostap
According to the bug:
https://bugzilla.tianocore.org/show_bug.cgi?id=2777
the deprecated code under DISABLE_NEW_DEPRECATED_INTERFACES
will be removed, which will result in compilation breakage
of the Marvell platforms. Prevent that by switching to the
different PcdSet API.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
index fba75b6..e8cad86 100644
--- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
+++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
@@ -1059,12 +1059,12 @@ MvFvbConfigureFlashInstance (
return EFI_OUT_OF_RESOURCES;
}
- PcdSet64 (PcdFlashNvStorageVariableBase64,
+ PcdSet64S (PcdFlashNvStorageVariableBase64,
(UINT64) FlashInstance->RegionBaseAddress);
- PcdSet64 (PcdFlashNvStorageFtwWorkingBase64,
+ PcdSet64S (PcdFlashNvStorageFtwWorkingBase64,
(UINT64) FlashInstance->RegionBaseAddress
+ VariableSize);
- PcdSet64 (PcdFlashNvStorageFtwSpareBase64,
+ PcdSet64S (PcdFlashNvStorageFtwSpareBase64,
(UINT64) FlashInstance->RegionBaseAddress
+ VariableSize
+ FtwWorkingSize);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [platforms: PATCH 1/1] Marvell/Drivers: MvFvbDxe: Switch to PcdSet64S
2020-07-30 16:06 [platforms: PATCH 1/1] Marvell/Drivers: MvFvbDxe: Switch to PcdSet64S Marcin Wojtas
@ 2020-07-31 1:53 ` Liming Gao
0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2020-07-31 1:53 UTC (permalink / raw)
To: devel@edk2.groups.io, mw@semihalf.com
Cc: leif@nuviainc.com, ard.biesheuvel@arm.com, jsd@semihalf.com,
nadavh@marvell.com, kostap@marvell.com
Reviewed-by: Liming Gao <liming.gao@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Marcin Wojtas
Sent: 2020年7月31日 0:06
To: devel@edk2.groups.io
Cc: leif@nuviainc.com; ard.biesheuvel@arm.com; mw@semihalf.com; jsd@semihalf.com; nadavh@marvell.com; kostap@marvell.com
Subject: [edk2-devel] [platforms: PATCH 1/1] Marvell/Drivers: MvFvbDxe: Switch to PcdSet64S
According to the bug:
https://bugzilla.tianocore.org/show_bug.cgi?id=2777
the deprecated code under DISABLE_NEW_DEPRECATED_INTERFACES will be removed, which will result in compilation breakage of the Marvell platforms. Prevent that by switching to the different PcdSet API.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
index fba75b6..e8cad86 100644
--- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
+++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
@@ -1059,12 +1059,12 @@ MvFvbConfigureFlashInstance (
return EFI_OUT_OF_RESOURCES;
}
- PcdSet64 (PcdFlashNvStorageVariableBase64,
+ PcdSet64S (PcdFlashNvStorageVariableBase64,
(UINT64) FlashInstance->RegionBaseAddress);
- PcdSet64 (PcdFlashNvStorageFtwWorkingBase64,
+ PcdSet64S (PcdFlashNvStorageFtwWorkingBase64,
(UINT64) FlashInstance->RegionBaseAddress
+ VariableSize);
- PcdSet64 (PcdFlashNvStorageFtwSpareBase64,
+ PcdSet64S (PcdFlashNvStorageFtwSpareBase64,
(UINT64) FlashInstance->RegionBaseAddress
+ VariableSize
+ FtwWorkingSize);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-31 1:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-30 16:06 [platforms: PATCH 1/1] Marvell/Drivers: MvFvbDxe: Switch to PcdSet64S Marcin Wojtas
2020-07-31 1:53 ` [edk2-devel] " Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox