From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.84107.1597820898932993228 for ; Wed, 19 Aug 2020 00:08:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=WmINorXg; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) IronPort-SDR: 8uP7sQie7gtxAVU/DvEixDYgb6eWgBmTskCwOTCdWTToQc1WsVeh3sUznTOyZjC7oEtkm4XdU3 HfQ2Svpl7qsg== X-IronPort-AV: E=McAfee;i="6000,8403,9717"; a="152680040" X-IronPort-AV: E=Sophos;i="5.76,330,1592895600"; d="scan'208";a="152680040" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2020 00:08:15 -0700 IronPort-SDR: ujuNg4yE2GQhg3x9kXg3btVXAoGQ2Vpe21bqdva+b6CtMN7ODf9T5HHNzQPPmD+N2y5awkrx9D VfgCVymHadtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,330,1592895600"; d="scan'208";a="371155813" Received: from orsmsx605-2.jf.intel.com (HELO ORSMSX605.amr.corp.intel.com) ([10.22.229.85]) by orsmga001.jf.intel.com with ESMTP; 19 Aug 2020 00:08:15 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 19 Aug 2020 00:08:14 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 19 Aug 2020 00:08:14 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Aug 2020 00:08:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FgJjvC6zdXJjpUwY8QQxJYD7nj8LkaFYnIeqhSuQ25zL5B5O2N4KaFruBmTJc5ul6WLFWvPhe0v/bhH9TMctZ4mLDbZYAPS0miVqUuDlZnWVgx/XAjbOuE+iVjYC4XRycZYrooCgQdGIvZ0SpI9ZlRmGpmu+f7S3ZKtBmTtyaiy6rc2S96Ju4VcaMwZtgekaLrPGLo3Yi/k+LJhweUewZJp2G6Tjt6FcpuYRJHnF54T/TAN7/WIrl+Ca5MELsUkDkqmd27/RA3a0bsAQMMLZbzkdcWIMssyRquy0SgbZUwdp4K0UOojnqzHD0jJ5byzCfM6HVClqq8iRHil8X4+sOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UJGJEaL8SlhUeQ2Usdsjp0oAb/No4NJI68jjuJwR5cQ=; b=kl7lZeOE15lTmuyES0asOMGFYtFAWLH/5uo6+FGRrqr46nxiwi3szZ5GjN+89APoDU0wIoGd9mizNTQBPXsfVPA5F3IHEjak81jsz8REcVq+dJeR6lkOjEk5tBXqLEZfkJzaFAwYLADfriJZcZiYIjnbVyZuDUSSgnv/m0xmX23D2os1UjXydT2eSSG0NGtKlS7Kov789lMcvTve0T5dVyZ3LMD7W1xX6/EaHtfY9gla7k1o4MQ4NJ84Zraw1RgAlj8jWhX/mwX2F7Mx4w0KesONeMHy1jN0mxRUS+xTOmGYFL2XYv9DnBKiqWaga+lo1uWOibsZZY/vthJFiDTruA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UJGJEaL8SlhUeQ2Usdsjp0oAb/No4NJI68jjuJwR5cQ=; b=WmINorXgeYa+NrFwHTv3ddCYNl3KBwtJSPjcUEPcPBH/xWs0H8viO/kzodAmD/k/J/V6yK9+58aPgF+Ld5ucFkO+ZgRobDmZ8tOYncuSgQoLtbkJvBHHFB/Kp5J7YNPTV9elqgKXpvcMjwvh8Ps4ow72kBNOwKvIuoa9cpLvCOc= Received: from CY4PR11MB1526.namprd11.prod.outlook.com (2603:10b6:910:7::10) by CY4PR11MB1527.namprd11.prod.outlook.com (2603:10b6:910:c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.22; Wed, 19 Aug 2020 07:08:13 +0000 Received: from CY4PR11MB1526.namprd11.prod.outlook.com ([fe80::f8c4:711:84e3:4c97]) by CY4PR11MB1526.namprd11.prod.outlook.com ([fe80::f8c4:711:84e3:4c97%4]) with mapi id 15.20.3283.028; Wed, 19 Aug 2020 07:08:13 +0000 From: "Liming Gao" To: Tom Lendacky , "devel@edk2.groups.io" CC: "Dong, Eric" , "Ni, Ray" , "Laszlo Ersek" , "Kumar, Rahul1" Subject: Re: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable Thread-Topic: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable Thread-Index: AQHWdWEQjtRZ3zfZfEClExkh8pc+nqk/BBmQ Date: Wed, 19 Aug 2020 07:08:13 +0000 Message-ID: References: <477f5449c898cd96240729105dde26b1fd75baa9.1597756206.git.thomas.lendacky@amd.com> In-Reply-To: <477f5449c898cd96240729105dde26b1fd75baa9.1597756206.git.thomas.lendacky@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d7c7b5b3-a8b1-4528-df56-08d8440ea34c x-ms-traffictypediagnostic: CY4PR11MB1527: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OgxUybSgJ7pT9LFhj9nOnvQdf6sohXUboGh0MwHAnAt22tM1a2LUiQ1chPIUzvLgMIbMXv3qbDtWdV1IQOXVpqTR6kpkgJVNMIOtmv8NlITaMJ6YHn+srZun5y5xYujYagdbPlzH/M13cgQvIhNn6N2Qoj/nVRF9HrffNiFOi8c0dbDZOWaco23/tMgabraqvWpIfxzIGxMRwEy8kYYaxsK6niRTQG960DfiZLbmnPBlJbJre12pirqht7P7jar4ithr7x+AKgD+JENrSG3tZ20G6O+BYOwfQB76r8VZftrdVzQY3Q3/uds9Sbj6b0T58xk5DmkJ3IZVefU3FgsGoRvaoDmME5DEz4Mfy64fuBfHi3KtFRfWMZq+mDVQGpkQPqwjy3R8RnOea1Ye7Qf9iQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1526.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(39860400002)(376002)(346002)(396003)(136003)(7696005)(53546011)(66556008)(6506007)(26005)(8936002)(71200400001)(2906002)(66946007)(55016002)(186003)(52536014)(66446008)(478600001)(83380400001)(86362001)(966005)(64756008)(76116006)(66476007)(9686003)(8676002)(107886003)(110136005)(33656002)(54906003)(4326008)(5660300002)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: bAOo2iOzPNfZaRKP8P1WZaaNYNyMjog3ndWbqlp+HlHGLFtsMGDyUAEN0kBR/CQsDuY4U4at7O8sovOIoVCHanhIYS8flOrQQAtB7xCaHp5jSufoDZxFup931G8bJJVKZ6Llhug+/ELZOS/xuTBawd1q7Q5U7Saghp4QkYWNwQXP4G8W4wWOOzRCC7lDJhxBQLWGnTQE944vZMyrvEEXNjIYxtNEOsDsBgTOf4a+F8uWkIWTAEQ6CAS+CGU0MpIXRsjruvNG5uPGu9NmJ+Op5ENVDI0fMb2FmqotwI5tyoLMNEwsE4pWnIUXUOJGmr4maB62gLMWiG9+Yig/l92t1B5ydWfZ0BpDVKQ7h+b0DhVuV7tr2zLPC9jyf2GnRGipvmAicEWkB3UPJ3Zfj9xwcKt2y4/5nr+gS33zRB8dw6FYXKRPoTEUSdFHuAi10UDLmWGKZPAnfztLuB+2WgiZMSK1kE+rYS6qwX5031NqXtIuekwIkpdpbE9EOp6oYrsbW6FK7FQf5kSbDCSet8h4tTfQw5s40+2zBS4gN7f0SJvAmmp6I/7bLfXyqvZ2nfsa7dGbq23p8Q+5B7hoODXmnZ7h8Wf26vrbW0hYe9fp8GPqAvrcZA69HRyX1ukS1en/ypkrRJVh10UYP4SOP9E4sA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1526.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7c7b5b3-a8b1-4528-df56-08d8440ea34c X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2020 07:08:13.2330 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HnpP72TBlYfXTkR65ne12C6jzKDKvB3E1rlrfyKD83cexYcfJNO7aTXl+2WJ6fi93LlFNu93ieON7WwF+ZQHjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1527 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Tested-by: Liming Gao Reviewed-by: Liming Gao -----Original Message----- From: Tom Lendacky =20 Sent: 2020=1B$BG/=1B(B8=1B$B7n=1B(B18=1B$BF|=1B(B 21:10 To: devel@edk2.groups.io Cc: Gao, Liming ; Dong, Eric ; N= i, Ray ; Laszlo Ersek ; Kumar, Rahul1 = Subject: [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecremen= t variable From: Tom Lendacky REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2901 The DoDecrement variable in ApWakeupFunction () wasn't always being initial= ized. Update the code to always fully initialize it. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Tom Lendacky --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index 90416c81b616..e24bdc64f930 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -885,9 +885,7 @@ ApWakeupFunction ( UINT64 Status; BOOLEAN DoDecrement; =20 - if (CpuMpData->InitFlag =3D=3D ApInitConfig) { - DoDecrement =3D TRUE; - } + DoDecrement =3D (CpuMpData->InitFlag =3D=3D ApInitConfig) ? TRUE= :=20 + FALSE; =20 while (TRUE) { Msr.GhcbPhysicalAddress =3D AsmReadMsr64 (MSR_SEV_ES_GHCB); -- 2.28.0