From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.124999.1597972623236255465 for ; Thu, 20 Aug 2020 18:17:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qyfHRAlB; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: liming.gao@intel.com) IronPort-SDR: mqOruIcrQRGfU1f+od9D+U8/be6EwwJsyzKjzT8umam+pEyRLAGoCwJjXVwCnkSM3SEzFQTWDr 2WvYZCnMTmwQ== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="219736674" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="219736674" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 18:17:01 -0700 IronPort-SDR: jNB2Mtg752dB3E5YsLv+bQcCsIiM8HUg7EtLI1lo2GHv62O1vGViK68JIU5Q1mMKri4Lstq0bq ByWir/Dv9IRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="335177677" Received: from unknown (HELO fmsmsx605.amr.corp.intel.com) ([10.18.84.215]) by FMSMGA003.fm.intel.com with ESMTP; 20 Aug 2020 18:17:01 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 20 Aug 2020 18:17:01 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 20 Aug 2020 18:17:01 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Aug 2020 18:17:01 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Aug 2020 18:17:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nn3P4nEwtFf7tNdkHh6vUSiCIeLYlZzT7GC4gM57oQmrT0r2lrTIUhMUrypsuPqo3/F53JYRL+khy2WHyh8t17HNMKRKnty+9SjsiTFsyiX4MVS5UNgtq8sxnn/s+99iq0sLdg65SKd+Zhou9ub5t8oZBYFE69FMkQg0yKCOETUp1idarjX4ucRcr66Ycd+ZoC0k3ZYp3JpngfyeLK9bgR99Vj5v0jyVkzh6xULpVbZMGEtB61TyonWG1PPEieN7cWsIxEzTrjD8hmT/s/LKVEj/zLUltdtIgSjjSjGT8Y9Zq7rfvNeLXBBSTsM4uDTroNDxByKlWA3CMly2nug8KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pm+fy2pIdvsL1o4p2zq0P9T8M16QYyieaiCp7c+tCZw=; b=FO5e3qTeXlKBrL/wAkevJ1uHWFaA6Suk3i5fBO2gikzH7wWvi/HgZAsL//BYoanK0tVXzycCZHi3u+pYdsn5Zlr4BosAit2Y6HQxEqlvBmFZV2BHyC2RZPvJ3Mm6+t+5Tov5KcNT/5EK4+3eF+8LXEFRCzLgQv7BBzX4iG+uvbiILjuCdGK+AFupDexUEH/trEB5m67F2bagmmscyOPkI4H8ld+brDfYro57zCS0RS9tADXHZkfpw3KtxmeAK/aW9GqP6GDXJoR5olIXgvXUA1SfMw3GYLv7E8hRlaR9ffu2Ag8Q/1yzaJXgZOtnlKLiQRyGQYZr3hKzc0rLTV/HLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pm+fy2pIdvsL1o4p2zq0P9T8M16QYyieaiCp7c+tCZw=; b=qyfHRAlB2QCB48FLhqUT+5LHw/YChRPFl/KVaZkR3TYJDNoeu9ODAwA+1TJvHh0qTO6MndeO1EpZUDNHoThMmLOLyJ1Nq/rcTgFnBz/hxzzzAkUGcCynJ0SljWF7yMTyAlvyePtn1b5NaAZfyWiY9C9YcPoguGf3w3ZfyoulQV8= Received: from CY4PR11MB1526.namprd11.prod.outlook.com (2603:10b6:910:7::10) by CY4PR1101MB2343.namprd11.prod.outlook.com (2603:10b6:903:ba::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.25; Fri, 21 Aug 2020 01:16:58 +0000 Received: from CY4PR11MB1526.namprd11.prod.outlook.com ([fe80::8cdc:9dca:82ab:a412]) by CY4PR11MB1526.namprd11.prod.outlook.com ([fe80::8cdc:9dca:82ab:a412%10]) with mapi id 15.20.3305.025; Fri, 21 Aug 2020 01:16:58 +0000 From: "Liming Gao" To: "Dong, Eric" , "devel@edk2.groups.io" , "thomas.lendacky@amd.com" CC: "Ni, Ray" , Laszlo Ersek , "Kumar, Rahul1" Subject: Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable Thread-Topic: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable Thread-Index: AQHWdwG0Tk25QDB3uUyAIlnliTMWn6lBuOEAgAAKniA= Date: Fri, 21 Aug 2020 01:16:58 +0000 Message-ID: References: <76a9f18992475b915e5f8457704676067210cacf.1597935198.git.thomas.lendacky@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3e7cea4b-785c-401d-dfc1-08d8456fe6d4 x-ms-traffictypediagnostic: CY4PR1101MB2343: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +XPA6X6rW+hK9DTbakwdgZ+dvk7U9CYMjEhLzEI2EA2UkrD0s4Q3bJTaGLQRXJXb/i+W1pSa1XEyz6phcIdiXRPDvsWUOeBRPafBnLlXfGdOg94DW9+ZxuCtkkpg15xAIpkDE1ZoXEOMt8zQsmNHUR9kXpZCsK8kyc58H7PqblN/HBWTgdcTsBVShrPA7WsYPy7I4cvW/vUnzCq6bbMM6cEi6erf10HiQeX8jvK7QMEqV1TCwABef8v3qhiVkROJ9HYXI4DCeGCdk/v66wv1s/WEYBdiEg3hte0/JfL4QdMciO0U9hUpSX5xy4d0ggrjh/84zDXUP2suJMx3xXN9BoGJhMHAsWkoqVIaSozuc1FWMtEIVhbW1R9oZWdS/8F/pArDay1+NHrmtk7qwc7xZw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1526.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(376002)(346002)(366004)(39860400002)(136003)(4326008)(316002)(86362001)(9686003)(7696005)(55016002)(186003)(83380400001)(107886003)(71200400001)(33656002)(966005)(66446008)(2906002)(5660300002)(8936002)(26005)(66476007)(66946007)(64756008)(76116006)(6506007)(110136005)(478600001)(53546011)(54906003)(8676002)(52536014)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: orMZkw6CW3NT4FRViE6UbR2jlk+7UNxstq+vMyWDi5KPXMPGgn2FFKsai8p2pgdw4cax/T/k0KISkwxFmft/ngfDrKT91m1X5e7gNIhk4iKouB5uJSyt4pY8uhR/9BPMPj744QNYK0jDaDrH7WY6Kge208DaIP2XEUXAlz5n4k8msB71/VbL5GyLCyT9xfdUoH0xBQqaZdTooGZku6GvAceKj9/ejDblw7kKQfwDlbrjAffp7E6DW6mat6V24pGH0nTgTF8tur6dhdCopDSm1O3Ak7FtqQFS/pSRRRXApra6hA58dYsQ/XyHTw3LV/SkdGyrFveZjLzjS1n2ubCfy6Bwdaa2fcG3bw/ljRHqtt09QcdOUVSP1q0OETyttrgPsnmDBmrQWiWJe7XkN6M3bHXwXZv5lYyHCIczwyIqi4HAYgPpk9mULccmqHlO/URv8jsi83TJAmy71fvBC3bdJB+aKL0ANFiXPwrbQFVtDQqi54Jk/kRQTmL+RLvLP0AiEvbuPoXUf5u1fXo5fyzm6MsQHjNwkfllxFb+9QYMba9hgF1mX32PHtpO/dOMhnu5SQNYg3cXf8gjIMUDa87Mqbpcl/Y8nywFpwqaLgY4vfZemldFnziRTCaDGDIBxS7kNHulv5UZWR2oD1TY5RJQtA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1526.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e7cea4b-785c-401d-dfc1-08d8456fe6d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2020 01:16:58.7652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9OelaA+goJYxA90Uh88t08AfMZcSjjwgwr0NcC7pB5f42L6tCVbje2zvAsBiRcpU8+joud0WxB10oUxpcGuw4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2343 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Tested-by: Liming Gao -----Original Message----- From: Dong, Eric =20 Sent: 2020=1B$BG/=1B(B8=1B$B7n=1B(B21=1B$BF|=1B(B 8:39 To: devel@edk2.groups.io; thomas.lendacky@amd.com Cc: Gao, Liming ; Ni, Ray ; Laszlo= Ersek ; Kumar, Rahul1 Subject: RE: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always init= ialize the DoDecrement variable Reviewed-by: Eric Dong > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of=20 > Lendacky, Thomas > Sent: Thursday, August 20, 2020 10:53 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric=20 > ; Ni, Ray ; Laszlo Ersek=20 > ; Kumar, > Rahul1 > Subject: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always=20 > initialize the DoDecrement variable >=20 > From: Tom Lendacky >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2901 >=20 > The DoDecrement variable in ApWakeupFunction () wasn't always being=20 > initialized. Update the code to always fully initialize it. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Tom Lendacky > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c > b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 90416c81b616..07426274f639 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -885,9 +885,7 @@ ApWakeupFunction ( > UINT64 Status; > BOOLEAN DoDecrement; >=20 > - if (CpuMpData->InitFlag =3D=3D ApInitConfig) { > - DoDecrement =3D TRUE; > - } > + DoDecrement =3D (BOOLEAN) (CpuMpData->InitFlag =3D=3D=20 > + ApInitConfig); >=20 > while (TRUE) { > Msr.GhcbPhysicalAddress =3D AsmReadMsr64 (MSR_SEV_ES_GHCB); > -- > 2.28.0 >=20 >=20 >=20