public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule
@ 2020-07-29  7:00 Guomin Jiang
  2020-07-29  9:10 ` Laszlo Ersek
  2020-08-03  5:51 ` [edk2-devel] " Wang, Jian J
  0 siblings, 2 replies; 4+ messages in thread
From: Guomin Jiang @ 2020-07-29  7:00 UTC (permalink / raw)
  To: devel; +Cc: Andrew Fish, Laszlo Ersek, Leif Lindholm, Michael D Kinney

Add myself as reviewer for CryptoPkg/ and *Capsule* and FmpDevicePkg/.

Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Maintainers.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 5504bb3d17cc..8c27094e433e 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -164,6 +164,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
 M: Jiewen Yao <jiewen.yao@intel.com>
 M: Jian J Wang <jian.j.wang@intel.com>
 R: Xiaoyu Lu <xiaoyux.lu@intel.com>
+R: Guomin Jiang <guomin.jiang@intel.com>
 
 DynamicTablesPkg
 F: DynamicTablesPkg/
@@ -197,6 +198,7 @@ F: FmpDevicePkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/FmpDevicePkg
 M: Liming Gao <liming.gao@intel.com>
 M: Michael D Kinney <michael.d.kinney@intel.com>
+R: Guomin Jiang <guomin.jiang@intel.com>
 
 IntelFsp2Pkg
 F: IntelFsp2Pkg/
@@ -321,6 +323,7 @@ F: MdeModulePkg/Library/FmpAuthenticationLibNull/
 F: MdeModulePkg/Universal/Esrt*/
 R: Hao A Wu <hao.a.wu@intel.com>
 R: Liming Gao <liming.gao@intel.com>
+R: Guomin Jiang <guomin.jiang@intel.com>
 
 MdeModulePkg: HII and UI modules
 F: MdeModulePkg/*FileExplorer*/
-- 
2.25.1.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule
  2020-07-29  7:00 [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule Guomin Jiang
@ 2020-07-29  9:10 ` Laszlo Ersek
  2020-07-29 13:59   ` Liming Gao
  2020-08-03  5:51 ` [edk2-devel] " Wang, Jian J
  1 sibling, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2020-07-29  9:10 UTC (permalink / raw)
  To: Guomin Jiang, devel
  Cc: Andrew Fish, Leif Lindholm, Michael D Kinney, Jiewen Yao,
	Jian J Wang, Liming Gao, Michael Kinney, Hao A Wu

On 07/29/20 09:00, Guomin Jiang wrote:
> Add myself as reviewer for CryptoPkg/ and *Capsule* and FmpDevicePkg/.
> 
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 5504bb3d17cc..8c27094e433e 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -164,6 +164,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
>  M: Jiewen Yao <jiewen.yao@intel.com>
>  M: Jian J Wang <jian.j.wang@intel.com>
>  R: Xiaoyu Lu <xiaoyux.lu@intel.com>
> +R: Guomin Jiang <guomin.jiang@intel.com>
>  
>  DynamicTablesPkg
>  F: DynamicTablesPkg/
> @@ -197,6 +198,7 @@ F: FmpDevicePkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/FmpDevicePkg
>  M: Liming Gao <liming.gao@intel.com>
>  M: Michael D Kinney <michael.d.kinney@intel.com>
> +R: Guomin Jiang <guomin.jiang@intel.com>
>  
>  IntelFsp2Pkg
>  F: IntelFsp2Pkg/
> @@ -321,6 +323,7 @@ F: MdeModulePkg/Library/FmpAuthenticationLibNull/
>  F: MdeModulePkg/Universal/Esrt*/
>  R: Hao A Wu <hao.a.wu@intel.com>
>  R: Liming Gao <liming.gao@intel.com>
> +R: Guomin Jiang <guomin.jiang@intel.com>
>  
>  MdeModulePkg: HII and UI modules
>  F: MdeModulePkg/*FileExplorer*/
> 

>From my side:

Acked-by: Laszlo Ersek <lersek@redhat.com>

But, before merging this patch, one "M" person from each of the affected
packages should respond with a Reviewed-by:

- CryptoPkg: Jiewen or Jian
- FmpDevicePkg: Liming or Mike
- MdeModulePkg (Firmware Update modules): Jian or Hao

I've CC'd these maintainers now.

Thanks
Laszlo


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule
  2020-07-29  9:10 ` Laszlo Ersek
@ 2020-07-29 13:59   ` Liming Gao
  0 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2020-07-29 13:59 UTC (permalink / raw)
  To: Laszlo Ersek, Jiang, Guomin, devel@edk2.groups.io
  Cc: Andrew Fish, Leif Lindholm, Kinney, Michael D, Yao, Jiewen,
	Wang, Jian J, Kinney, Michael D, Wu, Hao A

Reviewed-by: Liming Gao <liming.gao@intel.com> for FmpDevicePkg and MdeModulePkg.

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, July 29, 2020 5:10 PM
> To: Jiang, Guomin <guomin.jiang@intel.com>; devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Leif Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule
> 
> On 07/29/20 09:00, Guomin Jiang wrote:
> > Add myself as reviewer for CryptoPkg/ and *Capsule* and FmpDevicePkg/.
> >
> > Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  Maintainers.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 5504bb3d17cc..8c27094e433e 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -164,6 +164,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
> >  M: Jiewen Yao <jiewen.yao@intel.com>
> >  M: Jian J Wang <jian.j.wang@intel.com>
> >  R: Xiaoyu Lu <xiaoyux.lu@intel.com>
> > +R: Guomin Jiang <guomin.jiang@intel.com>
> >
> >  DynamicTablesPkg
> >  F: DynamicTablesPkg/
> > @@ -197,6 +198,7 @@ F: FmpDevicePkg/
> >  W: https://github.com/tianocore/tianocore.github.io/wiki/FmpDevicePkg
> >  M: Liming Gao <liming.gao@intel.com>
> >  M: Michael D Kinney <michael.d.kinney@intel.com>
> > +R: Guomin Jiang <guomin.jiang@intel.com>
> >
> >  IntelFsp2Pkg
> >  F: IntelFsp2Pkg/
> > @@ -321,6 +323,7 @@ F: MdeModulePkg/Library/FmpAuthenticationLibNull/
> >  F: MdeModulePkg/Universal/Esrt*/
> >  R: Hao A Wu <hao.a.wu@intel.com>
> >  R: Liming Gao <liming.gao@intel.com>
> > +R: Guomin Jiang <guomin.jiang@intel.com>
> >
> >  MdeModulePkg: HII and UI modules
> >  F: MdeModulePkg/*FileExplorer*/
> >
> 
> From my side:
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> 
> But, before merging this patch, one "M" person from each of the affected
> packages should respond with a Reviewed-by:
> 
> - CryptoPkg: Jiewen or Jian
> - FmpDevicePkg: Liming or Mike
> - MdeModulePkg (Firmware Update modules): Jian or Hao
> 
> I've CC'd these maintainers now.
> 
> Thanks
> Laszlo


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule
  2020-07-29  7:00 [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule Guomin Jiang
  2020-07-29  9:10 ` Laszlo Ersek
@ 2020-08-03  5:51 ` Wang, Jian J
  1 sibling, 0 replies; 4+ messages in thread
From: Wang, Jian J @ 2020-08-03  5:51 UTC (permalink / raw)
  To: devel@edk2.groups.io, Jiang, Guomin
  Cc: Andrew Fish, Laszlo Ersek, Leif Lindholm, Kinney, Michael D


Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guomin
> Jiang
> Sent: Wednesday, July 29, 2020 3:01 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif
> Lindholm <leif@nuviainc.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as
> reviewer for Crypto and Capsule
> 
> Add myself as reviewer for CryptoPkg/ and *Capsule* and FmpDevicePkg/.
> 
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 5504bb3d17cc..8c27094e433e 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -164,6 +164,7 @@ W:
> https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
>  M: Jiewen Yao <jiewen.yao@intel.com>
>  M: Jian J Wang <jian.j.wang@intel.com>
>  R: Xiaoyu Lu <xiaoyux.lu@intel.com>
> +R: Guomin Jiang <guomin.jiang@intel.com>
> 
>  DynamicTablesPkg
>  F: DynamicTablesPkg/
> @@ -197,6 +198,7 @@ F: FmpDevicePkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/FmpDevicePkg
>  M: Liming Gao <liming.gao@intel.com>
>  M: Michael D Kinney <michael.d.kinney@intel.com>
> +R: Guomin Jiang <guomin.jiang@intel.com>
> 
>  IntelFsp2Pkg
>  F: IntelFsp2Pkg/
> @@ -321,6 +323,7 @@ F: MdeModulePkg/Library/FmpAuthenticationLibNull/
>  F: MdeModulePkg/Universal/Esrt*/
>  R: Hao A Wu <hao.a.wu@intel.com>
>  R: Liming Gao <liming.gao@intel.com>
> +R: Guomin Jiang <guomin.jiang@intel.com>
> 
>  MdeModulePkg: HII and UI modules
>  F: MdeModulePkg/*FileExplorer*/
> --
> 2.25.1.windows.1
> 
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-03  5:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-29  7:00 [PATCH 1/1] Maintainers.txt: Add "Guomin Jiang" as reviewer for Crypto and Capsule Guomin Jiang
2020-07-29  9:10 ` Laszlo Ersek
2020-07-29 13:59   ` Liming Gao
2020-08-03  5:51 ` [edk2-devel] " Wang, Jian J

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox