From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.5901.1597194523520334744 for ; Tue, 11 Aug 2020 18:08:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qIbphRBu; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: liming.gao@intel.com) IronPort-SDR: KZIxNWYqRYIw57CFph6Bu9SfLg3Q2pXeMrDx3xz3EsQk0mFF5CjtDn9NTKjBpEmNjXENrArWYd kQRNnoGrIPgw== X-IronPort-AV: E=McAfee;i="6000,8403,9710"; a="133914243" X-IronPort-AV: E=Sophos;i="5.76,302,1592895600"; d="scan'208";a="133914243" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 18:08:42 -0700 IronPort-SDR: suWlV5hkf3X6qVkav8sxLL7zk6LG8SyX0Ae21DpiUDHA2gBqySKVJwl3BWh80OKR5INcyid0wU 7i/zMI00rrCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,302,1592895600"; d="scan'208";a="317920908" Received: from unknown (HELO fmsmsx604.amr.corp.intel.com) ([10.18.84.214]) by fmsmga004.fm.intel.com with ESMTP; 11 Aug 2020 18:08:42 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 18:08:41 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 11 Aug 2020 18:08:41 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 18:08:15 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 18:08:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jN8bDVLkcRKl8S6pJNJn+noLiy/itMdIBUED5cutHoKzoka231X4Vk0BGCy+ZrAD6FWnLZ9X9aAAU4669dZFS5/lCTMLF1EbHYzT3yrSfVb5br68oe3cGMJZA7UR4FFNA2YUwbZfCFE7t+Z2yL+p9Lo0LU4s1y6zygiuFwRlUpR9+/2q0fg45IZkrMEkmyBgmR47+866sp1BIpvs22OaksEYLABMf6d0t7pxsmxQypB44rlkz3aLr9tzd0PYY8f3bKYhRFydjFuImaASQmHQARXQW/FCd/gLcv/BqNU5yXwEATG85n40yPiLwqNa0GFtA/zb7CdJxuz/d8RmnU8UHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M2JdiGt+YAZ8zkqrE2vXEhJxb1TgnC++eoMRYBUowtw=; b=EsJpxXn7M51Ox7FQmdLYqs0Kibu3XvnxRxrJurIChVkon7fxXJFFRRPtdTo/yUR05u6b5QckP2vTshgg9scDegEGLwnROVKEabwCqxKpKSTsKlaIpI18egv8AmbmBBcu5cwhUC3+eSgwqEx3EqQAk6dK9mZQ8dqiU0e9AFNa+vLoUcUsOTUTU0RNPG90Fv5IdGMA3EIlGXUic/RsnTXzghNER17XyjvfTcyTZwYCMAnT5AnecRHjmVrhBdLFsI51GZweaoUY9VC6qzyjf1ScawM+bSxQtVOaeNqEsLcx40eKrU3anuY358k+9kVAJ+0QNBeRThBLvEhZG16l5dN3+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M2JdiGt+YAZ8zkqrE2vXEhJxb1TgnC++eoMRYBUowtw=; b=qIbphRBuvypyWqrEDZo2dmhB+7vk0M+r9SXefG/e0gBT3qbEjjcbKoOm07frA1gnWfviM2OWkD/TBMJyjo9oEjx97sLY/ZQYq07JZ3JsmqsXVLu38q40TijSOd3WdXq4v67H6rqQ0YnwTWU/B6Ft0nuLe6K13p/0M674v4ziYIU= Received: from CY4PR11MB1526.namprd11.prod.outlook.com (2603:10b6:910:7::10) by CY4PR11MB1830.namprd11.prod.outlook.com (2603:10b6:903:125::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Wed, 12 Aug 2020 01:07:56 +0000 Received: from CY4PR11MB1526.namprd11.prod.outlook.com ([fe80::f8c4:711:84e3:4c97]) by CY4PR11MB1526.namprd11.prod.outlook.com ([fe80::f8c4:711:84e3:4c97%4]) with mapi id 15.20.3261.025; Wed, 12 Aug 2020 01:07:56 +0000 From: "Liming Gao" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Feng, Bob C" , Bret Barkelew , "Kinney, Michael D" , Sean Brogan Subject: Re: [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Thread-Topic: [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open ci Thread-Index: AQHWb61cJPToBTb1i0a7GTFftURELqkyoDeg Date: Wed, 12 Aug 2020 01:07:56 +0000 Message-ID: References: <20200811070204.55160-1-shenglei.zhang@intel.com> In-Reply-To: <20200811070204.55160-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d679df53-6cfb-4167-c761-08d83e5c25c4 x-ms-traffictypediagnostic: CY4PR11MB1830: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rIrI4Lg/dnkDzN+c9y1XaJh5lm9WjOSJh/0ID4sEDKE2bkK/pIWqv9xW2KbL/V2hGh7z4zSRKlp1WlebQ3M0tMrd9/lmisEJfAKp4taUFVIe2io2DyryVFMAC/uJm1iQhvWTaz5m0j6OqBo28KCDmXpmGDadQ2Mc2dKE+/AEcH1i6wi9VuCfh925q35NHlSF7qES3d4SXpobIVRnfaZcxhsgLpOfgdJZdOP6E5Vp/WH14G/Y8C+Zypx0Mxwy94mmccFn8PI3ePdROdnfbOZAhYtAY2EXfKM6pfw2d7nchk8luT0nkQgrx55TbOmoN2PPGz/sWOfsC5jSdMViKTb6ywYGYDvd9VqRUQGh+1jEwvli3PbUPSctsp33oigf7oDc66ehYUYQfyv99jk5Aow4PA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1526.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(186003)(33656002)(53546011)(64756008)(2906002)(26005)(71200400001)(6506007)(76116006)(66946007)(66446008)(66476007)(66556008)(9686003)(55016002)(7696005)(966005)(52536014)(5660300002)(4326008)(478600001)(86362001)(316002)(83380400001)(8936002)(110136005)(54906003)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: EVYkRp/qXx6V7FQAzvNmB/e8V9S4Yp4erI/10jRAg+ILRQBFKrWRPrd/XS077AuZSnUa3dn1QHKhQoKBUifC+NcJH4SHczeo8Lx8umnjTp7PJoOyukhiUWONBJDJ8NA/Xy7nMqHZUWNpkZWrELkiLkHyr18W+mnfNSsPsmRvs+YXxGh48geVdUw/5oAO/zyd/pmpubcwNxiEKYuD7QWjHBBzNl0G5Q15zQdrYUBaP3kuHpsvYRZkIpVuFttpA4FC17DGAhwWEGPBEtWT1E4tGC1ViXugNMp922NppkcNsM3M7YFRGuYXKr09+JO5qQz4T5jEgOQUwXbA2HL9CuvVdOX25eWbJvxV6Bgdmp8Ys7x+d8YjHWaxkfdWOB4jBPftgxCmArvuvkgWILTZKFMSEmxqnEbJeRxUhU24iZlJtnFQbubz8Eu28+sAlWVnt1gdbACi/15X5FcfW58F0lkY6Ozl+GqRkFwU35QqG1PeTMh18Xh0cwMx9zy0e4krfZ78YUI6QmODZlUDQdcR5FAIc9tA1e2JQ1fe3EhVsLLJQ4pTHYR3cX1WpCYadlOUcHrdG/M+SVetT7tpTMVF772nCXazbBg08JNkpOEC6KqdVmd/TYIgsaGUUCC0+nWQMj2IKa9TPyZ9xPZ3l1Gy2/Ip3g== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1526.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d679df53-6cfb-4167-c761-08d83e5c25c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2020 01:07:56.3082 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oHydcZv8mRB1bWD4VFrwbKNL9cEby+/u3iBOhgGn4XKjJki6trNM72lvYeJ1Wb8eR1x88o1sfxUOSXWRUSUvcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1830 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao -----Original Message----- From: Zhang, Shenglei =20 Sent: 2020=1B$BG/=1B(B8=1B$B7n=1B(B11=1B$BF|=1B(B 15:02 To: devel@edk2.groups.io Cc: Feng, Bob C ; Bret Barkelew ; Kinney, Michael D ; Gao, Liming ; Sean Brogan Subject: [PATCH v9 00/16] Add a plugin to check Ecc issues for edk2 on open= ci REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2606 As planed we will enable Ecc check for edk2 on open ci. And they are ready = now. I appreciate receiving feedback and comments if someone find errors or= false positive issues. I created a pipline of EccCheck for my forked edk2. Welcome everyone to cre= ate pull request to test the quality of this plugin. My forked tree: https://github.com/shenglei10/edk2 And I also created some test cases for ECC plugin. Below are test cases. https://github.com/shenglei10/edk2/tree/ECC Results can be view in below azure server. https://dev.azure.com/shengleizhang/shengleizhang/_build?definitionId=3D12&= _a=3Dsummary Patches 1/16: It's a lib necessary for py3 to run Ecc on azure servers. 2/16: EccCheck.py is a plugin to report Ecc issues for commits. It can be r= un on azure servers for open ci, or a local virtual environment. 3/16~16/16: We consider some cases that will report out Ecc issues but they= won't be fixed, like submodule and industry standard related things. So we add two configuration fields "Exception" and "IgnoreFiles" for people to use. These patches add configuration in yaml files for Ecc check. Cc: Bob Feng Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan v2: Update 1/17, fix the bug that the script can't hanlde multiple commits. v3: Update 1/17, set the only workalbe workspace is edk2 root directory. Update 2/17, designate the version of antlr4 is 4.7.1. Add 4/17~17/17. v4. Update 1/17, remove the function EdksetupRebuild(), instead add function SetupEnvironment(). Update variables' format and type hints to pass flake8 and mypy. v5. Conver the former method to plugin solution, to align with other check points on open ci. v6. The 1/16 patch is missed in v5 series. Now add it in v6. v7. Fix a bug that Ecc plugin can not be run correctly under Linux OS. v8. Enable error code config section to ignore certain kinds of issues, which are always false positive in partial Ecc scaning. All patches except 2/16 have been R-B and are not updated in v8 series. To avoid making noise in community, I only send cover letter and 2/16 p= atch. v9. Update 2/16, 3/16, 5/16 and 16/16. 1. Enable directory path for "IgnoreFiles" section in xxxPkg.yaml. So t= hat users can skip a certain directory and don't need to fill in with fi= le names. 2. Add submodule pathes in "IgnoreFiles" in MdeModulePkg.ci.yaml, CryptoPkg.ci.yaml and UnitTestFrameworkPkg.ci.yaml. Shenglei Zhang (16): pip-requirements.txt: Add Ecc required lib .pytool/Plugin: Add a plugin EccCheck MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file .pytool/Plugin/EccCheck/EccCheck.py | 302 ++++++++++++++++++ .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml | 11 + .pytool/Plugin/EccCheck/Readme.md | 15 + ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 + CryptoPkg/CryptoPkg.ci.yaml | 13 + EmulatorPkg/EmulatorPkg.ci.yaml | 11 + FatPkg/FatPkg.ci.yaml | 12 + FmpDevicePkg/FmpDevicePkg.ci.yaml | 12 + MdeModulePkg/MdeModulePkg.ci.yaml | 13 + MdePkg/MdePkg.ci.yaml | 11 + NetworkPkg/NetworkPkg.ci.yaml | 12 + OvmfPkg/OvmfPkg.ci.yaml | 11 + PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 12 + SecurityPkg/SecurityPkg.ci.yaml | 12 + ShellPkg/ShellPkg.ci.yaml | 12 + UefiCpuPkg/UefiCpuPkg.ci.yaml | 12 + .../UnitTestFrameworkPkg.ci.yaml | 11 + pip-requirements.txt | 1 + 18 files changed, 494 insertions(+) create mode 100644 .pytool/Plugin/EccCheck/EccCheck.py create mode 100644 .pytool/Plugin/EccCheck/EccCheck_plug_in.yaml create mode 100644 .pytool/Plugin/EccCheck/Readme.md -- 2.18.0.windows.1