public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Patch List for 202008 stable tag
@ 2020-08-20 11:30 Liming Gao
  2020-08-20 12:43 ` Lendacky, Thomas
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Liming Gao @ 2020-08-20 11:30 UTC (permalink / raw)
  To: Leif Lindholm, Laszlo Ersek, afish@apple.com, Kinney, Michael D,
	Guptha, Soumya K, Chang, Abner (HPS SW/FW Technologist),
	Vladimir Olovyannikov, Tom Lendacky
  Cc: devel@edk2.groups.io

[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 202008 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.

Feature List:
https://edk2.groups.io/g/devel/message/63767 [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
[Liming] This patch pass code review after Soft Feature Freeze (SFF) starts. According to SFF definition, it should not be merged for this stable tag. But, the patch submitter says this patch is important to RISC-V community. To catch it for this stable tag, Laszlo proposed the solution to defer SFF start day from 2020-08-14 to 2020-08-21, then hard feature freeze and release date will also defer one week. Any patches those pass review before new SFF start day can be merged. @ Stewards, please give your comments to defer this stable tag release by one week.

https://edk2.groups.io/g/devel/message/63348 [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
[Liming] This patch has collected the review comment. New version will be sent. I have no information how important it is. @Vladimir, does this patch must catch this stable tag? If yes, can you give the reason?

Bug List:
https://edk2.groups.io/g/devel/message/64383 [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
[Liming] This patch has collected the review comment. New version will be sent.

https://edk2.groups.io/g/devel/message/50406 [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
[Liming] This patch passed review early. But, it is not merged. I will merge it.

Thanks
Liming

[-- Attachment #2: Type: text/html, Size: 8688 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Patch List for 202008 stable tag
  2020-08-20 11:30 Patch List for 202008 stable tag Liming Gao
@ 2020-08-20 12:43 ` Lendacky, Thomas
  2020-08-20 15:41   ` Vladimir Olovyannikov
  2020-08-21  3:21 ` Abner Chang
  2020-08-21 11:06 ` Laszlo Ersek
  2 siblings, 1 reply; 15+ messages in thread
From: Lendacky, Thomas @ 2020-08-20 12:43 UTC (permalink / raw)
  To: Gao, Liming, Leif Lindholm, Laszlo Ersek, afish@apple.com,
	Kinney, Michael D, Guptha, Soumya K,
	Chang, Abner (HPS SW/FW Technologist), Vladimir Olovyannikov
  Cc: devel@edk2.groups.io

Oh, I didn't realize you were waiting on another version of the bug fix. 
I'll send a v2 with the change over to:

   DoDecrement = (BOOLEAN) (CpuMpData->InitFlag == ApInitConfig);

Thanks,
Tom

On 8/20/20 6:30 AM, Gao, Liming wrote:
> Hi Stewards and all:
> 
>    I collect current patch lists in devel mail list. Those patch 
> contributors request to add them for 202008 stable tag. Because we have 
> enter into Soft Feature Freeze, I want to collect your feedback for them. 
> If any patches are missing, please reply this mail to add them.
> 
> *Feature List:*
> 
> https://edk2.groups.io/g/devel/message/63767 
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F63767&data=02%7C01%7Cthomas.lendacky%40amd.com%7C04409f1bdbf04facbdf308d844fc7ad5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637335198474345594&sdata=6APiDA0gEzodq5NqaM69fSgbkTWr5FVFr%2FcAS4cTAfY%3D&reserved=0> 
> [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
> 
> [Liming] This patch pass code review after Soft Feature Freeze (SFF) 
> starts. According to SFF definition, it should not be merged for this 
> stable tag. But, the patch submitter says this patch is important to 
> RISC-V community. To catch it for this stable tag, Laszlo proposed the 
> solution to defer SFF start day from 2020-08-14 to 2020-08-21, then hard 
> feature freeze and release date will also defer one week. Any patches 
> those pass review before new SFF start day can be merged. @ Stewards, 
> please give your comments to defer this stable tag release by one week.
> 
> https://edk2.groups.io/g/devel/message/63348 
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F63348&data=02%7C01%7Cthomas.lendacky%40amd.com%7C04409f1bdbf04facbdf308d844fc7ad5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637335198474345594&sdata=NGolIWo0RmVnECYD9p9RwZKlTW0lVRJCs2Yl5TS1NX8%3D&reserved=0> 
> [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
> 
> [Liming] This patch has collected the review comment. New version will be 
> sent. I have no information how important it is. @Vladimir, does this 
> patch must catch this stable tag? If yes, can you give the reason?
> 
> *Bug List:*
> 
> https://edk2.groups.io/g/devel/message/64383 
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F64383&data=02%7C01%7Cthomas.lendacky%40amd.com%7C04409f1bdbf04facbdf308d844fc7ad5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637335198474355583&sdata=nR8jZ9zQ6je9vz3rdCkv%2BTSHjBIaRPr%2FdqPOgxUNH4Y%3D&reserved=0> 
> [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
> 
> [Liming] This patch has collected the review comment. New version will be 
> sent.
> 
> https://edk2.groups.io/g/devel/message/50406 
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F50406&data=02%7C01%7Cthomas.lendacky%40amd.com%7C04409f1bdbf04facbdf308d844fc7ad5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637335198474355583&sdata=jzJAHkl5Lc8BDzDHw1GOjfQUDe2E1yAIroEkBmUrAHU%3D&reserved=0> 
> [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in 
> SmBios.h
> 
> [Liming] This patch passed review early. But, it is not merged. I will 
> merge it.
> 
> Thanks
> 
> Liming
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Patch List for 202008 stable tag
  2020-08-20 12:43 ` Lendacky, Thomas
@ 2020-08-20 15:41   ` Vladimir Olovyannikov
  2020-08-21 11:10     ` Laszlo Ersek
  0 siblings, 1 reply; 15+ messages in thread
From: Vladimir Olovyannikov @ 2020-08-20 15:41 UTC (permalink / raw)
  To: Gao, Liming, Tom Lendacky, Leif Lindholm, Laszlo Ersek, afish,
	Kinney, Michael D, Guptha, Soumya K,
	Chang, Abner (HPS SW/FW Technologist)
  Cc: devel

Hi Gao,

> -----Original Message-----
> From: Tom Lendacky <thomas.lendacky@amd.com>
> Sent: Thursday, August 20, 2020 5:44 AM
> To: Gao, Liming <liming.gao@intel.com>; Leif Lindholm
<leif@nuviainc.com>;
> Laszlo Ersek <lersek@redhat.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Guptha, Soumya K
> <soumya.k.guptha@intel.com>; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; Vladimir Olovyannikov
> <vladimir.olovyannikov@broadcom.com>
> Cc: devel@edk2.groups.io
> Subject: Re: Patch List for 202008 stable tag
>
> Oh, I didn't realize you were waiting on another version of the bug fix.
> I'll send a v2 with the change over to:
>
>    DoDecrement = (BOOLEAN) (CpuMpData->InitFlag == ApInitConfig);
>
> Thanks,
> Tom
>
> On 8/20/20 6:30 AM, Gao, Liming wrote:
> > Hi Stewards and all:
> >
> >    I collect current patch lists in devel mail list. Those patch
> > contributors request to add them for 202008 stable tag. Because we
> > have enter into Soft Feature Freeze, I want to collect your feedback
for
> them.
> > If any patches are missing, please reply this mail to add them.
> >
> > *Feature List:*
> >
> > https://edk2.groups.io/g/devel/message/63767
> >
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed
> k
> >
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F63767&data=02%7C01%7Cthomas
> .lendac
> >
> ky%40amd.com%7C04409f1bdbf04facbdf308d844fc7ad5%7C3dd8961fe4884e
> 608e11
> >
> a82d994e183d%7C0%7C0%7C637335198474345594&sdata=6APiDA0gEzodq5N
> qaM69fS
> > gbkTWr5FVFr%2FcAS4cTAfY%3D&reserved=0>
> > [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
> >
> > [Liming] This patch pass code review after Soft Feature Freeze (SFF)
> > starts. According to SFF definition, it should not be merged for this
> > stable tag. But, the patch submitter says this patch is important to
> > RISC-V community. To catch it for this stable tag, Laszlo proposed the
> > solution to defer SFF start day from 2020-08-14 to 2020-08-21, then
> > hard feature freeze and release date will also defer one week. Any
> > patches those pass review before new SFF start day can be merged. @
> > Stewards, please give your comments to defer this stable tag release
by
> one week.
> >
> > https://edk2.groups.io/g/devel/message/63348
> >
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed
> k
> >
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F63348&data=02%7C01%7Cthomas
> .lendac
> >
> ky%40amd.com%7C04409f1bdbf04facbdf308d844fc7ad5%7C3dd8961fe4884e
> 608e11
> >
> a82d994e183d%7C0%7C0%7C637335198474345594&sdata=NGolIWo0RmVnE
> CYD9p9RwZ
> > KlTW0lVRJCs2Yl5TS1NX8%3D&reserved=0>
> > [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
> >
> > [Liming] This patch has collected the review comment. New version will
> > be sent. I have no information how important it is. @Vladimir, does
> > this patch must catch this stable tag? If yes, can you give the
reason?
I am sending the revised patch set today. The patchset adds "http" command
which
works the same way as tftp. I am not sure how important it is, as this is
an improvement,
not a bug fix. When these are in, OvmfPkg/ArmVirtPkg will have this
feature in as well.
@Laszlo
Laszlo, can you please add your comment?

Thank you,
Vladimir
> >
> > *Bug List:*
> >
> > https://edk2.groups.io/g/devel/message/64383
> >
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed
> k
> >
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F64383&data=02%7C01%7Cthomas
> .lendac
> >
> ky%40amd.com%7C04409f1bdbf04facbdf308d844fc7ad5%7C3dd8961fe4884e
> 608e11
> >
> a82d994e183d%7C0%7C0%7C637335198474355583&sdata=nR8jZ9zQ6je9vz3r
> dCkv%2
> > BTSHjBIaRPr%2FdqPOgxUNH4Y%3D&reserved=0>
> > [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement
> > variable
> >
> > [Liming] This patch has collected the review comment. New version will
> > be sent.
> >
> > https://edk2.groups.io/g/devel/message/50406
> >
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fed
> k
> >
> 2.groups.io%2Fg%2Fdevel%2Fmessage%2F50406&data=02%7C01%7Cthomas
> .lendac
> >
> ky%40amd.com%7C04409f1bdbf04facbdf308d844fc7ad5%7C3dd8961fe4884e
> 608e11
> >
> a82d994e183d%7C0%7C0%7C637335198474355583&sdata=jzJAHkl5Lc8BDzDH
> w1GOjf
> > QUDe2E1yAIroEkBmUrAHU%3D&reserved=0>
> > [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h
> > in SmBios.h
> >
> > [Liming] This patch passed review early. But, it is not merged. I will
> > merge it.
> >
> > Thanks
> >
> > Liming
> >

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Patch List for 202008 stable tag
  2020-08-20 11:30 Patch List for 202008 stable tag Liming Gao
  2020-08-20 12:43 ` Lendacky, Thomas
@ 2020-08-21  3:21 ` Abner Chang
  2020-08-21  4:11   ` [edk2-devel] " Liming Gao
  2020-08-21 11:06 ` Laszlo Ersek
  2 siblings, 1 reply; 15+ messages in thread
From: Abner Chang @ 2020-08-21  3:21 UTC (permalink / raw)
  To: Gao, Liming, Leif Lindholm, Laszlo Ersek, afish@apple.com,
	Kinney, Michael D, Guptha, Soumya K, Vladimir Olovyannikov,
	Tom Lendacky
  Cc: devel@edk2.groups.io

[-- Attachment #1: Type: text/plain, Size: 2736 bytes --]

Hi Liming, I didn't see https://edk2.groups.io/g/devel/message/63767<https://edk2.groups.io/g/devel/message/63767> [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
push to edk2 master and today is 8/12. Could you please help to push this commit?

Thanks
Abner

From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Thursday, August 20, 2020 7:31 PM
To: Leif Lindholm <leif@nuviainc.com>; Laszlo Ersek <lersek@redhat.com>; afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>; Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io
Subject: Patch List for 202008 stable tag

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 202008 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.

Feature List:
https://edk2.groups.io/g/devel/message/63767<https://edk2.groups.io/g/devel/message/63767> [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
[Liming] This patch pass code review after Soft Feature Freeze (SFF) starts. According to SFF definition, it should not be merged for this stable tag. But, the patch submitter says this patch is important to RISC-V community. To catch it for this stable tag, Laszlo proposed the solution to defer SFF start day from 2020-08-14 to 2020-08-21, then hard feature freeze and release date will also defer one week. Any patches those pass review before new SFF start day can be merged. @ Stewards, please give your comments to defer this stable tag release by one week.

https://edk2.groups.io/g/devel/message/63348<https://edk2.groups.io/g/devel/message/63348> [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
[Liming] This patch has collected the review comment. New version will be sent. I have no information how important it is. @Vladimir, does this patch must catch this stable tag? If yes, can you give the reason?

Bug List:
https://edk2.groups.io/g/devel/message/64383<https://edk2.groups.io/g/devel/message/64383> [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
[Liming] This patch has collected the review comment. New version will be sent.

https://edk2.groups.io/g/devel/message/50406<https://edk2.groups.io/g/devel/message/50406> [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
[Liming] This patch passed review early. But, it is not merged. I will merge it.

Thanks
Liming

[-- Attachment #2: Type: text/html, Size: 11658 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [edk2-devel] Patch List for 202008 stable tag
  2020-08-21  3:21 ` Abner Chang
@ 2020-08-21  4:11   ` Liming Gao
  2020-08-21  4:14     ` Abner Chang
  0 siblings, 1 reply; 15+ messages in thread
From: Liming Gao @ 2020-08-21  4:11 UTC (permalink / raw)
  To: devel@edk2.groups.io, abner.chang@hpe.com, Leif Lindholm,
	Laszlo Ersek, afish@apple.com, Kinney, Michael D,
	Guptha, Soumya K, Vladimir Olovyannikov, Tom Lendacky

[-- Attachment #1: Type: text/plain, Size: 3477 bytes --]

Abner:
 I plan to wait 1~2 days and collect the feedback about delay 202008 stable tag. If no objection, I will help merge this change.

Thanks
Liming
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang
Sent: 2020年8月21日 11:22
To: Gao, Liming <liming.gao@intel.com>; Leif Lindholm <leif@nuviainc.com>; Laszlo Ersek <lersek@redhat.com>; afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>; Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>; Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] Patch List for 202008 stable tag

Hi Liming, I didn’t see https://edk2.groups.io/g/devel/message/63767 [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
push to edk2 master and today is 8/12. Could you please help to push this commit?

Thanks
Abner

From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Thursday, August 20, 2020 7:31 PM
To: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Guptha, Soumya K <soumya.k.guptha@intel.com<mailto:soumya.k.guptha@intel.com>>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com<mailto:vladimir.olovyannikov@broadcom.com>>; Tom Lendacky <thomas.lendacky@amd.com<mailto:thomas.lendacky@amd.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Patch List for 202008 stable tag

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 202008 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.

Feature List:
https://edk2.groups.io/g/devel/message/63767 [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
[Liming] This patch pass code review after Soft Feature Freeze (SFF) starts. According to SFF definition, it should not be merged for this stable tag. But, the patch submitter says this patch is important to RISC-V community. To catch it for this stable tag, Laszlo proposed the solution to defer SFF start day from 2020-08-14 to 2020-08-21, then hard feature freeze and release date will also defer one week. Any patches those pass review before new SFF start day can be merged. @ Stewards, please give your comments to defer this stable tag release by one week.

https://edk2.groups.io/g/devel/message/63348 [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
[Liming] This patch has collected the review comment. New version will be sent. I have no information how important it is. @Vladimir, does this patch must catch this stable tag? If yes, can you give the reason?

Bug List:
https://edk2.groups.io/g/devel/message/64383 [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
[Liming] This patch has collected the review comment. New version will be sent.

https://edk2.groups.io/g/devel/message/50406 [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
[Liming] This patch passed review early. But, it is not merged. I will merge it.

Thanks
Liming


[-- Attachment #2: Type: text/html, Size: 13969 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [edk2-devel] Patch List for 202008 stable tag
  2020-08-21  4:11   ` [edk2-devel] " Liming Gao
@ 2020-08-21  4:14     ` Abner Chang
  0 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2020-08-21  4:14 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io, Leif Lindholm, Laszlo Ersek,
	afish@apple.com, Kinney, Michael D, Guptha, Soumya K,
	Vladimir Olovyannikov, Tom Lendacky

[-- Attachment #1: Type: text/plain, Size: 4631 bytes --]

Ok. Thanks. Just make sure someone will help to merge it.

Abner

From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Friday, August 21, 2020 12:12 PM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Leif Lindholm <leif@nuviainc.com>; Laszlo Ersek <lersek@redhat.com>; afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>; Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>; Tom Lendacky <thomas.lendacky@amd.com>
Subject: RE: [edk2-devel] Patch List for 202008 stable tag

Abner:
 I plan to wait 1~2 days and collect the feedback about delay 202008 stable tag. If no objection, I will help merge this change.

Thanks
Liming
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Abner Chang
Sent: 2020年8月21日 11:22
To: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Guptha, Soumya K <soumya.k.guptha@intel.com<mailto:soumya.k.guptha@intel.com>>; Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com<mailto:vladimir.olovyannikov@broadcom.com>>; Tom Lendacky <thomas.lendacky@amd.com<mailto:thomas.lendacky@amd.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Re: [edk2-devel] Patch List for 202008 stable tag

Hi Liming, I didn’t see https://edk2.groups.io/g/devel/message/63767<https://edk2.groups.io/g/devel/message/63767> [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
push to edk2 master and today is 8/12. Could you please help to push this commit?

Thanks
Abner

From: Gao, Liming [mailto:liming.gao@intel.com]
Sent: Thursday, August 20, 2020 7:31 PM
To: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Guptha, Soumya K <soumya.k.guptha@intel.com<mailto:soumya.k.guptha@intel.com>>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com<mailto:vladimir.olovyannikov@broadcom.com>>; Tom Lendacky <thomas.lendacky@amd.com<mailto:thomas.lendacky@amd.com>>
Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: Patch List for 202008 stable tag

Hi Stewards and all:
  I collect current patch lists in devel mail list. Those patch contributors request to add them for 202008 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.

Feature List:
https://edk2.groups.io/g/devel/message/63767<https://edk2.groups.io/g/devel/message/63767> [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
[Liming] This patch pass code review after Soft Feature Freeze (SFF) starts. According to SFF definition, it should not be merged for this stable tag. But, the patch submitter says this patch is important to RISC-V community. To catch it for this stable tag, Laszlo proposed the solution to defer SFF start day from 2020-08-14 to 2020-08-21, then hard feature freeze and release date will also defer one week. Any patches those pass review before new SFF start day can be merged. @ Stewards, please give your comments to defer this stable tag release by one week.

https://edk2.groups.io/g/devel/message/63348<https://edk2.groups.io/g/devel/message/63348> [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
[Liming] This patch has collected the review comment. New version will be sent. I have no information how important it is. @Vladimir, does this patch must catch this stable tag? If yes, can you give the reason?

Bug List:
https://edk2.groups.io/g/devel/message/64383<https://edk2.groups.io/g/devel/message/64383> [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
[Liming] This patch has collected the review comment. New version will be sent.

https://edk2.groups.io/g/devel/message/50406<https://edk2.groups.io/g/devel/message/50406> [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
[Liming] This patch passed review early. But, it is not merged. I will merge it.

Thanks
Liming


[-- Attachment #2: Type: text/html, Size: 16618 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Patch List for 202008 stable tag
  2020-08-20 11:30 Patch List for 202008 stable tag Liming Gao
  2020-08-20 12:43 ` Lendacky, Thomas
  2020-08-21  3:21 ` Abner Chang
@ 2020-08-21 11:06 ` Laszlo Ersek
  2020-08-22  0:15   ` 答复: [edk2-devel] " gaoliming
       [not found]   ` <162D6EE567916534.7353@groups.io>
  2 siblings, 2 replies; 15+ messages in thread
From: Laszlo Ersek @ 2020-08-21 11:06 UTC (permalink / raw)
  To: Gao, Liming, Leif Lindholm, afish@apple.com, Kinney, Michael D,
	Guptha, Soumya K, Chang, Abner (HPS SW/FW Technologist),
	Vladimir Olovyannikov, Tom Lendacky
  Cc: devel@edk2.groups.io

On 08/20/20 13:30, Gao, Liming wrote:
> Hi Stewards and all:
>   I collect current patch lists in devel mail list. Those patch contributors request to add them for 202008 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.
> 
> Feature List:
> https://edk2.groups.io/g/devel/message/63767 [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp
> [Liming] This patch pass code review after Soft Feature Freeze (SFF) starts. According to SFF definition, it should not be merged for this stable tag. But, the patch submitter says this patch is important to RISC-V community. To catch it for this stable tag, Laszlo proposed the solution to defer SFF start day from 2020-08-14 to 2020-08-21, then hard feature freeze and release date will also defer one week. Any patches those pass review before new SFF start day can be merged. @ Stewards, please give your comments to defer this stable tag release by one week.

Thank you, very nice summary.

As stated earlier, I'm OK with 1 week (or even two weeks, if needed)
extension. I invite Andrew, Leif and Mike to comment.

> 
> https://edk2.groups.io/g/devel/message/63348 [PATCH v5 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand
> [Liming] This patch has collected the review comment. New version will be sent. I have no information how important it is. @Vladimir, does this patch must catch this stable tag? If yes, can you give the reason?

This is a feature addition. While it's a super useful feature, it needs
to mature (mainly from the coding style perspective, as I gather).
Posting of new versions and review are on-going.

Most likely material for the next stable tag. In case we extend the
deadlines, and Maciej and the ShellPkg maintainers approve one of the
upcoming versions until the new SFF, then yes, we can merge that too.

> Bug List:
> https://edk2.groups.io/g/devel/message/64383 [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
> [Liming] This patch has collected the review comment. New version will be sent.

This is a bugfix. Certainly a build fix on CLANGPDB. I tried to do some
(lightweight) analysis to see whether the bug is a functional one as
well (i.e. whether the bad code path that CLANG warns about can actually
occur in practice), but in the end I didn't want to spend much time on
it, as the build breakage needs to be fixed anyway.

So, this patch (more precisely, v2 of this patch) would even qualify
during the hard feature freeze (as it's clearly a bugfix).

> 
> https://edk2.groups.io/g/devel/message/50406 [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
> [Liming] This patch passed review early. But, it is not merged. I will merge it.

Right, it was approved on 2019-Nov-18. If it still applies cleanly, it
should be merged, before we enter the Hard Feature Freeze.

Well... now that I'm writing this, we have already entered the HFF (as
planned originally) and the patch doesn't seem to be upstream yet. So
unless we extend, I don't think this patch qualifies.

(On the other hand -- it seems like we really should extend.)

Thanks!
Laszlo


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Patch List for 202008 stable tag
  2020-08-20 15:41   ` Vladimir Olovyannikov
@ 2020-08-21 11:10     ` Laszlo Ersek
  2020-08-21 16:26       ` Vladimir Olovyannikov
  0 siblings, 1 reply; 15+ messages in thread
From: Laszlo Ersek @ 2020-08-21 11:10 UTC (permalink / raw)
  To: Vladimir Olovyannikov, Gao, Liming, Tom Lendacky, Leif Lindholm,
	afish, Kinney, Michael D, Guptha, Soumya K,
	Chang, Abner (HPS SW/FW Technologist)
  Cc: devel

On 08/20/20 17:41, Vladimir Olovyannikov wrote:

> I am sending the revised patch set today. The patchset adds "http"
> command which works the same way as tftp. I am not sure how important
> it is, as this is an improvement, not a bug fix. When these are in,
> OvmfPkg/ArmVirtPkg will have this feature in as well. @Laszlo Laszlo,
> can you please add your comment?

Expanding on what I said elsewhere in this thread, I'd like to confirm
that, *whenever* the HTTP dynamic command is merged, the dependent
OvmfPkg/ArmVirtPkg patches can / should be merged too, as they have been
reviewed and test earlier, in the thread linked in the bugzilla comment at

  https://bugzilla.tianocore.org/show_bug.cgi?id=2857#c2

Thanks
Laszlo


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: Patch List for 202008 stable tag
  2020-08-21 11:10     ` Laszlo Ersek
@ 2020-08-21 16:26       ` Vladimir Olovyannikov
  2020-08-22  0:09         ` 答复: [edk2-devel] " gaoliming
  0 siblings, 1 reply; 15+ messages in thread
From: Vladimir Olovyannikov @ 2020-08-21 16:26 UTC (permalink / raw)
  To: Gao, Liming, Laszlo Ersek, Tom Lendacky, Leif Lindholm, afish,
	Kinney, Michael D, Guptha, Soumya K,
	Chang, Abner (HPS SW/FW Technologist)
  Cc: devel

Hi Gao,

Can someone please also consider including this one?
https://edk2.groups.io/g/devel/message/61938

It was reviewed, but then stuck in limbo for a couple of months.

Thank you,
Vladimir

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Friday, August 21, 2020 4:10 AM
> To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>; Gao,
> Liming <liming.gao@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; Leif Lindholm <leif@nuviainc.com>;
> afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>;
> Guptha, Soumya K <soumya.k.guptha@intel.com>; Chang, Abner (HPS
> SW/FW Technologist) <abner.chang@hpe.com>
> Cc: devel@edk2.groups.io
> Subject: Re: Patch List for 202008 stable tag
>
> On 08/20/20 17:41, Vladimir Olovyannikov wrote:
>
> > I am sending the revised patch set today. The patchset adds "http"
> > command which works the same way as tftp. I am not sure how important
> > it is, as this is an improvement, not a bug fix. When these are in,
> > OvmfPkg/ArmVirtPkg will have this feature in as well. @Laszlo Laszlo,
> > can you please add your comment?
>
> Expanding on what I said elsewhere in this thread, I'd like to confirm
> that,
> *whenever* the HTTP dynamic command is merged, the dependent
> OvmfPkg/ArmVirtPkg patches can / should be merged too, as they have
> been reviewed and test earlier, in the thread linked in the bugzilla
> comment
> at
>
>   https://bugzilla.tianocore.org/show_bug.cgi?id=2857#c2
>
> Thanks
> Laszlo

^ permalink raw reply	[flat|nested] 15+ messages in thread

* 答复: [edk2-devel] Patch List for 202008 stable tag
  2020-08-21 16:26       ` Vladimir Olovyannikov
@ 2020-08-22  0:09         ` gaoliming
  0 siblings, 0 replies; 15+ messages in thread
From: gaoliming @ 2020-08-22  0:09 UTC (permalink / raw)
  To: devel, vladimir.olovyannikov, 'Gao, Liming',
	'Laszlo Ersek', 'Tom Lendacky',
	'Leif Lindholm', afish, 'Kinney, Michael D',
	'Guptha, Soumya K',
	'Chang, Abner (HPS SW/FW Technologist)'

Sure. Seemly, this one is also missing. 

> -----邮件原件-----
> 发件人: bounce+27952+64541+4905953+8761045@groups.io
> [mailto:bounce+27952+64541+4905953+8761045@groups.io] 代表
> Vladimir Olovyannikov via groups.io
> 发送时间: 2020年8月22日 0:27
> 收件人: Gao, Liming <liming.gao@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Tom Lendacky <thomas.lendacky@amd.com>; Leif
> Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Guptha, Soumya K
> <soumya.k.guptha@intel.com>; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> 抄送: devel@edk2.groups.io
> 主题: Re: [edk2-devel] Patch List for 202008 stable tag
> 
> Hi Gao,
> 
> Can someone please also consider including this one?
> https://edk2.groups.io/g/devel/message/61938
> 
> It was reviewed, but then stuck in limbo for a couple of months.
> 
> Thank you,
> Vladimir
> 
> > -----Original Message-----
> > From: Laszlo Ersek <lersek@redhat.com>
> > Sent: Friday, August 21, 2020 4:10 AM
> > To: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>; Gao,
> > Liming <liming.gao@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>;
> > Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Guptha, Soumya K
> > <soumya.k.guptha@intel.com>; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: devel@edk2.groups.io
> > Subject: Re: Patch List for 202008 stable tag
> >
> > On 08/20/20 17:41, Vladimir Olovyannikov wrote:
> >
> > > I am sending the revised patch set today. The patchset adds "http"
> > > command which works the same way as tftp. I am not sure how
> > > important it is, as this is an improvement, not a bug fix. When
> > > these are in, OvmfPkg/ArmVirtPkg will have this feature in as well.
> > > @Laszlo Laszlo, can you please add your comment?
> >
> > Expanding on what I said elsewhere in this thread, I'd like to confirm
> > that,
> > *whenever* the HTTP dynamic command is merged, the dependent
> > OvmfPkg/ArmVirtPkg patches can / should be merged too, as they have
> > been reviewed and test earlier, in the thread linked in the bugzilla
> > comment at
> >
> >   https://bugzilla.tianocore.org/show_bug.cgi?id=2857#c2
> >
> > Thanks
> > Laszlo
> 
> 




^ permalink raw reply	[flat|nested] 15+ messages in thread

* 答复: [edk2-devel] Patch List for 202008 stable tag
  2020-08-21 11:06 ` Laszlo Ersek
@ 2020-08-22  0:15   ` gaoliming
       [not found]   ` <162D6EE567916534.7353@groups.io>
  1 sibling, 0 replies; 15+ messages in thread
From: gaoliming @ 2020-08-22  0:15 UTC (permalink / raw)
  To: devel, lersek, 'Leif Lindholm', afish,
	'Kinney, Michael D', 'Guptha, Soumya K',
	'Chang, Abner (HPS SW/FW Technologist)',
	'Vladimir Olovyannikov', 'Tom Lendacky',
	gaoliming

Laszlo:

> -----邮件原件-----
> 发件人: bounce+27952+64532+4905953+8761045@groups.io
> [mailto:bounce+27952+64532+4905953+8761045@groups.io] 代表 Laszlo
> Ersek
> 发送时间: 2020年8月21日 19:07
> 收件人: Gao, Liming <liming.gao@intel.com>; Leif Lindholm
> <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Guptha, Soumya K
> <soumya.k.guptha@intel.com>; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; Vladimir Olovyannikov
> <vladimir.olovyannikov@broadcom.com>; Tom Lendacky
> <thomas.lendacky@amd.com>
> 抄送: devel@edk2.groups.io
> 主题: Re: [edk2-devel] Patch List for 202008 stable tag
> 
> On 08/20/20 13:30, Gao, Liming wrote:
> > Hi Stewards and all:
> >   I collect current patch lists in devel mail list. Those patch
contributors
> request to add them for 202008 stable tag. Because we have enter into Soft
> Feature Freeze, I want to collect your feedback for them. If any patches
are
> missing, please reply this mail to add them.
> >
> > Feature List:
> > https://edk2.groups.io/g/devel/message/63767 [PATCH]
> > EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp [Liming] This
> patch pass code review after Soft Feature Freeze (SFF) starts. According
to SFF
> definition, it should not be merged for this stable tag. But, the patch
submitter
> says this patch is important to RISC-V community. To catch it for this
stable tag,
> Laszlo proposed the solution to defer SFF start day from 2020-08-14 to
> 2020-08-21, then hard feature freeze and release date will also defer one
> week. Any patches those pass review before new SFF start day can be
merged.
> @ Stewards, please give your comments to defer this stable tag release by
> one week.
> 
> Thank you, very nice summary.
> 
> As stated earlier, I'm OK with 1 week (or even two weeks, if needed)
> extension. I invite Andrew, Leif and Mike to comment.
> 
[Liming] I don't see any other urgent request. I think it is enough to defer
1 week for this stable tag.
So far, there is objection for this defer. I will send the announcement
mail. 

> >
> > https://edk2.groups.io/g/devel/message/63348 [PATCH v5 1/1]
> > ShellPkg/DynamicCommand: add HttpDynamicCommand [Liming] This
> patch has collected the review comment. New version will be sent. I have
no
> information how important it is. @Vladimir, does this patch must catch
this
> stable tag? If yes, can you give the reason?
> 
> This is a feature addition. While it's a super useful feature, it needs to
mature
> (mainly from the coding style perspective, as I gather).
> Posting of new versions and review are on-going.
> 
> Most likely material for the next stable tag. In case we extend the
deadlines,
> and Maciej and the ShellPkg maintainers approve one of the upcoming
> versions until the new SFF, then yes, we can merge that too.
> 
[Liming] So, this is not urgent. Let's defer it to next stable tag. 

Thanks
Liming

> > Bug List:
> > https://edk2.groups.io/g/devel/message/64383 [PATCH 1/1]
> > UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
[Liming]
> This patch has collected the review comment. New version will be sent.
> 
> This is a bugfix. Certainly a build fix on CLANGPDB. I tried to do some
> (lightweight) analysis to see whether the bug is a functional one as well
(i.e.
> whether the bad code path that CLANG warns about can actually occur in
> practice), but in the end I didn't want to spend much time on it, as the
build
> breakage needs to be fixed anyway.
> 
> So, this patch (more precisely, v2 of this patch) would even qualify
during the
> hard feature freeze (as it's clearly a bugfix).
> 
> >
> > https://edk2.groups.io/g/devel/message/50406 [PATCH 1/1]
> > MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
> [Liming] This patch passed review early. But, it is not merged. I will
merge it.
> 
> Right, it was approved on 2019-Nov-18. If it still applies cleanly, it
should be
> merged, before we enter the Hard Feature Freeze.
> 
> Well... now that I'm writing this, we have already entered the HFF (as
planned
> originally) and the patch doesn't seem to be upstream yet. So unless we
> extend, I don't think this patch qualifies.
> 
> (On the other hand -- it seems like we really should extend.)
> 
> Thanks!
> Laszlo
> 
> 
> 




^ permalink raw reply	[flat|nested] 15+ messages in thread

* 回复: [edk2-devel] Patch List for 202008 stable tag
       [not found]   ` <162D6EE567916534.7353@groups.io>
@ 2020-09-01  9:35     ` gaoliming
  2020-09-01 12:33       ` Laszlo Ersek
  0 siblings, 1 reply; 15+ messages in thread
From: gaoliming @ 2020-09-01  9:35 UTC (permalink / raw)
  To: devel, gaoliming, lersek, 'Leif Lindholm', afish,
	'Kinney, Michael D', 'Guptha, Soumya K',
	'Zhiguang Liu', 'Zhang, Qi1'

Hi, all
  There are still some patches to be merged for 202008 stable tag. They are
all bug fixes. The risk is low. I agree to catch them in this stable tag. If
you have other comments, please reply this mail. 

https://edk2.groups.io/g/devel/message/64873 [PATCH v3]
MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull
https://edk2.groups.io/g/devel/message/64865 [PATCH] SecurityPkg: Initailize
variable Status before it is consumed.
https://edk2.groups.io/g/devel/message/64812 [PATCH]
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec: add FspMeasurementLib.h

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+64554+4905953+8761045@groups.io
> <bounce+27952+64554+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2020年8月22日 8:16
> 收件人: devel@edk2.groups.io; lersek@redhat.com; 'Leif Lindholm'
> <leif@nuviainc.com>; afish@apple.com; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; 'Guptha, Soumya K'
> <soumya.k.guptha@intel.com>; 'Chang, Abner (HPS SW/FW Technologist)'
> <abner.chang@hpe.com>; 'Vladimir Olovyannikov'
> <vladimir.olovyannikov@broadcom.com>; 'Tom Lendacky'
> <thomas.lendacky@amd.com>; gaoliming@byosoft.com.cn
> 主题: 答复: [edk2-devel] Patch List for 202008 stable tag
> 
> Laszlo:
> 
> > -----邮件原件-----
> > 发件人: bounce+27952+64532+4905953+8761045@groups.io
> > [mailto:bounce+27952+64532+4905953+8761045@groups.io] 代表 Laszlo
> > Ersek
> > 发送时间: 2020年8月21日 19:07
> > 收件人: Gao, Liming <liming.gao@intel.com>; Leif Lindholm
> > <leif@nuviainc.com>; afish@apple.com; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Guptha, Soumya K
> > <soumya.k.guptha@intel.com>; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>; Vladimir Olovyannikov
> > <vladimir.olovyannikov@broadcom.com>; Tom Lendacky
> > <thomas.lendacky@amd.com>
> > 抄送: devel@edk2.groups.io
> > 主题: Re: [edk2-devel] Patch List for 202008 stable tag
> >
> > On 08/20/20 13:30, Gao, Liming wrote:
> > > Hi Stewards and all:
> > >   I collect current patch lists in devel mail list. Those patch
> contributors
> > request to add them for 202008 stable tag. Because we have enter into
Soft
> > Feature Freeze, I want to collect your feedback for them. If any patches
> are
> > missing, please reply this mail to add them.
> > >
> > > Feature List:
> > > https://edk2.groups.io/g/devel/message/63767 [PATCH]
> > > EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp [Liming]
> This
> > patch pass code review after Soft Feature Freeze (SFF) starts. According
> to SFF
> > definition, it should not be merged for this stable tag. But, the patch
> submitter
> > says this patch is important to RISC-V community. To catch it for this
> stable tag,
> > Laszlo proposed the solution to defer SFF start day from 2020-08-14 to
> > 2020-08-21, then hard feature freeze and release date will also defer
one
> > week. Any patches those pass review before new SFF start day can be
> merged.
> > @ Stewards, please give your comments to defer this stable tag release
by
> > one week.
> >
> > Thank you, very nice summary.
> >
> > As stated earlier, I'm OK with 1 week (or even two weeks, if needed)
> > extension. I invite Andrew, Leif and Mike to comment.
> >
> [Liming] I don't see any other urgent request. I think it is enough to
defer
> 1 week for this stable tag.
> So far, there is objection for this defer. I will send the announcement
> mail.
> 
> > >
> > > https://edk2.groups.io/g/devel/message/63348 [PATCH v5 1/1]
> > > ShellPkg/DynamicCommand: add HttpDynamicCommand [Liming] This
> > patch has collected the review comment. New version will be sent. I have
> no
> > information how important it is. @Vladimir, does this patch must catch
> this
> > stable tag? If yes, can you give the reason?
> >
> > This is a feature addition. While it's a super useful feature, it needs
to
> mature
> > (mainly from the coding style perspective, as I gather).
> > Posting of new versions and review are on-going.
> >
> > Most likely material for the next stable tag. In case we extend the
> deadlines,
> > and Maciej and the ShellPkg maintainers approve one of the upcoming
> > versions until the new SFF, then yes, we can merge that too.
> >
> [Liming] So, this is not urgent. Let's defer it to next stable tag.
> 
> Thanks
> Liming
> 
> > > Bug List:
> > > https://edk2.groups.io/g/devel/message/64383 [PATCH 1/1]
> > > UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable
> [Liming]
> > This patch has collected the review comment. New version will be sent.
> >
> > This is a bugfix. Certainly a build fix on CLANGPDB. I tried to do some
> > (lightweight) analysis to see whether the bug is a functional one as
well
> (i.e.
> > whether the bad code path that CLANG warns about can actually occur in
> > practice), but in the end I didn't want to spend much time on it, as the
> build
> > breakage needs to be fixed anyway.
> >
> > So, this patch (more precisely, v2 of this patch) would even qualify
> during the
> > hard feature freeze (as it's clearly a bugfix).
> >
> > >
> > > https://edk2.groups.io/g/devel/message/50406 [PATCH 1/1]
> > > MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h
> > [Liming] This patch passed review early. But, it is not merged. I will
> merge it.
> >
> > Right, it was approved on 2019-Nov-18. If it still applies cleanly, it
> should be
> > merged, before we enter the Hard Feature Freeze.
> >
> > Well... now that I'm writing this, we have already entered the HFF (as
> planned
> > originally) and the patch doesn't seem to be upstream yet. So unless we
> > extend, I don't think this patch qualifies.
> >
> > (On the other hand -- it seems like we really should extend.)
> >
> > Thanks!
> > Laszlo
> >
> >
> >
> 
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 回复: [edk2-devel] Patch List for 202008 stable tag
  2020-09-01  9:35     ` 回复: " gaoliming
@ 2020-09-01 12:33       ` Laszlo Ersek
  2020-09-01 14:57         ` 回复: " gaoliming
  0 siblings, 1 reply; 15+ messages in thread
From: Laszlo Ersek @ 2020-09-01 12:33 UTC (permalink / raw)
  To: gaoliming, devel, 'Leif Lindholm', afish,
	'Kinney, Michael D', 'Guptha, Soumya K',
	'Zhiguang Liu', 'Zhang, Qi1'

On 09/01/20 11:35, gaoliming wrote:
> Hi, all
> There are still some patches to be merged for 202008 stable tag. They
> are all bug fixes. The risk is low. I agree to catch them in this
> stable tag. If you have other comments, please reply this mail.
>
> https://edk2.groups.io/g/devel/message/64873
> [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to TpmMeasurementLibNull

Needs maintainer approval, and then it should be merged, yes.


> https://edk2.groups.io/g/devel/message/64865
> [PATCH] SecurityPkg: Initailize variable Status before it is consumed.

Needs maintainer approval, and then it should be merged, yes.


> https://edk2.groups.io/g/devel/message/64812
> [PATCH] IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec: add FspMeasurementLib.h

Yes, should be merged (it has been Reviewed-by: Chasel Chiu
<chasel.chiu@intel.com>).


More candidates (bugfixes):

* [Patch V2] BaseTools/Ecc: Fix an issue of path separator compatibility
  https://edk2.groups.io/g/devel/message/64887
  http://mid.mail-archive.com/  <20200901102315.38840-1-bob.c.feng@intel.com

Needs maintainer review, and then it should be merged.


* [PATCH EDK2 v1 0/1] EmulatorPkg/host: fix overflow in Mult
  https://edk2.groups.io/g/devel/message/64890
  http://mid.mail-archive.com/  <1598957888-128729-1-git-send-email-xiewenyi2@huawei.com

Needs a review and a maintainer decision whether it is material for the
stable tag.


* [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment overflow (CVE-2019-14562)
  https://edk2.groups.io/g/devel/message/64882
  http://mid.mail-archive.com/  <20200901091221.20948-1-lersek@redhat.com

Needs maintainer review, plus testing from Wenyi Xie with their
reproducer, plus a maintainer decision whether it is material for the
stable tag.

Thanks
Laszlo


^ permalink raw reply	[flat|nested] 15+ messages in thread

* 回复: 回复: [edk2-devel] Patch List for 202008 stable tag
  2020-09-01 12:33       ` Laszlo Ersek
@ 2020-09-01 14:57         ` gaoliming
  2020-09-01 15:17           ` Laszlo Ersek
  0 siblings, 1 reply; 15+ messages in thread
From: gaoliming @ 2020-09-01 14:57 UTC (permalink / raw)
  To: 'Laszlo Ersek', devel, 'Leif Lindholm', afish,
	'Kinney, Michael D', 'Guptha, Soumya K',
	'Zhiguang Liu', 'Zhang, Qi1',
	'Yao, Jiewen', xiewenyi2, ray.ni

Hi, all
  Now, we are in Hard Feature Freeze phase. 202008 stable tag will be
created on 2020-09-04 Date (00:00:00 UTC-8).
  If you request any bug fix to catch this stable tag, please send your
request one day before 2020-09-04.
  And, also make sure this patch pass code review one day before 2020-09-04.
Then, we have time to merge it. 

Laszlo:
  I add my comments.

Thanks
Liming
> -----邮件原件-----
> 发件人: Laszlo Ersek <lersek@redhat.com>
> 发送时间: 2020年9月1日 20:34
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Leif
> Lindholm' <leif@nuviainc.com>; afish@apple.com; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; 'Guptha, Soumya K'
> <soumya.k.guptha@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>;
> 'Zhang, Qi1' <qi1.zhang@intel.com>
> 主题: Re: 回复: [edk2-devel] Patch List for 202008 stable tag
> 
> On 09/01/20 11:35, gaoliming wrote:
> > Hi, all
> > There are still some patches to be merged for 202008 stable tag. They
> > are all bug fixes. The risk is low. I agree to catch them in this
> > stable tag. If you have other comments, please reply this mail.
> >
> > https://edk2.groups.io/g/devel/message/64873
> > [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to
> TpmMeasurementLibNull
> 
> Needs maintainer approval, and then it should be merged, yes.
> 
> 
> > https://edk2.groups.io/g/devel/message/64865
> > [PATCH] SecurityPkg: Initailize variable Status before it is consumed.
> 
> Needs maintainer approval, and then it should be merged, yes.
> 
https://edk2.groups.io/g/devel/message/64843 Jiewen has given reviewed-by
for this patch. 

> 
> > https://edk2.groups.io/g/devel/message/64812
> > [PATCH] IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec: add
> FspMeasurementLib.h
> 
> Yes, should be merged (it has been Reviewed-by: Chasel Chiu
> <chasel.chiu@intel.com>).
> 
> 
> More candidates (bugfixes):
> 
> * [Patch V2] BaseTools/Ecc: Fix an issue of path separator compatibility
>   https://edk2.groups.io/g/devel/message/64887
>   http://mid.mail-archive.com/
> <20200901102315.38840-1-bob.c.feng@intel.com
> 
> Needs maintainer review, and then it should be merged.
> 
Agree. I give Reviewed-by. https://edk2.groups.io/g/devel/message/64900

> 
> * [PATCH EDK2 v1 0/1] EmulatorPkg/host: fix overflow in Mult
>   https://edk2.groups.io/g/devel/message/64890
>   http://mid.mail-archive.com/
> <1598957888-128729-1-git-send-email-xiewenyi2@huawei.com
> 
> Needs a review and a maintainer decision whether it is material for the
> stable tag.
> 
> 
> * [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment
overflow
> (CVE-2019-14562)
>   https://edk2.groups.io/g/devel/message/64882
>   http://mid.mail-archive.com/
> <20200901091221.20948-1-lersek@redhat.com
> 
> Needs maintainer review, plus testing from Wenyi Xie with their
> reproducer, plus a maintainer decision whether it is material for the
> stable tag.
> 
> Thanks
> Laszlo




^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: 回复: 回复: [edk2-devel] Patch List for 202008 stable tag
  2020-09-01 14:57         ` 回复: " gaoliming
@ 2020-09-01 15:17           ` Laszlo Ersek
  0 siblings, 0 replies; 15+ messages in thread
From: Laszlo Ersek @ 2020-09-01 15:17 UTC (permalink / raw)
  To: gaoliming, devel, 'Leif Lindholm', afish,
	'Kinney, Michael D', 'Guptha, Soumya K',
	'Zhiguang Liu', 'Zhang, Qi1',
	'Yao, Jiewen', xiewenyi2, ray.ni

On 09/01/20 16:57, gaoliming wrote:
> Hi, all
>   Now, we are in Hard Feature Freeze phase. 202008 stable tag will be
> created on 2020-09-04 Date (00:00:00 UTC-8).
>   If you request any bug fix to catch this stable tag, please send your
> request one day before 2020-09-04.
>   And, also make sure this patch pass code review one day before 2020-09-04.
> Then, we have time to merge it. 
> 
> Laszlo:
>   I add my comments.
> 
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: Laszlo Ersek <lersek@redhat.com>
>> 发送时间: 2020年9月1日 20:34
>> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; 'Leif
>> Lindholm' <leif@nuviainc.com>; afish@apple.com; 'Kinney, Michael D'
>> <michael.d.kinney@intel.com>; 'Guptha, Soumya K'
>> <soumya.k.guptha@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>;
>> 'Zhang, Qi1' <qi1.zhang@intel.com>
>> 主题: Re: 回复: [edk2-devel] Patch List for 202008 stable tag
>>
>> On 09/01/20 11:35, gaoliming wrote:
>>> Hi, all
>>> There are still some patches to be merged for 202008 stable tag. They
>>> are all bug fixes. The risk is low. I agree to catch them in this
>>> stable tag. If you have other comments, please reply this mail.
>>>
>>> https://edk2.groups.io/g/devel/message/64873
>>> [PATCH v3] MdeModulePkg/Library: add PEIM and SEC module type to
>> TpmMeasurementLibNull
>>
>> Needs maintainer approval, and then it should be merged, yes.
>>
>>
>>> https://edk2.groups.io/g/devel/message/64865
>>> [PATCH] SecurityPkg: Initailize variable Status before it is consumed.
>>
>> Needs maintainer approval, and then it should be merged, yes.
>>
> https://edk2.groups.io/g/devel/message/64843 Jiewen has given reviewed-by
> for this patch. 

Ah, you are correct. It was even correctly included in v2. Sorry about
missing it!

Thanks!
Laszlo

> 
>>
>>> https://edk2.groups.io/g/devel/message/64812
>>> [PATCH] IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec: add
>> FspMeasurementLib.h
>>
>> Yes, should be merged (it has been Reviewed-by: Chasel Chiu
>> <chasel.chiu@intel.com>).
>>
>>
>> More candidates (bugfixes):
>>
>> * [Patch V2] BaseTools/Ecc: Fix an issue of path separator compatibility
>>   https://edk2.groups.io/g/devel/message/64887
>>   http://mid.mail-archive.com/
>> <20200901102315.38840-1-bob.c.feng@intel.com
>>
>> Needs maintainer review, and then it should be merged.
>>
> Agree. I give Reviewed-by. https://edk2.groups.io/g/devel/message/64900
> 
>>
>> * [PATCH EDK2 v1 0/1] EmulatorPkg/host: fix overflow in Mult
>>   https://edk2.groups.io/g/devel/message/64890
>>   http://mid.mail-archive.com/
>> <1598957888-128729-1-git-send-email-xiewenyi2@huawei.com
>>
>> Needs a review and a maintainer decision whether it is material for the
>> stable tag.
>>
>>
>> * [PATCH 0/3] SecurityPkg/DxeImageVerificationLib: catch alignment
> overflow
>> (CVE-2019-14562)
>>   https://edk2.groups.io/g/devel/message/64882
>>   http://mid.mail-archive.com/
>> <20200901091221.20948-1-lersek@redhat.com
>>
>> Needs maintainer review, plus testing from Wenyi Xie with their
>> reproducer, plus a maintainer decision whether it is material for the
>> stable tag.
>>
>> Thanks
>> Laszlo
> 
> 
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2020-09-01 15:17 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-20 11:30 Patch List for 202008 stable tag Liming Gao
2020-08-20 12:43 ` Lendacky, Thomas
2020-08-20 15:41   ` Vladimir Olovyannikov
2020-08-21 11:10     ` Laszlo Ersek
2020-08-21 16:26       ` Vladimir Olovyannikov
2020-08-22  0:09         ` 答复: [edk2-devel] " gaoliming
2020-08-21  3:21 ` Abner Chang
2020-08-21  4:11   ` [edk2-devel] " Liming Gao
2020-08-21  4:14     ` Abner Chang
2020-08-21 11:06 ` Laszlo Ersek
2020-08-22  0:15   ` 答复: [edk2-devel] " gaoliming
     [not found]   ` <162D6EE567916534.7353@groups.io>
2020-09-01  9:35     ` 回复: " gaoliming
2020-09-01 12:33       ` Laszlo Ersek
2020-09-01 14:57         ` 回复: " gaoliming
2020-09-01 15:17           ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox