From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.12409.1669096083515759844 for ; Mon, 21 Nov 2022 21:48:03 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FidUQAzy; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669096083; x=1700632083; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Pl9t2qZcTL7IVHy2i7nUoIHiHUn4BWznFp4jAnMO3yE=; b=FidUQAzyvT8kEseNdBm7A4461Wp3C/aAIxtQeV6TeEBzzUpt0WX5uyQZ 5qQM2S4U0iI+WUluERXhJHn6NIIRTfNALO+98BiHXhlnM4GPuvnEChZk+ rf20LFQli0HTm/iEOqGbXGdkSiQ/2NOtb3zxOzxgiSIOWCoWwXLb3AWIE oCBPkYeKhf302I+wYOnlNemyFVgKOIy21JyNC5yaKehiYLvB0Kg4ucXBl 5jR/FxGzqXSH100oqj4CJ7krzzUyyDKLsXkbDKlSYDWD7lzdHYADZogMG TRPtvayrql/Faxdl7KOQgmqzWOS5M+xIMXESlQT0kKOQ9mCC8lNRi9AtJ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="315559161" X-IronPort-AV: E=Sophos;i="5.96,183,1665471600"; d="scan'208";a="315559161" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 21:48:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="766226745" X-IronPort-AV: E=Sophos;i="5.96,183,1665471600"; d="scan'208";a="766226745" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 21 Nov 2022 21:48:02 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 21 Nov 2022 21:48:02 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 21 Nov 2022 21:48:02 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 21 Nov 2022 21:48:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hn3ml3wNshu/tlcOnWR2L6nuOawyK1eRbxvhvJafciDwD6Vld5uTPq9eudPAzfx7MS+HhKFDX0WokOHauwiRtPBQGijF/xsKvfHETnJFlxluTeekPsMYnI67f8ujajS0oDsbcQEGD3Hmtx0rQR+4iPaBlizcQsrnX+phhK57E+mc4pXWi8PmjnScqmgkdi/C4I/nkpPD9c+b1+vCkM7Se5ZiRlrUr9fS2BuKTNMHhu9IYT1wTDvVSnANfXIupPhzMbfi9o4/PbHl7knosB6qKhX/+n6ywlMfaQRPCC/fPWaCdmCz7nq9yAN5jQDaK2dNgOdj9qZIC6dN7TPLs7IZuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hPSXtzvjTY+L2y6niXOkBp+tSdwsF224RGLcnD2sQFQ=; b=KOhtoPjb+4giFn6s0Y0ewmHcdypMsBzvvH+adyQtDVMQRUyDYO4u8c5peRrxclCVo0mx7QjwDHX/+zV78jAOMa0S8pvAWy3NqQ2M+uhul+/ylV+wbKlYaGsLPRsz1xGBM8+8gg/eZNegroP8nPphK7XEaL3ggUv4B1YIIpTeMuz0ga9L6UXv/Ash6VyUd0hIHmRddbTdpqYom7T0HIuuzryO3ukYg4waV65cxMjKOBDpXz0cKiBlU5xD1FQCnXTVE6EDIfO46kTH2kHe5adaraB+2ooY2zJSzbCZMoWzjLaoty4g7LIEAX+jN7ITwWpLEqO0Wtd7xkqlriyyzPH9Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR11MB1622.namprd11.prod.outlook.com (2603:10b6:910:e::10) by CH0PR11MB5300.namprd11.prod.outlook.com (2603:10b6:610:bf::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Tue, 22 Nov 2022 05:48:01 +0000 Received: from CY4PR11MB1622.namprd11.prod.outlook.com ([fe80::18e:10de:92ab:7526]) by CY4PR11MB1622.namprd11.prod.outlook.com ([fe80::18e:10de:92ab:7526%10]) with mapi id 15.20.5834.011; Tue, 22 Nov 2022 05:48:01 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "abner.chang@amd.com" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC Thread-Topic: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section 5.4.2.2 STATIC Thread-Index: AQHY/i2l1ZbUe5p+uEamPchmelEW265KbpDw Date: Tue, 22 Nov 2022 05:48:01 +0000 Message-ID: References: <20221122044708.672-1-abner.chang@amd.com> In-Reply-To: <20221122044708.672-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY4PR11MB1622:EE_|CH0PR11MB5300:EE_ x-ms-office365-filtering-correlation-id: af2207e1-c6c8-43aa-5c85-08dacc4d1de3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jYTSI0CuigGvD+UsqF05WhDtAYHmdD+76nVSe3FtZxCiPFUCh7NOdaYhflGcCn1Bj9qvRnrDN/NydhRa5HzD1ikeO3/gdtSUpi40QVkOs1I05nCICFG+2jRQ40u9w0TqLGz0TDSokEws5NHuzuJ8stsigA3yjrGc/RVrf5FPCCp+ocSpkRHjr+2+rVdFxLgfBDeabBrbFHkPfiLpKR91kglVjs/Ti5OiodaJXL94r/yhsaDMPo9TvBHvEf1d50rab9P/POF0KOHNFcDocg5BS6gow/1xXywxWyFES6cCemdeVU78ebgvipP4iDqt6jytJoC7feQ3BCK3HuduPikdLb3qSK/MPMTzqOQzqpqQVB4u7Ke7iYcUoqymYYiT+8TA8T7Q0epNWUrW8dr54GdqJAdM1Kh7iWN0d2wx2oHgAGcyfN3+szHh4ZMtbf6axxO58xkblXzqMBYYHNv12cryLpa3jkYGcDePnL5ElmBVCLtf+T2V2y/5NHbPzbCyJFqVZf1b6Ms6SgZWgzDuwMmHEJw4u5Is4uHyDfKiz0ayRAOlBBdVfxH3ZRFjDFbWxhm7dtwejnIxckMEVTI/+OsUFPrGPbl3iPrT7mVRrnnD76beijUMDmQniCna+2RgeFxovoRSLZiSH4KvlIh4H0DuEI25iyfhYcrcXGj00YtvQlM4rhk0n/eoErt86ETIu/LrV650UKO59lcenxE/vb/5MRi00OK0BtkpviasTSFU2P0+qJYiUBXj2TIu544I9yCy3oPjVK80+i5/aWi1nCNxbw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(366004)(39860400002)(136003)(396003)(451199015)(66899015)(86362001)(38100700002)(122000001)(26005)(38070700005)(52536014)(82960400001)(186003)(83380400001)(110136005)(9686003)(2906002)(33656002)(8936002)(5660300002)(7696005)(107886003)(6506007)(478600001)(55016003)(71200400001)(53546011)(966005)(66476007)(41300700001)(316002)(4326008)(66556008)(76116006)(66946007)(64756008)(66446008)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5trAtRcIgYaX/cncEOAC+QBjUPbdn+YKr6pC90cZlbRs9t/v2WTp8qjKbYrj?= =?us-ascii?Q?8uceH6KqtjRGSGfrFILUnIA7Z747kLYmK02GHIY84e2ffmIzIqw2xCsbunzP?= =?us-ascii?Q?k6FNtpjw3Pg2SEeRrWuZGZgQtafZBxXxaEOtITW4t5yvZR6ohjuPXOeYxLNF?= =?us-ascii?Q?+6lvTOt3Jl0uTXW+b/okpkUfECFc3nitO5nvrG9yQHRxN9gS2Iwk+rgg7flc?= =?us-ascii?Q?yHKWShZmsishF5L1aRlfv8ClNwR/mxP+qbhis0IAjJfsyet6fuCZghyOIBWR?= =?us-ascii?Q?6NsfPxneYRX+8B8ayeqFRT9VZPKhmnzDY6SXrMfk5CFESY97U9GPZ0Ev/cNM?= =?us-ascii?Q?J5H87VVMR7KGx/vUDGCSSPaGPOfgqgPS+ygZjBuccG21kcjfBH/BBUewnAfb?= =?us-ascii?Q?LLFG8EFhvI6+OTCx0njwRYIDfjvMeZkIPJ3I5NZKj2WXZPqdxOV5KIC+FEpZ?= =?us-ascii?Q?yPT6Qp8Qnjtwc8F9HyqsS0jR+DkQ4qfOhY4SlRDHbbvHyFpm7jc3GWt8S7UP?= =?us-ascii?Q?RKgCl6hjSGbVc4BooVp9SCX9M0wQJNTW7k29bvF2OVbhHSfWj1XFn/8M7VN5?= =?us-ascii?Q?ixdl7L1Eysp858jcEVzSN63Spykg7eWfI35/QXkeGpT8u8OYEvtptO46NmEn?= =?us-ascii?Q?2YU8cFhX9uqr+449thR8enuAfLhEw4PmNOJUZTTFX8cO/0AiC5s+fmUOgn9W?= =?us-ascii?Q?/0726wOlvimHlNea1MCQtnhK8IjqkP0mrNAe7m9lDKH+1IxPxs+FonPdjgxx?= =?us-ascii?Q?al0z9/B+cMHzQZ1JwcXUQBETER3IOkE3e1COK16i7FWanNVQxGgr/E/noO8M?= =?us-ascii?Q?jssM0T8ANVs8JO/328j7IxMXh5k695frLsp4Hk4lGo40NifdmP5u9g8z5IeI?= =?us-ascii?Q?EJ26nuxB9ysTPpHI579OkG9+YreawV7lNyd/wdjt4cLlNGfQ8RKR3P+RJEzz?= =?us-ascii?Q?kHtzICafsrAgNiT0LUOoKsW7QGi6OBfRkt+PpraazOj5uMwUb412WndRcwxN?= =?us-ascii?Q?OtPAw4EfvkT05gbv8xkCPbEwu7D0NapN40hfq/bokQBfM+lgaccsobypGQ/j?= =?us-ascii?Q?Yqp5Agit+pYBNzoO3p3BHRgoRtsE1fmxviVfFez3C+V21RhyNe1D6mnV0FWt?= =?us-ascii?Q?CGCihWnybKjdNxEFx/pS4NGQ06tRFt5wrGlRVHILDqW+mQ3TN80OBcDA5cx9?= =?us-ascii?Q?BjPtZhyxcK5AfMrsb3/I7xngI0BfQ5h35c5l8zY0iQl+aMG2Imb9zqpZgApd?= =?us-ascii?Q?xc+16+M7k0+ubG7ufgP7Jc/fXdFZwcEw9aih49nlORqIlZ0KEsnCZi1g9UAe?= =?us-ascii?Q?PVVZzAlLtH74duQsw/KrAgBzY5/hZwH0fOOCrMbQFlVOQ8c5rZWj00WODN+o?= =?us-ascii?Q?ZUr4VLMigZlHFXMs8d9dDEHj83DWRKhg3kNCOvQGKvbOVmM6G2YuJJppjB7H?= =?us-ascii?Q?n8JY64MbUavCTA5/DpoPuGO1k8smYcqmJldcwqaMFZNYQKxBoNvl2swKglfM?= =?us-ascii?Q?H7Ebi2+sSTrQMknbF9jl2IBbcgkhQF8cftF60YONnNVIqR7AKA/EcsLlMlO4?= =?us-ascii?Q?Ngfu9gbHPPxemTgbdo4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af2207e1-c6c8-43aa-5c85-08dacc4d1de3 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2022 05:48:01.2177 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jOD5iCO8M8iFMsI1hCV7tfWwW4SdwXJ0CekgAZ3XqpbxA8IV1O087T3+ZSvKzKoUh3JYLY8YPtE6mWUmikXqvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5300 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Abner, >>From what I read, the idea of BZ1766 is to add recommendations to use stati= c for local symbols. "Add recommendations to the EDK II C Coding Standards Specification to use 'static' for all functions and global variables that are not referenced outside the current C file." Do you want to capture that in the EDKII C Coding Standard? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Tuesday, November 22, 2022 12:47 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Kinney, Michael D > > Subject: [edk2-devel] [PATCH] edk II C Coding Standard: Remove section > 5.4.2.2 STATIC >=20 > From: Abner Chang >=20 > BZ #1766 >=20 > Remove the entire 5.4.2.2 section. > We are not allowed to use upper-case STATIC in the source file now. > Just follow C standard and use the lower-case 'static'. >=20 > Leave the macro "#deifne STATIC static" there without removing > it to keep the backward compatable. >=20 > Signed-off-by: Abner Chang > Cc: Ray Ni > Cc: Michael D Kinney > --- > 5_source_files/54_code_file_structure.md | 16 ---------------- > 1 file changed, 16 deletions(-) >=20 > diff --git a/5_source_files/54_code_file_structure.md > b/5_source_files/54_code_file_structure.md > index 0c4d6a2..9acc620 100644 > --- a/5_source_files/54_code_file_structure.md > +++ b/5_source_files/54_code_file_structure.md > @@ -267,19 +267,3 @@ specified in Section 5.4.1.3 "Compile-Time Names". > Thus, while it might be legal C, do **not** declare external variables > anywhere > other than at the top level of a file as specified by this document. >=20 > -#### 5.4.2.2 Static > - > -An object declared `STATIC` has either file or block scope. > - > -##### 5.4.2.2.1 Do not reuse an object or function identifier with stati= c > storage duration. > - > -Throughout the set of source files defined within a single .inf file, do= not > -reuse an identifier with static storage duration. The compiler may not b= e > -confused by this, but the user may confuse unrelated variables with the > same > -name. > - > -##### 5.4.2.2.2 Functions should not be declared STATIC. > - > -Some source-level debuggers are unable to resolve static functions. Unti= l it > -can be verified that no one is dependent upon a debugger with this > limitation, > -it is strongly recommended that functions not be declared static. > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20