From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.21186.1647216876602971807 for ; Sun, 13 Mar 2022 17:14:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AuJAAzn+; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647216876; x=1678752876; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tIOa2PBTJH88GLW+56vJ2r5ZHTws2ls+21xq5rwFgZE=; b=AuJAAzn+XYNwzxuRaQ3u3rACETNQmo+dknlWk1badsFa9F2k0yTTh5HQ tvC+nc9cs6ogjwXjh4Wo+sI8+jTViIdqRGrtknOmsTHgbvYqv22LHhTpi W/xi9KjWce8tb/aBbM9rfcE+zU+YrS5vmHdxd+MSrDSzWmP6HgMBimHh7 osIdZBc9eChrfqoC/N/xdpEUXVKBqrRXYUSDUSfVKlV8ciX+7nUnvcM7f tmM6RLKDqd6/mBfSTE2ZFuO1vl6FpDewbYkh7VvdE2jIJBwuYn/9m+3y6 6heLPUaWbiQupYOj0S1BWRJCdtbSUSjDKhzW2bvA5hjADo3gh/NCAnRG0 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10285"; a="253468672" X-IronPort-AV: E=Sophos;i="5.90,179,1643702400"; d="scan'208";a="253468672" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2022 17:14:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,179,1643702400"; d="scan'208";a="634009781" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by FMSMGA003.fm.intel.com with ESMTP; 13 Mar 2022 17:14:36 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Sun, 13 Mar 2022 17:14:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Sun, 13 Mar 2022 17:14:35 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Sun, 13 Mar 2022 17:14:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mySPlUhOeAvsJK3242/455a86el1l4vVZFsuYHMqlv6GbNAYanryKUStm6U7+pRHDEEcdx4rmDmyE44TxP8wHsuG6XyKjYZU+yumfuPb884Z/gISk6php2/IXSEDz0YDgDB5UsN0nRzZj/W4/t+hmOlc9syWYXbHuXAU1BLbarrW1ikqULt1EzPlGq1onM+LYAYm1E6Fws2rnDPIlGUM5jXXT3+kgKY6WEx07h6jDfj/pb5Dxb3ROaTFmvaNe3368JNUsRDRgnP3AYLZ9rqik6W2j3pjl+PLwvGpFEH5CiS2mA24FdSrVS5jxyE5q9nlP+TnCyuMdFlNWYURYxiLNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NfvBTUXDIdn8HJbL+L8aIrDHwowQ3p1MutZsKtQQDOE=; b=JuLU/hzAFcBk1rHlLAaoCnzR/9+pP8UrfxIslSlaXKiEINEM5EREzGrU8KFH1+Vl2H+2HvfrqkLyz2YNmh/hCa89zTC5M/Hilfnw82oBT4bqK41wms1JWjWb5CHm/Oty8dp2YDqpm24RuT6n2lFDiJbIReHQypVL6SW4Xez2MEe3DjHkO169ynE8EeWx41pw3zmTyxAoxwjf85KwByTAIydfihjBDx/i70oaxOu46wxtvBpQqPgnITXQelH+lqIkq4fNChCXLzt9ISIFqm8Ic7A1AQOBefGwswCRgjLbfESGP+mI6+cHYJvl90RgLAdgQzYtL2QmYOR7dHHjK+ewzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR11MB1622.namprd11.prod.outlook.com (2603:10b6:910:e::10) by BY5PR11MB4022.namprd11.prod.outlook.com (2603:10b6:a03:18a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Mon, 14 Mar 2022 00:14:33 +0000 Received: from CY4PR11MB1622.namprd11.prod.outlook.com ([fe80::9988:fd3a:9117:99f6]) by CY4PR11MB1622.namprd11.prod.outlook.com ([fe80::9988:fd3a:9117:99f6%4]) with mapi id 15.20.5061.028; Mon, 14 Mar 2022 00:14:33 +0000 From: "Ni, Ray" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" Subject: Re: [PATCH v1] MdeModulePkg/DxeIpl: Create 5-level page table for long mode Thread-Topic: [PATCH v1] MdeModulePkg/DxeIpl: Create 5-level page table for long mode Thread-Index: AQHYNWDy8lfQsy83REeSlpplPa3S+6y+BiVg Date: Mon, 14 Mar 2022 00:14:32 +0000 Message-ID: References: <20220311155851.2304-1-yun.lou@intel.com> In-Reply-To: <20220311155851.2304-1-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36902862-c9c1-41fd-77ef-08da054f9d94 x-ms-traffictypediagnostic: BY5PR11MB4022:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V1OnCY6wOkBv33tznf7b1Etmgd1w2S/uCIt+fOsr0/nW7Ka8gchGXmifajyYp6XCso87/JQ5/p/gW3hKXh0VcwgZFGZvoEJfA8X6RQWwCYI9XXUwivnxUnAzTLrh1yzF3WR1hpv0GUR/lucDBGD9dlMypDuXUVzu+STxAHJzlbNMUy5x9cDcJ4Dcu+4FtXrYG8jud5N/pUUvb0uOw2Ybj5ed2UrQ8Ji6862XlIoQpOOZe88NGjO+jQqWJfVhgkg2xpQf9Gd5BY/rihtUA4JuWiGunPWGi1j57N0SG1Yh9c9Okh7gv1iWr0EG4mFITuk3uJ+draJPNJDhaYvWZ4cliMgF9GjvoWxhhHf07h4K9jf49En/eF8vq7OIDdE0IrmunSl4/TMom49YK4Z+Edamlj7H1oikWOQkEewTAWCNWGO3qNT5rR3nEsOlnVRPLTr6KhmCQ0ieDIWRlrS5t24qckRyox9Nuz9fEY5Rxm6ncJ7m+SgTVhotfhsx1JJEXHz0xVtlXZib5z3J7ZeOEFqTQjCU+i+w2Yjj7GxhGFY8ZP//M0GqoKeu1LbT8zMCfeV/CdVDFFRBNsdKPpzMKkSU9S6lYnc/qY7acr4/tAX1isOksDsXupfwQG7m/Lfq+Xj082HuVKaeejcHT50tpuCu5TL34mWdgwvYAOm+JIO4hVbYtCIBcBZxz7b0O5+pf9dN0PW1knY0uOTKD5fkTd2cz0Qcod9mrPxpjy6LOYiqra1CLrIqPafJ64tYI8wTvZplZ2DEHcvGS+NZfYBQuoSxiKlRKVSjcaf4CiBPL6Wq89U= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8936002)(38070700005)(52536014)(5660300002)(122000001)(82960400001)(38100700002)(26005)(186003)(71200400001)(53546011)(7696005)(6506007)(966005)(508600001)(9686003)(76116006)(64756008)(66946007)(4326008)(8676002)(54906003)(316002)(110136005)(83380400001)(19627235002)(55016003)(86362001)(2906002)(33656002)(66556008)(66476007)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dga0W4S35f5GcOGaURdn9Vcp64jnFtSOQa0/hgb6pqmWYhLcT5+X4L5WvrAI?= =?us-ascii?Q?E8IUE4Sb4rpaRsdSzSNhCBdsRtMv8i3QQ+ip9dZtvVOFMEaXpwOrc/hgbmi1?= =?us-ascii?Q?4wTti/yF3IH9PiFPHpIaX716LWrS3C3ep/Pm9IyKGd53dDALkkkjaFS3IQPL?= =?us-ascii?Q?9+67Gg7/xFXs9jyT+nsJUpqrUeYnGEomrHE0do77DqMr2utqtrjkxUqe+Qzg?= =?us-ascii?Q?irIBgabH3ppJM6qzZL5ipc5yUzsmH1ntoRSDt9Ly8FlIqV/5x2u3qxP2idHX?= =?us-ascii?Q?ZWg9FVUzNl75pdV/iZox9pEMba7Z6MK/hR3u5IOL0QZB8ZXeILuUDBr76z9t?= =?us-ascii?Q?K0O/MZLq5U8PpLMHjo97b08GnvRUwYmTsjfwLQtC1Ts/ZM/O/RMlr0lWYdCl?= =?us-ascii?Q?2IyLwmAb2k0DAuDx724dGVNAVa0zpccZIX8t1NXpW0EImxt15k7T4pzUI0ET?= =?us-ascii?Q?zN5mGgDf70dz7N6aGBaI3c2IXgR4+0pRgrPqrgN9ow8WCBraAAYsLeG9sF0Z?= =?us-ascii?Q?iPB22mDSFK+H6sd7n0/1DlrOUO8VHQ5D48I3x26kKh7zJuzctniK2KT7FJEx?= =?us-ascii?Q?0bu/l7UeSbV9lPCdB4zcytZhONi7uX6CfE106bht1aCMLtsoLaAYOy1uOc1d?= =?us-ascii?Q?4UNkr2Jn7yWYQKubumN08wn3WkV/bydn7F/atAZcXIjt2ncgJkNCeav+tFIZ?= =?us-ascii?Q?agikQkzh5UPOQMSVtAMiJid2G0ltj0Rg7nEY4UsMOt21auAoAOZK5lUVC79j?= =?us-ascii?Q?Vq5YY7Dd/FjqhWsCYwZ/3r9hxDghRp7q99ftPtjOsXgXhflCDMgY3u8MRnK9?= =?us-ascii?Q?hvSxfF5dMcKcNj0vGeGEc92tVy2UYhyUEiE6CP9IYKNLz+R6sT1z9AqrCveY?= =?us-ascii?Q?HmPx7svkE8B00/e6EU1Zmw4hoNqcr3IMlthY9wSOMd5qkxZpkoee6/0tX/Mh?= =?us-ascii?Q?GpdrIdxypXr3udvKAi1syYh7ik+pihCIbsrvyhbUo3xp/o8uex++BbdFODso?= =?us-ascii?Q?58PVuQ7m8S8rlT608DW6wVDARskHVfUdont0tjquSi5DxT4bHTg4lYymuT+o?= =?us-ascii?Q?WseoSi1QdlIr1EzkBmikwVO1dfyfhCekRd3jmUCs8D8oQbmEaToTBfXVYqhc?= =?us-ascii?Q?F/Iz0BeK3VeuTbBoidxmhrJCnAwFl3zkbEOMH77/smOL7RX1d5MmtA5TSIEX?= =?us-ascii?Q?41kc1ZDIoTDLw9H5dcEGPlNABnfXSIBfjmoBORqKNlRwqpPcb5UKOiOLCciU?= =?us-ascii?Q?trMV2go6zU7uJf+9swYeB5oTO6PkZr7sbvcV4L+pMis//jdYRVdEYXzpchqW?= =?us-ascii?Q?OcFHkCAw3vFFPffLlk9BTigROa8tQHSs1kJkLsUFD6D2LBU7ffLRBtohthUI?= =?us-ascii?Q?TDKK8cP9I5/F+omyXmsZBZ9K7Ti3WiXRCTqJ1r1abArIiFPAZ7O4yhpHmvam?= =?us-ascii?Q?D1Q9SmLY3UvAqtImfIYvgGCCr5eGDoGQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36902862-c9c1-41fd-77ef-08da054f9d94 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2022 00:14:32.9717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hlssUjiANxQ+7ch2tGb7xBavaXdL2aKBnZKsyPJuFwQF8FU+6icsHZLy1zRlbI+RCeaxY8J+feSOIecvUAtdrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4022 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni -----Original Message----- From: Lou, Yun =20 Sent: Friday, March 11, 2022 11:59 PM To: devel@edk2.groups.io Cc: Lou, Yun ; Ni, Ray ; Bi, Dandan ; Gao, Liming Subject: [PATCH v1] MdeModulePkg/DxeIpl: Create 5-level page table for long= mode REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2008 Correct the logic about whether 5-level paging is supported. Signed-off-by: Jason Lou Cc: Ray Ni Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c b/MdeModulePk= g/Core/DxeIplPeim/X64/VirtualMemory.c index 0700f310b2..1ebab27820 100644 --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c @@ -15,7 +15,7 @@ 2) IA-32 Intel(R) Architecture Software Developer's Manual Volume 2:In= struction Set Reference, Intel 3) IA-32 Intel(R) Architecture Software Developer's Manual Volume 3:Sy= stem Programmer's Guide, Intel =20 -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.
Copyright (c) 2017, AMD Incorporated. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent @@ -748,8 +748,8 @@ CreateIdentityMappingPageTables ( CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS, CPUID_STRUCTURED_EXTENDED_FEATURE_FLAGS_SUB_LEAF_INFO, NULL, - &EcxFlags.Uint32, NULL, + &EcxFlags.Uint32, NULL ); if (EcxFlags.Bits.FiveLevelPage !=3D 0) { --=20 2.28.0.windows.1