From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.51950.1658312026517772126 for ; Wed, 20 Jul 2022 03:13:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IjV7vaZu; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658312026; x=1689848026; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9QgAS4jvslKhjyQbzwyj9yQVrnn1gADp8j8eVffQZNQ=; b=IjV7vaZubncywPrYJQbZ/hOqnIsCdhiR/YGVPEqcr0NcSnEwio7dVccs lWBCZMGM06SYakOVVZhLhVz3cvANJ/BA8P0TKhWZWEMY835DkNxP2cLpS 2I2IoiKs/Ztc7X46rSCZfsK35n3Bd+hBGEJtxvgokSLMNA5Gp5c1RQSze nTPRjA+Oblj+9bv9JTXmNoypIpCj15mbpYSVp6XMRyvkdIkOph7tQUDqP evMyKttoFEbXuwNjKwXDTnnvTm6+x0bbIyYvW0WAZfbfU/vfTdENxK0yt +pzmLfzGTqF0/6v9tnjYkPufJzYGgwZN7ziDBcPmRTcvlc9pH8kXuCi0y Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="284296432" X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="284296432" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 03:13:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="665804612" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga004.fm.intel.com with ESMTP; 20 Jul 2022 03:13:45 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 20 Jul 2022 03:13:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 20 Jul 2022 03:13:45 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 20 Jul 2022 03:13:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pj/Ge4a8ItViCiemHmdO5iKqXTnIr9WAKli2WaiHhmJg0ZQGtmBc/9cEtKqWtemaWKFTxL125oAaCCCrLg0gaLjQhZvRE6+bMI1HI8iWU065AP2ZPNJKWe/zD1mCfXybPjTzI4IAuJnAw2kfnKY/1xF5FKqPGDFlf3XkojFOvTjgxTnak6/MwvBOeAf9NUuA9HesubmGGr218ZJcZM/tGex4XpPiTwlP0Khbns04ukYVB5h7zOLr+ZC3Tqin1r/irjcXRORI5GCz/GeKFAktu/ScXc8SVlKev63Llte2dl7iDIybNKwOPbd9EmlYy32aKQN/n/pHMPQfPDKMxH9lKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MlZFXDi7EOz6lK3juGiGJNNzoVSz6rDpGIrHVmBWPsk=; b=mnygNX8xDYeIcBcvpkn1MQ2GvoDFqAyYMYifKa+3KWuYfFle5rhhyyxGZsghYsgZiMj1xrgqYJ6RYxPrW3PHr3g1Skbek/C/3cwE/OPQ8oWNFDke7/d8jecHhfGwq3Q3Y2Zk6uwmsJ5BC1ipMTdlIE1VVI6I+sLyK0Wq4gQ5VB4JW77Em8GZjNppuHbhJxk9qe+rHRd+rxL+TtHXHrfC/oADIiVSyL3wiIG5dP9L7VwZvwmDh1pLm7tlZgbAM6yLxuQXsXP+A2G4Ps+UU2HIPj4YPPSmgJyjAMXpgXURONj7yadkOTJ70xA7zv5CGZzrK7z5FlS0HNxzLtVsWM3s+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR11MB1622.namprd11.prod.outlook.com (2603:10b6:910:e::10) by BYAPR11MB3685.namprd11.prod.outlook.com (2603:10b6:a03:fa::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 10:13:42 +0000 Received: from CY4PR11MB1622.namprd11.prod.outlook.com ([fe80::1149:3ce9:ae30:7c79]) by CY4PR11MB1622.namprd11.prod.outlook.com ([fe80::1149:3ce9:ae30:7c79%12]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 10:13:42 +0000 From: "Ni, Ray" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: Andrew Fish Subject: Re: [PATCH] EmulatorPkg/PosixFileSystem: Add NULL check on memory allocation Thread-Topic: [PATCH] EmulatorPkg/PosixFileSystem: Add NULL check on memory allocation Thread-Index: AQHYm64n6tfCpXv7vUCiADeCWg2K1K2HCwpw Date: Wed, 20 Jul 2022 10:13:42 +0000 Message-ID: References: <20220719202826.18300-1-miki.shindo@intel.com> In-Reply-To: <20220719202826.18300-1-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c4110242-2a62-41df-eece-08da6a388608 x-ms-traffictypediagnostic: BYAPR11MB3685:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oPTlLpg39E2V96vf0zYn/s63hFFDfX+Dr8wROWzl/TvEvrVVw7J5V7zAt8/gS37ibUWIbBhYkUGK9MBOhekpchYyOfiEqZ3mRgqrKTXps4eim755TsWQCypYvPh18nIkEyp2Eg+PEH0bjrV8TjpjyfEtJYdP4ag8G9ak9cFTMx5L2wvQdvtO2abaj8jnIHrVmd6akmE8BRGhaDfWn60LU+SjVu9X/ATivzDIJNl6fgrfj07vTWAcqLTU4QZ9H8rf7PKePnP8LMyFEiVxsB5rEyB1zM3FP4mH/+3apWdZAg52lNcJjJK6dU/CDUsumB3RJb4TLJ3fvuh2bMWHm+9EJ8DAdqPCIIKRDjozJY5MBpXbB8Zac0iYkfjMMWq6CN3vHXcSlYxqvsYd6ng8Rb5giTM3l6cMrR3OcEhoyH5ZsWsSSYjDFFSNTdDmYp1Uv9x65h9yMHMGpoJ7UaBdnPLJIrF3TmGc+d7DWVbP7jNwRJm9PmVUC9wijZjS9E9C/KXsw+d9SEyifZA3pk/xCOg8ao7HgKa5yCHwZ3zkFr0OaqoFQ/6tmTNKdvviHgnqisl74/Yjbrptp+H6f7T+2YnGQjgggyEE5Nsi/ZpBrXIQ9kmQqdHJXADYIYor8o9VWz9YW9p8ExHzlr81BIMwdEQz8aMCuSeG0AsVDD4pAVGpOVNOr7WYvO4IpobuqMxzcf4YzKHf569ouSebDX8pSZIrGAx3UqHtLtPI6YVYmIQNU1DNetVow+U5s5kxZZheWWc8utMgU3RaoU8ze89m3mPm5pnxR8k/8/kB8+gMO5t+uXQrj97A0hbW2ehy/qjsSRf2T1wft8wCzwDSJcZP3A45FA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1622.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(136003)(396003)(366004)(346002)(53546011)(186003)(83380400001)(82960400001)(122000001)(66476007)(86362001)(38100700002)(38070700005)(64756008)(66446008)(66946007)(66556008)(76116006)(8676002)(71200400001)(4326008)(316002)(55016003)(2906002)(110136005)(8936002)(52536014)(5660300002)(478600001)(33656002)(966005)(41300700001)(26005)(9686003)(7696005)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?waZhoPM6n6eJuWoRokdvCve3EOOSKI2/FfR1YniILzzAcXimud2zczxeVZWs?= =?us-ascii?Q?uV5o4jGtWk75m410GY9PIRnnRrGprGJXjDFza68ifgdpD91ukZbsy8xAREHQ?= =?us-ascii?Q?pSFpgr3vQ1QJal7qfGKO+L4A2iSli9eHJubc/4Yom3VTdHIEBWw0cn1kUJYT?= =?us-ascii?Q?I/d0K1CBjgUbzbKEDc0Kho2Olh044TXUdRrBiIa7Dq/5ly8gMHBHe9vZttUD?= =?us-ascii?Q?JNIGyAm3TQ1DO/umJWSSla4b3pKv5cw+SuKRd+nMyxEEdzWGhcoDIJTi13z7?= =?us-ascii?Q?pzczXiXeqIfMfYNg6yF75/jM3lrYnG1WOMHm9ySN3LOklxMF2Dq2yM9MzpsZ?= =?us-ascii?Q?OFNxdbMzKzhgB6449iBlAIUyxJmucdmYg7B/Him89KoaN+vC//ImA9bnPqfu?= =?us-ascii?Q?zrwEXGXp9qIAl4XtRZly1nRuE0620rlgDxwIQbSmlYsMJWhhT20O0PP0EDk2?= =?us-ascii?Q?KdJrCRviMnZRFwSHtVlNRvODUc2wXzMtD3To3GCP9oB137uxq4Y0epVNmxAs?= =?us-ascii?Q?bEgZuf4VlBTPCuCGHQiBuZG6RBDWRdUx2MkNYeaKtnJVw8uz0i/pfthfBxyp?= =?us-ascii?Q?XPrGTa5wV+MmPcRUxhVrRaiMbJ/yMpl46Ay2yZpXgEdLbG5uQEmXJVFWCH6q?= =?us-ascii?Q?vpoJf9Ds/sj/VxNwMstMe4IQtp+muWOROzBcX8wKvj/6Vd67W2mFhJGuninN?= =?us-ascii?Q?ouA2CHMcL4PetNeFOqwP3JZA5+9JWhW1a8uFsXwgUKCp0zEKdjf7m1RLSTv5?= =?us-ascii?Q?4SyVyuUBkmRJF7PZ5AJWeotK2bl01sU3HqIRko9Rxc8xJgTM7t3z0++nv4BH?= =?us-ascii?Q?i4755H4Cwk1ftPakC1R4kejAUi8Clm5efiDkps9CvUDR6wUOEGS979KV/xg5?= =?us-ascii?Q?z6epkOzjOfaRJlFfGF83/Tinb+BsoEmIvOb7e8RFLFwsZvX0JCDQ2bKi6GMy?= =?us-ascii?Q?k+G+1jtcjTGKfbnVqKT4H6H+T69Y06Xzaad2wqi0juf7yjtTFxpDaZX5OEFt?= =?us-ascii?Q?Gp1DDEsqZMyJEcpKPM9QEpaKo9w7gOjEWLoOVyQ9gDUN1LpHqLjPT4Ua/K0i?= =?us-ascii?Q?ImOPJ9sYCVDKIducxUgmQxKTjeJw1TP3YDpaRhmxuYXRo+HWXzX2JPZrZiey?= =?us-ascii?Q?wqGckcKS0GzPKZ6Md3KWw9stKiCFnW2qbIPF6c2uogD9r8iUAUg17xDqW6tB?= =?us-ascii?Q?wSj/XafnKJl7JazxHiXUm64meStNDb9mY/PqdFFPovVxRXohwwh/36N3djZ+?= =?us-ascii?Q?+830MZp1ERn7CWB+SyogXIXSdaj5eV8A5Wt30SAHde3QmvuVlVz+gH6enLNR?= =?us-ascii?Q?0TZvDENjVlwkLtI3tCkmV3hVCZ9NH5+ZoVcJjsu3qQ770XCfoPM7e53gwkm5?= =?us-ascii?Q?hSMjrnIKXbRnNYGVdGHvqZJtghy+UX/HIfHt5wdcLHWMz1sBGRpUU3HgaTZd?= =?us-ascii?Q?vMX5f5QUc3LHelF6HkWCHeS5DWpw+ebgG56StmNgSGi4tN+imNdwyhfTDm4Y?= =?us-ascii?Q?jE/LeJm0s1qIIjjq0iyMgWh//g7L0ly/bYC5irF8pAzbsO8GY4q7B1oM0Obv?= =?us-ascii?Q?Ir7EPRPYNYqwEhH42ZQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1622.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4110242-2a62-41df-eece-08da6a388608 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 10:13:42.5635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zzEjH50n9Iuw7EG5ziBm3KZZzfpBRDFynVLbAeIZ1Ql/4yIqDInBdG1LSkOhX0X1ex+Va0fF7dewwri0H1Vr6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3685 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Shindo, Miki > Sent: Wednesday, July 20, 2022 4:28 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray > Subject: [PATCH] EmulatorPkg/PosixFileSystem: Add NULL check on memory > allocation >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4001 >=20 > This commit adds NULL check on memory allocation of the size > for FileName in ASCII string format at PosixFileSetInfo(). >=20 > Signed-off-by: Miki Shindo > Cc: Andrew Fish > Cc: Ray Ni > --- > EmulatorPkg/Unix/Host/PosixFileSystem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/EmulatorPkg/Unix/Host/PosixFileSystem.c > b/EmulatorPkg/Unix/Host/PosixFileSystem.c > index ae3fe72a05..b69d3d5520 100644 > --- a/EmulatorPkg/Unix/Host/PosixFileSystem.c > +++ b/EmulatorPkg/Unix/Host/PosixFileSystem.c > @@ -1187,7 +1187,7 @@ PosixFileSetInfo ( > } >=20 >=20 >=20 > OldFileName =3D malloc (AsciiStrSize (PrivateFile->FileName)); >=20 > - if (OldFileInfo =3D=3D NULL) { >=20 > + if (OldFileName =3D=3D NULL) { >=20 > goto Done; >=20 > } >=20 >=20 >=20 > -- > 2.27.0.windows.1