public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure
@ 2020-10-13  5:29 cbduggap
  2020-10-13  7:06 ` Zhiguang Liu
  2020-10-13  9:00 ` Bob Feng
  0 siblings, 2 replies; 4+ messages in thread
From: cbduggap @ 2020-10-13  5:29 UTC (permalink / raw)
  To: devel; +Cc: cbduggap, Bob Feng, Liming Gao, Liu, Zhiguang

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981

Added Type Casting to print UINT64 Value using Printf to fix the GCC build error.

Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Liu, Zhiguang <zhiguang.liu@intel.com>

Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
---
 Silicon/Intel/Tools/FitGen/FitGen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitGen/FitGen.c
index febeb008fe..e9541c1e95 100644
--- a/Silicon/Intel/Tools/FitGen/FitGen.c
+++ b/Silicon/Intel/Tools/FitGen/FitGen.c
@@ -1004,7 +1004,7 @@ Returns:
     //
     gFitTableContext.TopFlashAddressRemapValue = 0x100000000;
   }
-  printf ("Top Flash Address Value : 0x%llx\n", gFitTableContext.TopFlashAddressRemapValue);
+  printf ("Top Flash Address Value : 0x%llx\n", (unsigned long long) gFitTableContext.TopFlashAddressRemapValue);
   //
   // 0.4 Clear FIT table related memory
   //
-- 
2.26.2.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure
  2020-10-13  5:29 [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure cbduggap
@ 2020-10-13  7:06 ` Zhiguang Liu
  2020-10-13  9:00 ` Bob Feng
  1 sibling, 0 replies; 4+ messages in thread
From: Zhiguang Liu @ 2020-10-13  7:06 UTC (permalink / raw)
  To: Duggapu, Chinni B, devel@edk2.groups.io
  Cc: Feng, Bob C, Liming Gao, Liu, Zhiguang

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: Duggapu, Chinni B <chinni.b.duggapu@intel.com>
> Sent: Tuesday, October 13, 2020 1:30 PM
> To: devel@edk2.groups.io
> Cc: Duggapu, Chinni B <chinni.b.duggapu@intel.com>; Feng, Bob C
> <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu; Liu,
> Zhiguang <zhiguang.liu@intel.com>
> Subject: [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981
> 
> Added Type Casting to print UINT64 Value using Printf to fix the GCC build error.
> 
> Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>
> 
> Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
> ---
>  Silicon/Intel/Tools/FitGen/FitGen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
> b/Silicon/Intel/Tools/FitGen/FitGen.c
> index febeb008fe..e9541c1e95 100644
> --- a/Silicon/Intel/Tools/FitGen/FitGen.c
> +++ b/Silicon/Intel/Tools/FitGen/FitGen.c
> @@ -1004,7 +1004,7 @@ Returns:
>      //
> 
>      gFitTableContext.TopFlashAddressRemapValue = 0x100000000;
> 
>    }
> 
> -  printf ("Top Flash Address Value : 0x%llx\n",
> gFitTableContext.TopFlashAddressRemapValue);
> 
> +  printf ("Top Flash Address Value : 0x%llx\n", (unsigned long long)
> gFitTableContext.TopFlashAddressRemapValue);
> 
>    //
> 
>    // 0.4 Clear FIT table related memory
> 
>    //
> 
> --
> 2.26.2.windows.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure
  2020-10-13  5:29 [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure cbduggap
  2020-10-13  7:06 ` Zhiguang Liu
@ 2020-10-13  9:00 ` Bob Feng
  2020-10-14  5:14   ` 回复: [edk2-devel] " gaoliming
  1 sibling, 1 reply; 4+ messages in thread
From: Bob Feng @ 2020-10-13  9:00 UTC (permalink / raw)
  To: Duggapu, Chinni B, devel@edk2.groups.io; +Cc: Liming Gao, Liu, Zhiguang

Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Duggapu, Chinni B <chinni.b.duggapu@intel.com> 
Sent: Tuesday, October 13, 2020 1:30 PM
To: devel@edk2.groups.io
Cc: Duggapu, Chinni B <chinni.b.duggapu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu; Liu, Zhiguang <zhiguang.liu@intel.com>
Subject: [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981

Added Type Casting to print UINT64 Value using Printf to fix the GCC build error.

Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Liu, Zhiguang <zhiguang.liu@intel.com>

Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
---
 Silicon/Intel/Tools/FitGen/FitGen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c b/Silicon/Intel/Tools/FitGen/FitGen.c
index febeb008fe..e9541c1e95 100644
--- a/Silicon/Intel/Tools/FitGen/FitGen.c
+++ b/Silicon/Intel/Tools/FitGen/FitGen.c
@@ -1004,7 +1004,7 @@ Returns:
     //

     gFitTableContext.TopFlashAddressRemapValue = 0x100000000;

   }

-  printf ("Top Flash Address Value : 0x%llx\n", gFitTableContext.TopFlashAddressRemapValue);

+  printf ("Top Flash Address Value : 0x%llx\n", (unsigned long long) gFitTableContext.TopFlashAddressRemapValue);

   //

   // 0.4 Clear FIT table related memory

   //

-- 
2.26.2.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* 回复: [edk2-devel] [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure
  2020-10-13  9:00 ` Bob Feng
@ 2020-10-14  5:14   ` gaoliming
  0 siblings, 0 replies; 4+ messages in thread
From: gaoliming @ 2020-10-14  5:14 UTC (permalink / raw)
  To: devel, bob.c.feng, 'Duggapu, Chinni B'; +Cc: 'Liu, Zhiguang'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Merge @ b0459fb6cf5083f5fcdf91d1e1518a86b22add1b in edk2-platform.

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66168+4905953+8761045@groups.io
> <bounce+27952+66168+4905953+8761045@groups.io> 代表 Bob Feng
> 发送时间: 2020年10月13日 17:00
> 收件人: Duggapu, Chinni B <chinni.b.duggapu@intel.com>;
> devel@edk2.groups.io
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> <zhiguang.liu@intel.com>
> 主题: Re: [edk2-devel] [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC
> Build Failure
> 
> Reviewed-by: Bob Feng <bob.c.feng@intel.com>
> 
> -----Original Message-----
> From: Duggapu, Chinni B <chinni.b.duggapu@intel.com>
> Sent: Tuesday, October 13, 2020 1:30 PM
> To: devel@edk2.groups.io
> Cc: Duggapu, Chinni B <chinni.b.duggapu@intel.com>; Feng, Bob C
> <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu; Liu,
> Zhiguang <zhiguang.liu@intel.com>
> Subject: [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2981
> 
> Added Type Casting to print UINT64 Value using Printf to fix the GCC build
> error.
> 
> Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Liu, Zhiguang <zhiguang.liu@intel.com>
> 
> Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
> ---
>  Silicon/Intel/Tools/FitGen/FitGen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
> b/Silicon/Intel/Tools/FitGen/FitGen.c
> index febeb008fe..e9541c1e95 100644
> --- a/Silicon/Intel/Tools/FitGen/FitGen.c
> +++ b/Silicon/Intel/Tools/FitGen/FitGen.c
> @@ -1004,7 +1004,7 @@ Returns:
>      //
> 
>      gFitTableContext.TopFlashAddressRemapValue = 0x100000000;
> 
>    }
> 
> -  printf ("Top Flash Address Value : 0x%llx\n",
> gFitTableContext.TopFlashAddressRemapValue);
> 
> +  printf ("Top Flash Address Value : 0x%llx\n", (unsigned long long)
> gFitTableContext.TopFlashAddressRemapValue);
> 
>    //
> 
>    // 0.4 Clear FIT table related memory
> 
>    //
> 
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-14  5:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-13  5:29 [Patch V4 1/1] [BUG FIX] Tools\FitGen: FIX for GCC Build Failure cbduggap
2020-10-13  7:06 ` Zhiguang Liu
2020-10-13  9:00 ` Bob Feng
2020-10-14  5:14   ` 回复: [edk2-devel] " gaoliming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox