From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.24172.1593328986087177061 for ; Sun, 28 Jun 2020 00:23:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=E7glK/wW; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: asIXkrKbHEcNtBdTSsMIYKvTK6X2RMb0LViksTdP3Z6EMzxUfCQOyCH69A05Hs8nmfgbZGXXUZ MWfSuOurWkSw== X-IronPort-AV: E=McAfee;i="6000,8403,9665"; a="230588812" X-IronPort-AV: E=Sophos;i="5.75,290,1589266800"; d="scan'208";a="230588812" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2020 00:23:05 -0700 IronPort-SDR: 6Han03c3cq/lLrtztN7WPXkwPFgivWYnkYNd7ImWRvRRlpngz5f+MxIU9RKA5a6WumprkQjNfh lu6eRxMV4mOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,290,1589266800"; d="scan'208";a="276771224" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 28 Jun 2020 00:23:05 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 00:23:04 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jun 2020 00:23:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bS73j6vezd1sdRhz6i95HjtuxnUgYoxRzARSq932IH0be75mB9kX1x6DNaBM7vDoPbeXJ5bXETZHQ/tpGlA8KPpdEyeG/55Cj80kcWUX6lbKzaROL3L5m+YpfznBVi3/hdiRxCYoql6/JTEtSHd00cGlS16LST3zghxaUZFcWa34yTtWG+7aeE3auX62NaO4fvz5lOYwFiUU/BSg1Vy8wexPc8VUtrLWJt9JeJyLmCNunL9h5TWRclr0+DNo/K/Wonn7rGpGEzyGjWN+qSlnruFy9UrQo0vBWVbqtZ1eBToxVes5JBxlH9RLUOZFh9N0sFJvArHKIRbE2VTMWbDKng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kENUOd3HRwP04op+H+yHGYffKuSLvP12hUSfFXeXe68=; b=ZtTspXf9XqMIwhAMaHyPv7QANDpO+YlanB9qN0YxxsLS4GLcb7t+1GCd5Vzth92sOfgfxAFF0JlRfNbD3zZ7HmuTFzGEzHSumC7CawtBnOVw/iBzK3J5RBv5oav8EVD2kITZ2mKnKznRPWy2auSX7HfDcd56Ri+OpUzfBYL/L2Btm4MvKQiYI+EOCsEUcMgyzybS7zxlBaS73KRo8ZxkOE29MoWot70I1QkXwjnY3Hw8vbdGCJvcliAzOH0gEtj/TZzgsoCQb8pOZq8aHxtHS5jU9r5gTYZSxgplWdmJw5doQpORXgsoK6gvG5AGxY6bTlo88Du575FUfbxSvgzFSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kENUOd3HRwP04op+H+yHGYffKuSLvP12hUSfFXeXe68=; b=E7glK/wWisaQ8HKa3NNZo+4tNIJY8oM/xzKDdTsTbStQFLZA6O6AIpfI7i8n/7f9cZp6kd37/OMNNG3KRfTp25hnOZT0X7eq8pTXCEtNw0Z8r9wsDJw1slictmjBSMaiHEUo/Ts9tlvtgAcnVdrqyf2VnAy9UAqn9J5PE3SQC08= Received: from CY4PR11MB1687.namprd11.prod.outlook.com (2603:10b6:903:2e::11) by CY4PR11MB1990.namprd11.prod.outlook.com (2603:10b6:903:25::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.25; Sun, 28 Jun 2020 07:23:04 +0000 Received: from CY4PR11MB1687.namprd11.prod.outlook.com ([fe80::1490:81c1:9ca1:df58]) by CY4PR11MB1687.namprd11.prod.outlook.com ([fe80::1490:81c1:9ca1:df58%9]) with mapi id 15.20.3131.026; Sun, 28 Jun 2020 07:23:04 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "Gao, Liming" , "Kinney, Michael D" , "Felixp@ami.com" Subject: Re: [edk2-devel] [PATCH V2] MdePkg: Add Serial Terminal Device Type Guid Thread-Topic: [edk2-devel] [PATCH V2] MdePkg: Add Serial Terminal Device Type Guid Thread-Index: AQHWSkNwBdEJA+x87UmxdYXXN+1Rb6jtpSOg Date: Sun, 28 Jun 2020 07:23:03 +0000 Message-ID: References: <20200624161939.42772-1-oleksiyy@ami.com> In-Reply-To: <20200624161939.42772-1-oleksiyy@ami.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 148521cb-bec2-49e5-935c-08d81b3418bb x-ms-traffictypediagnostic: CY4PR11MB1990: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0448A97BF2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 31iHhnzeaCkURMKkou7jDbl2VS2vTArQkVXSQBNfICj3l6OUhsgU8TduP4W8+7PMbpafaiP/OIDMfKsiyJ2IcuaYCFs/Bb+UcaBNOIfDcs0HGPfHt5EUOE+NeVtk6pYZiEehtZPCrJWEF57tnEbhwMjm1D0+dbyfMI6JMuZDUPH59AX7kNH1yzma36ZG0GyVM9mUv4MAOUtg3y8dHO64RPz8ue9M8K9AN3ep3T5Q8THc52sSxbroDya1IO9TMbtf2phKqvxRXcW1cVoJQ0TNz5/wgePMh+Qy6S0LsSQ5SkBW6imZ2yCCo/KOc2llT4oc+sbqRs1jRzJmlVjG6mNO1JKSGe6JjNjBdS/JqLdT6V7zIPYGBafpgqX3XpzoAIsgWOkdOdk5n8Q/jhx3I7u0kQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1687.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(346002)(396003)(366004)(376002)(39860400002)(52536014)(86362001)(33656002)(7696005)(316002)(71200400001)(8676002)(5660300002)(966005)(478600001)(83380400001)(6506007)(9686003)(66446008)(26005)(55016002)(8936002)(2906002)(76116006)(54906003)(64756008)(66476007)(66946007)(110136005)(66556008)(53546011)(4326008)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: YdWn7muHws0OMP+2hr6NNhs5HAbKfe+A9n1asIQYcC5DOj9t1R09qgmezwSaxaWAMrVY7e7jT1K1veFYql/s72CJUxDRJ37UoFnYsE+/M/uVQb1AuFfjuFYdqVj2NPo8DMYRmshwxfWP8kt8O4QPWFQa/Lm4g5fRkduqbXi/tvHLayT4v/8WguVCAYIZ80oktL9007aMxxbfTV9oZjj8/ePsK7T4D1Fmz/NmKU2hh3+puX48vUPfU67nlDqHa7NEkMmBeL3LeWP5K8fRolI4SrTUDW/zk7VwuQzMI/Olj8H0IpBcVjZiWCU9eYW2MJ7K6Fj9sG7y2ZnhjixSP9k2JC+iRY5MWgwJubezwDExIZ7YKzbUt+7lsHdfe2x37TWi2SfYNEv1BhMfE7gNiCi5oPiVwJoEgTjqSpsuLvG39KQ103hW2PgE6jTYJuvps62Eu554Mh3E0931Ps48BwbXtWmzltXULI1gvTMQZeOjkGktCZDCZ+Q4orWSW6btulGq MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1687.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 148521cb-bec2-49e5-935c-08d81b3418bb X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2020 07:23:03.9241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t+9bFWyc4fjAd5wEwyz3LIO0VOR5XRmawYbEe6syNT46iBT4wW2emQoQUI7T4bpQLGrdp/eAPh1j0DxhDBHmSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1990 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Oleksiy, If you build OVMF with your code change, it will report one error: error 3000: Invalid GUID value format gEfiSerialTerminalDeviceTypeGuid =3D { 0x6AD9A60F, 0x5815, 0x4C7C, { 0x08= A, 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }} ( =3D ) This is because you use "0x08A" instead of "0x8A", and the tool thought yo= u are trying to write a 2 bytes number 008A, not 1-byte number 8A. Please fix it by just using "0x8A" Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Thursday, June 25, 2020 12:20 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Felixp@ami.com; oleksiyy@ami.com > Subject: [edk2-devel] [PATCH V2] MdePkg: Add Serial Terminal Device Type > Guid >=20 > Add definition of EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID. > It was miseed in "Extend SERIAL_IO with DeviceTypeGuid" patch. > (UEFI 2.8, mantis 1832) >=20 > Signed-off-by: Oleksiy Yakovlev > --- > MdePkg/Include/Protocol/SerialIo.h | 6 ++++++ > MdePkg/MdePkg.dec | 3 +++ > 2 files changed, 9 insertions(+) >=20 > diff --git a/MdePkg/Include/Protocol/SerialIo.h > b/MdePkg/Include/Protocol/SerialIo.h > index e2e0c61..16a865b 100644 > --- a/MdePkg/Include/Protocol/SerialIo.h > +++ b/MdePkg/Include/Protocol/SerialIo.h > @@ -17,6 +17,11 @@ > 0xBB25CF6F, 0xF1D4, 0x11D2, {0x9A, 0x0C, 0x00, 0x90, 0x27, 0x3F, 0x= C1, > 0xFD } \ > } >=20 > +#define EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID \ > + { \ > + 0X6AD9A60F, 0X5815, 0X4C7C, { 0X8A, 0X10, 0X50, 0X53, 0XD2, 0XBF, > +0X7A, 0X1B } \ > + } > + > /// > /// Protocol GUID defined in EFI1.1. > /// > @@ -299,5 +304,6 @@ struct _EFI_SERIAL_IO_PROTOCOL { }; >=20 > extern EFI_GUID gEfiSerialIoProtocolGuid; > +extern EFI_GUID gEfiSerialTerminalDeviceTypeGuid; >=20 > #endif > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > d03fc5b..fc4dae2 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -670,6 +670,9 @@ > ## Include/Guid/RtPropertiesTable.h > gEfiRtPropertiesTableGuid =3D { 0xeb66918a, 0x7eef, 0x402a, { 0x= 84, 0x2e, > 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} >=20 > + ## Include/Protocol/SerilaIo.h > + gEfiSerialTerminalDeviceTypeGuid =3D { 0x6AD9A60F, 0x5815, 0x4C7C, { > + 0x08A, 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }} > + > # > # GUID defined in PI1.0 > # > -- > 2.9.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 >=20