* Re: [PATCH V2] MdePkg: Add Serial Terminal Device Type Guid
2020-06-24 16:19 [PATCH V2] MdePkg: Add Serial Terminal Device Type Guid Oleksiy Yakovlev
@ 2020-06-26 3:31 ` Liming Gao
2020-06-28 7:23 ` [edk2-devel] " Zhiguang Liu
1 sibling, 0 replies; 3+ messages in thread
From: Liming Gao @ 2020-06-26 3:31 UTC (permalink / raw)
To: Oleksiy Yakovlev, devel@edk2.groups.io; +Cc: Kinney, Michael D, Felixp@ami.com
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Oleksiy Yakovlev <oleksiyy@ami.com>
> Sent: Thursday, June 25, 2020 12:20 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com
> Subject: [PATCH V2] MdePkg: Add Serial Terminal Device Type Guid
>
> Add definition of EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID.
> It was miseed in "Extend SERIAL_IO with DeviceTypeGuid" patch.
> (UEFI 2.8, mantis 1832)
>
> Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> ---
> MdePkg/Include/Protocol/SerialIo.h | 6 ++++++
> MdePkg/MdePkg.dec | 3 +++
> 2 files changed, 9 insertions(+)
>
> diff --git a/MdePkg/Include/Protocol/SerialIo.h b/MdePkg/Include/Protocol/SerialIo.h
> index e2e0c61..16a865b 100644
> --- a/MdePkg/Include/Protocol/SerialIo.h
> +++ b/MdePkg/Include/Protocol/SerialIo.h
> @@ -17,6 +17,11 @@
> 0xBB25CF6F, 0xF1D4, 0x11D2, {0x9A, 0x0C, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0xFD } \
> }
>
> +#define EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID \
> + { \
> + 0X6AD9A60F, 0X5815, 0X4C7C, { 0X8A, 0X10, 0X50, 0X53, 0XD2, 0XBF, 0X7A, 0X1B } \
> + }
> +
> ///
> /// Protocol GUID defined in EFI1.1.
> ///
> @@ -299,5 +304,6 @@ struct _EFI_SERIAL_IO_PROTOCOL {
> };
>
> extern EFI_GUID gEfiSerialIoProtocolGuid;
> +extern EFI_GUID gEfiSerialTerminalDeviceTypeGuid;
>
> #endif
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index d03fc5b..fc4dae2 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -670,6 +670,9 @@
> ## Include/Guid/RtPropertiesTable.h
> gEfiRtPropertiesTableGuid = { 0xeb66918a, 0x7eef, 0x402a, { 0x84, 0x2e, 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }}
>
> + ## Include/Protocol/SerilaIo.h
> + gEfiSerialTerminalDeviceTypeGuid = { 0x6AD9A60F, 0x5815, 0x4C7C, { 0x08A, 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }}
> +
> #
> # GUID defined in PI1.0
> #
> --
> 2.9.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication
> is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is
> not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please
> promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH V2] MdePkg: Add Serial Terminal Device Type Guid
2020-06-24 16:19 [PATCH V2] MdePkg: Add Serial Terminal Device Type Guid Oleksiy Yakovlev
2020-06-26 3:31 ` Liming Gao
@ 2020-06-28 7:23 ` Zhiguang Liu
1 sibling, 0 replies; 3+ messages in thread
From: Zhiguang Liu @ 2020-06-28 7:23 UTC (permalink / raw)
To: devel@edk2.groups.io, oleksiyy@ami.com
Cc: Gao, Liming, Kinney, Michael D, Felixp@ami.com
Hi Oleksiy,
If you build OVMF with your code change, it will report one error:
error 3000: Invalid GUID value format
gEfiSerialTerminalDeviceTypeGuid = { 0x6AD9A60F, 0x5815, 0x4C7C, { 0x08A, 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }} (<CName> = <GuidValueInCFormat:{8,4,4,{2,2,2,2,2,2,2,2}}>)
This is because you use "0x08A" instead of "0x8A", and the tool thought you are trying to write a 2 bytes number 008A, not 1-byte number 8A.
Please fix it by just using "0x8A"
Thanks
Zhiguang
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oleksiy
> Yakovlev
> Sent: Thursday, June 25, 2020 12:20 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Felixp@ami.com; oleksiyy@ami.com
> Subject: [edk2-devel] [PATCH V2] MdePkg: Add Serial Terminal Device Type
> Guid
>
> Add definition of EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID.
> It was miseed in "Extend SERIAL_IO with DeviceTypeGuid" patch.
> (UEFI 2.8, mantis 1832)
>
> Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> ---
> MdePkg/Include/Protocol/SerialIo.h | 6 ++++++
> MdePkg/MdePkg.dec | 3 +++
> 2 files changed, 9 insertions(+)
>
> diff --git a/MdePkg/Include/Protocol/SerialIo.h
> b/MdePkg/Include/Protocol/SerialIo.h
> index e2e0c61..16a865b 100644
> --- a/MdePkg/Include/Protocol/SerialIo.h
> +++ b/MdePkg/Include/Protocol/SerialIo.h
> @@ -17,6 +17,11 @@
> 0xBB25CF6F, 0xF1D4, 0x11D2, {0x9A, 0x0C, 0x00, 0x90, 0x27, 0x3F, 0xC1,
> 0xFD } \
> }
>
> +#define EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID \
> + { \
> + 0X6AD9A60F, 0X5815, 0X4C7C, { 0X8A, 0X10, 0X50, 0X53, 0XD2, 0XBF,
> +0X7A, 0X1B } \
> + }
> +
> ///
> /// Protocol GUID defined in EFI1.1.
> ///
> @@ -299,5 +304,6 @@ struct _EFI_SERIAL_IO_PROTOCOL { };
>
> extern EFI_GUID gEfiSerialIoProtocolGuid;
> +extern EFI_GUID gEfiSerialTerminalDeviceTypeGuid;
>
> #endif
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> d03fc5b..fc4dae2 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -670,6 +670,9 @@
> ## Include/Guid/RtPropertiesTable.h
> gEfiRtPropertiesTableGuid = { 0xeb66918a, 0x7eef, 0x402a, { 0x84, 0x2e,
> 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }}
>
> + ## Include/Protocol/SerilaIo.h
> + gEfiSerialTerminalDeviceTypeGuid = { 0x6AD9A60F, 0x5815, 0x4C7C, {
> + 0x08A, 0x10, 0x50, 0x53, 0xD2, 0xBF, 0x7A, 0x1B }}
> +
> #
> # GUID defined in PI1.0
> #
> --
> 2.9.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread