public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: Paul <Paul.Grimes@amd.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition
Date: Fri, 28 Aug 2020 01:26:32 +0000	[thread overview]
Message-ID: <CY4PR11MB168736652741C9DFDAFBE23C90520@CY4PR11MB1687.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200827204051.777-2-Paul.Grimes@amd.com>

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: Paul <Paul.Grimes@amd.com>
> Sent: Friday, August 28, 2020 4:41 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [PATCH v1 1/1] MdePkg: Correcting
> EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition
> 
> In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10,
> but should be 0x02 per the ACPI Specification.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2937
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Paul G <paul.grimes@amd.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi10.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi10.h
> b/MdePkg/Include/IndustryStandard/Acpi10.h
> index fa06eefbb6e6..adeb5ae8c219 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi10.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi10.h
> @@ -358,7 +358,7 @@ typedef struct {
>  #define EFI_ACPI_DMA_TRANSFER_TYPE_MASK                 0x03
> 
>  #define   EFI_ACPI_DMA_TRANSFER_TYPE_8_BIT              0x00
> 
>  #define   EFI_ACPI_DMA_TRANSFER_TYPE_8_BIT_AND_16_BIT   0x01
> 
> -#define   EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT             0x10
> 
> +#define   EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT             0x02
> 
> 
> 
>  //
> 
>  // IO Information
> 
> --
> 2.21.0


  parent reply	other threads:[~2020-08-28  1:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 20:40 [PATCH v1 0/1] Fix for define error in Acpi10.h paul.grimes
2020-08-27 20:40 ` [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition Paul
2020-08-28  0:57   ` 回复: [edk2-devel] " gaoliming
2020-08-28  1:50     ` Andrew Fish
2020-08-28 19:09     ` Paul
2020-08-28 19:23       ` Paul
2020-08-30  1:37         ` 回复: " gaoliming
2020-08-28  1:26   ` Zhiguang Liu [this message]
2020-08-28 17:05   ` Laszlo Ersek
2020-08-28 18:39     ` Paul
2020-08-30  1:02       ` 回复: " gaoliming
2020-08-31  8:22       ` Laszlo Ersek
2020-09-02  8:58   ` Laszlo Ersek
2020-09-02 15:12     ` Paul
2020-09-07 13:58       ` Philippe Mathieu-Daudé
2020-09-08  8:10         ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR11MB168736652741C9DFDAFBE23C90520@CY4PR11MB1687.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox