From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"abner.chang@hpe.com" <abner.chang@hpe.com>,
Mark Salter <msalter@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>,
"Schaefer, Daniel" <daniel.schaefer@hpe.com>,
"Chen, Gilbert" <gilbert.chen@hpe.com>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] RISC-V: Fix build errors
Date: Wed, 23 Dec 2020 02:53:20 +0000 [thread overview]
Message-ID: <CY4PR11MB168757F53AA0823BCFB1F9A190DE0@CY4PR11MB1687.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CS1PR8401MB11446B39678BC7331BCAF396FFDF0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM>
[-- Attachment #1.1: Type: text/plain, Size: 2291 bytes --]
Hi Abner,
The git history for edk2-platforms master branch looks strange.
And the commit message of df24ce325872020e80d8f7bee93407f4c1517845 is missing
Can you help fix it?
Thanks
Zhiguang
[cid:image001.jpg@01D6D919.D10D2E00]
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner
> Chang
> Sent: Tuesday, December 22, 2020 2:36 PM
> To: Mark Salter <msalter@redhat.com>; devel@edk2.groups.io
> Cc: Leif Lindholm <leif@nuviainc.com>; Schaefer, Daniel
> <daniel.schaefer@hpe.com>; Chen, Gilbert <gilbert.chen@hpe.com>
> Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/2] RISC-V: Fix build errors
>
> Entire patch set looks good to me. Thanks for fixing this.
> Reviewed-by: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
>
> > -----Original Message-----
> > From: Mark Salter [mailto:msalter@redhat.com]
> > Sent: Tuesday, December 22, 2020 4:39 AM
> > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> > Cc: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Chang, Abner (HPS SW/FW
> > Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; Schaefer, Daniel
> > <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>>; Chen, Gilbert <gilbert.chen@hpe.com<mailto:gilbert.chen@hpe.com>>
> > Subject: [PATCH edk2-platforms 0/2] RISC-V: Fix build errors
> >
> > I ran into some errors while compiling for RISC-V/SiFive target.
> > These were trivial things arising from edk2 commits:
> >
> > bd9da7b1da26 MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field
> > ProcessorManufacturer
> > 9c1f455f5f0e MdePkg: Remove code wrapped by
> > DISABLE_NEW_DEPRECATED_INTERFACES
> >
> > Mark Salter (2):
> > Silicon/RISC-V: Update old SMBIOS struct filed name
> > Platform/SiFive/U5SeriesPkg: Remove use of deprecated interfaces
> >
> > .../Dxe/RamFvbServicesRuntimeDxe/FwBlockService.c | 9 ++++++---
> > .../ProcessorPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.c | 2 +-
> > .../SiFive/U54/Library/PeiCoreInfoHobLib/CoreInfoHob.c | 2 +-
> > 3 files changed, 8 insertions(+), 5 deletions(-)
> >
> > --
> > 2.29.2
>
>
>
>
>
[-- Attachment #1.2: Type: text/html, Size: 7602 bytes --]
[-- Attachment #2: image001.jpg --]
[-- Type: image/jpeg, Size: 74820 bytes --]
next prev parent reply other threads:[~2020-12-23 2:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 20:38 [PATCH edk2-platforms 0/2] RISC-V: Fix build errors Mark Salter
2020-12-21 20:38 ` [PATCH edk2-platforms 1/2] Silicon/RISC-V: Update old SMBIOS struct filed name Mark Salter
2020-12-21 20:38 ` [PATCH edk2-platforms 2/2] Platform/SiFive/U5SeriesPkg: Remove use of deprecated interfaces Mark Salter
2020-12-22 6:36 ` [PATCH edk2-platforms 0/2] RISC-V: Fix build errors Abner Chang
2020-12-23 2:53 ` Zhiguang Liu [this message]
2020-12-23 6:41 ` 回复: [edk2-devel] " gaoliming
2020-12-23 6:44 ` Michael D Kinney
2020-12-23 7:05 ` 回复: " gaoliming
2020-12-23 7:17 ` Bob Feng
2020-12-23 7:28 ` Zhiguang Liu
2020-12-23 15:47 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB168757F53AA0823BCFB1F9A190DE0@CY4PR11MB1687.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox