Re: [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16

["Zhiguang Liu" <zhiguang.liu@intel.com>]

Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>

> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:30 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v2 5/5] MdePkg: Fix SmBios.h
> PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16
> 
> The ProcessorCharacteristics is a UINT16 field, so the
> PROCESSOR_CHARACTERISTIC_FLAGS bitfield should be UINT16 too.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index c495c48f3b47..1ee01645679a 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -862,17 +862,17 @@ typedef struct {
>  } PROCESSOR_FEATURE_FLAGS;
> 
>  typedef struct {
> -  UINT32  ProcessorReserved1             :1;
> -  UINT32  ProcessorUnknown               :1;
> -  UINT32  Processor64BitCapble           :1;
> -  UINT32  ProcessorMultiCore             :1;
> -  UINT32  ProcessorHardwareThread        :1;
> -  UINT32  ProcessorExecuteProtection     :1;
> -  UINT32  ProcessorEnhancedVirtulization :1;
> -  UINT32  ProcessorPowerPerformanceCtrl  :1;
> -  UINT32  Processor128bitCapble          :1;
> -  UINT32  ProcessorArm64SocId            :1;
> -  UINT32  ProcessorReserved2             :6;
> +  UINT16  ProcessorReserved1             :1;
> +  UINT16  ProcessorUnknown               :1;
> +  UINT16  Processor64BitCapble           :1;
> +  UINT16  ProcessorMultiCore             :1;
> +  UINT16  ProcessorHardwareThread        :1;
> +  UINT16  ProcessorExecuteProtection     :1;
> +  UINT16  ProcessorEnhancedVirtulization :1;
> +  UINT16  ProcessorPowerPerformanceCtrl  :1;
> +  UINT16  Processor128bitCapble          :1;
> +  UINT16  ProcessorArm64SocId            :1;
> +  UINT16  ProcessorReserved2             :6;
>  } PROCESSOR_CHARACTERISTIC_FLAGS;
> 
>  typedef struct {
> --
> 2.26.2