From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.10500.1595296784915218550 for ; Mon, 20 Jul 2020 18:59:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LD3ZWoK1; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: xMa4FVbkYI6FUk2/9B4cQYGec1foKmKTrMZOeDB3py10mklKBqqfdbs6DVUHLiUErmSwMVIrIN Vc/hzgckRfKw== X-IronPort-AV: E=McAfee;i="6000,8403,9688"; a="130122405" X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="130122405" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2020 18:59:43 -0700 IronPort-SDR: BPtGsAYHWtDNrAUe17IRhuOR7VwD1bi0wWKLZppeo2d/MMFpIQd2JvAO+E7N8ieqkWyXQYWigD 7Uhb3wrjuNKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,377,1589266800"; d="scan'208";a="431817701" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga004.jf.intel.com with ESMTP; 20 Jul 2020 18:59:43 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Jul 2020 18:59:42 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 20 Jul 2020 18:59:42 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.53) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jul 2020 18:59:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xmbi6uko7w+H9K6OtWoMI7zV2JB5GxdqMARstmpq6Iw/ZZHMfnfzzDBsdtWCnTzN5abV9BT/Cl9gux1mULw/K+OpqXX9fxdlT3Eo+AvflFO0A7QDMEySewlHVuy7F64+CEWpaV4SVcSdyvB6KOZAEYBlA8Ri4pBf7+hMxbYQ0TiuTThS0dkmzeXJuYP+yP2S95i8d+BxIyIu4XMOh8mkm/hZ2HegFZUhWWEmYc86elAoqVxafvJcjmzRMBWtfJbFbtPbFZS5Td2h0CevPuZppwzMmWaKOW3J1A8KKaSUwaexYWq1KFHn+5yGxZ0PxRZ1Y+hggKopZrttb95C0T10HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Q1RGFRbJ8E4UO+WSg1YWFRq54l31kWMS1PiRbKMG/o=; b=NaJUmFxVoNcg1ATqOArofNLKYs0tpCunVnB2IdGmvXkijSuGcr2R+1Jo4ZiKiUP6uKiaFYu6nYvCR3NoPZf0vNRvg2a0sEfXlAwRpg+YTArLy+mHpVioY1RtPeOHXoW+FYO2oqh4O6J74hgs9eZ/43ccjn0ZaPNe9Bqi0xgk53RtPsqw34xYY6ztxwQbe4LWPPwEVPdK8RvTnRStm/4YCpxP+bz1n315suEv8L6Ht6S6qtazZKVKFb+teaoLOdMhGJcQmlZ7PnBEVhfkuTqiyk4vEoC+zZKfFuJeKvQu0og502GUt4pSVZEKLA2XHDKYzC/XtX5Iwj5mz8ydj2zGSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Q1RGFRbJ8E4UO+WSg1YWFRq54l31kWMS1PiRbKMG/o=; b=LD3ZWoK1kSbwxe8UJ7F+cI/yfZyuiVn8w/pXqY+UQZqZQU1NzwZLerRUIatv0AXANl5lnLH07igeogMM/WiEL0qkJ7MV2q97ZZz8O4/mXhBaSJ53bfj1vYhi5x+/JBzVuuBGei6jOpcfhTYnPaxTgloV1k4p5/ALIPoPLoOY4S4= Received: from CY4PR11MB1687.namprd11.prod.outlook.com (2603:10b6:903:2e::11) by CY4PR11MB1735.namprd11.prod.outlook.com (2603:10b6:903:127::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.24; Tue, 21 Jul 2020 01:59:40 +0000 Received: from CY4PR11MB1687.namprd11.prod.outlook.com ([fe80::1490:81c1:9ca1:df58]) by CY4PR11MB1687.namprd11.prod.outlook.com ([fe80::1490:81c1:9ca1:df58%9]) with mapi id 15.20.3195.025; Tue, 21 Jul 2020 01:59:40 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "leif@nuviainc.com" , Jessica Clarke CC: "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for __builtin_return_address Thread-Topic: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for __builtin_return_address Thread-Index: AQHWXp7fbBHyG5uF60SLeWzKhikxcKkRR8sg Date: Tue, 21 Jul 2020 01:59:40 +0000 Message-ID: References: <20200720134946.33723-1-jrtc27@jrtc27.com> <20200720140446.GP12303@vanye> In-Reply-To: <20200720140446.GP12303@vanye> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62a3f12f-77c6-4411-4f8b-08d82d19baeb x-ms-traffictypediagnostic: CY4PR11MB1735: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:352; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /HnqgwyFJUNuCZXPnZ3cv14eI7DGFoQoX5nKNqiZVem0RH2V9ecvHmoZwEHitNGMdPYjEh6Upzjtsb97bEbqqsh6955He/L3qyftbRs1z0mLfZOOy3jDOwh9ZedXx99dmJg8IV/rJFnT7ILTB5tCtI8K2xP6Dg2RjeHryxdIv1yB5wii+LjVY+1hXUfaqM8Vmv3OZscnRyC871kOTIFoOvxmwSsDsrTo8WQLasw+d3KP4VLNOvpZwzDapN3aQRP16PbCxYv33S/2sqwyyWLDaFSEgsXZdxpOewFQlO0An0G4msYGshiwMnWKFMZbDAazrut8QLD2KvD1bKA3FG1mNv9fFLjdage9cbHhfpQR/TUxQi+dIJkVnx2aXeTKzZbwsMr28ovLtuUnDZHffBf2VQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1687.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(2906002)(8936002)(83380400001)(53546011)(54906003)(5660300002)(316002)(110136005)(6506007)(52536014)(478600001)(966005)(86362001)(7696005)(186003)(55016002)(26005)(4326008)(33656002)(8676002)(9686003)(66446008)(76116006)(71200400001)(66476007)(64756008)(66946007)(66556008)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: GAr5kCwIpvHTphpzXX8n8aP7sNUjkEHn7WBI5jFF4i+J/RL9VxXPVLWSho9AfEk2hecamHGU3vU6XKOhK9eMRrQRTC8owRhHI4Xv5d7W2ZzX7ZtPGSDYsoo4rUCBtJmFdhr60OCJCablQ063O1wqhyyU48vjcAxogWVbAzBneq6JEfWheLZ0pMSzBshFeBDJ7BOxOHfgDSNd2VbGoDRGcdcIMzplVESq4mJDLJMlrCJabXekGQDm7SEPSlhMPFnHuIS2T+HGWsqN7yKSu1YiKPmKztrDgwzgS/S3AKN313G8jxMygbjTzRdYNPMmhPOju2hgCCvTNDD/j3TtZJV015wbeKrA7C+9MCkoJ/Ne+yz89TCJNjLa3UT6xkMx1eh2MtVhBeqfSIIfZPqDdAEOZpFc59YZyMxHZdqx35j+srLs6tE2em5Q+6WUXrBDWw1QxYOWHogAUPFf7PNO5CpuMt6M5EInyPfVhk6OwaKPdxErNsOoMTkHIAPD60isWPNl MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1687.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62a3f12f-77c6-4411-4f8b-08d82d19baeb X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 01:59:40.5511 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ca6zgrMBoYIXr6dEbfFJgds16zHXkrXHnExLTKnOM2nWFlwUThw34NNpdhVyQ9Nm1kL4x1Y5GmrpuZ1s/aVCwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1735 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhiguang Liu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Leif > Lindholm > Sent: Monday, July 20, 2020 10:05 PM > To: Jessica Clarke > Cc: devel@edk2.groups.io; Kinney, Michael D = ; > Gao, Liming > Subject: Re: [edk2-devel] [PATCH] MdePkg Base.h: Delete prototype for > __builtin_return_address >=20 > +Mike, Liming >=20 > On Mon, Jul 20, 2020 at 14:49:46 +0100, Jessica Clarke wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1004 > > > > Being a compiler builtin, the type of __builtin_return_address is > > already known to the compiler so no prototype is needed. Clang also > > errors out when redeclaring certain builtins like this[1], though > > currently only for ones with custom type checking. At the moment, > > __builtin_return_address does not use custom type checking and so does > > not trigger this error, however, the CHERI fork of LLVM, which will > > form the basis of the toolchain for Arm's experimental Morello > > platform, does use custom type checking for it, and so gives an error. > > Thus, simply delete the unnecessary line. > > > > [1] > > https://github.com/llvm/llvm- > project/commit/41af97137572ad6d4dafc872e7 > > ecf6bbb08d4984 > > > > Cc: Leif Lindholm > > Signed-off-by: Jessica Clarke > > --- > > MdePkg/Include/Base.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index > > 85a091b9d5..8e4271f6ea 100644 > > --- a/MdePkg/Include/Base.h > > +++ b/MdePkg/Include/Base.h > > @@ -1273,7 +1273,6 @@ typedef UINTN RETURN_STATUS; > > **/ > > #define RETURN_ADDRESS(L) ((L =3D=3D 0) ? _ReturnAddress() : (V= OID *) 0) > > #elif defined (__GNUC__) || defined (__clang__) > > - void * __builtin_return_address (unsigned int level); >=20 > Agreed this looks somewhat bonkers. > And I can't see any ill effects from dropping it, so: > Reviewed-by: Leif Lindholm >=20 > > /** > > Get the return address of the calling function. > > > > -- > > 2.20.1 > > >=20 >=20