From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.7730.1598944567485251370 for ; Tue, 01 Sep 2020 00:16:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=fKxv3zmO; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhiguang.liu@intel.com) IronPort-SDR: CWJMAgPAu8upbDGfbBxDXK1QoJhK5pGPXReJnSf6AkQWT5JtBQ43udPfxz1NS497sFWAvmgSd2 QhE8wDf8rh9w== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="137166660" X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="137166660" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 00:16:06 -0700 IronPort-SDR: rfD9D0MxSww0wIN/R7gkuiBUEIp/MPyOKm7P4AU4V5veQiPqwmIix28kLN1OgdZL0ezPcuZT+6 TJLeElFdh6dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="446017720" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 01 Sep 2020 00:16:05 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 1 Sep 2020 00:15:07 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 1 Sep 2020 00:15:07 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 1 Sep 2020 00:15:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWy7S9xGhnKIPThZ7VCu2FJA4sl54UNuqLLpUga4f1WUz5rD8vuv6+3ZN3ZY0gj1cv2ENfVZkbXdB41IomHAW53Lah76QvzkcqVBp0sVpXHskhKOSn98RXF+yHPzeCXpkm31oppdcboZllQv4Uhy1UV7ta0ujKUJscrJKX63aDwK9+wv2qFEoAR/1OjsIJ/rowynkf3hdCtTF4m5pzExQG6J2BXaHzSTXjvjLQpGEuzZJPeQKLrN2SUYOxMQmMMNIcO42YXaScW7iKJGo37Pn/KgpmY3D0sFp9BbQ65KBQr6A68j+EHPv2qnkz+GuAEgXI+KCqhWFppAMNQPtSXlMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRv8lAi3XkrLYD9Rmh0MzBUEYWHTxr8aILb8E/OU3ME=; b=YpjC3hEpR4lJvzp1nfJ2eHVKFNcUiAn+yWo4JBTSWJicTp0UhfyzC/BV9yMNbROWTor1YLq0uG1fVNHe8Z7CBVk1IZxR15g1ht6ziNMY39ykO7ZU6yyY8Csy+gvd1EXRYB6VGJMeftY9J+M0W+YAmmgZx6nJ++y3AmLS4bRJ80OO5OqKjLeo2KcU/nndnc3UztxmGHwMC4JcUhpdIJwhTuFBlGfEoLAY8EqbNPcBzxVe+dj0wUOktg3wyHrCTon0gTAM7Byiv6YYQNefc5hRqyibdHC3V8mD97zDjbPCLs+jDcsbycV6My0qoWaeeuxXQAyCj5ORBLyiD47x7IBo2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yRv8lAi3XkrLYD9Rmh0MzBUEYWHTxr8aILb8E/OU3ME=; b=fKxv3zmO4F/O+vPjK+EI6FIWFBmKa3tjPoMwBLtP01J2/NakvQI6DmByU9NtBIIqXMiOBGD7hsAZXpbSVvFa/BDumOHjmvfpAKKyKP6AyoEWJ65a7etID7MOPghUdFy+dAgUDeZ4bOaA1AnjwPjKl10GsQuDx5fnc4FOs+abeq8= Received: from CY4PR11MB1687.namprd11.prod.outlook.com (2603:10b6:903:2e::11) by CY4PR11MB1734.namprd11.prod.outlook.com (2603:10b6:903:125::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.23; Tue, 1 Sep 2020 07:15:03 +0000 Received: from CY4PR11MB1687.namprd11.prod.outlook.com ([fe80::b590:372a:9224:5e7b]) by CY4PR11MB1687.namprd11.prod.outlook.com ([fe80::b590:372a:9224:5e7b%8]) with mapi id 15.20.3326.025; Tue, 1 Sep 2020 07:15:03 +0000 From: "Zhiguang Liu" To: "devel@edk2.groups.io" , "Liu, Zhiguang" , Liming Gao CC: "Yao, Jiewen" , "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul1" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed. Thread-Topic: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status before it is consumed. Thread-Index: AQHWf/qb1Ev2GgVub0muY5wAZoqk/qlTXbrg Date: Tue, 1 Sep 2020 07:15:03 +0000 Message-ID: References: <163082D6E46F54DD.9345@groups.io> In-Reply-To: <163082D6E46F54DD.9345@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eed3b96d-f288-4b0d-481b-08d84e46bf21 x-ms-traffictypediagnostic: CY4PR11MB1734: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:663; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: exeozD7b1z6Sj+9hESBMsEFEX/g2+LgPsAZttQoA/mSCI/JUnc7Poyo68VtHGmJ1333r/IGJV8+8Am1HSmKHesp34jJQjBKAjlT9CTwWl58qV6T6t0rakUaC6lH6qGHOPirIxX62oSqF2IGGnaWnlhSBEGOcuQtqgNgjiYWjFrg3/ZWId5LAGV4t63xfh1KOC3pTA5S3SMicS+R+A5zj0sO6Lw6PVBgYyrtI0qGGX4JLaYRg58/5oSQip/uBciCZE3gHncyBUc0BSLnlzZqSXg5EjNty1aAVnwcratD0C2QM1FQmE6T3+eZcn9tOLDQVS0Odl9LrafmP9fnw9ctd3Gz3QLcgyuHh1BMzt3hJGMApOoKrCoA8rqvM2uQewfcfCjgTeqXhMaLjIQiOIK+h7g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR11MB1687.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(376002)(136003)(346002)(39860400002)(19627235002)(2906002)(8676002)(5660300002)(15650500001)(966005)(52536014)(83380400001)(4326008)(71200400001)(478600001)(33656002)(53546011)(66556008)(7696005)(6506007)(66446008)(8936002)(55016002)(66476007)(66946007)(86362001)(9686003)(316002)(76116006)(64756008)(110136005)(26005)(54906003)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: YCw+ykebnvZAI8zu2WXzVCQtHZJV66lXCL7WOdgwdnNdlb1s6EtSEmtchKbi8OY3Fm8VKf3iqLDxrftiedPgxwQaKBGReGYDV2mJb/cpbfWEG8M0neIM9wmOp+FZEzomFsWZJ1GV/KooP7AXzU/iyYbPGngTvj8C7/5Atq8QaP4Xkl820jUop40mDxgoTGc/vOmPNya2blPW5R6tnUgpbVAC6iVgpsisIEXgzf5H8c1j1EEj3LtA2mjPYw88pK9P2eCee4+1R6me+fex1XD5l1/5LPxGImKvpN73IBMAOgXXb/C7UpbMPOmUBRu3J+7Gy6X/DXAIYNb+Ai+jSYNXo1K1hHknhVWdO/pzHu0hiyPouxx2AdPHhOEkrhlzEOjHJh4GJquWbLxX3r0MMgFpBjl7kWrW9wHuyNd2WP5N319amslqY7YruUDqRtByiw6mFPZQqNqZmHLPRlOnuXQ9iZMqFyIHP+0SzitVrsgE0X5oeLwRTuuP0XmpWpHDfsXoN1Ob5wefZF+0acSw7hv26ZGxHP4RynH+Kezb6938H84Q4JcHFGuY7q5DOiVMAVvm5HTpkFf2lPdsRW7Gz8Jzb/xh05eAb2CAggIYYnaf8Nasx+0Gny/+W8WaLYOl1N99DN/wZk4Hy/FafVwOWWS25g== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1687.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eed3b96d-f288-4b0d-481b-08d84e46bf21 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 07:15:03.2362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H1xVoI3x5YZWrTUAoegpYBi6pblQg+LRTrhRNKYgb2UB8ExBPu8A20vaejBsyW2gIV8P1Jl0R6tJjMFpyKy+4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1734 Return-Path: zhiguang.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Can this patch check in before this stable tag? Thanks Zhiguang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhiguang > Liu > Sent: Tuesday, September 1, 2020 8:55 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 ; > Laszlo Ersek > Subject: [edk2-devel] [PATCH] SecurityPkg: Initailize variable Status bef= ore it is > consumed. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2945 >=20 > V2: Move "Status =3D EFI_SUCCESS;" before the EDKII_TCG_PRE_HASH check. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Laszlo Ersek > Reviewed-by: Jiewen Yao > Signed-off-by: Zhiguang Liu > --- > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > index 0e770f4485..93a8803ff6 100644 > --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c > @@ -456,6 +456,7 @@ HashLogExtendEvent ( > if ((Flags & EDKII_TCG_PRE_HASH) !=3D 0 || (Flags & > EDKII_TCG_PRE_HASH_LOG_ONLY) !=3D 0) { >=20 > ZeroMem (&DigestList, sizeof(DigestList)); >=20 > CopyMem (&DigestList, HashData, sizeof(DigestList)); >=20 > + Status =3D EFI_SUCCESS; >=20 > if ((Flags & EDKII_TCG_PRE_HASH) !=3D0 ) { >=20 > Status =3D Tpm2PcrExtend ( >=20 > NewEventHdr->PCRIndex, >=20 > -- > 2.25.1.windows.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#64865): https://edk2.groups.io/g/devel/message/64865 > Mute This Topic: https://groups.io/mt/76530112/1779286 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [zhiguang.liu@intel.co= m] > -=3D-=3D-=3D-=3D-=3D-=3D