From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: Rebecca Cran <rebecca@nuviainc.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Ni, Ray" <ray.ni@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field
Date: Wed, 28 Oct 2020 05:05:06 +0000 [thread overview]
Message-ID: <CY4PR11MB1687F8D24B2F091EA3BC030C90170@CY4PR11MB1687.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201027172931.27297-5-rebecca@nuviainc.com>
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> -----Original Message-----
> From: Rebecca Cran <rebecca@nuviainc.com>
> Sent: Wednesday, October 28, 2020 1:30 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0
> ARM64 SoC ID field
>
> SMBIOS 3.4.0 defines bit 9 of the Type 4 table Processor Characteristics field
> to be the ARM64 SoC ID support. Add it to the
> PROCESSOR_CHARACTERISTIC_FLAGS struct bitfield.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index f2db11f947d1..c495c48f3b47 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -871,7 +871,8 @@ typedef struct {
> UINT32 ProcessorEnhancedVirtulization :1;
> UINT32 ProcessorPowerPerformanceCtrl :1;
> UINT32 Processor128bitCapble :1;
> - UINT32 ProcessorReserved2 :7;
> + UINT32 ProcessorArm64SocId :1;
> + UINT32 ProcessorReserved2 :6;
> } PROCESSOR_CHARACTERISTIC_FLAGS;
>
> typedef struct {
> --
> 2.26.2
next prev parent reply other threads:[~2020-10-28 5:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 17:29 [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 1/5] ShellPkg: Fix a couple of typos in smbiosview Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 2/5] ShellPkg: Fix smbiosview string definition name for "boot from CD" Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 3/5] ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview Rebecca Cran
2020-10-27 17:29 ` [PATCH v2 4/5] MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field Rebecca Cran
2020-10-28 5:05 ` Zhiguang Liu [this message]
2020-10-27 17:29 ` [PATCH v2 5/5] MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 Rebecca Cran
2020-10-28 5:05 ` Zhiguang Liu
2020-10-28 0:56 ` 回复: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition gaoliming
2020-10-28 1:27 ` [edk2-devel] " Rebecca Cran
2020-10-30 1:08 ` Gao, Zhichao
2020-10-30 1:14 ` 回复: " gaoliming
2020-10-30 13:28 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR11MB1687F8D24B2F091EA3BC030C90170@CY4PR11MB1687.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox