From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by mx.groups.io with SMTP id smtpd.web10.12367.1580146138252871513 for ; Mon, 27 Jan 2020 09:28:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=n1 header.b=i8eyobXq; spf=pass (domain: nvidia.com, ip: 203.18.50.4, mailfrom: ashishsingha@nvidia.com) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 28 Jan 2020 01:28:55 +0800 Received: from HKMAIL101.nvidia.com ([10.18.16.10]) by hkpgpgate101.nvidia.com (PGP Universal service); Mon, 27 Jan 2020 09:28:55 -0800 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Mon, 27 Jan 2020 09:28:55 -0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 27 Jan 2020 17:28:54 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 27 Jan 2020 17:28:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hr8IFdYT7Qxl26+5o0uiO4075Abluoxvc9iDzGw7ZuXWOKP8Ukc2E3firc1lUxEZ5K3n8etIK9ubByc7CJi92BowaMPJwLIV/4MAWUhdmGxzzBKQWzN1sI1Mr62CtNsk54btIN+NNR/o5I/wXEVs7uIQpA3j+01kxA/ZykGL2WFdkyx1cbcIx2MMhdoQDh7Hj1Svmsm0udgLkvAG5dVNcqUi2LdPMFVEMccjX1qtRT9C/0sFCodUV2+g5pSlFr7wiz2Ijgn9V9UjGyl0nvWS1kCJ/XoM24R+DxHtDdlYspZUAi0AZ+hc8UazM4QWWPijKTcKqf5q2LUK+qFPLmJMWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kOlT0lTOhj6rd62RHoBynO66FzFkJPx4xQ1d+Hg2taQ=; b=MGtsu0Q+zHpiFFhic88comETIp+4ZjedOs2+/wPaYwlDkQt7Oy5biBc4CgF7dQxCW+Knv8QrbMqf7SSkjDznctM1JsUSCHa5xQlirexSOd06OcqEqjQF4nKVcOR//xIH1lxKwd8Yx5mlF3sFxnMnwQX1QoRnotLElkTibgiQEm7xeviOJlYKw4Ot2qyw/VJtzAgfTv93UciJKqVERxaUiENjqxdpkD6GnwvN0PQnHOGqA7fI1j/f5AfddlbawyF1896pI/7DPFfhrDbXEIp+A31EKRlRFUv1K9kjC3fdKYKao6xwBFk48HASsqnj9jQi6ratPOf13lA1H0s9JaZFgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB0134.namprd12.prod.outlook.com (10.172.77.143) by CY4PR1201MB0007.namprd12.prod.outlook.com (10.172.118.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.22; Mon, 27 Jan 2020 17:28:52 +0000 Received: from CY4PR1201MB0134.namprd12.prod.outlook.com ([fe80::d8da:419a:32ed:2bcc]) by CY4PR1201MB0134.namprd12.prod.outlook.com ([fe80::d8da:419a:32ed:2bcc%11]) with mapi id 15.20.2665.026; Mon, 27 Jan 2020 17:28:52 +0000 From: "Ashish Singhal" To: "Gao, Zhichao" , "devel@edk2.groups.io" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Topic: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser Thread-Index: AQHVz1S76mKn+oSl4EuAekfFnBqRZ6fzK6gAgAuj+9A= Date: Mon, 27 Jan 2020 17:28:52 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ashishsingha@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-01-27T17:28:50.1583651Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=6d1a2c85-404b-455b-bbb5-0efc30f3abec; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic authentication-results: spf=none (sender IP is ) smtp.mailfrom=ashishsingha@nvidia.com; x-originating-ip: [216.228.112.21] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8deb31a5-1a17-4c99-336f-08d7a34e60e6 x-ms-traffictypediagnostic: CY4PR1201MB0007: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:411; x-forefront-prvs: 02951C14DC x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(376002)(366004)(396003)(136003)(39860400002)(189003)(199004)(478600001)(8676002)(966005)(8936002)(186003)(86362001)(81166006)(81156014)(110136005)(55016002)(9686003)(316002)(7696005)(26005)(53546011)(6506007)(33656002)(5660300002)(2906002)(52536014)(66446008)(64756008)(66556008)(76116006)(66476007)(66946007)(71200400001)(213903007);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR1201MB0007;H:CY4PR1201MB0134.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nvidia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Qep6jpiEuy+HlVlgsI28RRBkSEmIEBn2fL/2jg1fEO5EYssnT5RhL8kFyrEcdfA1NxMz4UIgXvwzXrgK0aP4MzcMa2QS0q4Fq0nKexRofqxD6Q6JEkUxhnv0VpYWB2Uq7C+FRfo4Xjvb/cKBKwGzhz1Pfu2rMxrBZ9ARXsOgFf3qiAIE6B8hrskiRYYzVHs5bXJb6MoA/Px5v8Gh1SDUrBOMGxMm213Emiy1MtS2ZqPrL3Lq28R/m2unbU9Ujb0DpaK8ateWV1NwaK4qOymqRo4A58OgVlh7De4ZFjJap1BHTizOEElKMzcb3IRcibmfOUTOixvfqx6S0JVkbk/jypHPRwmj7Ga2E78eWvTIBoud2CzEMz9YHflvM5Krhld/68vtPbal7LimUa6/6SVePPzRt7t/QzWbUAcE5xkUA+29p4wErIo/eBgqgtN5S/VPLViquInNbi1GccOm0GR4fVU09YJ/fQGPgMEwuAPgjY1hmpvCyPty/iHQoqpgNWATh68chtsHxxGC91fnlu3HtVnPmDb1tTfsn6wHwte/kRLG2ohzJr8AzO3+6W00daR x-ms-exchange-antispam-messagedata: KU9FFfNoftAhvhD/r2hVFgwo3lhyS0WpvsUFp3H5kTWcQLyMuE2bJsJfVyKn1laeHw9qucv2e2Bs4qTIRyH+5Zl8+DeW/bIMRnQG3ZmL6SPOx7qElU/shHi0/u5YFNh6Ysa1vZKw0loOFYEOEZmUxw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8deb31a5-1a17-4c99-336f-08d7a34e60e6 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2020 17:28:52.3730 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m0m+y2Qyv8JRQefKVzNFBo9D/51dehrtD4KHAjNfMLMW5A4VeAy7Ot04wBvJKq4KB79cEBnsJjJxflaERBUJ9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0007 Return-Path: ashishsingha@nvidia.com X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1580146135; bh=PsQuazPYq1w154ju3/hSXoTxuDFuxzDNS2qXsj1iTb8=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:msip_labels: authentication-results:x-originating-ip:x-ms-publictraffictype: x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-forefront-prvs:x-forefront-antispam-report:received-spf: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg: Content-Language:Content-Type:Content-Transfer-Encoding; b=i8eyobXqIcQv/PAQAa50AH7HFZgxIeYson1oEeGTR5du0zLXUWZgoqenuqHUrHOTe mxZI2eQRalC1Yr1ygCIc7nWMXZN8p11SV2bGQon1g06HsTUd/gWdBRJGytSkvGXViV JNeQyz8pQzQDpM+E9QmcyzEl8KYvcrTUAKsw9HowXLaMS3VoLJkW0H6JR3Ggrfib4p UwiSar6o8TGo88yiNaZctycQ+GD2ucpqwihkL6HPArFJwPfIFlkAvUzZ84/cg14Of+ aEyxxtQZqxa2DIL3fUtjBb6zc/9AWAX0Gu5afNHLmuqe8Md9hlBSfKJrwA23+Sw07P loysJjwi8wARQ== Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Zhichao, Do you know by when this may be merged? Thanks Ashish -----Original Message----- From: Gao, Zhichao =20 Sent: Monday, January 20, 2020 12:42 AM To: devel@edk2.groups.io; Ashish Singhal ; Ni, Ra= y Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fi= x FADT Parser External email: Use caution opening links or attachments Reviewed-by: Zhichao Gao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20 > Ashish Singhal > Sent: Monday, January 20, 2020 1:45 PM > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao=20 > > Cc: Ashish Singhal > Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib:=20 > Fix FADT Parser > > FADT parser was checking for reduced ACPI flag incorrectly leading to=20 > incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are both=20 > 0. > > Signed-off-by: Ashish Singhal > --- > .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > index 5b8cc174f1..8acfbac3b1 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars > +++ er.c > @@ -253,7 +253,7 @@ ParseAcpiFadt ( > // present. > if ((Trace) && > (Flags !=3D NULL) && > - ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D 0)) { > + ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=3D > + EFI_ACPI_6_3_HW_REDUCED_ACPI)) { > IncrementErrorCount (); > Print (L"ERROR: No FACS table found, " > L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are=20 > zero.\n"); > -- > 2.17.1 > > >=20 --------------------------------------------------------------------------= --------- This email message is for the sole use of the intended recipient(s) and ma= y contain confidential information. Any unauthorized review, use, disclosure or dis= tribution is prohibited. If you are not the intended recipient, please contact the = sender by reply email and destroy all copies of the original message. --------------------------------------------------------------------------= ---------