From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0053.outbound.protection.outlook.com [104.47.33.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BB76121E1B76E for ; Thu, 21 Sep 2017 06:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oFBkC+Z/URUlb4KZsJ31MpQaEqZ5dGVrkjjzeFqTTJU=; b=2z5xjYOsJCh8EXCD7ifKKS5lo8/CTJW1y5DmAEBJZHolYH/ywG0q4aTzdx70/hb8+/QIAFvIvlZ7wOfrFlcNw1rxHQwdUB79iOuoZf3x7sgLbflU31FokI1PwYQ9jsuskc1Lw9ReN8IhmFbpA/isEj26Ong+mO6/uk66B4Db8Ps= Received: from CY4PR12MB1702.namprd12.prod.outlook.com (10.175.62.136) by CY4PR12MB1704.namprd12.prod.outlook.com (10.175.62.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 21 Sep 2017 13:21:59 +0000 Received: from CY4PR12MB1702.namprd12.prod.outlook.com ([10.175.62.136]) by CY4PR12MB1702.namprd12.prod.outlook.com ([10.175.62.136]) with mapi id 15.20.0077.011; Thu, 21 Sep 2017 13:21:59 +0000 From: "Kirkendall, Garrett" To: Leif Lindholm , "edk2-devel@lists.01.org" CC: Michael D Kinney , Jordan Justen , Laszlo Ersek , Andrew Fish , Ard Biesheuvel Thread-Topic: [edk2] [RFC 0/6] Create central repository for boilerplate configuration Thread-Index: AQHTMjXRBd5aZid2kkuLmsZvYzn6tqK/UEoQ Date: Thu, 21 Sep 2017 13:21:59 +0000 Message-ID: References: <20170920172755.22767-1-leif.lindholm@linaro.org> In-Reply-To: <20170920172755.22767-1-leif.lindholm@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Garrett.Kirkendall@amd.com; x-originating-ip: [165.204.77.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR12MB1704; 20:tesP7/baTqPGs5nzpu1SamGD+cPGOMh+iMo584SMGVSEUc+UNcZd7oeWVYOj7MtErMKkiKtcANfsOtr5P/9JvqC30pN1KFHDISMBvmhtV4yfCmW7YBcuYyz8dwBNoR8QB2TpjmqdhasM6RW6pUiyEuSbuOyFXXurdSPv/4uEQEes9+9WWXS2mdAPY6hdn41PEzLi+tECQlbOewJ6g1heWSSupoNfxd4E8E0n5HfWyNQ6241Dvnglhefg924yiCpz x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: b62fdc11-54ba-450a-b274-08d500f3bd17 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY4PR12MB1704; x-ms-traffictypediagnostic: CY4PR12MB1704: x-exchange-antispam-report-test: UriScan:(80524489315369)(192374486261705)(767451399110)(162533806227266)(81227570615382)(31960201722614)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR12MB1704; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR12MB1704; x-forefront-prvs: 04371797A5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(39860400002)(376002)(377454003)(13464003)(199003)(189002)(174864002)(25786009)(68736007)(189998001)(86362001)(6246003)(9686003)(6306002)(105586002)(6506006)(106356001)(102836003)(6116002)(77096006)(99286003)(3846002)(8666007)(55016002)(81156014)(81166006)(8676002)(229853002)(2900100001)(2950100002)(33656002)(3660700001)(6436002)(8936002)(53936002)(2501003)(316002)(478600001)(2906002)(966005)(72206003)(54906003)(50986999)(54356999)(101416001)(66066001)(110136005)(14454004)(76176999)(4326008)(5660300001)(97736004)(305945005)(7736002)(53546010)(3280700002)(74316002)(7696004)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1704; H:CY4PR12MB1702.namprd12.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2017 13:21:59.0574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1704 Subject: Re: [RFC 0/6] Create central repository for boilerplate configuration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 13:18:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Something I have found useful is leaving the intended file extension at the= end of the file name. That way, you still know it is intended to be "!inc= lude"ed, but any editor file extensions you have set up still work on these= files. ConfigPkg/Security/Security.dsc.inc =3D> ConfigPkg/Security/Security.inc.ds= c Since DSC can merge sections from different files, one *.inc.dsc file is su= fficient with multiple sections. =20 For FDF files, I've found that sections cannot be merged so it might be bet= ter to indicate where pieces are intended to be included *.pei.inc.fdf and = *.dxe.inc.fdf. Also, these files probably shouldn't contain section header= s because you don't know what a platform might call the sections/FVs. (gen= eral statements, not critique on this RFC) This allows people to "!include" directly and know where the pieces are int= ended to go. Plus it gives a quick view indication in the platform DSC and= FDF files that things have been "!include"ed in the correct sections of th= e file. Thanks, GARRETT KIRKENDALL SMTS Firmware Engineer | CTE 7171 Southwest Parkway, Austin, TX 78735 USA=20 AMD=A0=A0 facebook=A0 |=A0 amd.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Leif Lindholm > Sent: Wednesday, September 20, 2017 12:28 PM > To: edk2-devel@lists.01.org > Cc: Michael D Kinney ; Jordan Justen > ; Laszlo Ersek ; Andrew Fis= h > ; Ard Biesheuvel > Subject: [edk2] [RFC 0/6] Create central repository for boilerplate > configuration >=20 > An awful lot of platform configuration is just repeated verbatim for ever= y > platform. This is my first stab at eliminating some of this redundancy. >=20 > I have additional bits as work in progress, but before I sink too much > time into it, I would like to try to gather feedback on this approach (al= l > the way down to directory structure). >=20 > This first round deals with basic network support and Secure Boot > requirements. >=20 > Leif Lindholm (6): > ConfigPkg: add new package for holding common config fragments > ArmVirtPkg: use ConfigPkg for common network items > OvmfPkg: use ConfigPkg for common network items > ConfigPkg: add common Security settings > ArmVirtPkg: use ConfigPkg for common security items > OvmfPkg: use ConfigPkg for common security items >=20 > ArmVirtPkg/ArmVirt.dsc.inc | 25 ++-------- > ArmVirtPkg/ArmVirtQemu.dsc | 46 +++--------------- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 24 ++-------- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 46 +++--------------- > ConfigPkg/Network/Network.dsc.inc | 92 > ++++++++++++++++++++++++++++++++++++ > ConfigPkg/Network/Network.fdf.inc | 47 ++++++++++++++++++ > ConfigPkg/Security/Security.dsc.inc | 67 ++++++++++++++++++++++++++ > ConfigPkg/Security/Security.fdf.inc | 17 +++++++ > OvmfPkg/OvmfPkgIa32.dsc | 92 ++++--------------------------= - > ----- > OvmfPkg/OvmfPkgIa32.fdf | 37 +-------------- > OvmfPkg/OvmfPkgIa32X64.dsc | 90 ++++--------------------------= - > ---- > OvmfPkg/OvmfPkgIa32X64.fdf | 37 +-------------- > OvmfPkg/OvmfPkgX64.dsc | 92 ++++--------------------------= - > ----- > OvmfPkg/OvmfPkgX64.fdf | 37 +-------------- > 14 files changed, 276 insertions(+), 473 deletions(-) create mode 10064= 4 > ConfigPkg/Network/Network.dsc.inc create mode 100644 > ConfigPkg/Network/Network.fdf.inc create mode 100644 > ConfigPkg/Security/Security.dsc.inc > create mode 100644 ConfigPkg/Security/Security.fdf.inc >=20 > -- > 2.11.0 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel