From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.68.109; helo=nam04-bn3-obe.outbound.protection.outlook.com; envelope-from=jerecox@microsoft.com; receiver=edk2-devel@lists.01.org Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680109.outbound.protection.outlook.com [40.107.68.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 248372117D749 for ; Mon, 29 Oct 2018 09:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ajk7h0LxVLkvGjjuqwn3aAd2u8EEF0UdjQU+20efg8=; b=d660S3wdaigliOgxB4ZaDT/d0Qe7wKD9A2560Lzc2DPe5wj9Nnw26xNyP2EYCdvOi7ividBuuQmQYsnCOaKLhpwUi9Sy80isFmPPPrIiu54j5o4tePysENdGChQ7wRF1crofRQJja9LP8eT7uM2NDYlT1tOt0d8JMh+i+02G0oI= Received: from CY4PR21MB0166.namprd21.prod.outlook.com (10.173.192.148) by CY4PR21MB0840.namprd21.prod.outlook.com (10.173.192.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.4; Mon, 29 Oct 2018 16:29:29 +0000 Received: from CY4PR21MB0166.namprd21.prod.outlook.com ([fe80::53:2b59:97d0:922f]) by CY4PR21MB0166.namprd21.prod.outlook.com ([fe80::53:2b59:97d0:922f%9]) with mapi id 15.20.1294.014; Mon, 29 Oct 2018 16:29:29 +0000 From: Jeremiah Cox To: "Bi, Dandan" , "Wang, Jian J" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [PATCH] MdeModulePkg/Core: correct one coding style Thread-Index: AQHUbZsTbuCe2r60OEi5rMYRZFWgu6U2bZkw Date: Mon, 29 Oct 2018 16:29:29 +0000 Message-ID: References: <20181027021324.18528-1-jian.j.wang@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB3BBFA54B@shsmsx102.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3BBFA54B@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [50.35.76.74] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR21MB0840; 6:HFgNA3UinoSDuM9cLiCgYfH6zp6Q82oy6dDywvn0whBcq6KLCN5Ztvxm09TWugdYk5qnJA8yHLc/7kdrQusw5vOGM7rp9cuHopDKf9FPSU8bcSwudceo8wcK9yv8t+QTUZczfszkw7nSdeuV/h10CZV4/qGPYY7t4GwHjFxc7ZBYRguEDcnMwbWnqa3MncOVm+xvcVnpFywC5nu15CiZJJbo2JGDRFDNE1e3TK4fsf5YoCDhz4eia0PoSrR4msIQLJUqOwsAw15XUv/7Nfexit2MF3acUs4rFwb0uVwwA66rI8Ic4yiYt/AzcMhUQGG/ozbRh+D96gO2zWtZ6m4yVKFPZ8uG0B5P3zqMHmnX0ve0JPkXwYpen6E5tej9uXE746q1wh89Vb5cw/VAjGtO4i2FbxiTeaT5WPgUB7q7VfV+btLjm5SgeBrG99TfdBVU+3tG8udWaDJqIR9WxroxZQ==; 5:/LmSMDluIvA3IbBRuvwgl/br3dcB+dJ3BcRQEZ5OmuqofmM+WdLAtbdqEdStw6wNHNP+qC4rpBrXAiQ11+G/EyZ03eHKT5DfRiXOZXlnrLz4ua0CgIVz5A6s8AAfGoUSlTsqqsO9RIwlErtCZrfEJRenMcXQxtQrbLMZouN4Tc8=; 7:QVjVagFc8fiqHqQ/eT/3Y9OIfeBN5tKelcw3PeOfI0bI3/neRIleWsjw/c3l6lQcwFsOiYzCD30qAW51qUDFIudYqy9J6GprO4o3dFQvU4EODiQ0660zueHW3kfaikti40HbWwiHFFVkgH7Bz9mVzA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: e9bef8fe-4f60-4cb1-d881-08d63dbbb32f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:CY4PR21MB0840; x-ms-traffictypediagnostic: CY4PR21MB0840: authentication-results: spf=none (sender IP is ) smtp.mailfrom=jerecox@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266)(219752817060721)(189930954265078)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(8220027)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(2018427008)(93006095)(93001095)(3002001)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:CY4PR21MB0840; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0840; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(39860400002)(376002)(346002)(366004)(396003)(13464003)(199004)(189003)(8936002)(8676002)(81166006)(68736007)(5660300001)(305945005)(7736002)(186003)(10290500003)(8990500004)(229853002)(316002)(6246003)(478600001)(10090500001)(99286004)(81156014)(53546011)(102836004)(66066001)(6436002)(14454004)(4326008)(86612001)(7696005)(86362001)(966005)(6506007)(76176011)(575784001)(6306002)(256004)(33656002)(2501003)(97736004)(55016002)(110136005)(53936002)(14444005)(9686003)(2900100001)(6116002)(3846002)(71200400001)(486006)(26005)(446003)(476003)(71190400001)(11346002)(74316002)(22452003)(106356001)(5250100002)(2906002)(25786009)(105586002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0840; H:CY4PR21MB0166.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: wy6jP4gfm5VQJIUQDZS9vzc/yPG+mdLfUoaaia//NEN7Exf5zVOyFd1Brpe6/07Q9MGcRwHqkh22yHHAGj5acrklGrZkYhP55gKmHucvIBCm2qO67hevyqgRyu2szs9YL2Yg9awGxZw6mlHDs91f6ML544+30sWLcEKrNgqEoe/h7/38yVFG5XaCf0qyKqR+RUg1fa9cJEeHbNMKJCDB+1OXpQkxKo4maqDEpwo73VfBuAIQWdv6CSDN/4s5p2BE7A0tYkWQFf3/Wvc3jMV8+6M2XmdUdEokdo76ashE594gq3I/Yh6SA6PmP5xt45Zt/BBTFO45TSK7kCxVfHLrAq8i4gd1+mIIFxGRsFUj81A= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9bef8fe-4f60-4cb1-d881-08d63dbbb32f X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 16:29:29.2778 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0840 Subject: Re: [PATCH] MdeModulePkg/Core: correct one coding style X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 16:29:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please ignore, testing DMARC issue -----Original Message----- From: edk2-devel On Behalf Of Bi, Dandan Sent: Friday, October 26, 2018 7:16 PM To: Wang, Jian J ; edk2-devel@lists.01.org Cc: Zeng, Star Subject: Re: [edk2] [PATCH] MdeModulePkg/Core: correct one coding style Reviewed-by: Bi Dandan Thanks, Dandan > -----Original Message----- > From: Wang, Jian J > Sent: Saturday, October 27, 2018 10:13 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Zeng, Star > Subject: [PATCH] MdeModulePkg/Core: correct one coding style >=20 > REF:=20 > https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzi > lla.tianocore.org%2Fshow_bug.cgi%3Fid%3D1284&data=3D02%7C01%7Cjereco > x%40microsoft.com%7Cf845cc7305144d6fa26108d63bb232cd%7C72f988bf86f141a > f91ab2d7cd011db47%7C1%7C0%7C636762033910771752&sdata=3DDsl5pUhg5plef > EERnF4LnU87wwY9XBkzz%2FIw8mlP%2FdU%3D&reserved=3D0 >=20 > Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, <= =20 > >=3D, <=3D) >=20 > Cc: Dandan Bi > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > --- > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > index 521e0d7b2a..9f89df8d8f 100644 > --- a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > +++ b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > @@ -1559,7 +1559,7 @@ PromoteGuardedFreePages ( > } > } >=20 > - if (AvailablePages) { > + if (AvailablePages !=3D 0) { > DEBUG ((DEBUG_INFO, "Promoted pages: %lX (%lx)\r\n", Start,=20 > (UINT64)AvailablePages)); > ClearGuardedMemoryBits (Start, AvailablePages); >=20 > -- > 2.19.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://na01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists.01= .org%2Fmailman%2Flistinfo%2Fedk2-devel&data=3D02%7C01%7Cjerecox%40micro= soft.com%7Cf845cc7305144d6fa26108d63bb232cd%7C72f988bf86f141af91ab2d7cd011d= b47%7C1%7C0%7C636762033910771752&sdata=3Dc3FltaTxgnzeGkEnwF1dDBc4CGyWn1= 9XuUjnHPrgC%2Fs%3D&reserved=3D0