From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [EXTERNAL] [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file
Date: Tue, 11 Feb 2020 22:36:51 +0000 [thread overview]
Message-ID: <CY4PR21MB07430E9DC374B9B8ECF1F0F6EF180@CY4PR21MB0743.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200210202441.10608-2-michael.d.kinney@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
- Bret
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Michael D Kinney via Groups.Io <michael.d.kinney=intel.com@groups.io>
Sent: Monday, February 10, 2020 12:24:40 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2514&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C9e9da4e9e08b40dca06308d7ae67455a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637169630879174350&sdata=ye%2FQPMZgnrj8BE3spu07pO5optLKsh%2F%2Fa8YRZruZZ94%3D&reserved=0
Remove EBC as one of the supported architectures
in the UnitTestFrameworkPkg DSC file. The EBC
compiler does not support cararg macros and the
UnitTestLib class uses this feature.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
index 0ad4482273..53d8f52754 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
@@ -13,7 +13,7 @@ [Defines]
PLATFORM_VERSION = 1.00
DSC_SPECIFICATION = 0x00010005
OUTPUT_DIRECTORY = Build/UnitTestFrameworkPkg
- SUPPORTED_ARCHITECTURES = IA32|X64|EBC|ARM|AARCH64
+ SUPPORTED_ARCHITECTURES = IA32|X64|ARM|AARCH64
BUILD_TARGETS = DEBUG|RELEASE|NOOPT
SKUID_IDENTIFIER = DEFAULT
--
2.21.0.windows.1
[-- Attachment #2: Type: text/html, Size: 4426 bytes --]
next prev parent reply other threads:[~2020-02-11 22:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 20:24 [Patch 0/2] Disable EBC for unit tests Michael D Kinney
2020-02-10 20:24 ` [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file Michael D Kinney
2020-02-11 9:02 ` [edk2-devel] " Laszlo Ersek
2020-02-20 2:41 ` [EXTERNAL] " Bret Barkelew
2020-02-11 22:36 ` Bret Barkelew [this message]
2020-02-10 20:24 ` [Patch 2/2] MdePkg: Disable EBC for unit tests in MdePkg.dsc Michael D Kinney
2020-02-11 22:57 ` [EXTERNAL] [edk2-devel] [Patch 0/2] Disable EBC for unit tests Bret Barkelew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR21MB07430E9DC374B9B8ECF1F0F6EF180@CY4PR21MB0743.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox