From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Jiang, Guomin" <guomin.jiang@intel.com>,
"newexplorerj@gmail.com" <newexplorerj@gmail.com>
Subject: Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData
Date: Mon, 23 Mar 2020 21:54:44 +0000 [thread overview]
Message-ID: <CY4PR21MB07430F6A7BEDD4C45CC86314EFF00@CY4PR21MB0743.namprd21.prod.outlook.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9EED9C1@ORSMSX113.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 3700 bytes --]
Agree.
- Bret
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Michael D Kinney via Groups.Io <michael.d.kinney=intel.com@groups.io>
Sent: Monday, March 23, 2020 11:16:15 AM
To: Gao, Liming <liming.gao@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io>; newexplorerj@gmail.com <newexplorerj@gmail.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData
Guomin,
In the function RfcEncodeTest() above, the following code
is used to make sure an allocated buffer is not NULL.
b64WorkString = (CHAR8 *) AllocatePool(b64StringSize);
UT_ASSERT_NOT_NULL(b64WorkString);
We should use the same style in both functions.
Thanks,
Mike
> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Monday, March 23, 2020 6:34 AM
> To: Jiang, Guomin <guomin.jiang@intel.com>;
> devel@edk2.groups.io; newexplorerj@gmail.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v3]
> MdePkg/UnitTestBaseLib: Add check for pointer BinData
>
> Guomin:
> The change is ok to me. Reviewed-by: Liming Gao
> <liming.gao@intel.com>
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Jiang, Guomin <guomin.jiang@intel.com>
> > Sent: Monday, March 23, 2020 2:12 PM
> > To: devel@edk2.groups.io; newexplorerj@gmail.com
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Gao, Liming <liming.gao@intel.com>
> > Subject: RE: [edk2-devel] [PATCH v3]
> MdePkg/UnitTestBaseLib: Add check for pointer BinData
> >
> > Hi Michael, Liming,
> >
> > Could you help review the patch.
> >
> > Thanks.
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of
> > > GuoMinJ
> > > Sent: Thursday, March 5, 2020 1:58 PM
> > > To: devel@edk2.groups.io
> > > Cc: GuoMinJ <newexplorerj@gmail.com>; Kinney,
> Michael D
> > > <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> > > Subject: [edk2-devel] [PATCH v3]
> MdePkg/UnitTestBaseLib: Add check for
> > > pointer BinData
> > >
> > > REF:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2531&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C238d3abd482e45ac697708d7cf564945%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205841811948950&sdata=4I%2B8toPls61MZnTLofea5pjkiC%2Bqnt3uG6j2HYHhORA%3D&reserved=0
> > >
> > > AllocatePool may fail and BinData may be invalid,
> check it before use.
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> > > ---
> > >
> MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c |
> 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git
> a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> > >
> b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> > > index 6f7c31cab4..933d2b40e0 100644
> > > ---
> a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> > > +++
> b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> > > @@ -252,6 +252,9 @@ RfcDecodeTest(
> > > BinSize = AsciiStrnLenS (binString,
> MAX_TEST_STRING_SIZE);
> > >
> > > BinData = AllocatePool (BinSize);
> > > + if (BinData == NULL) {
> > > + return UNIT_TEST_ERROR_TEST_FAILED; }
> > > Btc->BufferToFree = BinData;
> > >
> > > ReturnSize = BinSize;
> > > --
> > > 2.17.1
> > >
> > >
> > >
[-- Attachment #2: Type: text/html, Size: 6932 bytes --]
prev parent reply other threads:[~2020-03-23 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 5:58 [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData GuoMinJ
2020-03-23 6:11 ` [edk2-devel] " Guomin Jiang
2020-03-23 13:33 ` Liming Gao
2020-03-23 18:16 ` Michael D Kinney
2020-03-23 21:54 ` Bret Barkelew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR21MB07430F6A7BEDD4C45CC86314EFF00@CY4PR21MB0743.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox