From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.77.108]) by mx.groups.io with SMTP id smtpd.web12.1049.1585000485421767429 for ; Mon, 23 Mar 2020 14:54:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=Z+t/W29N; spf=pass (domain: microsoft.com, ip: 40.107.77.108, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuWEjtcIog4k1pvrxWoWOsl71C6wSNKGwJY0JUvs2ZBHLeO64MZnVZi1LpOlmAoew/3iTs8DFbPAdy/N3wbfxDCa4tAoSkqiiSbzb3OC9FJGqqSvNeJL6po/5UlT9OdPuKwP0gE80GLTDTsB3wROOUmv3R5oGi1N7LEh606WCGK7kdprtvfvR+pX8UPU1e2jbSAc9Lpt5UkwdJqTJudN4urgH4SD0vs4NBdB+Y6XveiEPgXetqtMn/mE4ig4vJn9SoB0s+yBnvv33BGEdftOtSvJO9tMxHFPZM6QcxdT/ByN5w+M6cfJFJS9NZrWE/DpeG/I9OFLgIYYaQTVzp4b9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHkYaIi4Wcta6YI5qEmaeGCtlGRauv73QaCAM94gWzc=; b=e4sZOfrLxsS057rf20nDtge9KcL2DqBqQi76Nmm4CFbcBWLaK0NAbVLLh+ewBY/qZ2Yz32eOES7hIljFbtO1p0CwDgrIunIzygEwCkKbVYeeUN7aDgPfpaYcCZMDvev/J/FSp0z1rQpdAgPK0qmWMsR5amEpmchBqkV5LMjvtvst+9zA4PnO0lK9lQdSEEj6EqjvOJYj0x9urjn7TSZcx/UD+I/tR2jkNBQX/LxJxeDMkKyrcdfiuJ11w1LyvWw9P4wYjZDO1fACriAAi5j2Z0AAY14jt1wx7UVcFWDQDhDKpRkruDYO++d3O75Ne6j9ZxJoIFjzL6DIjZDenjX6Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHkYaIi4Wcta6YI5qEmaeGCtlGRauv73QaCAM94gWzc=; b=Z+t/W29Nm6WmvC2mfe38IgtVaa7/ldwY3TIKWRQGWlUvPrDzmiQI/JFOz9cfg1Hk76+MGMi9+CrW5o82BbVEViUKcwKPr0yPzclSIwZ6TtpwQireaRYGwH0bUJ5EILl9Sa8aG30MPYBx3GvLDqmoDLtHONVVXfI7eVsOlMWAeS0= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0504.namprd21.prod.outlook.com (2603:10b6:903:dc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.2; Mon, 23 Mar 2020 21:54:44 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%10]) with mapi id 15.20.2878.000; Mon, 23 Mar 2020 21:54:44 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "Kinney, Michael D" , "Gao, Liming" , "Jiang, Guomin" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData Thread-Topic: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Add check for pointer BinData Thread-Index: AQHWANn8UKMldU4RtEaQjw7HBnbUjKhWLbGAgABO4oCAAD0FOg== Date: Mon, 23 Mar 2020 21:54:44 +0000 Message-ID: References: <06db8303487e47dc9d1cd165447bf8f8@intel.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-03-23T21:54:38.4370943Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 094b6759-c944-4761-c1cb-08d7cf74cbfd x-ms-traffictypediagnostic: CY4PR21MB0504:|CY4PR21MB0504: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0351D213B3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(376002)(396003)(366004)(136003)(39860400002)(346002)(66574012)(7696005)(71200400001)(316002)(2906002)(110136005)(86362001)(9686003)(55016002)(8936002)(81156014)(81166006)(8676002)(76116006)(66476007)(66556008)(64756008)(52536014)(478600001)(966005)(5660300002)(186003)(53546011)(6506007)(66946007)(8990500004)(10290500003)(26005)(66446008)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0504;H:CY4PR21MB0743.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lFA0hM85V/RiltrDahNTEJ2WWEqSjqmEZsqUoft4viVJ7FneHO+Yzx6FGnKgc+ANKX1Sp5hluTsXbOeCeL14BkmWAuJxY/TVyNDPEDEXxyphco2R1EJOqBLtO5V85qo1JWFPysa+C1cfGcTUdTR0mmoIZ08ESspOd6S9k9x3HIHZ/pvvSLKKmV+riCw//X4WbysUUTERPgVLfonFbkH7ZSaSZ2T73tQwE/MUKT4VfhiTk+L2qAGTdyFGcdMvkuKWI/qwIqg7VOSP4uJtE5y4Z/oBtOup52UnKzIGbpTVyTMDrI/oCyQ5oNzJIpUJ6DjVhHVvdhuQ4vRaFC8t7Q3pzD6bnki6J0nzB5EDfERnG67IePpr0zaxSUNzkAQvj9vvUMnP8EZ0sHMHsvFlecSmzBWMaTgNIOmBqyQJwV8rBvka/S9LPw2kK/orW0PgJQqO+JMJi4CeR+nMr0IbCvAKBcGxY8jx743hRZinLt6b+rkSJL67jzfwlSlmckErVuQrOcObygdSITcDHUXLQO6+pg== x-ms-exchange-antispam-messagedata: 5CEXVS62vnYVbX7X316uM33NffFwkJ0iG+ZwhXLbrzamgCGQi/R0Fp1nY4X4ekW0bek5yZIISxiKwzlfvEv4VzOJMdRS4MU6dNaCdEDtRjRFFiirwgaAuoLmU7W78FZIkjMHLs3t3Qi8XGSKUXT5xg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 094b6759-c944-4761-c1cb-08d7cf74cbfd X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2020 21:54:44.0366 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Gl1+5ZGt+CxSQSxKKuwnsgb5XDwmlhFuc8jPFkobpYvQnXtyi9WjwiGVVBzTKouNDOmODtQ4RnIebELNL9r0XQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0504 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB07430F6A7BEDD4C45CC86314EFF00CY4PR21MB0743namp_" --_000_CY4PR21MB07430F6A7BEDD4C45CC86314EFF00CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agree. - Bret ________________________________ From: devel@edk2.groups.io on behalf of Michael D K= inney via Groups.Io Sent: Monday, March 23, 2020 11:16:15 AM To: Gao, Liming ; Jiang, Guomin ; devel@edk2.groups.io ; newexplorerj@gmail.com <= newexplorerj@gmail.com>; Kinney, Michael D Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBaseLib: Ad= d check for pointer BinData Guomin, In the function RfcEncodeTest() above, the following code is used to make sure an allocated buffer is not NULL. b64WorkString =3D (CHAR8 *) AllocatePool(b64StringSize); UT_ASSERT_NOT_NULL(b64WorkString); We should use the same style in both functions. Thanks, Mike > -----Original Message----- > From: Gao, Liming > Sent: Monday, March 23, 2020 6:34 AM > To: Jiang, Guomin ; > devel@edk2.groups.io; newexplorerj@gmail.com > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH v3] > MdePkg/UnitTestBaseLib: Add check for pointer BinData > > Guomin: > The change is ok to me. Reviewed-by: Liming Gao > > > Thanks > Liming > > -----Original Message----- > > From: Jiang, Guomin > > Sent: Monday, March 23, 2020 2:12 PM > > To: devel@edk2.groups.io; newexplorerj@gmail.com > > Cc: Kinney, Michael D ; > Gao, Liming > > Subject: RE: [edk2-devel] [PATCH v3] > MdePkg/UnitTestBaseLib: Add check for pointer BinData > > > > Hi Michael, Liming, > > > > Could you help review the patch. > > > > Thanks. > > > > > -----Original Message----- > > > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of > > > GuoMinJ > > > Sent: Thursday, March 5, 2020 1:58 PM > > > To: devel@edk2.groups.io > > > Cc: GuoMinJ ; Kinney, > Michael D > > > ; Gao, Liming > > > > Subject: [edk2-devel] [PATCH v3] > MdePkg/UnitTestBaseLib: Add check for > > > pointer BinData > > > > > > REF: > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugz= illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D2531&data=3D02%7C01%7Cbret.bar= kelew%40microsoft.com%7C238d3abd482e45ac697708d7cf564945%7C72f988bf86f141af= 91ab2d7cd011db47%7C1%7C0%7C637205841811948950&sdata=3D4I%2B8toPls61MZnT= Lofea5pjkiC%2Bqnt3uG6j2HYHhORA%3D&reserved=3D0 > > > > > > AllocatePool may fail and BinData may be invalid, > check it before use. > > > > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Signed-off-by: GuoMinJ > > > --- > > > > MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | > 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git > a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > > > > b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > > > index 6f7c31cab4..933d2b40e0 100644 > > > --- > a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > > > +++ > b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c > > > @@ -252,6 +252,9 @@ RfcDecodeTest( > > > BinSize =3D AsciiStrnLenS (binString, > MAX_TEST_STRING_SIZE); > > > > > > BinData =3D AllocatePool (BinSize); > > > + if (BinData =3D=3D NULL) { > > > + return UNIT_TEST_ERROR_TEST_FAILED; } > > > Btc->BufferToFree =3D BinData; > > > > > > ReturnSize =3D BinSize; > > > -- > > > 2.17.1 > > > > > > > > > --_000_CY4PR21MB07430F6A7BEDD4C45CC86314EFF00CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Agree.

 

- Bret

 

From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Michael D Kinney via Groups.Io &= lt;michael.d.kinney=3Dintel.com@groups.io>
Sent: Monday, March 23, 2020 11:16:15 AM
To: Gao, Liming <liming.gao@intel.com>; Jiang, Guomin <guo= min.jiang@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io>;= newexplorerj@gmail.com <newexplorerj@gmail.com>; Kinney, Michael D &= lt;michael.d.kinney@intel.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v3] MdePkg/UnitTestBase= Lib: Add check for pointer BinData
 
Guomin,

In the function RfcEncodeTest() above, the following code
is used to make sure an allocated buffer is not NULL.

  b64WorkString =3D (CHAR8 *) AllocatePool(b64StringSize);
  UT_ASSERT_NOT_NULL(b64WorkString);

We should use the same style in both functions.

Thanks,

Mike

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Monday, March 23, 2020 6:34 AM
> To: Jiang, Guomin <guomin.jiang@intel.com>;
> devel@edk2.groups.io; newexplorerj@gmail.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH v3]
> MdePkg/UnitTestBaseLib: Add check for pointer BinData
>
> Guomin:
>   The change is ok to me. Reviewed-by: Liming Gao
> <liming.gao@intel.com>
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Jiang, Guomin <guomin.jiang@intel.com>
> > Sent: Monday, March 23, 2020 2:12 PM
> > To: devel@edk2.groups.io; newexplorerj@gmail.com
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Gao, Liming <liming.gao@intel.com>
> > Subject: RE: [edk2-devel] [PATCH v3]
> MdePkg/UnitTestBaseLib: Add check for pointer BinData
> >
> > Hi Michael, Liming,
> >
> > Could you help review the patch.
> >
> > Thanks.
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io<= /a>] On Behalf Of
> > > GuoMinJ
> > > Sent: Thursday, March 5, 2020 1:58 PM
> > > To: devel@edk2.groups.io
> > > Cc: GuoMinJ <newexplorerj@gmail.com>; Kinney,
> Michael D
> > > <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> > > Subject: [edk2-devel] [PATCH v3]
> MdePkg/UnitTestBaseLib: Add check for
> > > pointer BinData
> > >
> > > REF:
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2531&amp;data=3D02%7C01%7Cbret.b= arkelew%40microsoft.com%7C238d3abd482e45ac697708d7cf564945%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637205841811948950&amp;sdata=3D4I%2B8toPls= 61MZnTLofea5pjkiC%2Bqnt3uG6j2HYHhORA%3D&amp;reserved=3D0
> > >
> > > AllocatePool may fail and BinData may be invalid,
> check it before use.
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> > > ---
> > >
> MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c |
> 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git
> a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> > >
> b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> > > index 6f7c31cab4..933d2b40e0 100644
> > > ---
> a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> > > +++
> b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c
> > > @@ -252,6 +252,9 @@ RfcDecodeTest(
> > >    BinSize =3D AsciiStrnLenS (binString,
> MAX_TEST_STRING_SIZE);
> > >
> > >    BinData =3D AllocatePool (BinSize);
> > > +  if (BinData =3D=3D NULL) {
> > > +    return UNIT_TEST_ERROR_TEST_FAILED;=   }
> > >    Btc->BufferToFree =3D BinData;
> > >
> > >    ReturnSize =3D BinSize;
> > > --
> > > 2.17.1
> > >
> > >
> > >




--_000_CY4PR21MB07430F6A7BEDD4C45CC86314EFF00CY4PR21MB0743namp_--