From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.121]) by mx.groups.io with SMTP id smtpd.web11.16756.1586459593370353895 for ; Thu, 09 Apr 2020 12:13:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=f+OKWZFG; spf=pass (domain: microsoft.com, ip: 40.107.93.121, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ngz54xaH9LfTRPw0x9sYBmo8ZE08Eck51OuQmj9oQwHfllDrp0oMtaRo1+5VLNKDrjygqNcjmuo7wwds+OsLhXKK0NpPvOtk8HHzmeXUkI9hf0benImQesO2IDzuuhVmhvXO0K4WUJrd9C0UQ2Hy8k2gqbU5C4SaDsVAV97XKLBv+64IMfR2a1nEY4ItQfpnywBm5zcpb/vdvj0y6SpH7dWXC0PTWkq/rrrop8YoltUCUaQVvcsDjKOiBH8wMaTntLyfVOGXjpAV1531V0ez3Y5hk2PpkLJLaapFohbB4VvPpJksGjcHt/fT8qxz9nVxr7B2h3Na5FhBL4vVcvDQxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q2ypHmquDUSHUQAMkSg7GlOLEAEmKMS8Uuq2CD6DxgQ=; b=dlcdw/pEyVqOAf2BEyZNOzf+HDKOjoOEGsLcru0bYUGP0bSIBkSgo7d5iua9Gcn5RTj0MO/VbC0ie8cqgiv5W9L1yqZr2Q98pfUfe98mOqTsM8h7xi9t3ngB4U4w4PLLbF2rLbEtDfDt1054oQ7gvdn7o9YEYyDDZexsqmC+H5JtHhy/ZgEUC7UWlHMeWRelvCn+KwRm0YtjRjMNP6tnzOMAVU9Fpb8M7zYdS5MWZyBLcflVo2j2WqyKiv6+b5BgueOIcUjeVuyIIw8anbl/cOwKL/bbxIBR+BSRWb0jFuoLBsKyBLWtmiuGVhKIGAzJtThsWiPl9NwzQ0jTfScuzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q2ypHmquDUSHUQAMkSg7GlOLEAEmKMS8Uuq2CD6DxgQ=; b=f+OKWZFGSnxRz+PCjhg1+gGoR3UCHBiclk+WE7In/cZK1Ru9vgvzafK0PGhIAIjPbQmDzXi2cngA8RBF5+isXOytsJXpa5S8+C8kB97jN78ZG6qViIWKvMVu6ie/UJ2VNfNItpzHa8Z+fa5g/M4Ccy+4WhE/OjG+Bms8mdfr2pg= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0183.namprd21.prod.outlook.com (2603:10b6:903:ba::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.14; Thu, 9 Apr 2020 19:13:06 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%12]) with mapi id 15.20.2921.009; Thu, 9 Apr 2020 19:13:06 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "ard.biesheuvel@arm.com" CC: "jian.j.wang@intel.com" , "hao.a.wu@intel.com" , Ard Biesheuvel Subject: Re: [EXTERNAL] [edk2-devel] [PATCH 1/2] MdeModulePkg/DxeCore/Image: make local functions STATIC Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH 1/2] MdeModulePkg/DxeCore/Image: make local functions STATIC Thread-Index: AQHWDolQ1CQBHqgz4E6pi6rvDmrrkahxKKiN Date: Thu, 9 Apr 2020 19:13:06 +0000 Message-ID: References: <20200409160948.23427-1-ard.biesheuvel@arm.com>,<20200409160948.23427-2-ard.biesheuvel@arm.com> In-Reply-To: <20200409160948.23427-2-ard.biesheuvel@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-09T19:12:51.8147830Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 84fefb0d-9280-4f7b-d30a-08d7dcba08e5 x-ms-traffictypediagnostic: CY4PR21MB0183: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0368E78B5B x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(7696005)(55016002)(9686003)(66446008)(5660300002)(8936002)(316002)(64756008)(66556008)(81156014)(66476007)(54906003)(53546011)(6506007)(110136005)(52536014)(76116006)(66946007)(8676002)(71200400001)(478600001)(86362001)(10290500003)(4326008)(81166007)(8990500004)(966005)(2906002)(33656002)(82950400001)(82960400001)(26005)(186003);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OfU81DpmE1qfthsrRlculbr5nOLkRADwhtNqouDZ0TuZsgmqkV/mPBOgH5gXh8l7YP5kSF5wORqf/F6bKGBD9eemq/rNtkjTBcxXLKj6ubna7rA0i2vH6TAQxszK6wPld2PwLruk7PcurIK5jbGyo4jmcHEHdKDGqRVBG9jzxvTxafeiGMpUhzhsx4F0d2FsTaka8LSzylLEAr9gvRAhDEBGt1NtonNd7OPp3+ybXz0HXWW3aSun2weFxpddMunRgVXzgx9uB48IWbZoHjpUjMK0tWCmBlQe24WuhcIheQugU52x3pc7yaezAmwnOQSXbZ3UYRwZrzmfY4ILPUO61tddtJv4MUAqwZ0PooUyBDeE+QK/rM3su21eVFgnTnRSs2VFm7w4pA3/wExoFWD/XPelR7CRaS+DIa//X4G4s0eAY+BkUQnY916SdZ2VId6jIMO33pGpdEYIdjUt/4+ez3iZZIvmRvEJcsEPXhBmRVrSBXtTa6Kry7m4XyWVSWte2s+76lrSP+aLFUph/Mh7Ew== x-ms-exchange-antispam-messagedata: B41enSfUwjOtVKJZwQ5N/l9Qs9y+bRzOL3wGiPWG8M8lEdYJ9Ek206E5OlUTz3LoXqbuKJLIsMhJ5P5kj5FyaTZzEOEBaUaD42KSe1MgUU3V4F5YekxMYmdQEhWFVlBNrWoflTaSUnh0ltX/oIidMQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84fefb0d-9280-4f7b-d30a-08d7dcba08e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2020 19:13:06.6592 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kAztCNa1WKlW8moWvW9D1evH0y4HuOmsdaQBvnqVUO/N73Y+kne65y1GDc7+borYmh0ODdbKl1gyPYcngYGt8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0183 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB074332228B9074BAD9815486EFC10CY4PR21MB0743namp_" --_000_CY4PR21MB074332228B9074BAD9815486EFC10CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret ________________________________ From: devel@edk2.groups.io on behalf of Ard Biesheu= vel via groups.io Sent: Thursday, April 9, 2020 9:09:47 AM To: devel@edk2.groups.io Cc: jian.j.wang@intel.com ; hao.a.wu@intel.com ; Ard Biesheuvel Subject: [EXTERNAL] [edk2-devel] [PATCH 1/2] MdeModulePkg/DxeCore/Image: m= ake local functions STATIC Use static linkage for functions that are only used locally, to help the compiler optimize away unused code in non-LTO builds. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Core/Dxe/Image/Image.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/I= mage/Image.c index d86da89ee704..aae2c1eaa516 100644 --- a/MdeModulePkg/Core/Dxe/Image/Image.c +++ b/MdeModulePkg/Core/Dxe/Image/Image.c @@ -86,6 +86,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO mMachin= eTypeInfo[] =3D { UINT16 mDxeCoreImageMachineType =3D 0; +#ifndef MDEPKG_NDEBUG /** Return machine type name. @@ -93,6 +94,7 @@ UINT16 mDxeCoreImageMachineType =3D 0; @return machine type name **/ +STATIC CHAR16 * GetMachineTypeName ( UINT16 MachineType @@ -108,6 +110,7 @@ GetMachineTypeName ( return L""; } +#endif /** Notification event handler registered by CoreInitializeImageServices ()= to @@ -286,6 +289,7 @@ CoreInitializeImageServices ( into buffer. **/ +STATIC EFI_STATUS EFIAPI CoreReadImageFile ( @@ -334,6 +338,7 @@ CoreReadImageFile ( @retval EFI_SUCCESS The memory range the image will be loa= ded in is available @retval EFI_NOT_FOUND The memory range the image will be loa= ded in is not available **/ +STATIC EFI_STATUS CheckAndMarkFixLoadingMemoryUsageBitMap ( IN EFI_PHYSICAL_ADDRESS ImageBase, @@ -407,6 +412,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap ( @retval EFI_NOT_FOUND The image has no assigned fixed loadi= ng address. **/ +STATIC EFI_STATUS GetPeCoffImageFixLoadingAssignedAddress( IN OUT PE_COFF_LOADER_IMAGE_CONTEXT *ImageContext @@ -552,6 +558,7 @@ CoreIsImageTypeSupported ( @retval EFI_BUFFER_TOO_SMALL Buffer for image is too small **/ +STATIC EFI_STATUS CoreLoadPeImage ( IN BOOLEAN BootPolicy, @@ -877,6 +884,7 @@ CoreLoadPeImage ( @return Return the image private data associated with ImageHandle. **/ +STATIC LOADED_IMAGE_PRIVATE_DATA * CoreLoadedImageInfo ( IN EFI_HANDLE ImageHandle @@ -909,6 +917,7 @@ CoreLoadedImageInfo ( @param FreePage Free allocated pages **/ +STATIC VOID CoreUnloadAndCloseImage ( IN LOADED_IMAGE_PRIVATE_DATA *Image, @@ -1105,6 +1114,7 @@ CoreUnloadAndCloseImage ( platform policy specifies that the imag= e should not be started. **/ +STATIC EFI_STATUS CoreLoadImageCommon ( IN BOOLEAN BootPolicy, -- 2.17.1 --_000_CY4PR21MB074332228B9074BAD9815486EFC10CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@micros= oft.com>

 

- Bret

 

From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Ard Biesheuvel via groups.io <= ;ard.biesheuvel=3Darm.com@groups.io>
Sent: Thursday, April 9, 2020 9:09:47 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: jian.j.wang@intel.com <jian.j.wang@intel.com>; hao.a.wu@i= ntel.com <hao.a.wu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.= com>
Subject: [EXTERNAL] [edk2-devel] [PATCH 1/2] MdeModulePkg/DxeCore/I= mage: make local functions STATIC
 
Use static linkage for functions that are only us= ed locally, to help
the compiler optimize away unused code in non-LTO builds.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 MdeModulePkg/Core/Dxe/Image/Image.c | 10 +++++&#= 43;++++
 1 file changed, 10 insertions(+)

diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/I= mage/Image.c
index d86da89ee704..aae2c1eaa516 100644
--- a/MdeModulePkg/Core/Dxe/Image/Image.c
+++ b/MdeModulePkg/Core/Dxe/Image/Image.c
@@ -86,6 +86,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED MACHINE_TYPE_INFO = ; mMachineTypeInfo[] =3D {
 
 UINT16 mDxeCoreImageMachineType =3D 0;
 
+#ifndef MDEPKG_NDEBUG
 /**
  Return machine type name.
 
@@ -93,6 +94,7 @@ UINT16 mDxeCoreImageMachineType =3D 0;
 
  @return machine type name
 **/
+STATIC
 CHAR16 *
 GetMachineTypeName (
   UINT16 MachineType
@@ -108,6 +110,7 @@ GetMachineTypeName (
 
   return L"<Unknown>";
 }
+#endif
 
 /**
   Notification event handler registered by CoreInitializeImageS= ervices () to
@@ -286,6 +289,7 @@ CoreInitializeImageServices (
            &n= bsp;            = ;         into buffer.
 
 **/
+STATIC
 EFI_STATUS
 EFIAPI
 CoreReadImageFile (
@@ -334,6 +338,7 @@ CoreReadImageFile (
   @retval EFI_SUCCESS       =        The memory range the image will be loa= ded in is available
   @retval EFI_NOT_FOUND      &nbs= p;     The memory range the image will be loaded in is = not available
 **/
+STATIC
 EFI_STATUS
 CheckAndMarkFixLoadingMemoryUsageBitMap (
   IN  EFI_PHYSICAL_ADDRESS     &n= bsp;    ImageBase,
@@ -407,6 +412,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap (
   @retval EFI_NOT_FOUND      &nbs= p;      The image has no assigned fixed loading ad= dress.
 
 **/
+STATIC
 EFI_STATUS
 GetPeCoffImageFixLoadingAssignedAddress(
   IN OUT PE_COFF_LOADER_IMAGE_CONTEXT  *ImageContext
@@ -552,6 +558,7 @@ CoreIsImageTypeSupported (
   @retval EFI_BUFFER_TOO_SMALL    Buffer for ima= ge is too small
 
 **/
+STATIC
 EFI_STATUS
 CoreLoadPeImage (
   IN BOOLEAN        &nb= sp;            BootP= olicy,
@@ -877,6 +884,7 @@ CoreLoadPeImage (
   @return Return the image private data associated with ImageHa= ndle.
 
 **/
+STATIC
 LOADED_IMAGE_PRIVATE_DATA *
 CoreLoadedImageInfo (
   IN EFI_HANDLE  ImageHandle
@@ -909,6 +917,7 @@ CoreLoadedImageInfo (
   @param  FreePage      &nbs= p;         Free allocated pages
 
 **/
+STATIC
 VOID
 CoreUnloadAndCloseImage (
   IN LOADED_IMAGE_PRIVATE_DATA  *Image,
@@ -1105,6 +1114,7 @@ CoreUnloadAndCloseImage (
            &n= bsp;            = ;          platform policy spe= cifies that the image should not be started.
 
 **/
+STATIC
 EFI_STATUS
 CoreLoadImageCommon (
   IN  BOOLEAN       &nb= sp;            =       BootPolicy,
--
2.17.1




--_000_CY4PR21MB074332228B9074BAD9815486EFC10CY4PR21MB0743namp_--