From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (NAM04-SN1-obe.outbound.protection.outlook.com [40.107.70.93]) by mx.groups.io with SMTP id smtpd.web11.2357.1585268096064119224 for ; Thu, 26 Mar 2020 17:14:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=PfhJ+9oo; spf=pass (domain: microsoft.com, ip: 40.107.70.93, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkuBqOI9bQku+vmYrXwNDz/5NKr3NFy24Vcig99HwBYOvalte9I41F0d+vyRhebd7bIdFurnQ/blXCVVqOSFfkC8g+Vp0PVY7QmSyH112OXQFnsusKvChFe3Qxqp6wQK3ES13uJ2R9hFkfbHzP0MFlXjJ6fko0a3jPyi3Ik7wnULFgmr0bCTwtCRMjly+DyTwuNouXWzXKU2XkNSROD9ihe0zvEC1j9C748KIK8jjQ2Q2Cwhk5xa3MHO92YT35ul6Enb3623h5mtEeN9En2WMrB5vQtEAKsPtpgMxIIeBitO4zAVm979ZRAN3MUgb3ZxTQscmTeJ+kLozqSucM2+Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eaQHLzOtesJwgg6DiJ5195f17gaemhJ9sTv+H7d6eJU=; b=cm+7uYxqh/lnLK40nVa4ZqUSVKNc1Q40ALcVVXnMzfgJ5YsiiaN9HZQ0nRfj6zIykQ7AijWo0FTJvIq74XGb3m4HMRSdEDUVDxuvcawAM9+rWC6+5ZVRbCQ1gfZ3cRvhM4XkLeAWjh+7B16PmNtDQIOfOpKy3iCqkvrAibNNWl0fUZNNEsBMLwXy7mZeqHVkmfgIReugi5PsVDB/J34+hE8DguTcqReOAHJFejPbNv9NQwuzMOc6hswgVjMgLa6+S/xCANReUSWvf2ZyaYbCqVnsuNfGdt1DSuRPXQKArjQ/PXpTCvTXCLaMqMSEYWhIhzouVmKoXvz4mWA+wzAfpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eaQHLzOtesJwgg6DiJ5195f17gaemhJ9sTv+H7d6eJU=; b=PfhJ+9oohuFzul6p21xhwybXMq8bcgm9bQyOhpBRGUFqrUfdObmgxUoj60CRGWsETEMiBzIr7FawjRABdWISAdZNcA7bhmCh9PqDFP9lXn4FZWC0FQCNti9O8Yb+9C36Fcmr3NDcTziQif26nrVpPU7sGRp8Dxybl4TuyurfNXo= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0278.namprd21.prod.outlook.com (2603:10b6:903:bb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.5; Fri, 27 Mar 2020 00:14:54 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%10]) with mapi id 15.20.2878.007; Fri, 27 Mar 2020 00:14:54 +0000 From: "Bret Barkelew" To: "Kinney, Michael D" , "Zhang, Shenglei" , "devel@edk2.groups.io" CC: Sean Brogan , "Gao, Liming" Subject: Re: [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg Thread-Topic: [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg Thread-Index: AQHWAzzJvn04ndxsZEWDc0m6i1IasahbhNLdgAAKMgCAAAPG6w== Date: Fri, 27 Mar 2020 00:14:54 +0000 Message-ID: References: <20200326070418.25824-1-shenglei.zhang@intel.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-03-26T23:24:08.0674481Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e3584645-2963-4b66-122b-08d7d1e3e034 x-ms-traffictypediagnostic: CY4PR21MB0278:|CY4PR21MB0278:|CY4PR21MB0278: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0355F3A3AE x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(376002)(366004)(39860400002)(136003)(346002)(396003)(6506007)(66556008)(33656002)(316002)(66946007)(66476007)(5660300002)(64756008)(91956017)(478600001)(53546011)(186003)(76116006)(8990500004)(2906002)(10290500003)(110136005)(66446008)(9686003)(55016002)(52536014)(8936002)(966005)(81156014)(86362001)(4326008)(7696005)(26005)(81166006)(71200400001)(8676002)(54906003);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o7vADbrHp8varPY5RFmHy8MbFQxgg2s9+h60XvNgMQBYagQptNeTosZG04Oox1Vuu8sSs4VZ6f4Taz9AvN09OpWGKQrnPQsmOr3wh/hj9IeCw7Pj06wACczh+lj8r4tW7Og1GdDD1mx3YHALpdnOVDgW2uCNMJY8yXxOLMNsi3oEqTJDU7mPzp7iiI1DTxGymGdonyDXGl7avhR9kM4ICMg5ssFJb5d8K3Jez2ZkyUd70+ung8UhknBhx/+KvsdHtaKjzGl6HmSoVig0R5z/osxeTUt/ozKlJCaTgQ+PeCkm7E4Ug71248hYhsU5098OnxM/DZnZW2wumNI85e4NOFVpYfzyfhkDXKSp7AYZQbc0wU7WnT6jdr1LMWtT+kLwDm5Z/+ztRHumPFIW47R2IdhSKEHrweVIrAbgSjIGNlNh3FQsaxmO6d9e3q4U95P1I8xGMyV95tuJH0lGGwUcjjaVPESRyfSrWa0rXRKDWUcpcHjOA5f1tt94oiB1gEIuZLS8Aal9ik0+ICZIktQh9w== x-ms-exchange-antispam-messagedata: uKt3jTzdoO7KtFzDDigZypheyoDLIlQKR9P/CMZctzOQxuJ8qkl50wuNk2w6M342+XYcPcdn21tysP6YyiFXViBjRpjW1x9PP5S5TDMhme5IVFBZOhP1T0ymo7eQ1CzlOiMz3LMJ4wUb2bAnM+HY7Q== MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3584645-2963-4b66-122b-08d7d1e3e034 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2020 00:14:54.3875 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dljwBd614uodCCnxYQcq289/PJJmX4zLiCTftQca2iWFLO1ppu++b5um/nD9BoWX0Vz4/GzXH/yndGYd4LN17A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0278 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB074334CA6188CCB55A10E28FEFCC0CY4PR21MB0743namp_" --_000_CY4PR21MB074334CA6188CCB55A10E28FEFCC0CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable So just clarifying, the only thing in scope right now is a simple build-tes= t against these packages. There=92s no desire to run tests within the Ovmf = environment itself? - Bret From: Kinney, Michael D Sent: Thursday, March 26, 2020 5:00 PM To: Bret Barkelew; Zhang, Shenglei; devel@edk2.groups.io; Kinney, Michael D Cc: Sean Brogan; Gao, Liming Subject: RE: [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and = EmulatorPkg Bret, I would like to see issues with these platforms packages caught pre-commit.= If a core package change breaks one of these platforms, the we can potent= ially prevent an issue in many other platforms. Mike From: Bret Barkelew Sent: Thursday, March 26, 2020 4:27 PM To: Zhang, Shenglei ; devel@edk2.groups.io Cc: Sean Brogan ; Kinney, Michael D ; Gao, Liming Subject: RE: [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and = EmulatorPkg Taking a moment to look at this a different way=85 Is it expected at some point that we would want to run OvmfPkg-based integr= ation tests as part of a =93second-pass=94 automatic validation (maybe not = a PR-gate, since those should be as fast as possible, but a nightly CI)? If= so, I think I=92d rather see these platforms covered under that pipeline. If anyone would be interested in pursuing that approach (which would also b= e more portable to other platforms in edk2-platforms, if they should want a= utomated nightlys at some point), I=92d be happy to put a pin in this topic= and throw up a prototype of what that might look like. Thanks! - Bret From: Shenglei Zhang Sent: Thursday, March 26, 2020 12:04 AM To: devel@edk2.groups.io Cc: Sean Brogan; Bret Barkelew; Kinney, Michael D; Liming Gao Subject: [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg and Emul= atorPkg REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2570&data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7C198058e322e7419c15d708d7d153eaff%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637208030668393225&sdata=3DTkqjqO7Fi%2BN7F= PgJ0FlRcD4T59zCu7hfWQRbb%2FO5dKA%3D&reserved=3D0 OvmfPkg and EmulatorPkg are mostly used by the developers, so add them to target list. Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- .azurepipelines/templates/pr-gate-build-job.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipeli= nes/templates/pr-gate-build-job.yml index 61868554d43c..34f03745cc70 100644 --- a/.azurepipelines/templates/pr-gate-build-job.yml +++ b/.azurepipelines/templates/pr-gate-build-job.yml @@ -44,6 +44,12 @@ jobs: TARGET_SECURITY: Build.Pkgs: 'SecurityPkg' Build.Targets: 'DEBUG,RELEASE,NO-TARGET' + TARGET_OVMF: + Build.Pkgs: 'OvmfPkg' + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' + TARGET_EMULATOR: + Build.Pkgs: 'EmulatorPkg' + Build.Targets: 'DEBUG,RELEASE,NO-TARGET' workspace: clean: all -- 2.18.0.windows.1 --_000_CY4PR21MB074334CA6188CCB55A10E28FEFCC0CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

So just clarifying, the only thing in scope right no= w is a simple build-test against these packages. There=92s no desire to run= tests within the Ovmf environment itself?

 

- Bret

 

From: Kinney, Michael D
Sent: Thursday, March 26, 2020 5:00 PM
To: Bret Barkelew= ; Zhang, Shenglei; devel@edk2.gro= ups.io; Kinney, Michael D
Cc: Sean Brogan; Gao, Liming
Subject: RE: [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfP= kg and EmulatorPkg

 

Bret,

 

I would like to see issues with these platforms pack= ages caught pre-commit.  If a core package change breaks one of these = platforms, the we can potentially prevent an issue in many other platforms.=

 

Mike

 

From: Bret Barkelew <Bret.Barkelew@microso= ft.com>
Sent: Thursday, March 26, 2020 4:27 PM
To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.gro= ups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D= <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com&g= t;
Subject: RE: [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfP= kg and EmulatorPkg

 

Taking a moment to look at this a different way=85

 

Is it expected at some point that we would want to r= un OvmfPkg-based integration tests as part of a =93second-pass=94 automatic= validation (maybe not a PR-gate, since those should be as fast as possible= , but a nightly CI)? If so, I think I=92d rather see these platforms covered under that pipeline.

 

If anyone would be interested in pursuing that appro= ach (which would also be more portable to other platforms in edk2-platforms= , if they should want automated nightlys at some point), I=92d be happy to = put a pin in this topic and throw up a prototype of what that might look like.

 

Thanks!

 

- Bret

 

From: Shenglei Zhang
Sent: Thursday, March 26, 2020 12:04 AM
To: devel@edk2.groups.io=
Cc: Sean Brogan; Bret Barkelew; Kinney, Mi= chael D; Liming Gao
Subject: [EXTERNAL] [PATCH] .azurepipelines: Enable CI for OvmfPkg a= nd EmulatorPkg

 

REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2570&amp;data=3D02%7C01%7CBret.Ba= rkelew%40microsoft.com%7C198058e322e7419c15d708d7d153eaff%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637208030668393225&amp;sdata=3DTkqjqO7Fi%2B= N7FPgJ0FlRcD4T59zCu7hfWQRbb%2FO5dKA%3D&amp;reserved=3D0
OvmfPkg and EmulatorPkg are mostly used by the developers, so add
them to target list.

Cc: Sean Brogan <sean.broga= n@microsoft.com>
Cc: Bret Barkelew <Bret.B= arkelew@microsoft.com>
Cc: Michael D Kinney <mich= ael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel= .com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .azurepipelines/templates/pr-gate-build-job.yml | 6 +++&#= 43;++
 1 file changed, 6 insertions(+)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipeli= nes/templates/pr-gate-build-job.yml
index 61868554d43c..34f03745cc70 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -44,6 +44,12 @@ jobs:
       TARGET_SECURITY:
         Build.Pkgs: 'SecurityPkg'<= br>          Build.Targets: 'DEBUG,RELE= ASE,NO-TARGET'
+      TARGET_OVMF:
+        Build.Pkgs: 'OvmfPkg'
+        Build.Targets: 'DEBUG,RELEA= SE,NO-TARGET'
+      TARGET_EMULATOR:
+        Build.Pkgs: 'EmulatorPkg' +        Build.Targets: 'DEBUG,RELEA= SE,NO-TARGET'
 
   workspace:
     clean: all
--
2.18.0.windows.1

 

 

--_000_CY4PR21MB074334CA6188CCB55A10E28FEFCC0CY4PR21MB0743namp_--