From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.114]) by mx.groups.io with SMTP id smtpd.web11.301.1586297564279184824 for ; Tue, 07 Apr 2020 15:12:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=Xwns6/hW; spf=pass (domain: microsoft.com, ip: 40.107.243.114, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h06xELzPzvYuQcdjEga8yCWeFyrTWlxi8hAHXoGpEawQqFwEcqd/ZMCl3AZhx7vdGPQlK1HEcTt1e4DoR1iwmK4w+52/rLUEEaOOC0XzjA4U5noFnVBekpQH6qXrtIHFlYdmYwRP/6DzSaqVr9MqCEvzQXnhSnDcegD+DvJhwSfcf26OUxy5armr9VQEM3fWcILOwXyph8EiWYe97gYivdootZB65fL5hlBj0dqh6pF22MfJ2vMbBW9hcOgO1dAJ+ca4/rm4nepSXpS3093yxRSsHeFVBIy73Dj0Np65grfEaJZoBD75N3EdxAu1+8E/XUzLOJ5PrR8JtYwk63zeOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eZgD5x6qn8YOk6F8ew+HwYPg7LCd2V6GDYbS2pEgem4=; b=IYuZurv0CXEMMp6B8jZjDu8IHqdCfq2l++Ic3bEjN2cLSqadqXhTjYvLWD3/gvYS+FSj2TXAMdqOZDnL4QHWuiML1u6JHEER/9L2JIk1Zxb4E755Ajf0NN6by7Ehmt6Ls9ZVcMVQStgsVN7nOaT4l0MCWEp5zVQe3lcazgVvmENYVxPf1HSNzwVNmNVxhXZFs14D+gNnGELJsrbbt0NCddJcxPukdStpL0IYtmTBESlB0MekGO0H/lNujERIGCec+kfh0yma51jG7ntHc6Exx2nm7nCmYzDPdoQf5X2NqiErH6X+gT8bPhCkpFXmbkQt0i5983UkAq4sahdeoq202g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eZgD5x6qn8YOk6F8ew+HwYPg7LCd2V6GDYbS2pEgem4=; b=Xwns6/hW8tAW8X5MU8QenBu9f8EOPDBcCzo+vGOj6XB8fNiStQZWvEiB7eqU46Dn0H8w93Cf1Aap/PMyu5vgBs3jrXBuiE0sltAltfC/f8cF2R4L0mwropD4++sh1rP9+MZI3czfjX6lgmVUmvxQPbB0MWjfF6SkNbhQLPMmu6k= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB1538.namprd21.prod.outlook.com (2603:10b6:910:8f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.5; Tue, 7 Apr 2020 22:12:42 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%12]) with mapi id 15.20.2921.000; Tue, 7 Apr 2020 22:12:42 +0000 From: "Bret Barkelew" To: Oleksiy Yakovlev , "devel@edk2.groups.io" CC: "bob.c.feng@intel.com" , "liming.gao@intel.com" , "Kinney, Michael D" , Felix Polyudov Subject: Re: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset Thread-Index: AQHWCfdyW0/Xreo110eJ82zQDlMWEqhuOP+QgAAFowCAAAB0bg== Date: Tue, 7 Apr 2020 22:12:42 +0000 Message-ID: References: <20200403202238.34484-1-oleksiyy@ami.com>,<20200403202238.34484-4-oleksiyy@ami.com> ,<6BD875C24FFE2A4E8D6EFC142C67836F03FF6566A8@atlms1.us.megatrends.com> In-Reply-To: <6BD875C24FFE2A4E8D6EFC142C67836F03FF6566A8@atlms1.us.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-07T22:11:39.2661732Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9ebfccec-ab67-44ce-ebc4-08d7db40cb10 x-ms-traffictypediagnostic: CY4PR21MB1538:|CY4PR21MB1538: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 036614DD9C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(346002)(39860400002)(136003)(366004)(396003)(376002)(4326008)(82960400001)(66556008)(66446008)(91956017)(9686003)(82950400001)(8936002)(33656002)(64756008)(66946007)(81156014)(55016002)(66476007)(52536014)(186003)(81166006)(26005)(5660300002)(8676002)(76116006)(6506007)(54906003)(316002)(110136005)(71200400001)(53546011)(966005)(8990500004)(478600001)(10290500003)(7696005)(86362001)(2906002);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5X5dRFVsEzk3T5XD39TWebPLBBKV9A4oFcLU2olvTnLMbH016+csiyU5QKvpza++9V6T4LXGJhg/5teQzhss5cOzRm4M7fYYbMJayNw/vara7CVlDBEOAy7GTSMmdV0ozH4thypnar8eQFbdnYzTwW8cWJ9Qn5AtJwDfxqM7Yj4SdJJhEfk2zqlIR9Bpsai+5Id4yg2icfZ5DnEBwaadQKfg4ClJ+hEywxrQWH0tTLqi5zdu35WfYzVYyWybZEtM9xXduFl4lBzHI0rCAnIusDdIeU42LUbkJs5X++5NY3p4ho1i7e+bsNys5uHQ6Hda4EPlfolO5x2TMlkGue2huzDgeF1l34k5Hg6NiUMYlzRE25UiXHW8nqEHRGcomFOsHi2RuV49CrPWDAOsG6lflJSMrLGDpJ06/gWP9UXCWqlgWZdbUFs5TejJU9C5VNzohFpN0WHL/oFLa5f3e6VOTbnvFO/fHeDPixVrUZy9mBpQKnZPMlnJT2c9NBbQUHMg2WdnASuCVltYEifo0v9tYg== x-ms-exchange-antispam-messagedata: Z22P2lJrLQch/VGYEXd6QmONNHi5ghSXGPkjo8eko+PwQqjvmYmwu8T+CmbuZyTkVCpkoirDnllEieM3Lvh2RjrrM0WqS8XuaGNUO47oL8u8xm3AcjrDVHpooihcwCR4jzCijIWA+WHxLlSH0eF8LQ== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ebfccec-ab67-44ce-ebc4-08d7db40cb10 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2020 22:12:42.6428 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nk/Hvc9BiDpAl+53nnqwHlKH+2/PJhHkTVYR8ghJznV6imfedr0A7yasRnsNzEaxGwwr4qqIrBoEmZ/Hh65NOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB1538 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB0743362EECD78785F5C77211EFC30CY4PR21MB0743namp_" --_000_CY4PR21MB0743362EECD78785F5C77211EFC30CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable The other patch had a typo in the subject. This one has: extern EFI_GUID gEfiHiiUserCredentialFormsetGuid; +extern EFI_GUID gEfiHiiResetStyleFormsetGuid; Based on the name of the #DEFINE, I=92m guessing this should be =93gEfiHii= RestStyleFormsetGuid=94, not =93=85Reset=85=94. - Bret From: Oleksiy Yakovlev Sent: Tuesday, April 7, 2020 3:10 PM To: Bret Barkelew; devel@edk2.groups.i= o Cc: bob.c.feng@intel.com; liming.gao@intel.co= m; Kinney, Michael D; Felix Polyudov Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formse= t Hi Bret. Can you be more specific? I do not see any typos in Subject field. Regards, Oleksiy. From: Bret Barkelew [mailto:Bret.Barkelew@microsoft.com] Sent: Tuesday, April 07, 2020 5:50 PM To: devel@edk2.groups.io; Oleksiy Yakovlev Cc: bob.c.feng@intel.com; liming.gao@intel.com; Kinney, Michael D; Felix P= olyudov; Oleksiy Yakovlev Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formse= t Typo here. - Bret From: Oleksiy Yakovlev via groups.io Sent: Friday, April 3, 2020 1:35 PM To: devel@edk2.groups.io Cc: bob.c.feng@intel.com; liming.gao@intel.co= m; Kinney, Michael D; Felixp@ami.com; oleksiyy@ami.com Subject: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style formset New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. A formset with this class GUID indicates all the questions in the formset support REST style operation and can be exposed to a REST service point. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. An Opcode with this flag indicates this question support REST style operat= ion and can be exposed to a REST service point. (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/HiiPlatformSetupFormset.h | 4 ++++ MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 + 2 files changed, 5 insertions(+) diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h b/MdePkg/Includ= e/Guid/HiiPlatformSetupFormset.h index 540483d..a6ba55b 100644 --- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h +++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h @@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define EFI_HII_USER_CREDENTIAL_FORMSET_GUID \ { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca, 0x30, 0x8= 8, 0xcd } } +#define EFI_HII_REST_STYLE_FORMSET_GUID \ + { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, 0x31, 0x8= b, 0x27 } } + extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid; extern EFI_GUID gEfiHiiDriverHealthFormsetGuid; extern EFI_GUID gEfiHiiUserCredentialFormsetGuid; +extern EFI_GUID gEfiHiiResetStyleFormsetGuid; #endif diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h b/MdePkg= /Include/Uefi/UefiInternalFormRepresentation.h index 4a1346a..40fcdb7 100644 --- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h +++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h @@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER { #define EFI_IFR_FLAG_READ_ONLY 0x01 #define EFI_IFR_FLAG_CALLBACK 0x04 #define EFI_IFR_FLAG_RESET_REQUIRED 0x10 +#define EFI_IFR_FLAG_REST_STYLE 0x20 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40 #define EFI_IFR_FLAG_OPTIONS_ONLY 0x80 -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. P Please consider the environment before printing this email The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . --_000_CY4PR21MB0743362EECD78785F5C77211EFC30CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

The other patch had a typo in the subject.

 

This one has:

 extern EFI_GUID gEfiHiiUserCredentialFormsetGuid;
+extern EFI_GUID gEfiHiiResetStyleFor= msetGuid;
 
Based on the name of the #DEFINE, I=92m guessing this should be =93gEfiHii= RestStyleFormsetGuid=94, not =93=85Reset= =85=94.

 

- Bret

 

From: Oleksiy Yakovlev
Sent: Tuesday, April 7, 2020 3:10 PM
To: Bret Barkelew; devel@edk2.groups.io
Cc: bob.c.feng@intel.com; liming.gao@intel.com; Ki= nney, Michael D; Felix Polyudov
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style= formset

 

Hi Bret.

 

Can you be more speci= fic?

I do not see any typo= s in Subject field.

 

Regards, Oleksiy.

 

From: Bret Barkelew [mailto:Bret.Bark= elew@microsoft.com]
Sent: Tuesday, April 07, 2020 5:50 PM
To: devel@edk2.groups.io; Oleksiy Yakovlev
Cc: bob.c.feng@intel.com; liming.gao@intel.com; Kinney, Michael D; = Felix Polyudov; Oleksiy Yakovlev
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style= formset

 

Typo here.

 

- Bret

 

From: Oleksiy Yakovlev via groups.io
Sent: Friday, April 3, 2020 1:35 PM
To: devel@edk2.groups.io
Cc: bob.c.feng@intel.com; liming.gao@intel.com; Ki= nney, Michael D; Felixp@ami.com; oleksiyy@ami.com
Subject: [EXTERNAL] [edk2-devel] [PATCH 3/7] MdePkg: REST style for= mset

 

New ClassGuid EFI_HI= I_REST_STYLE_FORMSET_GUID is defined. A formset with
this class GUID indicates all the questions in the formset support REST style operation and can be exposed to a REST service point. 
In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined.
An Opcode with this flag indicates this question support REST style operat= ion
and can be exposed to a REST service point.
(UEFI 2.8 mantis 1853)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Guid/HiiPlatformSetupFormset.h    = ;    | 4 ++++
 MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h b/MdePkg/Includ= e/Guid/HiiPlatformSetupFormset.h
index 540483d..a6ba55b 100644
--- a/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
+++ b/MdePkg/Include/Guid/HiiPlatformSetupFormset.h
@@ -22,8 +22,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define EFI_HII_USER_CREDENTIAL_FORMSET_GUID \
   { 0x337f4407, 0x5aee, 0x4b83, { 0xb2, 0xa7, 0x4e, 0xad, 0xca,= 0x30, 0x88, 0xcd } }
 
+#define EFI_HII_REST_STYLE_FORMSET_GUID \
+  { 0x790217bd, 0xbecf, 0x485b, { 0x91, 0x70, 0x5f, 0xf7, 0x11, = 0x31, 0x8b, 0x27 } }
+ 
 extern EFI_GUID gEfiHiiPlatformSetupFormsetGuid;
 extern EFI_GUID gEfiHiiDriverHealthFormsetGuid;
 extern EFI_GUID gEfiHiiUserCredentialFormsetGuid;
+extern EFI_GUID gEfiHiiResetStyleFor= msetGuid;
 
 #endif
diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h b/MdePkg= /Include/Uefi/UefiInternalFormRepresentation.h
index 4a1346a..40fcdb7 100644
--- a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
+++ b/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h
@@ -825,6 +825,7 @@ typedef struct _EFI_IFR_QUESTION_HEADER {
 #define EFI_IFR_FLAG_READ_ONLY      &n= bsp;   0x01
 #define EFI_IFR_FLAG_CALLBACK      &nb= sp;    0x04
 #define EFI_IFR_FLAG_RESET_REQUIRED     0x10
+#define EFI_IFR_FLAG_REST_STYLE      &n= bsp;  0x20
 #define EFI_IFR_FLAG_RECONNECT_REQUIRED 0x40
 #define EFI_IFR_FLAG_OPTIONS_ONLY      = ; 0x80
 
--
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI).  This communication is intended to b= e read only by the individual or entity to whom it is addressed or by their= designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of= this message, in any form, is strictly prohibited.  Please promptly n= otify the sender by reply e-mail or by telephone at 770-246-8600, and then = delete or destroy all copies of the transmission.

 

P Please = consider the environment before printing this email

The information contained in this message may be confidential and propr= ietary to American Megatrends (AMI). This communication is intended to be r= ead only by the individual or entity to whom it is addressed or by their de= signee. If the reader of this message is not the intended recipient, you are on notice that any distribution of= this message, in any form, is strictly prohibited. Please promptly notify = the sender by reply e-mail or by telephone at 770-246-8600, and then delete= or destroy all copies of the transmission.

 

--_000_CY4PR21MB0743362EECD78785F5C77211EFC30CY4PR21MB0743namp_--