From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.125]) by mx.groups.io with SMTP id smtpd.web12.746.1586562813770274321 for ; Fri, 10 Apr 2020 16:53:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=NTf8w4Wl; spf=pass (domain: microsoft.com, ip: 40.107.220.125, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxVtWrzAd7x9rvF3JiBOY8lVGB4Cz+XuPzZPyrOWnFmf984WOroB7YbIZgUxQbMHgpsbkk0brBwtCbgqFAtuG7PtgyzWqHOWrIy5ZWFAFnK9dXNaLM6LM11uMVltnPqz0TSUBgnQX1G6S96A36g9MDwB/cx2i1qPb0dxRYdG2I617nK3rroVIKgu3Dj5QPzNFMwSBZx/SY/1mrVdeSa1UDKDfVQO92/NkDRZYc+VHR/k4KUInF5M0kAJ4TVgHcT7HJ9MhTHsE9AFSsFMEpvzdEZJULlvqyia3bSEzfmyG0wxBAN2rwmOM5EkT7WSmCdfdC3RFIpfiN/K2uoHqDXWKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcuIQTmDBvTGCIboyZB+geFyPnDNqX2qHsKN/fS/x3o=; b=BjlOOgg2Tz0zHVeqGRgWFR/a/fEk3/72oPcPkWpNE6P2+fN7x2uMe9kcyrlQtrZQ4x9NhCVmi8ruxKWsAUB6OqQImAlC0pXRsJz6Vig82qUZib/jZNY5Akp0baYsLAL1PVKa9XvpZNmKD3dBElhUpIw4Lv8Ba0fGy5x95cbbCbg+CQU4ci9kLnyjDc5F5dPvXO/+eWl2y8grrc6d/nKfEsjmbcJSBYqGqBhR32lghxns+GFFWAAsJ64Ni+q9ljHQf+sTxV0BiwfoHnzPNEYcBaN8wbwyqSM5ijJY6A7uixmoi228JFgMBBeQ2CYSfhfi6WW1qBWLFGW4+AM/QPQluA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NcuIQTmDBvTGCIboyZB+geFyPnDNqX2qHsKN/fS/x3o=; b=NTf8w4Wlon9PKXe/IEAgU/ht+EmkfAYRQ4ywtSljV+8nP6e9ocs4d0pFeeH+RzxG/bu7EYK7fJay5mR3RKuNMFZyIcPHugYbygO8q6SAy+Er73q63LfLgU3/OaobPPZsgOfMNI95qi58dcaSVVEmfujVXi4XW1U9VtJLv9Ku/3I= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0165.namprd21.prod.outlook.com (2603:10b6:903:b9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.6; Fri, 10 Apr 2020 23:53:31 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%12]) with mapi id 15.20.2921.009; Fri, 10 Apr 2020 23:53:31 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "liming.gao@intel.com" , "Kinney, Michael D" , "Felixp@ami.com" , "oleksiyy@ami.com" Subject: Re: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER Notification types Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER Notification types Thread-Index: AQHWD3J/g6NaAunufkyzj91Ot72UXahzB2Fd Date: Fri, 10 Apr 2020 23:53:31 +0000 Message-ID: References: <20200410195803.19972-1-oleksiyy@ami.com>,<20200410195803.19972-2-oleksiyy@ami.com> In-Reply-To: <20200410195803.19972-2-oleksiyy@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-10T23:52:47.8234490Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0d93d866-166e-48d8-d483-08d7ddaa5fb8 x-ms-traffictypediagnostic: CY4PR21MB0165:|CY4PR21MB0165: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2150; x-forefront-prvs: 0369E8196C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(6506007)(15650500001)(71200400001)(55016002)(82950400001)(26005)(66446008)(10290500003)(966005)(82960400001)(186003)(316002)(9686003)(7696005)(4326008)(81156014)(86362001)(478600001)(66556008)(8936002)(8990500004)(66946007)(110136005)(53546011)(54906003)(8676002)(33656002)(5660300002)(2906002)(64756008)(66476007)(76116006)(52536014)(91956017);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C3IoPS+0PRE4G12xFQ57z8mYmRZunfZVKYLBwBnDrHPFxhIp8B/777BYw0E/3sTKev9RSMC1/x6t6GnKr8bgByyhKsbTeIDhwOl+o02eNh17D29Oxaf5fZw7ZCLePtqKanQ5gHuYKqwL8vFZ+pTduuOCpNQQgVJ3JHETx2AiWHjIG7BodxSQDwyHnsJOqHQicsIJ80b9MdBBq2dhntRaUiIJfBhfU+nCpopeSQ7wgUG9O8z1ghKHVk9WhQ3OwJqSREuaYdpQ2rmTR9QuRl3eYyES//0iRBtA9N0AVkBBZ7JwkGNrVYRFBckfV9Z00IOysfQO5iZI4TVtrlC60wTuHKN1wIX4aBL60rsIaTS+1HmX8sY/EpCUlvqOTIbHX+3i3AiQvEP5KlbVzJmj4+i4bjJNPt1tZWPuNvk/5Ti93q+036MvsmDyWItnXXcwrjATaHqPpz4wMkOMbHClZF6+aNGwkPhjTwum1cM9XtztQxuyiuvRnALTW08CdMqhXPouvEVUWZrGPegOwVhAFH+m1w== x-ms-exchange-antispam-messagedata: 8DbtOvAUD1C20vJKLkfO0Rc6x+7fDmD9mpDC/FCpIkYWe1knVmndk1ah8dFWaZm2iAV+8ioVizibdBT8eUVfG+x+u8CuYmfiAgbQbQsHIQCqqN29LHQOHUA574hEdj5yWjMNTngBS7GJa3I1ZAtuwg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d93d866-166e-48d8-d483-08d7ddaa5fb8 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2020 23:53:31.5222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pd5YK5I5PEfudFYZPR711SWYJsrBl+ud+vhPj1f6VH+2y8jHKyta7yEaWKOSJWjlOIhzEgZ3X0CYFkRiKjI2Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0165 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB07433E7E07242D47A4B92684EFDE0CY4PR21MB0743namp_" --_000_CY4PR21MB07433E7E07242D47A4B92684EFDE0CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEA \ Multiple typos in these lines. > + ## Include/Guid/Cper.h Are all of these actually in the Cper.h file? - Bret From: Oleksiy Yakovlev via groups.io Sent: Friday, April 10, 2020 12:59 PM To: devel@edk2.groups.io Cc: liming.gao@intel.com; Kinney, Michael D; Felixp@ami.com; o= leksiyy@ami.com Subject: [EXTERNAL] [edk2-devel] [PATCH 1/4] MdePkg: Add new CPER Notifica= tion types Add SEA, SEI, and PEI CPER Notification types defined in UEFI 2.8 errata a= . (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/Cper.h | 15 +++++++++++++++ MdePkg/MdePkg.dec | 9 +++++++++ 2 files changed, 24 insertions(+) diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h index 0cacd30..b401c14 100644 --- a/MdePkg/Include/Guid/Cper.h +++ b/MdePkg/Include/Guid/Cper.h @@ -95,6 +95,18 @@ typedef struct { { \ 0x667DD791, 0xC6B3, 0x4c27, { 0x8A, 0x6B, 0x0F, 0x8E, 0x72, 0x2D, 0xE= B, 0x41 } \ } +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEA \ + { \ + 0x9A78788A, 0xBBE8, 0x11E4, { 0x80, 0x9E, 0x67, 0x61, 0x1E, 0x5D, 0x4= 6, 0xB0 } \ + } +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEI \ + { \ + 0x5C284C81, 0xB0AE, 0x4E87, { 0xA3, 0x22, 0xB0, 0x4C, 0x85, 0x62, 0x4= 3, 0x23 } \ + } +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_PEI \ + { \ + 0x09A9D5AC, 0x5204, 0x4214, { 0x96, 0xE5, 0x94, 0x99, 0x2E, 0x75, 0x2= B, 0xCD } \ + } ///@} /// @@ -1207,6 +1219,9 @@ extern EFI_GUID gEfiEventNotificationTypeInitGuid; extern EFI_GUID gEfiEventNotificationTypeNmiGuid; extern EFI_GUID gEfiEventNotificationTypeBootGuid; extern EFI_GUID gEfiEventNotificationTypeDmarGuid; +extern EFI_GUID gEfiEventNotificationTypeSeaGuid; +extern EFI_GUID gEfiEventNotificationTypeSeiGuid; +extern EFI_GUID gEfiEventNotificationTypePeiGuid; extern EFI_GUID gEfiProcessorGenericErrorSectionGuid; extern EFI_GUID gEfiProcessorSpecificErrorSectionGuid; diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index ac1f533..99e75f7 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -434,6 +434,15 @@ gEfiEventNotificationTypeDmarGuid =3D { 0x667DD791, 0xC6B3, 0x4c27, { = 0x8A, 0x6B, 0x0F, 0x8E, 0x72, 0x2D, 0xEB, 0x41 }} ## Include/Guid/Cper.h + gEfiEventNotificationTypeSeaGuid =3D { 0x9A78788A, 0xBBE8, 0x11E4, { = 0x80, 0x9E, 0x67, 0x61, 0x1E, 0x5D, 0x46, 0xB0 }} + + ## Include/Guid/Cper.h + gEfiEventNotificationTypeSeiGuid =3D { 0x5C284C81, 0xB0AE, 0x4E87, { = 0xA3, 0x22, 0xB0, 0x4C, 0x85, 0x62, 0x43, 0x23 }} + + ## Include/Guid/Cper.h + gEfiEventNotificationTypePeiGuid =3D { 0x09A9D5AC, 0x5204, 0x4214, { = 0x96, 0xE5, 0x94, 0x99, 0x2E, 0x75, 0x2B, 0xCD }} + + ## Include/Guid/Cper.h gEfiProcessorGenericErrorSectionGuid =3D { 0x9876ccad, 0x47b4, 0x4bdb,= { 0xb6, 0x5e, 0x16, 0xf1, 0x93, 0xc4, 0xf3, 0xdb }} ## Include/Guid/Cper.h -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. --_000_CY4PR21MB07433E7E07242D47A4B92684EFDE0CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

> +#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_= SEA \

Multiple typos in these lines.

 

> +  ## Include/Guid/Cper.h
Are all of these actually in the Cper.h file?

 

- Bret

 

 

Add SEA, SEI, and PE= I CPER Notification types defined in UEFI 2.8 errata a.
(UEFI 2.8 errata a, mantis 2026)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Guid/Cper.h | 15 +++++++&= #43;+++++++
 MdePkg/MdePkg.dec        &nb= sp; |  9 +++++++++
 2 files changed, 24 insertions(+)

diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h
index 0cacd30..b401c14 100644
--- a/MdePkg/Include/Guid/Cper.h
+++ b/MdePkg/Include/Guid/Cper.h
@@ -95,6 +95,18 @@ typedef struct {
   { \
     0x667DD791, 0xC6B3, 0x4c27, { 0x8A, 0x6B, 0x0F, 0= x8E, 0x72, 0x2D, 0xEB, 0x41 } \
   }
+#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEA \
+  { \
+    0x9A78788A, 0xBBE8, 0x11E4, { 0x80, 0x9E, 0x67, 0x= 61, 0x1E, 0x5D, 0x46, 0xB0 } \
+  }
+#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_SEI \
+  { \
+    0x5C284C81, 0xB0AE, 0x4E87, { 0xA3, 0x22, 0xB0, 0x= 4C, 0x85, 0x62, 0x43, 0x23 } \
+  }
+#define EFI_EVENT_NOTIFICATION_TYEP_DMAR_PEI \
+  { \
+    0x09A9D5AC, 0x5204, 0x4214, { 0x96, 0xE5, 0x94, 0x= 99, 0x2E, 0x75, 0x2B, 0xCD } \
+  }
 ///@}
 
 ///
@@ -1207,6 +1219,9 @@ extern EFI_GUID gEfiEventNotificationTypeInitGui= d;
 extern EFI_GUID gEfiEventNotificationTypeNmiGuid;
 extern EFI_GUID gEfiEventNotificationTypeBootGuid;
 extern EFI_GUID gEfiEventNotificationTypeDmarGuid;
+extern EFI_GUID gEfiEventNotificationTypeSeaGuid;
+extern EFI_GUID gEfiEventNotificationTypeSeiGuid;
+extern EFI_GUID gEfiEventNotificationTypePeiGuid;
 
 extern EFI_GUID gEfiProcessorGenericErrorSectionGuid;
 extern EFI_GUID gEfiProcessorSpecificErrorSectionGuid;
diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index ac1f533..99e75f7 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -434,6 +434,15 @@
   gEfiEventNotificationTypeDmarGuid  =3D { 0x667DD791, 0xC= 6B3, 0x4c27, { 0x8A, 0x6B, 0x0F, 0x8E, 0x72, 0x2D, 0xEB, 0x41 }}
 
   ## Include/Guid/Cper.h
+  gEfiEventNotificationTypeSeaGuid   =3D { 0x9A78788A,= 0xBBE8, 0x11E4, { 0x80, 0x9E, 0x67, 0x61, 0x1E, 0x5D, 0x46, 0xB0 }}
+ 
+  ## Include/Guid/Cper.h
+  gEfiEventNotificationTypeSeiGuid   =3D { 0x5C284C81,= 0xB0AE, 0x4E87, { 0xA3, 0x22, 0xB0, 0x4C, 0x85, 0x62, 0x43, 0x23 }}
+ 
+  ## Include/Guid/Cper.h
+  gEfiEventNotificationTypePeiGuid   =3D { 0x09A9D5AC,= 0x5204, 0x4214, { 0x96, 0xE5, 0x94, 0x99, 0x2E, 0x75, 0x2B, 0xCD }}
+
+  ## Include/Guid/Cper.h
   gEfiProcessorGenericErrorSectionGuid  =3D { 0x9876ccad, = 0x47b4, 0x4bdb, { 0xb6, 0x5e, 0x16, 0xf1, 0x93, 0xc4, 0xf3, 0xdb }}
 
   ## Include/Guid/Cper.h
--
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI).  This communication is intended to b= e read only by the individual or entity to whom it is addressed or by their= designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of= this message, in any form, is strictly prohibited.  Please promptly n= otify the sender by reply e-mail or by telephone at 770-246-8600, and then = delete or destroy all copies of the transmission.

 

--_000_CY4PR21MB07433E7E07242D47A4B92684EFDE0CY4PR21MB0743namp_--