From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.128]) by mx.groups.io with SMTP id smtpd.web09.294.1582166456976624603 for ; Wed, 19 Feb 2020 18:40:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=YpuIS225; spf=pass (domain: microsoft.com, ip: 40.107.220.128, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6qb6VywXNwhezkdFON81EwyA+d3cDiIBKM6UHseObxsc+9lUxOfgBD3qDBKrjtH+z+M/CNlmBbma/VpGRVpAcUi9o0M26L78Jm8AsRbvTga1JfqQ3ihD7yShIVk5Yavdg1OAApBHlF3ZX9uNY0GdoA4ObVZMcOgRbvJilgQ0CRO3cHEiSxWpnRzl5jSvmplAP3IIVFrN+FDxv2qgt+liCiVSAMMb1xOF1AsV8dS4VIlN8AXbqA2rPc/fop7Kook1rHltqdA0Zubk9o4vA3vFnqpGzCU9PdLK1sSXpwcbP8ZcbutuKc6Q4JjsPKocDP7WJU3k2sc/OhO/En2ZO3VxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ZXGxrycst1YmvCGz4clyBUQI/sVHACcGVvDWzB9d1Y=; b=Hhribn+UjpiepZbAZ6CUPcxwhyP1+7b7xN2WDZULo0eTPZaEoGwMTOjVdmTFCslJ30f82+821oeuMlaGephww/Jczk/we+RVwXTZ8Gc6lmfvZcYkS+Xs5P6KUZo/kQPPFo81fa+TAZE/SKKoyao9TdYShHPNo7XMpA7nLUH9HhjZzDM7cAFnakAw6H/wedP1D1iHcdnZiiH/CzVWkFON/xSI880HUxxXYigQ9xv6Px/896xExVoufjgdg9hBLm8fLDK0GTs89WgbGZXEt8oog0nqUTxN1yq/IYRTTNLmiAa3zlW98hMY/iMR8RjP/rMBuorDFVg321uGQDNtcJSnow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ZXGxrycst1YmvCGz4clyBUQI/sVHACcGVvDWzB9d1Y=; b=YpuIS225JiTp3dEPenDGWsCB5/GrAJP7oJHVAuMA3hWLHZxEJko1KdBnAKsl6sQ3ReYPaL0ELwMgNnx70AwjQIfaxOupo0Li8rrBJitPNwwYX5chJneK+ROCQLKzUzOJ5xWyKWaBii8NGDHtfdlWUMPK1z5dt3IjVQU3UJ9lOnI= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0152.namprd21.prod.outlook.com (2603:10b6:903:b2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.3; Thu, 20 Feb 2020 02:40:55 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9118:22ef:23c:d0ab]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9118:22ef:23c:d0ab%9]) with mapi id 15.20.2772.006; Thu, 20 Feb 2020 02:40:55 +0000 From: "Bret Barkelew" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sean Brogan Subject: Re: [EXTERNAL] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues Thread-Topic: [EXTERNAL] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues Thread-Index: AQHV4EIB8y+DhG4szkWIMFC1/7wtW6gjbbte Date: Thu, 20 Feb 2020 02:40:55 +0000 Message-ID: References: <20200210184332.30716-1-michael.d.kinney@intel.com> In-Reply-To: <20200210184332.30716-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-02-20T02:40:33.4848201Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [174.21.64.62] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2b16511c-5789-476c-1986-08d7b5ae4f7b x-ms-traffictypediagnostic: CY4PR21MB0152:|CY4PR21MB0152:|CY4PR21MB0152: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:45; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(346002)(39860400002)(136003)(376002)(396003)(366004)(199004)(189003)(5660300002)(8676002)(316002)(81166006)(8990500004)(4326008)(110136005)(9686003)(55016002)(71200400001)(107886003)(81156014)(33656002)(8936002)(86362001)(26005)(52536014)(53546011)(6506007)(186003)(478600001)(7696005)(2906002)(76116006)(66946007)(66556008)(64756008)(66446008)(66476007)(10290500003)(966005);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0152;H:CY4PR21MB0743.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jdr7o1tmZzXqL47T66/I1MvFEVPpDzyTlzIDuneZTIc45QRIN65psfTbInGiwGuq5HOcA501HOttqDUDgzMGr+9saeQWKvO3NEL3qsmtSGIRuY1GnQ+IUDbtiItDUKAUd/qPcfZqQkkvPqaH9f4CPpGQ3l1qjDaKOS7bJpy4iw1oYnCWkd4PUpMPOwYSDOavsFAFsQiTJbb1oALxehrZ7DU1XToxwk6+jgrfDPqXUmnsn3K0AxBDOijNFDwLdZ1WN+k0fagPYfrb2/259kmtBIIRG9rbMQ4d04bNCdCQQApDkNp7xJD8vYm/DGua0l3MOhiuG1d1ZFx2AhRht54MVm68Q4v9R0hbMZxe+GjuTk9xAEUOIUtyYqw07GcBfqlLHYJzfKzB9pgsDv3sbxHyb9qRTPRLNfQCdRaomRjtkvL+nu9slsWmNTIoRgv6kWdcyTmqi/SqrTc9owh6T3a4IfHEYY4GwtfydwFtj+fIgjt2sw3lDnooKinWcqix2cXl5nLSPcRdGKIH25M3cdqm+g== x-ms-exchange-antispam-messagedata: 4Ioj86FafDxNTEQHikEMDSWqNLA/0K6OxG2+Gn476Dlge/Lv4i+Hu5H9ebXUOkLK/PkK6CFVD1B1QQd3Y+54cp/lZZ5JL3utYzhc71AB4y7ZEfaIYPcCogZBeTaL9smF5ydkcsIQ1/OE5DZi1hsx/A== MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b16511c-5789-476c-1986-08d7b5ae4f7b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 02:40:55.7749 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ck8zsY/lx7g3ExzcIC11mSc8oTISmN95ErkTfIUDCuIkXLmm89Rb6MnI+0eRlZH+9OsZg1gH6cDv1/WBQCjOkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0152 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB07434A9D4C10D5F09EC06951EF130CY4PR21MB0743namp_" --_000_CY4PR21MB07434A9D4C10D5F09EC06951EF130CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret ________________________________ From: Michael D Kinney Sent: Monday, February 10, 2020 10:43:32 AM To: devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew Subject: [EXTERNAL] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE par= enthesis issues https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2512&data=3D02%7C01%7CBret.Barkel= ew%40microsoft.com%7C27b6bd3a84b64d456eec08d7ae5922fa%7C72f988bf86f141af91a= b2d7cd011db47%7C1%7C0%7C637169570173423344&sdata=3D%2BfnZ0QzM%2Fu1zVdS6= 9ZUyxIkngUjdvpZo8I93SKLqeh8%3D&reserved=3D0 Remove extra sets of parenthesis that generate warnings on XCODE5 builds. Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael D Kinney --- UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c | 6 +++--- UnitTestFrameworkPkg/Library/UnitTestLib/Log.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c b/UnitTestFr= ameworkPkg/Library/UnitTestLib/Assert.c index dd85b84b08..c327ba88f1 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c @@ -247,7 +247,7 @@ UnitTestAssertEqual ( IN CONST CHAR8 *DescriptionB ) { - if ((ValueA !=3D ValueB)) { + if (ValueA !=3D ValueB) { UnitTestLogFailure ( FAILURETYPE_ASSERTEQUAL, "%a::%d Value %a !=3D %a (%d !=3D %d)!\n", @@ -365,7 +365,7 @@ UnitTestAssertNotEqual ( IN CONST CHAR8 *DescriptionB ) { - if ((ValueA =3D=3D ValueB)) { + if (ValueA =3D=3D ValueB) { UnitTestLogFailure ( FAILURETYPE_ASSERTNOTEQUAL, "%a::%d Value %a =3D=3D %a (%d =3D=3D %d)!\n", @@ -420,7 +420,7 @@ UnitTestAssertStatusEqual ( IN CONST CHAR8 *Description ) { - if ((Status !=3D Expected)) { + if (Status !=3D Expected) { UnitTestLogFailure ( FAILURETYPE_ASSERTSTATUSEQUAL, "%a::%d Status '%a' is %r, should be %r!\n", diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c b/UnitTestFrame= workPkg/Library/UnitTestLib/Log.c index 78df086a28..ac4e229b40 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c @@ -136,7 +136,7 @@ UnitTestLogInit ( return; } - if((Buffer !=3D NULL) && (BufferSize > 0) && ((BufferSize <=3D UNIT_TEST= _MAX_LOG_BUFFER))) { + if((Buffer !=3D NULL) && (BufferSize > 0) && (BufferSize <=3D UNIT_TEST_= MAX_LOG_BUFFER)) { CopyMem (Test->Log, Buffer, BufferSize); } } -- 2.21.0.windows.1 --_000_CY4PR21MB07434A9D4C10D5F09EC06951EF130CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@microso= ft.com>

 

- Bret

 

From: Michael D Kinney <= michael.d.kinney@intel.com>
Sent: Monday, February 10, 2020 10:43:32 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <= ;Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XC= ODE parenthesis issues
 
https://nam06.safelinks.protection.outlook.com/?url= =3Dhttps%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2512&amp;= data=3D02%7C01%7CBret.Barkelew%40microsoft.com%7C27b6bd3a84b64d456eec08d7ae= 5922fa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637169570173423344&= amp;sdata=3D%2BfnZ0QzM%2Fu1zVdS69ZUyxIkngUjdvpZo8I93SKLqeh8%3D&amp;rese= rved=3D0

Remove extra sets of parenthesis that generate warnings on XCODE5
builds.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c | 6 +++= ---
 UnitTestFrameworkPkg/Library/UnitTestLib/Log.c    | 2 = +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c b/UnitTestFr= ameworkPkg/Library/UnitTestLib/Assert.c
index dd85b84b08..c327ba88f1 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
@@ -247,7 +247,7 @@ UnitTestAssertEqual (
   IN CONST CHAR8  *DescriptionB
   )
 {
-  if ((ValueA !=3D ValueB)) {
+  if (ValueA !=3D ValueB) {
     UnitTestLogFailure (
       FAILURETYPE_ASSERTEQUAL,
       "%a::%d Value %a !=3D %a (%d !=3D= %d)!\n",
@@ -365,7 +365,7 @@ UnitTestAssertNotEqual (
   IN CONST CHAR8  *DescriptionB
   )
 {
-  if ((ValueA =3D=3D ValueB)) {
+  if (ValueA =3D=3D ValueB) {
     UnitTestLogFailure (
       FAILURETYPE_ASSERTNOTEQUAL,
       "%a::%d Value %a =3D=3D %a (%d = =3D=3D %d)!\n",
@@ -420,7 +420,7 @@ UnitTestAssertStatusEqual (
   IN CONST CHAR8  *Description
   )
 {
-  if ((Status !=3D Expected)) {
+  if (Status !=3D Expected) {
     UnitTestLogFailure (
       FAILURETYPE_ASSERTSTATUSEQUAL,
       "%a::%d Status '%a' is %r, should= be %r!\n",
diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c b/UnitTestFrame= workPkg/Library/UnitTestLib/Log.c
index 78df086a28..ac4e229b40 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c
@@ -136,7 +136,7 @@ UnitTestLogInit (
     return;
   }
 
-  if((Buffer !=3D NULL) && (BufferSize > 0) && ((B= ufferSize <=3D UNIT_TEST_MAX_LOG_BUFFER))) {
+  if((Buffer !=3D NULL) && (BufferSize > 0) &&= (BufferSize <=3D UNIT_TEST_MAX_LOG_BUFFER)) {
     CopyMem (Test->Log, Buffer, BufferSize);
   }
 }
--
2.21.0.windows.1

--_000_CY4PR21MB07434A9D4C10D5F09EC06951EF130CY4PR21MB0743namp_--