From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.111]) by mx.groups.io with SMTP id smtpd.web10.862.1584992985826971046 for ; Mon, 23 Mar 2020 12:49:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=WfL07Vw9; spf=pass (domain: microsoft.com, ip: 40.107.220.111, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUAFK/dlDDIt2pRGEqrHBPbldAraNBDXRhnC2XAgGXDiDCMZVcnv+c4wVQplMVM9pzm3by+wZZo6En6ZtZkQcPvpa1DYnPOVQOVrY1YR9M5fBfY3To0LnUyIYm2TXHfjSR5tUK3k0kjJRAbLY3YrfRiEXbvhwHxp05x9jj5XKZ2pEYdVrFXwfEGSmmI4F95RK4XTDHGR0aWL6ro1q57egb9GQOf2BiLql8KPV8T7pxubZ1l4w8GLYKdBPtW8osSEJIu2G2yP16cQREBRIt1yBLkRseFRjJ/2d9AyLuaNUzUOl+mmR0nNQXa1VxsJ70IGj0gZ4M8TYPdbOg/9sef9eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qT2bWUt1ecG4CwMytkLSnYZzZVfFT0xKe5sq20qUDM0=; b=KlaRe93MjlfhxVkEhq2sJDravlFRr/u0TDRDSgJcShdC8PZfbMnJJi3UfQkIgd0kqqyNYN9gw5O5vl93YLNMms+QQfGMNUrBULO9eUqGZv/mRv+88DVPWvi+rwXoct0blUV3PZbqmRrxbQNCdZsqVSoSjcoUasqH0DxrUpsAdFJX2cLvz9tmdzyNAJpbgPL2HM3huFlcvQBsUncbTUZijtgdCvv/nsi1OrxKmevwCdwIyS3WXMATumgGYVuM62maOTXDKCnyVizWSL7CvpwGwmlfSXFjIp6+TwbgVMz5iwHVTWFJPCCTr7i/ifI3CpTRx+Oq1aVtZ2Gm+DJTnTEtoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qT2bWUt1ecG4CwMytkLSnYZzZVfFT0xKe5sq20qUDM0=; b=WfL07Vw9sFFJAcuvUOWknXvn1yrU5eFq9OXSAZOhiwyXwyIyTDvmUEd2Olkk2YLIUM7yxrHcxvQTBvZaZQm6rBQ/aU+Ycw0ZW9f12/E4TTh0duT7RQ4+tAT4JO8GKbB9FMd6DjTXw8WrytuvQDtXgo6WSlSxX4qM1vCgm6OlV1U= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0630.namprd21.prod.outlook.com (2603:10b6:903:12e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.2; Mon, 23 Mar 2020 19:49:44 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%10]) with mapi id 15.20.2878.000; Mon, 23 Mar 2020 19:49:44 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "guomin.jiang@intel.com" Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Thread-Topic: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Thread-Index: AQHWAMH9SnM7WxMvG0OgZ2xQZfimgqhWltJa Date: Mon, 23 Mar 2020 19:49:44 +0000 Message-ID: References: <20200318133343.393-1-guomin.jiang@intel.com> In-Reply-To: <20200318133343.393-1-guomin.jiang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-03-23T19:49:30.1401322Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8949bb74-240c-4343-5c2c-08d7cf6355f5 x-ms-traffictypediagnostic: CY4PR21MB0630: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1850; x-forefront-prvs: 0351D213B3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(199004)(8936002)(10290500003)(2906002)(55016002)(66946007)(110136005)(316002)(66446008)(81156014)(81166006)(66476007)(66556008)(8676002)(64756008)(478600001)(9686003)(8990500004)(71200400001)(966005)(52536014)(5660300002)(26005)(186003)(7696005)(76116006)(86362001)(53546011)(6506007)(33656002)(213903007);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0630;H:CY4PR21MB0743.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eDxRx3fqVUle3B1JAg7wvNMFUmkP7nhx3LMdPVBQ7TePXxueQxF8KCpEBJZz+ARjwsUtzOmhWxHpgTNEn2esAX/gYYbA4POVdtFMtc8eHyCwLY09Ysaep9teA7tiwvLU/BDPntOOaQoAjYCZr2P3Sh8yOtEIFHNJySC1bUXT91sJ7jYXSxu4DlmaBsdc9VL+afNcSsAYoToprV58u0z+nDzPUDCLp99G236aUnjW2iBI9cHI5zUCHiBQcCzSfg70zuqdNiijQG+qSJazMojJgOk3p4aPpsFip5H887pgGjcTVznnt8ONVZfyQvVkuxTL/AxUfqI3GXEczK/2ajIWPGz3ltvjyG06kF7tBW3SSyBDSJC2xzPuXTcBzscKDQjxTsHSbIBWIvvyNNVBODGJz2q7xwomcVWHNBeM8KzvvHLTD6cfOzSUISdJnGnClql3ccc+bsr5IJSwMvz4aXW2harp+rUGuyYfO0xptCvi40Gsys+SaiCG29zwP7EQvjBG2fCqX/EiYMIm/Si5JMbUpjPIKnftqJv8EQJ0PM6l2dgi1LQ7VjFWxR+azLX/2Vxq x-ms-exchange-antispam-messagedata: QAwkT7DoZHcbkMyXvoPXnaMDKg802l7i8SRdcPZR8QC9N+tkP18Efy/CWyWnpbzVTfBV0fep/dQz0HhwT3A+lqZ6WFKxED55gtUvYWwohuD9XPHCttXHc41R/0dtXD+CPGHyKGLCJMfjrhPqaSfyTg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8949bb74-240c-4343-5c2c-08d7cf6355f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2020 19:49:44.5790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MO9Z4qvx04uoLkEpGcgqmtMh///47MEgR/7AsSoePXfrYmKoGNwpjimr9AWNCoYqhaxtxiuodvLEGZ1ZYOCfBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0630 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB07434BA96B53A1E7895B48BCEFF00CY4PR21MB0743namp_" --_000_CY4PR21MB07434BA96B53A1E7895B48BCEFF00CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Looks good to me, but I=92m not an official reviewer. - Bret ________________________________ From: devel@edk2.groups.io on behalf of Guomin Jiang= via Groups.Io Sent: Wednesday, March 18, 2020 6:33:43 AM To: devel@edk2.groups.io Subject: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/In= telPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&data=3D02%7C01%7Cbret.b= arkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=3DPqgTLSHlFecHZWm= VyxA1f4BJDiRkOxrBLSpVQV%2B5bcI%3D&reserved=3D0 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL); + ASSERT(NewPciDevice !=3D NULL); NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment =3D PciSegment; -- 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56082): https://nam06.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F56082&data= =3D02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c= 8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdat= a=3DQTZLYm%2FZa%2BnAHSoQG%2BJDbjDu5KMYyWjXYtJuLr6bW3U%3D&reserved=3D0 Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F72484273%2F1852292&data=3D02%7C01%7Cbret.bar= kelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af= 91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=3DXi5DewUud2C5gHqx1= clGGcNnJ7cZFaPPJV2RlKnQ2gI%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D02%7C01%7Cbret.barkelew= %40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2= d7cd011db47%7C1%7C0%7C637205304196996734&sdata=3DYBaUMmZLuEmg64IxWcwica= qnJZlq3RtG3CAXJvAK1%2Fk%3D&reserved=3D0 [bret.barkelew@microsoft.com] -=3D-=3D-=3D-=3D-=3D-=3D --_000_CY4PR21MB07434BA96B53A1E7895B48BCEFF00CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Looks good to me, but I=92m not an official reviewer= .

 

- Bret

 

From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Guomin Jiang via Groups.Io <gu= omin.jiang=3Dintel.com@groups.io>
Sent: Wednesday, March 18, 2020 6:33:43 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Subject: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSilico= nPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
 
REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&amp;data=3D02%7C01%7Cbret.ba= rkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637205304196996734&amp;sdata=3DPqgTLSHlFecH= ZWmVyxA1f4BJDiRkOxrBLSpVQV%2B5bcI%3D&amp;reserved=3D0

According to code logic, it just judge the condition rather than the
status, it should use the ASSERT rather than ASSERT_EFI_ERROR.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
---
 .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c  =      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c<= br> index 29b6916f61..aa2bf14fa8 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelP= ciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
@@ -69,7 +69,7 @@ RecordPciDeviceInList(
   ASSERT_EFI_ERROR(Status);

 

   NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice));

-  ASSERT_EFI_ERROR(NewPciDevice !=3D NULL);

+  ASSERT(NewPciDevice !=3D NULL);

 

   NewPciDevice->Signature   =3D PCI_DEVICE_INSTANCE= _SIGNATURE;

   NewPciDevice->PciSegment  =3D PciSegment;

--
2.25.1.windows.1


-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56082): https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Fmessage%2F56082&amp;data=3D02%7C01%7Cbret.barkele= w%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab= 2d7cd011db47%7C1%7C0%7C637205304196996734&amp;sdata=3DQTZLYm%2FZa%2BnAH= SoQG%2BJDbjDu5KMYyWjXYtJuLr6bW3U%3D&amp;reserved=3D0
Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroups.= io%2Fmt%2F72484273%2F1852292&amp;data=3D02%7C01%7Cbret.barkelew%40micro= soft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011d= b47%7C1%7C0%7C637205304196996734&amp;sdata=3DXi5DewUud2C5gHqx1clGGcNnJ7= cZFaPPJV2RlKnQ2gI%3D&amp;reserved=3D0
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Funsub&amp;data=3D02%7C01%7Cbret.barkelew%40micros= oft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db= 47%7C1%7C0%7C637205304196996734&amp;sdata=3DYBaUMmZLuEmg64IxWcwicaqnJZl= q3RtG3CAXJvAK1%2Fk%3D&amp;reserved=3D0  [bret.barkelew@microsoft.com]
-=3D-=3D-=3D-=3D-=3D-=3D

--_000_CY4PR21MB07434BA96B53A1E7895B48BCEFF00CY4PR21MB0743namp_--