* [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR @ 2020-03-18 13:33 Jiang, Guomin 2020-03-23 19:49 ` [EXTERNAL] [edk2-devel] " Bret Barkelew 0 siblings, 1 reply; 4+ messages in thread From: Jiang, Guomin @ 2020-03-18 13:33 UTC (permalink / raw) To: devel REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni <ray.ni@intel.com> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com> --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice != NULL); + ASSERT(NewPciDevice != NULL); NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment = PciSegment; -- 2.25.1.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR 2020-03-18 13:33 [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Jiang, Guomin @ 2020-03-23 19:49 ` Bret Barkelew 2020-03-23 20:14 ` Michael D Kinney 0 siblings, 1 reply; 4+ messages in thread From: Bret Barkelew @ 2020-03-23 19:49 UTC (permalink / raw) To: devel@edk2.groups.io, guomin.jiang@intel.com [-- Attachment #1: Type: text/plain, Size: 3258 bytes --] Looks good to me, but I’m not an official reviewer. - Bret ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Guomin Jiang via Groups.Io <guomin.jiang=intel.com@groups.io> Sent: Wednesday, March 18, 2020 6:33:43 AM To: devel@edk2.groups.io <devel@edk2.groups.io> Subject: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=PqgTLSHlFecHZWmVyxA1f4BJDiRkOxrBLSpVQV%2B5bcI%3D&reserved=0 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni <ray.ni@intel.com> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com> --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice != NULL); + ASSERT(NewPciDevice != NULL); NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment = PciSegment; -- 2.25.1.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56082): https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F56082&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=QTZLYm%2FZa%2BnAHSoQG%2BJDbjDu5KMYyWjXYtJuLr6bW3U%3D&reserved=0 Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.io%2Fmt%2F72484273%2F1852292&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=Xi5DewUud2C5gHqx1clGGcNnJ7cZFaPPJV2RlKnQ2gI%3D&reserved=0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=YBaUMmZLuEmg64IxWcwicaqnJZlq3RtG3CAXJvAK1%2Fk%3D&reserved=0 [bret.barkelew@microsoft.com] -=-=-=-=-=-= [-- Attachment #2: Type: text/html, Size: 6726 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR 2020-03-23 19:49 ` [EXTERNAL] [edk2-devel] " Bret Barkelew @ 2020-03-23 20:14 ` Michael D Kinney 2020-03-24 17:19 ` Bret Barkelew 0 siblings, 1 reply; 4+ messages in thread From: Michael D Kinney @ 2020-03-23 20:14 UTC (permalink / raw) To: devel@edk2.groups.io, bret.barkelew@microsoft.com, Jiang, Guomin, Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 4227 bytes --] HI Bret, You reposted the issue in BZ, so your review is very valuable to make sure the change proposed addresses the issue reported. Reviews by Maintainers/Reviewers documented in Maintainers.txt are required to do the commit, but we welcome reviews from anyone in the community that wants to provide input in any changes. Thanks, Mike From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bret Barkelew via Groups.Io Sent: Monday, March 23, 2020 12:50 PM To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com> Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Looks good to me, but I’m not an official reviewer. - Bret ________________________________ From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Guomin Jiang via Groups.Io <guomin.jiang=intel.com@groups.io<mailto:guomin.jiang=intel.com@groups.io>> Sent: Wednesday, March 18, 2020 6:33:43 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Subject: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=PqgTLSHlFecHZWmVyxA1f4BJDiRkOxrBLSpVQV%2B5bcI%3D&reserved=0 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com<mailto:rangasai.v.chaganty@intel.com>> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com<mailto:guomin.jiang@intel.com>> --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice != NULL); + ASSERT(NewPciDevice != NULL); NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment = PciSegment; -- 2.25.1.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56082): https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F56082&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=QTZLYm%2FZa%2BnAHSoQG%2BJDbjDu5KMYyWjXYtJuLr6bW3U%3D&reserved=0 Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.io%2Fmt%2F72484273%2F1852292&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=Xi5DewUud2C5gHqx1clGGcNnJ7cZFaPPJV2RlKnQ2gI%3D&reserved=0 Group Owner: devel+owner@edk2.groups.io<mailto:devel+owner@edk2.groups.io> Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=YBaUMmZLuEmg64IxWcwicaqnJZlq3RtG3CAXJvAK1%2Fk%3D&reserved=0 [bret.barkelew@microsoft.com] -=-=-=-=-=-= [-- Attachment #2: Type: text/html, Size: 46744 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR 2020-03-23 20:14 ` Michael D Kinney @ 2020-03-24 17:19 ` Bret Barkelew 0 siblings, 0 replies; 4+ messages in thread From: Bret Barkelew @ 2020-03-24 17:19 UTC (permalink / raw) To: devel@edk2.groups.io, Kinney, Michael D, Jiang, Guomin [-- Attachment #1: Type: text/plain, Size: 6134 bytes --] Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com> - Bret ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Michael D Kinney via Groups.Io <michael.d.kinney=intel.com@groups.io> Sent: Monday, March 23, 2020 1:14:28 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Jiang, Guomin <guomin.jiang@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR HI Bret, You reposted the issue in BZ, so your review is very valuable to make sure the change proposed addresses the issue reported. Reviews by Maintainers/Reviewers documented in Maintainers.txt are required to do the commit, but we welcome reviews from anyone in the community that wants to provide input in any changes. Thanks, Mike From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bret Barkelew via Groups.Io Sent: Monday, March 23, 2020 12:50 PM To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com> Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Looks good to me, but I’m not an official reviewer. - Bret ________________________________ From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Guomin Jiang via Groups.Io <guomin.jiang=intel.com@groups.io<mailto:guomin.jiang=intel.com@groups.io>> Sent: Wednesday, March 18, 2020 6:33:43 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Subject: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=PqgTLSHlFecHZWmVyxA1f4BJDiRkOxrBLSpVQV%2B5bcI%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C27c3371c0a364eda10b408d7cf66cc83%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205912748480188&sdata=MSXneVD1umhUskP5mtBIHhXCICe5j5MLN1RokhejY2U%3D&reserved=0> According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com<mailto:rangasai.v.chaganty@intel.com>> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com<mailto:guomin.jiang@intel.com>> --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice != NULL); + ASSERT(NewPciDevice != NULL); NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment = PciSegment; -- 2.25.1.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56082): https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F56082&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=QTZLYm%2FZa%2BnAHSoQG%2BJDbjDu5KMYyWjXYtJuLr6bW3U%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F56082&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C27c3371c0a364eda10b408d7cf66cc83%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205912748490183&sdata=ULlDO3aFdDxpXDdcyn%2BElfHdxc2Vw9VdcaEGriAXff4%3D&reserved=0> Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.io%2Fmt%2F72484273%2F1852292&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=Xi5DewUud2C5gHqx1clGGcNnJ7cZFaPPJV2RlKnQ2gI%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.io%2Fmt%2F72484273%2F1852292&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C27c3371c0a364eda10b408d7cf66cc83%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205912748500177&sdata=VPZxpDFkPFzNUxsA4GCUI4yyo%2BMh6Fs0c%2BaR6W3KJmU%3D&reserved=0> Group Owner: devel+owner@edk2.groups.io<mailto:devel+owner@edk2.groups.io> Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=YBaUMmZLuEmg64IxWcwicaqnJZlq3RtG3CAXJvAK1%2Fk%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C27c3371c0a364eda10b408d7cf66cc83%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205912748500177&sdata=QGvlItACUGwtSKAtIXhgKtUwbKTeZkyZz7Y7scd%2BEgo%3D&reserved=0> [bret.barkelew@microsoft.com] -=-=-=-=-=-= [-- Attachment #2: Type: text/html, Size: 11565 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-24 17:19 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-18 13:33 [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Jiang, Guomin 2020-03-23 19:49 ` [EXTERNAL] [edk2-devel] " Bret Barkelew 2020-03-23 20:14 ` Michael D Kinney 2020-03-24 17:19 ` Bret Barkelew
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox