From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.95]) by mx.groups.io with SMTP id smtpd.web12.7549.1589381008960876652 for ; Wed, 13 May 2020 07:43:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=aluRkeoQ; spf=pass (domain: microsoft.com, ip: 40.107.243.95, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IqhCv7VDQSuT+0IHuhNlb3SlxRFq4jgGtHThT8Rj8dljkZABbmupMNuhYIIQALcPs85fCWRgkT7v7EcCQRx8vYiauGp563Nc2oDXFcYWHnwPLniZCoZ7g2HgY945nzRnx1u9GSLFt0TQN42g46x4yUZXCZqvu/aFzRnoy6St7phYSUlR8kFReSI7I5Db82ej2Y9M8PpfEGFrh3nzO7ov2IfbU3n+uClnZPeFYkICSjwxCOhue/P1O4RapmUfPpeVLyfauIKh+DgKtO+J8BatCVtg4iBSGSO5bd2Dwl7u03EfbdOkbM7ZEUYfe8b4bcc9gf1SzT053LJeZgFesShaow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ry2EG6JGD7EKC45N0lldiQj6vIHo4LHWmlob35QKk8=; b=lvW1VpLlzA1UG6BrMnzrrq+bsJe19/5xeC8Gs3rcdbkyBlWQrhtuls2uPJ1415LfEKls+tL5SJTyzMMUHMXDFR6UJpZQJZiCYCHhQyPX+FO1OeBouWnyO7RWEG8vUT9ymD/ccSZBtrF+hXako6GvrY8rmsoWkTQA3InDLUvha8mALJXZukKUWZzbSw4a1HhZP4nTlw3SR69hqM+n6oCDa+o127Z/53Ud6T/cCqiSYOYQUj/+xIap3thNWzFdRpWXpLv4LBK/+WkyIBKoYljSoIrkhFFJYrQQ9b4p3G1NNGV131v0yui5EtX3Bcqea3zotLujJ9GUwGVqle9LHgMl/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ry2EG6JGD7EKC45N0lldiQj6vIHo4LHWmlob35QKk8=; b=aluRkeoQTB/OL3X3NW4Z0dmxMSrl87FCvsoZ504ub+naNUuWPQegfBc4xBKLtBJNzJE9GA3/ss0EY+7aEB5K/x3ltWzx+FtFcQUp+E6wY1On87oxdQxrM1GQii9idQWGReZO+k+/YRRVXWYCkLtgaLoDuqv114KwX3FyZikCjG4= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB1554.namprd21.prod.outlook.com (2603:10b6:910:92::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.3; Wed, 13 May 2020 14:43:27 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9918:8742:bbe7:84e8]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9918:8742:bbe7:84e8%14]) with mapi id 15.20.3021.002; Wed, 13 May 2020 14:43:27 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "lersek@redhat.com" , "cheptsov@ispras.ru" CC: "Dong, Eric" , "Ni, Ray" Subject: Re: [EXTERNAL] Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib Thread-Index: AQHWKRa8IQ3HdYnTpUiqHMs5VcofDqimF0jR Date: Wed, 13 May 2020 14:43:27 +0000 Message-ID: References: <20200512170237.19796-1-cheptsov@ispras.ru> <20200512170237.19796-25-cheptsov@ispras.ru>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-05-13T14:42:29.9630656Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.135.200] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 786c82dc-b728-439a-8fd4-08d7f74bff65 x-ms-traffictypediagnostic: CY4PR21MB1554: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:227; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B+iQ9k3tNPvzfXCEY72bQiYcLtM59KfJDSKC/zGNxiyawICHyR5yaZKD+kRU8f84mupiDzp56PC2hpVkdHpvgvg+bUUadIaVxCu3rA0q8yiIiMoh8gHxVdeGK+E1ndfTQEE52+ZMuGPN41c3XN0vzYvm0q5CJRAHD9NyF1sLQ/5H9zGqkFFmDS2mFRcTAcTGdjRQEO7UysWSxz7kky1P7oWeXnj4Q8hEm/EuaK46IysMzXiy1+iQzIwA+A2BkNbH6DRtfH1WKjZYvq7fotppr1UbmLXRbrn6303068iO0ggU3HRIfmssF+e2IdIG0ejO7IcqT79c3nTei35Le2EMUUtjNPu7/Dluh5MPxAaJSahvWjROBXIs1cPmnQ1tHoLyK8Vz710T92KGzesIdeyoxlpE8YIAXh1P5ZU+mw2ZM9WE3S6NXyh5XVMaAyd/RZdHJhCGIoemggzHCc8ZwIvL65dpS2X4hUw+6a1jUG7dL6zoihocSa99gC1ZEueFRG7DCDZKXK37itH6vnXT5J0faAxOpRv4hglGPY5Lq0TgBGV0Rx7qp4fCF1aIN7qGzy6D4hzmqTF4fgaYS9ATUPyCPfH59tGaRCLaDrcKXlpiMWw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(366004)(376002)(39860400002)(346002)(33430700001)(478600001)(186003)(966005)(52536014)(316002)(2906002)(71200400001)(166002)(86362001)(33440700001)(8990500004)(26005)(10290500003)(7696005)(91956017)(4326008)(110136005)(82950400001)(82960400001)(8676002)(8936002)(55016002)(9686003)(54906003)(76116006)(66476007)(5660300002)(64756008)(66556008)(66446008)(33656002)(66946007)(53546011)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: OhBXb8z2R7vluy1s4G00u8Weu5jLYVg+Wn2B/alpO+Kw8bMxON3G4cKKI3l2Pp8i1SqTgJpK4e+x1B92WCZMgW9R+hF1pURyQmPueeMEpqI0Isq8hha1Hujlo9zafWvcXLxtmProAk2xyGx38rQ2Q13CUFfGGLMUkVAG2lSDUAfGMFlm3oYewAuAa+mMMRZ2kXpDrDW9tukt/zHSBfCiRw6Tn5GAH4DNqGxL4svn6zidMVHs1BRtas5HqjeS1tqWwOujRDVkeTAWOXmli/DvSFf89pOgZ4KEp7bqOjYt6QMXnQeFKK7dwYua4DLDdmQchhvPqb/GnqV6OXOgJzCdTARWIxHSXT1qCgEsadd+wjl/U5aHTZHSDnnNfkaubNin8N6NcbiqPfKFzZVE3zofXtCTEuO1KQKXrsfHvQVQPJ0zfanpkBcwDNfiyz646m0woKpoYoP+kjXrmsQwR0ezMQRnETwhtvlP1zh/AQt6OMTA/QyQG7ncI02W0qAnQ6oQ x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 786c82dc-b728-439a-8fd4-08d7f74bff65 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 14:43:27.4848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zmWYRgG4J/V+VdaOGlZCAD7ROZcjiX2dQ+0LlWcv9hb66wAksEJnsyILnVIm6hyl5h7G0xUQYyLb9+QoLdd3Jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB1554 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB074365894967FDDE656CFC6EEFBF0CY4PR21MB0743namp_" --_000_CY4PR21MB074365894967FDDE656CFC6EEFBF0CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Having only ever used PRs, what does that mean? He should have copied the = =93R-b=94 text and amended that commit message in this version? - Bret ________________________________ From: devel@edk2.groups.io on behalf of Laszlo Erse= k via groups.io Sent: Wednesday, May 13, 2020 4:07:34 AM To: devel@edk2.groups.io ; cheptsov@ispras.ru Cc: Dong, Eric ; Ni, Ray Subject: [EXTERNAL] Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add supp= ort for DebugCommonLib On 05/12/20 19:02, Vitaly Cheptsov wrote: > REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2054&data=3D02%7C01%7Cbre= t.barkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f= 141af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&sdata=3DuE8hQ1goSvrn= yjx8orh6l3%2BuS%2BzlOpZtXZylsEEzHBo%3D&reserved=3D0 > > CC: Eric Dong > CC: Ray Ni > CC: Laszlo Ersek > Signed-off-by: Vitaly Cheptsov > --- > UefiCpuPkg/UefiCpuPkg.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index d28cb5cccb..f5f407ad23 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -27,6 +27,7 @@ [LibraryClasses] > CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibN= ull.inf > + DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebugCommonLib.i= nf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba= seDebugPrintErrorLevelLib.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > Again, identical to the v4 counterpart. Should have picked up my R-b. https://nam06.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmid.mai= l-archive.com%2F0d0b6b6f-39c8-4056-c496-07151e33cdd5%40redhat.com&data= =3D02%7C01%7Cbret.barkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72dd= d70%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&sda= ta=3DX%2Bvi9LqaswphH3DM63JWIK2UJP8%2B%2BxDOBEkmDCF6%2FPw%3D&reserved=3D= 0 https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.g= roups.io%2Fg%2Fdevel%2Fmessage%2F59202&data=3D02%7C01%7Cbret.barkelew%4= 0microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2d7= cd011db47%7C1%7C0%7C637249648679637664&sdata=3DECkvl%2FeXKWbud%2FsNB2%2= BusXff9HY%2F7OWx%2FFD5DejhC3c%3D&reserved=3D0 anyway Reviewed-by: Laszlo Ersek --_000_CY4PR21MB074365894967FDDE656CFC6EEFBF0CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
Having only ever used PRs, what does that m= ean? He should have copied the =93R-b=94 text and amended that commit messa= ge in this version?

- Bret
From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Laszlo Ersek via groups.io <l= ersek=3Dredhat.com@groups.io>
Sent: Wednesday, May 13, 2020 4:07:34 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; cheptsov@isp= ras.ru <cheptsov@ispras.ru>
Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@inte= l.com>
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH V5 24/27] UefiCpuPkg: A= dd support for DebugCommonLib
 
On 05/12/20 19:02, Vitaly Cheptsov wrote:
> REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2054&amp;data=3D02%7C01%7Cbret.b= arkelew%40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637249648679637664&amp;sdata=3DuE8hQ1goSvr= nyjx8orh6l3%2BuS%2BzlOpZtXZylsEEzHBo%3D&amp;reserved=3D0
>
> CC: Eric Dong <eric.dong@intel.com>
> CC: Ray Ni <ray.ni@intel.com>
> CC: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index d28cb5cccb..f5f407ad23 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> @@ -27,6 +27,7 @@ [LibraryClasses]
>    CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
>    DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugL= ibNull.inf
>    SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/= BaseSerialPortLibNull.inf
> +  DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebu= gCommonLib.inf
>    DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPri= ntErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
>    DevicePathLib|MdePkg/Library/UefiDevicePathLib/Uefi= DevicePathLib.inf
>    UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUe= fiCpuLib.inf
>

Again, identical to the v4 counterpart. Should have picked up my R-b.

https://nam06.safelinks.protection.outlook.com/?url= = =3Dhttp%3A%2F%2Fmid.mail-archive.com%2F0d0b6b6f-39c8-4056-c496-07151e33cdd= 5%40redhat.com&amp;data=3D02%7C01%7Cbret.barkelew%40microsoft.com%7Cc38= 2255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C= 637249648679637664&amp;sdata=3DX%2Bvi9LqaswphH3DM63JWIK2UJP8%2B%2BxDOBE= kmDCF6%2FPw%3D&amp;reserved=3D0

h= ttps://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gro= ups.io%2Fg%2Fdevel%2Fmessage%2F59202&amp;data=3D02%7C01%7Cbret.barkelew= %40microsoft.com%7Cc382255c73964cb091ed08d7f72ddd70%7C72f988bf86f141af91ab2= d7cd011db47%7C1%7C0%7C637249648679637664&amp;sdata=3DECkvl%2FeXKWbud%2F= sNB2%2BusXff9HY%2F7OWx%2FFD5DejhC3c%3D&amp;reserved=3D0

anyway

Reviewed-by: Laszlo Ersek <lersek@redhat.com>




--_000_CY4PR21MB074365894967FDDE656CFC6EEFBF0CY4PR21MB0743namp_--