From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.131]) by mx.groups.io with SMTP id smtpd.web11.54162.1590509625398748387 for ; Tue, 26 May 2020 09:13:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=TYd5vrPX; spf=pass (domain: microsoft.com, ip: 40.107.93.131, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUlEdBZdy1MkX6DKEZTTldlOgAx54m2xA6Zm9yGGd0G2MqNl0w6FCH6Rbx+MltJoSMYMVKm3lGwNi2tutschHJRIdGlocpZyVTMPnb8Pconoi0Q7F6QBs+76dqfCnwO8WmySHsjjIP71mw9XsUaYkbCfF2hgjSkmxiVz2qjo/++gjRGtFPDt4S3ydD7RzZU9Y64HV53DGncS2J3A2o03Av1qd6axXQ0ELne3uIcC1te2coMG8GnGr2Q9Jd9IRbIHplrNojKYQ6ZQ2M5qawSEe8zBGVY02yrdeCnGnIdCDq9XMI+cf30mJnWSlPsbwO8HNeZOi0eaXQllEE3h8cDtHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fRkD3/tPocdBYyXbzbAZX1+ofcHrFs568KiRm+6ZgSo=; b=kiqvhSlpvsgW2TuQBCeyOs1zaaU71il8ytTO3uXZ+itGa+FfaJLZ3C3wFMfDjyhxMfE7B5y24uriE0TAS77iF/92SuqorAd2lDcK7lpyzMsSlQ6eTS1YOydQ62RpLWwsbCqeWfki7RMeYmoyvCndn2s/25k6fwS48c/BmGlYMfYaUeJCfAIunf5UHMir7p1hv4dcZqELCSDpbh1w2f9jEjG6vetr8Y4nUjQO4lPM45RxDhIjgVHQKr/khPox/cRdxOQ0EHK+m7U1KGKxLnPSzYNSXFW3AN8rhclO59rxLx2jIaBfI2xijQkXMyvQD642f2G1vvh4+FjNGcGquZ21zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fRkD3/tPocdBYyXbzbAZX1+ofcHrFs568KiRm+6ZgSo=; b=TYd5vrPXJXqbHnzd0DaNzU2mJZkY21eMVoI2qWwvlU/W3a3bFWfYWXjqmNM4NQLxjyl7JsyDsCKLH+n8uTKrdRkN3pgIssg1QognqFEhj4fqbol08sW+dFdEBIFzsh63xC6MO6y77w9ZW8HGz4RhQXkNz4OVmIyVVuQZcavlUI0= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB1554.namprd21.prod.outlook.com (2603:10b6:910:92::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.15; Tue, 26 May 2020 16:13:43 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::f112:82fb:d4fd:f7dd]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::f112:82fb:d4fd:f7dd%12]) with mapi id 15.20.3045.005; Tue, 26 May 2020 16:13:43 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , Samer El-Haj-Mahmoud , "rfc@edk2.groups.io" , "lersek@redhat.com" , Andrew Fish CC: "devel@edk2.groups.io" , "spbrogan@outlook.com" , "Desimone, Nathaniel L" , "Kinney, Michael D" , "Leif Lindholm (Nuvia address)" , Samer El-Haj-Mahmoud Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process Thread-Topic: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process Thread-Index: AQHWMkpAQllVD47S7Uu5/CgTnOOvwai5GwsAgAAFA4CAARnpAIAAOH+AgAAZ7e8= Date: Tue, 26 May 2020 16:13:43 +0000 Message-ID: References: <2107AEA7-9145-4FC9-9E1A-C396F23877ED@apple.com> <23ed8abb-2d08-5b67-4824-e88ba555e6cd@redhat.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-05-26T16:12:41.7302489Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [71.212.144.72] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 90efe0b9-95d1-4f84-d7a9-08d8018fc328 x-ms-traffictypediagnostic: CY4PR21MB1554: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 041517DFAB x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3SRassBB4N7o70KOJ/2qZuklblxhj0lqcdbjV2E0THGcCDyf6bkabjo9X4ZtlO+OCiMKx/k27Fh8GLjp73KYH1A/Dat/gB4H+3Dh34DJ1YayxV3w40JYPbKbTKlEvkXaZc2ui1lO92ed1TxdmRD//S/sRhvLVeidcT7TqpKHO04AwzlOU3BPpca3qntlitd8oAxwrh6uZFlrMet9CqMTpg7B2F45//zfSHkJ97yr8KiDGKuhc3C+hXXoRp/ynnPE+s45chaNPDCkMC5a2dslMES0wdHV15H1TIHWZBOTefum7u0uJBrmNoBFknjthU0cTWurx2GM6Fu43P01PEuFUMeWWBcfWmMVR4RxiSw5clGSJNl4fV0QePcHAJDBveqgceJjTiVznopgrBFWwdl41A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(366004)(136003)(346002)(39860400002)(376002)(82960400001)(186003)(110136005)(82950400001)(2906002)(8936002)(54906003)(71200400001)(52536014)(10290500003)(478600001)(316002)(86362001)(7696005)(5660300002)(166002)(966005)(4326008)(55016002)(9686003)(66946007)(66556008)(64756008)(8676002)(66446008)(66476007)(53546011)(6506007)(76116006)(8990500004)(26005)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: eJGmWEQXtyIhdyqBkaXLsN9fW+Ts6HqY27dHvcDPxeWxiwGdJaPQ5qap6pNsmpbVmGfz6IFvOhlvWlC44vWxDp7ICcNoWT79jxR+zR7wdRebHsidW1jtUHQDQuQ0uf+JzVCnoEms/9KXkMHvnvu2pYrbkRjnEhFhHNtmXQC9LyczN2iwPEZm5Bi7fR/fy/PTs1joN3XxUh14PHZOUtQbuVowsxAd9ZzUMPu/j0+rWbXrfbeWekDQs9jmWRjpG6/EaIzSlgoblilmGmUnrDfspDhPK8tNBEYGxwDgeyPZ/DmxlsSgobvGJNYore25qjfLht6D+lRe8tRXAH3rhwRSng3STy2n2sSSMre+62E32b2KMn+vW2vrez/T5Iq5Xe5Et2HSX7/RS6P8ztW74IKIfKBclrTRgH+r+sK+u6390DJ3JcBGTpIrgSEovYgfJwU7GcmANQoDb4lppqzShq0NRTLooSgnMqt+OjXs7axY8ak= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90efe0b9-95d1-4f84-d7a9-08d8018fc328 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2020 16:13:43.7200 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 29d5Yy/J5NCw0Ik91XL2SP5ADxTzBc1SjKF4LGcSCA0CK4qHWi9xr8MgM2UND+DD2VRcXyZKdyDgOnLBB3KCGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB1554 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB07436DC93C02000F8789BF45EFB00CY4PR21MB0743namp_" --_000_CY4PR21MB07436DC93C02000F8789BF45EFB00CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Samer, Have you had a chance to review Mike=92s PR process? Any thoughts as compa= rison? - Bret ________________________________ From: devel@edk2.groups.io on behalf of Samer El-Ha= j-Mahmoud via groups.io Sent: Tuesday, May 26, 2020 7:39:55 AM To: rfc@edk2.groups.io ; lersek@redhat.com ; Andrew Fish Cc: Bret Barkelew ; devel@edk2.groups.io ; spbrogan@outlook.com ; Desimone, = Nathaniel L ; Kinney, Michael D ; Leif Lindholm (Nuvia address) ; Samer= El-Haj-Mahmoud Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based = Code Review Process I agree with Andrew. I also found Laszlo's "unkempt guide" very useful. In= addition, there is a short page by Peter Batard that adds more details on = the commits validation, patchset generation, and e-mail submission: https:/= /nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgist.github.co= m%2Fpbatard%2Fec1c9d1dd6e7144b07a09b057b1735a8&data=3D02%7C01%7Cbret.ba= rkelew%40microsoft.com%7Cdca587d1198049354a6f08d80182b15a%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637261008123224059&sdata=3De%2Bk1gQubOWY8gW= lQAUAmjIIaqQMv6p%2FMqjUHcntVm1g%3D&reserved=3D0 > -----Original Message----- > From: rfc@edk2.groups.io On Behalf Of Laszlo Ersek > via groups.io > Sent: Tuesday, May 26, 2020 7:18 AM > To: Andrew Fish > Cc: Bret Barkelew ; devel@edk2.groups.io; > spbrogan@outlook.com; rfc@edk2.groups.io; Desimone, Nathaniel L > ; Mike Kinney > ; Leif Lindholm (Nuvia address) > > Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request base= d > Code Review Process > > On 05/25/20 20:28, Andrew Fish wrote: > > > > > >> On May 25, 2020, at 11:10 AM, Laszlo Ersek wrote: > >> > >> Hi Andrew, > >> > >> On 05/25/20 06:09, Andrew Fish wrote: > >> > >>> I also found I had to Bing/Google to find the detailed instructions > >>> I needed as a developer, as the Wiki seems to assume you just know > >>> the Linux kernel patch process. That feels like an area we can impro= ve. > >> > >> (apologies if I've lost context; please disregard my message below in > >> that case). > >> > >> I wrote the following wiki article originally in 2016: > >> > >> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg= ithub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FLaszlo%27s-unkemp&= data=3D02%7C01%7Cbret.barkelew%40microsoft.com%7Cdca587d1198049354a6f08d801= 82b15a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637261008123224059&= sdata=3DhwAXd7kabi4mQyTEr7AWlEyA4yHDkdwG8zr1lirgmA4%3D&reserved=3D0 > >> t-git-guide-for-edk2-contributors-and-maintainers > >> > >> I wrote it specifically for developers & maintainers with no (or > >> almost > >> no) prior git / mailing list experience. Multiple developers > >> confirmed later that the article had helped them. > >> > > > > Laszlo, > > > > Your wiki article was very very helpful. I just could not find it from= the > Tianocre wiki. It would be good if we could link to it from here [1], ma= ybe as > add to this: "Are you new to using git? If so, then the New to git page = may be > helpful."? > > The article at [1] is an official document, while the "unkempt guide" is= not > official. The unkempt guide starts by deferring to [1]. I didn't think t= he official > document should point to my unofficial one, and/or we should create a lo= op > of links. > > That said, if someone else updates [1] with a pointer, I won't protest. > That's just something that I (having authored the unkempt guide) would n= ot > propose myself. > > I do agree that the wiki search facilities on github are basic. What has= mostly > worked for me is clicking the Pages arrow, and then entering a *very sim= ple* > search term in the drop-down search box. For example, if I do that now, = and > only enter "git", then the "unkempt guide" is listed (with other hits of > course). I think this search box is basically for searching article titl= es. > > > > > There are a lot folks who use git but don't use the email based review= so > they have never setup git with emali before. Your wiki, plus me figuring= out > the magic internal SMTP reflector (I reached out on an internal git mall= ing list) > is what got me unblocked. > > It's great that you have access to such infrastructure at Apple! > > Thanks! > Laszlo > > > > > > [1] > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgi= thub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Developme&da= ta=3D02%7C01%7Cbret.barkelew%40microsoft.com%7Cdca587d1198049354a6f08d80182= b15a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637261008123234063&sd= ata=3DUqY5uoxqMamf5PkFLOJ20YKE1aWTZRqGnEYuK93AxiA%3D&reserved=3D0 > > nt-Process > > > > Thanks, > > > > Andrew Fish > > > >> Thanks > >> Laszlo > >> > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. --_000_CY4PR21MB07436DC93C02000F8789BF45EFB00CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
Samer,

Have you had a chance to review Mike=92s PR= process? Any thoughts as comparison?

- Bret
From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Samer El-Haj-Mahmoud via groups.= io <samer.el-haj-mahmoud=3Darm.com@groups.io>
Sent: Tuesday, May 26, 2020 7:39:55 AM
To: rfc@edk2.groups.io <rfc@edk2.groups.io>; lersek@redhat.co= m <lersek@redhat.com>; Andrew Fish <afish@apple.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.g= roups.io <devel@edk2.groups.io>; spbrogan@outlook.com <spbrogan@ou= tlook.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>= ; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm (Nuvia address) <leif@nuviainc.com>; Samer El-Haj-Mahmoud <Samer= .El-Haj-Mahmoud@arm.com>
Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request= based Code Review Process
 
I agree with Andrew. I also found Laszlo's "= unkempt guide" very useful. In addition, there is a short page by Pete= r Batard that adds more details on the commits validation, patchset generat= ion, and e-mail submission: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgist.g= ithub.com%2Fpbatard%2Fec1c9d1dd6e7144b07a09b057b1735a8&amp;data=3D02%7C= 01%7Cbret.barkelew%40microsoft.com%7Cdca587d1198049354a6f08d80182b15a%7C72f= 988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637261008123224059&amp;sdata=3D= e%2Bk1gQubOWY8gWlQAUAmjIIaqQMv6p%2FMqjUHcntVm1g%3D&amp;reserved=3D0=


> -----Original Message-----
> From: rfc@edk2.groups.io <rfc@edk2.groups.io> On Behalf Of Lasz= lo Ersek
> via groups.io
> Sent: Tuesday, May 26, 2020 7:18 AM
> To: Andrew Fish <afish@apple.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.gro= ups.io;
> spbrogan@outlook.com; rfc@edk2.groups.io; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Mike Kinney
> <michael.d.kinney@intel.com>; Leif Lindholm (Nuvia address)
> <leif@nuviainc.com>
> Subject: Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request b= ased
> Code Review Process
>
> On 05/25/20 20:28, Andrew Fish wrote:
> >
> >
> >> On May 25, 2020, at 11:10 AM, Laszlo Ersek <lersek@redhat= .com> wrote:
> >>
> >> Hi Andrew,
> >>
> >> On 05/25/20 06:09, Andrew Fish wrote:
> >>
> >>> I also found I had to Bing/Google to find the detailed i= nstructions
> >>> I needed as a developer, as the Wiki seems to assume you= just know
> >>> the Linux kernel patch process. That feels like an area = we can improve.
> >>
> >> (apologies if I've lost context; please disregard my message= below in
> >> that case).
> >>
> >> I wrote the following wiki article originally in 2016:
> >>
> >> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FLaszlo%27s-unkemp&amp;d= ata=3D02%7C01%7Cbret.barkelew%40microsoft.com%7Cdca587d1198049354a6f08d8018= 2b15a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637261008123224059&a= mp;sdata=3DhwAXd7kabi4mQyTEr7AWlEyA4yHDkdwG8zr1lirgmA4%3D&amp;reserved= =3D0
> >> t-git-guide-for-edk2-contributors-and-maintainers
> >>
> >> I wrote it specifically for developers & maintainers wit= h no (or
> >> almost
> >> no) prior git / mailing list experience. Multiple developers=
> >> confirmed later that the article had helped them.
> >>
> >
> > Laszlo,
> >
> > Your wiki article was very very helpful. I just could not find i= t from the
> Tianocre wiki. It would be good if we could link to it from here [1],= maybe as
> add to this: "Are you new to using git? If so, then the New to g= it page may be
> helpful."?
>
> The article at [1] is an official document, while the "unkempt g= uide" is not
> official. The unkempt guide starts by deferring to [1]. I didn't thin= k the official
> document should point to my unofficial one, and/or we should create a= loop
> of links.
>
> That said, if someone else updates [1] with a pointer, I won't protes= t.
> That's just something that I (having authored the unkempt guide) woul= d not
> propose myself.
>
> I do agree that the wiki search facilities on github are basic. What = has mostly
> worked for me is clicking the Pages arrow, and then entering a *very = simple*
> search term in the drop-down search box. For example, if I do that no= w, and
> only enter "git", then the "unkempt guide" is lis= ted (with other hits of
> course). I think this search box is basically for searching article t= itles.
>
> >
> > There are a lot folks who use git but don't use the email based = review so
> they have never setup git with emali before. Your wiki, plus me figur= ing out
> the magic internal SMTP reflector (I reached out on an internal git m= alling list)
> is what got me unblocked.
>
> It's great that you have access to such infrastructure at Apple!
>
> Thanks!
> Laszlo
>
>
> >
> > [1]
> > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub= .com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Developme&amp;da= ta=3D02%7C01%7Cbret.barkelew%40microsoft.com%7Cdca587d1198049354a6f08d80182= b15a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637261008123234063&am= p;sdata=3DUqY5uoxqMamf5PkFLOJ20YKE1aWTZRqGnEYuK93AxiA%3D&amp;reserved= =3D0
> > nt-Process
> >
> > Thanks,
> >
> > Andrew Fish
> >
> >> Thanks
> >> Laszlo
> >>
> >
>
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in any medium. Thank you.



--_000_CY4PR21MB07436DC93C02000F8789BF45EFB00CY4PR21MB0743namp_--