public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"oleksiyy@ami.com" <oleksiyy@ami.com>
Cc: "liming.gao@intel.com" <liming.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Felixp@ami.com" <Felixp@ami.com>,
	"oleksiyy@ami.com" <oleksiyy@ami.com>
Subject: Re: [EXTERNAL] [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image Header extension
Date: Fri, 10 Apr 2020 23:55:59 +0000	[thread overview]
Message-ID: <CY4PR21MB0743755D419197C4F73CF254EFDE0@CY4PR21MB0743.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200410195803.19972-5-oleksiyy@ami.com>

[-- Attachment #1: Type: text/plain, Size: 2632 bytes --]

Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>

- Bret

________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Oleksiy Yakovlev via groups.io <oleksiyy=ami.com@groups.io>
Sent: Friday, April 10, 2020 12:58:03 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: liming.gao@intel.com <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Felixp@ami.com <Felixp@ami.com>; oleksiyy@ami.com <oleksiyy@ami.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image Header extension

Add bitmask to structure which gives a binary-inspectable mechanism to determine
if a capsule contains an authentication section or depex section.
(UEFI 2.8 errata a, mantis 2026)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Guid/FmpCapsule.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Guid/FmpCapsule.h b/MdePkg/Include/Guid/FmpCapsule.h
index fb8c346..6bbdf0e 100644
--- a/MdePkg/Include/Guid/FmpCapsule.h
+++ b/MdePkg/Include/Guid/FmpCapsule.h
@@ -79,13 +79,22 @@ typedef struct {
   /// therefore can be modified without changing the Auth data.
   ///
   UINT64   UpdateHardwareInstance;
+
+  ///
+  /// A 64-bit bitmask that determines what sections are added to the payload.
+  /// #define CAPSULE_SUPPORT_AUTHENTICATION 0x0000000000000001
+  /// #define CAPSULE_SUPPORT_DEPENDENCY 0x0000000000000002
+  ///
+  UINT64   ImageCapsuleSupport;
 } EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER;

 #pragma pack()


 #define EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER_INIT_VERSION       0x00000001
-#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION 0x00000002
+#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION 0x00000003
+#define CAPSULE_SUPPORT_AUTHENTICATION    0x0000000000000001
+#define CAPSULE_SUPPORT_DEPENDENCY        0x0000000000000002

 extern EFI_GUID gEfiFmpCapsuleGuid;

--
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.




[-- Attachment #2: Type: text/html, Size: 4827 bytes --]

  reply	other threads:[~2020-04-10 23:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 19:57 [PATCH 0/4] Add definitions introduced in UEFI 2.8a Oleksiy Yakovlev
2020-04-10 19:58 ` [PATCH 1/4] MdePkg: Add new CPER Notification types Oleksiy Yakovlev
2020-04-10 23:53   ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2020-05-06 20:13     ` Oleksiy Yakovlev
2020-04-10 19:58 ` [PATCH 2/4] MdePkg: Fix OUT parameters marked as IN OUT Oleksiy Yakovlev
2020-04-10 19:58 ` [PATCH 3/4] MdePkg: Add EFI_PROPERTIES_TABLE Oleksiy Yakovlev
2020-04-27  9:04   ` [edk2-devel] " Zhiguang Liu
2020-04-10 19:58 ` [PATCH 4/4] MdePkg: Add FMP Capsule Image Header extension Oleksiy Yakovlev
2020-04-10 23:55   ` Bret Barkelew [this message]
2020-05-11  6:14   ` [edk2-devel] " Zhiguang Liu
2020-05-11 16:04     ` Xu, Wei6
2020-04-27  9:11 ` [edk2-devel] [PATCH 0/4] Add definitions introduced in UEFI 2.8a Zhiguang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR21MB0743755D419197C4F73CF254EFDE0@CY4PR21MB0743.namprd21.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox