From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.130]) by mx.groups.io with SMTP id smtpd.web12.16.1586562961320928526 for ; Fri, 10 Apr 2020 16:56:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=KCK8Io/3; spf=pass (domain: microsoft.com, ip: 40.107.220.130, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cQuBhI1JH2Nkn5BXM7a4RVafgeVnvdPlXXzN6rQ9XQgteXk/TBwrtpbK4nabU7wyfWRNTThKV7NO+NnWldhPZbIt5R6p3PQxVrVQAshW3X4Fv1ikG2Il8wjZT7UBlgT4fs7lX3k7JId23kWOWzJp7QGlR8/cuEecYnJB+DxF8HR0kNjrxB8DxhWgjmle8UdMNal8rSXApJ+ML9IKizT+sR5L3LtyF7J5D0j6j3wq/K4ag1Xbop401elaCQGSsrn3T2qmIs8xX/Ql/tap587YrNCtFiAmyoYg/7w/HRtoPqEP5v2rz8rBxY7CDSNLDTPm14zZf1M0ejPnejlyeF2fsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/2jB/7rHo4H+rkTxAqvFMGjOBgrmJIZTDUNOrMcUCUo=; b=Ve89jTBr6nN7hIpTMBdjrWROKm0Af3NyqOdsMN5KmJfiP53ulSI+YUoErfjL/EcWMKbK72buTbVmJQaMfAtPy4qrqjsJrniZGd6eun56c99ywIHfqMc7vPJMnAFBMBeIAp4J8Uy6z5GZOJXeicNKNsp5Uyv20n1JMwB4YrkJfK1V+bWGyGPBTYAC0Zl9NXYoNWphRdhiWnYhyJA+vc/Qc6Jc7UKC4hitwuczx4WrFYTo0cP3RkWkAXXfd84RPBZuE3orjQZ/juHbIZMl2Bnn4cOUVuLFXoLKYHwkUpvkxl37C7dUhbYGFrxEWC4HeRsaa+7S0SSfPUM6nTyLLDU6Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/2jB/7rHo4H+rkTxAqvFMGjOBgrmJIZTDUNOrMcUCUo=; b=KCK8Io/3BybpdfPhLo6K7FaOiPD8e0QcSI4u37iVyUTKWUxkPgmdeJltb6wYUq26cx/MREW/WakQqYGxF0iqACMelyYhcPTtYvJeR7Fh9/9yHg6zGQikZ5YWM0nbzisDSTJyDrOP5EyBfcym9wZCWoIwFzr7eJaCrJV6LQw8uE0= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0165.namprd21.prod.outlook.com (2603:10b6:903:b9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.6; Fri, 10 Apr 2020 23:56:00 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%12]) with mapi id 15.20.2921.009; Fri, 10 Apr 2020 23:55:59 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "oleksiyy@ami.com" CC: "liming.gao@intel.com" , "Kinney, Michael D" , "Felixp@ami.com" , "oleksiyy@ami.com" Subject: Re: [EXTERNAL] [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image Header extension Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image Header extension Thread-Index: AQHWD3KDR1qB//tSjkeGL0S2+rxGSKhzCDKP Date: Fri, 10 Apr 2020 23:55:59 +0000 Message-ID: References: <20200410195803.19972-1-oleksiyy@ami.com>,<20200410195803.19972-5-oleksiyy@ami.com> In-Reply-To: <20200410195803.19972-5-oleksiyy@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-04-10T23:55:43.1559574Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0ebf22e4-1446-4e61-03b0-08d7ddaab824 x-ms-traffictypediagnostic: CY4PR21MB0165:|CY4PR21MB0165: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0369E8196C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(6506007)(71200400001)(55016002)(82950400001)(26005)(66446008)(10290500003)(966005)(82960400001)(186003)(316002)(9686003)(7696005)(4326008)(81156014)(86362001)(478600001)(66556008)(8936002)(8990500004)(66946007)(110136005)(53546011)(54906003)(8676002)(33656002)(5660300002)(2906002)(64756008)(66476007)(76116006)(52536014)(91956017);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BrlVagbjZrcjTFGYyr5GMYKGFLdgZZWsdvScfTxpEBdhQUnTMN6UTtE+oLa5H3I3tiUGRDXfVRmSMuBQsvQE2y7pjJrXz3oLeUNqs8/Q7nC4hnBCKRQEhZ/xQ2z7NW4M6GLsR4YazwdKnWIXjVUNkiVjNOGHR95E1hve8vnuxNa4+iRJeRPdhJmJQbI5Bqf1HtbrQIjY04822SrtTV9SR02wKlr214b9b0DDhCCv2AESz4l6mjd1TShFPCumaV7FtWld+bTfjh+vTZ2XDR2ahq3qxLHlghRjscy6uKo10Yz6D3/mQ1APpvW76oxe9XmwchOLqpUvS5XHxwZeWL52GnWt/K8uv9HOhx8/5kDTwe8LQKRlTfw25X5WrY+cFDlb4CCbDCSkSw6s0zlrQakxucybNPyrMPcRtPfnKHWCqmw0phv+m0B3V2icQbqa/HzK4yzdYSp9eAyf2b0V8rcbGxwuToXa5FNbRCgLd5CigaFD8HNcGmfCppod/E19ThSE37pkaTbzp7x+TZTlb5EXZw== x-ms-exchange-antispam-messagedata: Qcg3SYe+JXZgRUUpuK7oeiCCWybQfd9nj0PfZFv0XSLD7HuQrsQGue1gHuQ7xh2Bvr9iWm72tUi6PqcpjnFGCrzxlVu1wOV0/WIhNGhA1N6aEN8F/gAfjnnLP/lMkFF0+aFmQv7+tJ+WHlFS4h6Fwg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ebf22e4-1446-4e61-03b0-08d7ddaab824 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2020 23:55:59.8481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P/gPixWpa43GnEQzQ1ru3owRXKCo/D2A2pIqzypiTNbKzkBMbZFz7YftFA60Ds0Fy60Y1Cj6/tJDIqh/0ImbEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0165 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB0743755D419197C4F73CF254EFDE0CY4PR21MB0743namp_" --_000_CY4PR21MB0743755D419197C4F73CF254EFDE0CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret ________________________________ From: devel@edk2.groups.io on behalf of Oleksiy Yak= ovlev via groups.io Sent: Friday, April 10, 2020 12:58:03 PM To: devel@edk2.groups.io Cc: liming.gao@intel.com ; Kinney, Michael D ; Felixp@ami.com ; oleksiyy@ami.com Subject: [EXTERNAL] [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsule Image= Header extension Add bitmask to structure which gives a binary-inspectable mechanism to det= ermine if a capsule contains an authentication section or depex section. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/FmpCapsule.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Guid/FmpCapsule.h b/MdePkg/Include/Guid/FmpCap= sule.h index fb8c346..6bbdf0e 100644 --- a/MdePkg/Include/Guid/FmpCapsule.h +++ b/MdePkg/Include/Guid/FmpCapsule.h @@ -79,13 +79,22 @@ typedef struct { /// therefore can be modified without changing the Auth data. /// UINT64 UpdateHardwareInstance; + + /// + /// A 64-bit bitmask that determines what sections are added to the pay= load. + /// #define CAPSULE_SUPPORT_AUTHENTICATION 0x0000000000000001 + /// #define CAPSULE_SUPPORT_DEPENDENCY 0x0000000000000002 + /// + UINT64 ImageCapsuleSupport; } EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER; #pragma pack() #define EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER_INIT_VERSION 0x00000= 001 -#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION 0x00000= 002 +#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION 0x00000= 003 +#define CAPSULE_SUPPORT_AUTHENTICATION 0x0000000000000001 +#define CAPSULE_SUPPORT_DEPENDENCY 0x0000000000000002 extern EFI_GUID gEfiFmpCapsuleGuid; -- 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be rea= d only by the individual or entity to whom it is addressed or by their desi= gnee. If the reader of this message is not the intended recipient, you are = on notice that any distribution of this message, in any form, is strictly p= rohibited. Please promptly notify the sender by reply e-mail or by telepho= ne at 770-246-8600, and then delete or destroy all copies of the transmissi= on. --_000_CY4PR21MB0743755D419197C4F73CF254EFDE0CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@micros= oft.com>

 

- Bret

 

From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Oleksiy Yakovlev via groups.io &= lt;oleksiyy=3Dami.com@groups.io>
Sent: Friday, April 10, 2020 12:58:03 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: liming.gao@intel.com <liming.gao@intel.com>; Kinney, Mich= ael D <michael.d.kinney@intel.com>; Felixp@ami.com <Felixp@ami.com= >; oleksiyy@ami.com <oleksiyy@ami.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH 4/4] MdePkg: Add FMP Capsul= e Image Header extension
 
Add bitmask to structure which gives a binary-ins= pectable mechanism to determine
if a capsule contains an authentication section or depex section.
(UEFI 2.8 errata a, mantis 2026)

Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
---
 MdePkg/Include/Guid/FmpCapsule.h | 11 ++++++= ++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Guid/FmpCapsule.h b/MdePkg/Include/Guid/FmpCap= sule.h
index fb8c346..6bbdf0e 100644
--- a/MdePkg/Include/Guid/FmpCapsule.h
+++ b/MdePkg/Include/Guid/FmpCapsule.h
@@ -79,13 +79,22 @@ typedef struct {
   /// therefore can be modified without changing the Auth data.=
   ///
   UINT64   UpdateHardwareInstance;
+ 
+  ///
+  /// A 64-bit bitmask that determines what sections are added t= o the payload.
+  /// #define CAPSULE_SUPPORT_AUTHENTICATION 0x0000000000000001<= br> +  /// #define CAPSULE_SUPPORT_DEPENDENCY 0x0000000000000002
+  ///
+  UINT64   ImageCapsuleSupport;
 } EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER;
 
 #pragma pack()
 
 
 #define EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER_INIT_VERSION &nb= sp;     0x00000001
-#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION 0x00000= 002
+#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION 0x0= 0000003
+#define CAPSULE_SUPPORT_AUTHENTICATION    0x0000000000= 000001
+#define CAPSULE_SUPPORT_DEPENDENCY      = ;  0x0000000000000002
 
 extern EFI_GUID gEfiFmpCapsuleGuid;
 
--
2.9.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI).  This communication is intended to b= e read only by the individual or entity to whom it is addressed or by their= designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of= this message, in any form, is strictly prohibited.  Please promptly n= otify the sender by reply e-mail or by telephone at 770-246-8600, and then = delete or destroy all copies of the transmission.



--_000_CY4PR21MB0743755D419197C4F73CF254EFDE0CY4PR21MB0743namp_--