Reviewed-by: Bret Barkelew - Bret ________________________________ From: devel@edk2.groups.io on behalf of Michael D Kinney via Groups.Io Sent: Monday, March 23, 2020 1:14:28 PM To: devel@edk2.groups.io ; Bret Barkelew ; Jiang, Guomin ; Kinney, Michael D Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR HI Bret, You reposted the issue in BZ, so your review is very valuable to make sure the change proposed addresses the issue reported. Reviews by Maintainers/Reviewers documented in Maintainers.txt are required to do the commit, but we welcome reviews from anyone in the community that wants to provide input in any changes. Thanks, Mike From: devel@edk2.groups.io On Behalf Of Bret Barkelew via Groups.Io Sent: Monday, March 23, 2020 12:50 PM To: devel@edk2.groups.io; Jiang, Guomin Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Looks good to me, but I’m not an official reviewer. - Bret ________________________________ From: devel@edk2.groups.io > on behalf of Guomin Jiang via Groups.Io > Sent: Wednesday, March 18, 2020 6:33:43 AM To: devel@edk2.groups.io > Subject: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=PqgTLSHlFecHZWmVyxA1f4BJDiRkOxrBLSpVQV%2B5bcI%3D&reserved=0 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni > Cc: Rangasai V Chaganty > Signed-off-by: Guomin Jiang > --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice != NULL); + ASSERT(NewPciDevice != NULL); NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment = PciSegment; -- 2.25.1.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56082): https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F56082&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=QTZLYm%2FZa%2BnAHSoQG%2BJDbjDu5KMYyWjXYtJuLr6bW3U%3D&reserved=0 Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.io%2Fmt%2F72484273%2F1852292&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=Xi5DewUud2C5gHqx1clGGcNnJ7cZFaPPJV2RlKnQ2gI%3D&reserved=0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=YBaUMmZLuEmg64IxWcwicaqnJZlq3RtG3CAXJvAK1%2Fk%3D&reserved=0 [bret.barkelew@microsoft.com] -=-=-=-=-=-=