From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.94]) by mx.groups.io with SMTP id smtpd.web12.729.1585070367452817874 for ; Tue, 24 Mar 2020 10:19:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=aVfO4b7q; spf=pass (domain: microsoft.com, ip: 40.107.93.94, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TOvSyiZA9T3GWBZ+Do16yFxc8tfB/CUKnC/MMYAZXCDgv5yh1I2KAOP7EOALiCEkSLqhIXBlrvU/I4qCpasQHV+SWI2c0CU9PmOh8gmxBaiVnPAZ2XHOXAXv8VNXcmj41Dh2vX8gIy024WN5v7hnBqCy6i4/lJmqzzELSQiYEDqFcyIn8PcjhDSM99MHp3n6v7panzMwnmgDDtXMyL0jaYWJiQhzkFnHjgXES0N4dbANlgqn0bjAjDp72JMi9I9DZbIzfIFgXm1+JXK+XQLF/whE2UHsc5arV2QbTs1gewUakM98SP7rTYm+oqYGWpbRqHTTPXeu262wOyJ5AtADTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qK5dpA6Flrg7NRTAwbtDFp9GDqqD9NTkkFa3mmiD10A=; b=f85lsySWFVnmhcitgFI0KqdVuyaQNLzo0HU+ycwejwEGnGrcpU1zZMJMk7UmIDQ/ZxUCTWF/6SCYUSkfiAe4qBXvT7by1sjYxiKveEB4KNNWb5kvL1fwf5/A05+E8Qkzre+US8E65DYEiCmImoW6zsam7RLBGU2hwfL7LPOWCBREHqlvZJqxWH7lAOErDJ5Um7Mla5P8r9NiWMzrc/5QthlaV46AmOlNb9jY/zCBqGlMzRqNUH+U2gkQlG9dBaE9kntWIlpsofdv8a+W6bPEQhioKsIrCRPLqg8bnbsykc2NdbuHJn8rYMbUVrvOFzIlrsPh7oC1fisUXzRidmM6zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qK5dpA6Flrg7NRTAwbtDFp9GDqqD9NTkkFa3mmiD10A=; b=aVfO4b7qVDGrTyQYgC0AqZjPXYZUxoEw79UILvhSuEPb0eqfjipYPFn2x/2cuSF3GtL9raazJVOLFLvpXi7tY8x3WJzRHhZteRcdEd7+7UTWArS7lqxQa3uVHRn0l5MFncNytbylzOOOP0cm91xGA/bTyYTXYmVdU2XAyVO5uy0= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0184.namprd21.prod.outlook.com (2603:10b6:903:ba::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.2; Tue, 24 Mar 2020 17:19:26 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::90d:10d9:c5bc:5318%10]) with mapi id 15.20.2878.000; Tue, 24 Mar 2020 17:19:26 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "Kinney, Michael D" , "Jiang, Guomin" Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Thread-Topic: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Thread-Index: AQHWAMH9SnM7WxMvG0OgZ2xQZfimgqhWltJagAAG+QCAAWFdJA== Date: Tue, 24 Mar 2020 17:19:26 +0000 Message-ID: References: <20200318133343.393-1-guomin.jiang@intel.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-03-23T19:49:30.1401322Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [71.212.145.195] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: cb66a135-5c9d-4de2-4e51-08d7d01780ec x-ms-traffictypediagnostic: CY4PR21MB0184:|CY4PR21MB0184: x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:218; x-forefront-prvs: 03524FBD26 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(136003)(346002)(376002)(396003)(39860400002)(366004)(2906002)(966005)(26005)(8990500004)(8936002)(8676002)(76236002)(81166006)(186003)(81156014)(71200400001)(7696005)(53546011)(6506007)(66946007)(33656002)(9686003)(19627235002)(86362001)(5660300002)(52536014)(478600001)(316002)(55016002)(10290500003)(76116006)(91956017)(110136005)(66446008)(64756008)(66476007)(66556008)(213903007);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0184;H:CY4PR21MB0743.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kMyzWgtPSwGsz1EYC4uyqM72ApujcO42w5UKnenD56QzwD+JVY5cgstcxUD4+fUyFqP2t78rrwFLikhUnMP28xjCRD7yrbujEpBiYXpyLU+aMH78A1oqv/FQ05cyaJqqEm3pP9ey732wJGm2BiNA5GQPgW+Md2/3DuJyseBVIaE0UldzuVpJMaiqSBQZrTO4nyU1em5T85lue1SZQH/D9jDQqGR2tungmhR6c29aT4XRo31dsrBbqBZc5NNSDU7xyvNOor/jmGPGUi7n2Qjkz3xdpzH/92RB2uomQvw0klr2H6urWFeQTC23PJ0fLi6DgL0B9GB11myCqHQz5lsoam8Bdyow0THyZPfWUnc9+1+8QeXR4DXdcMIATaqAgpPTCnE9wHwZxTyUnYHhd3V75TDFrUZ/w/D1XHexT8GygxjsmfVMXLt6MRSqq6Lpa13W5CXvOJ7KA6Qm5BmsVZYMiW9gs2rs1KShhPxIs7s3IDyx9m39VzL7dWPxP9YzXzdzqgYEM9vObFW+LfkWldevOAsPc9jBdi8LiuYqfu0fyfK5EGkFQLjQxyXOUR2+QGVk x-ms-exchange-antispam-messagedata: AgWGFHLTsEsRK5hzv6hskG91eipmhHLX9IadUe+IitFWjCz0aGiBrO7hGuYfDtSbld6Um8E/QP2Gf5lEi4pFRnFB9pr7iKEatKi8NwdpY/phZL/bT4Xk8YccViM6jBF33bwCc9if5WF7k7uKPkr4kA== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb66a135-5c9d-4de2-4e51-08d7d01780ec X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2020 17:19:26.0740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f7QGagru3iMBqjNJEm7yRAehU5BEDXXNSYhI1/onRIP+7iWOX0yaReM7DYq5Z4vwB96rjCclENuqD5m4vzK9Wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0184 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB074382167D85AA1584726BE4EFF10CY4PR21MB0743namp_" --_000_CY4PR21MB074382167D85AA1584726BE4EFF10CY4PR21MB0743namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret ________________________________ From: devel@edk2.groups.io on behalf of Michael D K= inney via Groups.Io Sent: Monday, March 23, 2020 1:14:28 PM To: devel@edk2.groups.io ; Bret Barkelew ; Jiang, Guomin ; Kinney, Michael= D Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconP= kg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR HI Bret, You reposted the issue in BZ, so your review is very valuable to make sure= the change proposed addresses the issue reported. Reviews by Maintainers/Reviewers documented in Maintainers.txt are require= d to do the commit, but we welcome reviews from anyone in the community tha= t wants to provide input in any changes. Thanks, Mike From: devel@edk2.groups.io On Behalf Of Bret Barkel= ew via Groups.Io Sent: Monday, March 23, 2020 12:50 PM To: devel@edk2.groups.io; Jiang, Guomin Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconP= kg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Looks good to me, but I=92m not an official reviewer. - Bret ________________________________ From: devel@edk2.groups.io > on behalf of Guomin Jiang via Groups.Io <= guomin.jiang=3Dintel.com@groups.io> Sent: Wednesday, March 18, 2020 6:33:43 AM To: devel@edk2.groups.io > Subject: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/I= ntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fb= ugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&data=3D02%7C01%7Cbret.= barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f14= 1af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=3DPqgTLSHlFecHZW= mVyxA1f4BJDiRkOxrBLSpVQV%2B5bcI%3D&reserved=3D0 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni > Cc: Rangasai V Chaganty > Signed-off-by: Guomin Jiang > --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDe= viceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg= /Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSec= urityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSec= urityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL); + ASSERT(NewPciDevice !=3D NULL); NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment =3D PciSegment; -- 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56082): https://nam06.safelinks.protection.outlook.com= /?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F56082&data= = =3D02%7C01%7Cbret.barkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91= c8d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sda= ta=3DQTZLYm%2FZa%2BnAHSoQG%2BJDbjDu5KMYyWjXYtJuLr6bW3U%3D&reserved=3D0<= https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Fmessage%2F56082&data=3D02%7C01%7Cbret.barkelew%40micr= osoft.com%7C27c3371c0a364eda10b408d7cf66cc83%7C72f988bf86f141af91ab2d7cd011= db47%7C1%7C0%7C637205912748490183&sdata=3DULlDO3aFdDxpXDdcyn%2BElfHdxc2Vw9V= dcaEGriAXff4%3D&reserved=3D0> Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=3Dhtt= ps%3A%2F%2Fgroups.io%2Fmt%2F72484273%2F1852292&data=3D02%7C01%7Cbret.ba= rkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=3DXi5DewUud2C5gHqx= 1clGGcNnJ7cZFaPPJV2RlKnQ2gI%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3= A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D02%7C01%7Cbret.barkele= w%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab= 2d7cd011db47%7C1%7C0%7C637205304196996734&sdata=3DYBaUMmZLuEmg64IxWcwic= aqnJZlq3RtG3CAXJvAK1%2Fk%3D&reserved=3D0 [bret.b= arkelew@microsoft.com] -=3D-=3D-=3D-=3D-=3D-=3D --_000_CY4PR21MB074382167D85AA1584726BE4EFF10CY4PR21MB0743namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@micros= oft.com>

 

- Bret

 

From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of Michael D Kinney via Groups.Io &= lt;michael.d.kinney=3Dintel.com@groups.io>
Sent: Monday, March 23, 2020 1:14:28 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Bret Barkele= w <Bret.Barkelew@microsoft.com>; Jiang, Guomin <guomin.jiang@intel= .com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelS= iliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
 

HI Bret,

 

You reposted the issue in BZ, so= your review is very valuable to make sure the change proposed addresses th= e issue reported.

 

Reviews by Maintainers/Reviewers= documented in Maintainers.txt are required to do the commit, but we welcom= e reviews from anyone in the community that wants to provide input in any c= hanges.

 

Thanks,

 

Mike

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bret Barkelew via Groups.Io
Sent: Monday, March 23, 2020 12:50 PM
To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com&= gt;
Subject: Re: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelS= iliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

 

Looks good to me, but I=92m not an official revie= wer.

 

- Bret

 

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf o= f Guomin Jiang via Groups.Io <guomin.jiang=3Dintel.com@groups.io>
Sent: Wednesday, March 18, 2020 6:33:43 AM
To: devel@edk2.groups.io <devel@edk2.groups.io><= br> Subject: [EXTERNAL] [edk2-devel] [edk2-platforms][PATCH] IntelSilic= onPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

 

R= EF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2589&amp;data=3D02%7C01%7Cbret.b= arkelew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637205304196996734&amp;sdata=3DPqgTLSHlFec= HZWmVyxA1f4BJDiRkOxrBLSpVQV%2B5bcI%3D&amp;reserved=3D0

According to code logic, it just judge the condition rather than the
status, it should use the ASSERT rather than ASSERT_EFI_ERROR.

Cc: Ray Ni <ray.ni@intel.com>= ;
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Guomin Jiang <= guomin.jiang@intel.com>
---
 .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c  = ;     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDe= viceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg= /Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c=
index 29b6916f61..aa2bf14fa8 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSec= urityDxe/IntelPciDeviceSecurityDxe.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/Intel= PciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
@@ -69,7 +69,7 @@ RecordPciDeviceInList(
   ASSERT_EFI_ERROR(Status);

 

   NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice));

-  ASSERT_EFI_ERROR(NewPciDevice !=3D NULL);

+  ASSERT(NewPciDevice !=3D NULL);

 

   NewPciDevice->Signature   =3D PCI_DEVICE_INSTANC= E_SIGNATURE;

   NewPciDevice->PciSegment  =3D PciSegment;

--
2.25.1.windows.1


-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56082): https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.g= roups.io%2Fg%2Fdevel%2Fmessage%2F56082&amp;data=3D02%7C01%7Cbret.barkel= ew%40microsoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91a= b2d7cd011db47%7C1%7C0%7C637205304196996734&amp;sdata=3DQTZLYm%2FZa%2BnA= HSoQG%2BJDbjDu5KMYyWjXYtJuLr6bW3U%3D&amp;reserved=3D0
Mute This Topic: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroups= .io%2Fmt%2F72484273%2F1852292&amp;data=3D02%7C01%7Cbret.barkelew%40micr= osoft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011= db47%7C1%7C0%7C637205304196996734&amp;sdata=3DXi5DewUud2C5gHqx1clGGcNnJ= 7cZFaPPJV2RlKnQ2gI%3D&amp;reserved=3D0
Group Owner: devel+o= wner@edk2.groups.io
Unsubscribe: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.g= roups.io%2Fg%2Fdevel%2Funsub&amp;data=3D02%7C01%7Cbret.barkelew%40micro= soft.com%7C4480a52ff6784232720d08d7ced91c8d%7C72f988bf86f141af91ab2d7cd011d= b47%7C1%7C0%7C637205304196996734&amp;sdata=3DYBaUMmZLuEmg64IxWcwicaqnJZ= lq3RtG3CAXJvAK1%2Fk%3D&amp;reserved=3D0  [bret.barkelew@microsoft.com]
-=3D-=3D-=3D-=3D-=3D-=3D

--_000_CY4PR21MB074382167D85AA1584726BE4EFF10CY4PR21MB0743namp_--