From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Navdeeppal.Singh@dell.com" <Navdeeppal.Singh@dell.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [EXTERNAL] [edk2-devel] EDK2 environment setup
Date: Thu, 23 Apr 2020 18:23:48 +0000 [thread overview]
Message-ID: <CY4PR21MB0743835F6CED2A9D23F32E12EFD30@CY4PR21MB0743.namprd21.prod.outlook.com> (raw)
In-Reply-To: <MN2PR11MB4461D1F8A540AD28A52BF5D1D2D30@MN2PR11MB4461.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 5703 bytes --]
I’ll play with it a little and see if the pipelines/documentation needs to change. Thanks!
- Bret
________________________________
From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Thursday, April 23, 2020 10:26:32 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Navdeeppal.Singh@dell.com <Navdeeppal.Singh@dell.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup
Bret,
I wonder if this is an order of operations issue.
Those 2 commits convert Brotli support to submodules. One for the FW decompress lib, and the other for the compression tool. The patch adds both submodule links to CISettings.py and we know that works for FW components. However, this may be the first time it is used for a C tool in BaseTools.
In order for BaseTool/EDK2ToolsBuild.py to complete, all the sources need to be present. So does CISettings.py need to be processed before running BaseTool/EDK2ToolsBuild.py?
Mike
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bret Barkelew via groups.io
Sent: Thursday, April 23, 2020 9:34 AM
To: Navdeeppal.Singh@dell.com; devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [EXTERNAL] [edk2-devel] EDK2 environment setup
Confirmed that it seems related to these two commits:
https://github.com/tianocore/edk2/commit/58802e02c41bd715a5d3586f4bf2a4b1c46e9274<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2F58802e02c41bd715a5d3586f4bf2a4b1c46e9274&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C766c0b1bef7145e0acd208d7e7ab8f7a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637232596365128994&sdata=2VhPZnY3MDipJb7E4PhnTCFu7a0cpZfhr0KjjyN1FU0%3D&reserved=0>
https://github.com/tianocore/edk2/commit/06033f5abad3815e8d80de22c97ba38a05017262<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2F06033f5abad3815e8d80de22c97ba38a05017262&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C766c0b1bef7145e0acd208d7e7ab8f7a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637232596365138987&sdata=crxrT6K7r3uiTfSLXH2BRHyIT1tOgcswd1E77yliQ0U%3D&reserved=0>
If I roll back to the commit prior, the Tools build works. Anyone involved in BaseTools have an idea? @Feng, Bob C<mailto:bob.c.feng@intel.com> or @Liming Gao<mailto:liming.gao@intel.com>?
- Bret
From: Navdeeppal.Singh@dell.com<mailto:Navdeeppal.Singh@dell.com>
Sent: Thursday, April 23, 2020 9:21 AM
To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup
I will roll back to 202002 stable tag and try.
Thank you
Navdeep
From: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>
Sent: Thursday, April 23, 2020 9:48 PM
To: Singh, Navdeeppal; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup
[EXTERNAL EMAIL]
Yeah, I was noticing some problems with BrotliCompress the other day. Seems like a relatively recent change. I know the 202002 stable tag was fine.
I’ll try to dig into this a bit. Thanks for bring it to our attention!
- Bret
From: Navdeeppal.Singh@dell.com<mailto:Navdeeppal.Singh@dell.com>
Sent: Thursday, April 23, 2020 9:14 AM
To: Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup
Hi Bret,
Yes PIP requirements are up to date.
On further digging through the logging file BASETOOLS_BUILD.txt.
INFO - subprocess not exit successfully
INFO - Error while execute command 'nmake all' in direcotry C:\edk2\BaseTools\Source\C\BrotliCompress
Regards,
Navdeep
From: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>
Sent: Thursday, April 23, 2020 9:37 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Singh, Navdeeppal
Subject: RE: [EXTERNAL] [edk2-devel] EDK2 environment setup
[EXTERNAL EMAIL]
Have you installed the up-to-date Python requirements? “pip install –upgrade -r pip-requirements.txt”?
That’s the first thing I would check. Otherwise, happy to look at the problem with you.
- Bret
From: NAVDEEPPAL_SINGH via groups.io<mailto:NAVDEEPPAL_SINGH=DELL.COM@groups.io>
Sent: Thursday, April 23, 2020 6:05 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [EXTERNAL] [edk2-devel] EDK2 environment setup
I am trying to setup EDK2 environment setup from Tianocore/EDK2.
While doing the Base Tool setup. After running BaseTool/EDK2ToolsBuild.py -t VS2019
Getting following error :-
c:\edk2\BaseTools>python Edk2ToolsBuild.py -t VS2019
SECTION - Init SDE
SECTION - Loading Plugins
SECTION - Start Invocable Tool
Traceback (most recent call last):
File "Edk2ToolsBuild.py", line 177, in <module>
main()
File "Edk2ToolsBuild.py", line 173, in main
Edk2ToolsBuild().Invoke()
File "C:\Program Files\Python38\lib\site-packages\edk2toolext\base_abstract_invocable.py", line 141, in Invoke
retcode = self.Go()
File "Edk2ToolsBuild.py", line 139, in Go
raise Exception("Failed to build.")
Exception: Failed to build.
set EDK_TOOLS_PATH=C:\edk2\BaseTools
set EDK_TOOLS_BIN=C:\edk2\BaseTools\Bin\Win32
Can some one help
[-- Attachment #2: Type: text/html, Size: 12666 bytes --]
next prev parent reply other threads:[~2020-04-23 18:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 12:38 EDK2 environment setup NAVDEEPPAL_SINGH
2020-04-23 16:07 ` [EXTERNAL] [edk2-devel] " Bret Barkelew
2020-04-23 16:14 ` Navdeeppal.Singh
2020-04-23 16:17 ` Bret Barkelew
2020-04-23 16:21 ` Navdeeppal.Singh
2020-04-23 16:34 ` Bret Barkelew
2020-04-23 17:26 ` Michael D Kinney
2020-04-23 18:23 ` Bret Barkelew [this message]
2020-04-23 19:03 ` Sean
2020-04-27 8:26 ` Navdeeppal.Singh
2020-04-27 20:57 ` Sean
2020-04-28 9:15 ` Navdeeppal.Singh
2020-04-28 9:35 ` Guomin Jiang
2020-04-28 9:47 ` Leif Lindholm
2020-04-28 9:52 ` Navdeeppal.Singh
2020-04-30 5:09 ` Navdeeppal.Singh
2020-05-04 5:17 ` Navdeeppal.Singh
2020-05-04 17:40 ` Sean
2020-05-04 18:47 ` Andrew Fish
2020-04-28 9:38 ` [edk2-devel] EmulatorPkg WinHost build failure with VS2019 Was: " Leif Lindholm
2020-04-23 16:23 ` [EXTERNAL] [edk2-devel] " jim slaughter
2020-04-23 16:27 ` Bret Barkelew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR21MB0743835F6CED2A9D23F32E12EFD30@CY4PR21MB0743.namprd21.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox