From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.92]) by mx.groups.io with SMTP id smtpd.web11.307.1582166540060078205 for ; Wed, 19 Feb 2020 18:42:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=W2GUkXzQ; spf=pass (domain: microsoft.com, ip: 40.107.223.92, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cJasjoFlpCdrSCUKN36RAWBhWKtcfFMX4s9ZMc2PompjQAhTJpwZ9mafV3i7sYd1LNIj4aapPgWHCL+fzgE/PsAG+i6WdwGc7IEyRSzTgfwiHmyET+6VPeei9wv07BuKioFjkLAoLz7f5MSY1IccYjOHrMmjbli0CRF5e+/5q1GWpV1Q2eOCvErZNpLet+7hMU6sU7acVDXWFlC1mlYf2TS04V1/6aFogEb1aKhEwBQHJmSqNywuDC3cDOtIgm7nfu/qjWKNHbZPnVQ4WQo/qoBdUOcuNBKCUmZx+4sRohcSh/a24IQJY4Q+XKpKFjDzLoDlQOGuLCVDWtYVNB+E0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwAxS+CFA2p5gRKzLQ9Twk2Jj3WjlRub+UIpUjLqMJU=; b=N58ZcWeAVBvrXBl14YaNNkZJCPP6yC4Z1u4IQzFOyEKaBSBDXaoLoFb1404Z4s1jELqFD8NZA/aiZT1cjoaixfIe58wLD6QPvTHPW80TWdeRcttovA3qlNMOdKRuYltpw7UqdVzr9MlBRMsLwABjiHmUklWWm0zhG6Nf6gBAcl4WNjAZzFcEWbBg5jAYq96ZsjynQ81szL4GkDnNWXFwy+BUQoiQ+5Uvptq/ZktFtyGkjoJJ/IohXe8O9XVzvd8Mve/3OOuUh1kFRkAIcuvJXvAimNR4VHq8l1tPk47dW5wazAwhRi2baFqlTsyicCIQ3S8yQWIy0gY6MKTDCKZhZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwAxS+CFA2p5gRKzLQ9Twk2Jj3WjlRub+UIpUjLqMJU=; b=W2GUkXzQhtv8nBiyhFZARF2UiFClG+Q2N7JbGkBancRLNcYWQFPdvc+F6x+yAYPsfkeQAeBATJV+jgHB+iFkGPlJSXeVCIig/rieVYrj4wbJwcr6kFCqeOxGvnKo35Gz7OzNwS7PIa2bemdP2HOcRCHHprt5RhmjWvqOSvEFa2U= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0152.namprd21.prod.outlook.com (2603:10b6:903:b2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.3; Thu, 20 Feb 2020 02:42:18 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9118:22ef:23c:d0ab]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9118:22ef:23c:d0ab%9]) with mapi id 15.20.2772.006; Thu, 20 Feb 2020 02:42:18 +0000 From: "Bret Barkelew" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" CC: GuoMinJ Subject: Re: [EXTERNAL] [edk2-devel] [PATCH] UnitTestFrameworkPkg: Suspicious check for pointer Suite Thread-Topic: [EXTERNAL] [edk2-devel] [PATCH] UnitTestFrameworkPkg: Suspicious check for pointer Suite Thread-Index: AQHV5s2Y45Txlh00mkqP5tkNkGS4m6gjYRjP Date: Thu, 20 Feb 2020 02:42:18 +0000 Message-ID: References: <688166e8ec46f20a29ffedb8703ca7d94059b483.1582079674.git.newexplorerj@gmail.com> In-Reply-To: <688166e8ec46f20a29ffedb8703ca7d94059b483.1582079674.git.newexplorerj@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-02-20T02:42:10.6027601Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [174.21.64.62] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 96d49462-ccca-47a3-86be-08d7b5ae80b7 x-ms-traffictypediagnostic: CY4PR21MB0152: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(366004)(199004)(189003)(5660300002)(8676002)(81166006)(8990500004)(4326008)(110136005)(9686003)(55016002)(71200400001)(81156014)(33656002)(8936002)(86362001)(26005)(52536014)(53546011)(6506007)(186003)(7696005)(2906002)(76116006)(66946007)(66556008)(64756008)(66446008)(66476007)(498600001)(10290500003)(966005);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0152;H:CY4PR21MB0743.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LvF166HuxCUDjyhFT0sxnMTa2JoZPxv63+kMSRj/JbJ9VVeXgGLXyTXgKiDdI78I7R70M+ZfGrhRkf0qVKhAJHXbfiXl7677IR+eJzUeHqmVT/b7kkXNGRscyAJiq7o0dpBgVnzi7Zm9zpyGaVO/BayXfikg35BB4OfA8ZqE/7pVsAE1m+ADPHX3nS3gNg2y7OMyIMxC3KhG/DMjSYolauzYpsDXkOgKVni/nNS+9C3YSSrLRHrciPoapngNm2uQno/TdImOY+ENTKzSSYjdb6l0chT2DISjZ1iFNZ4yjBrlFkRIbS2jeLVDCxrdHCTKpm1b7Mx9hKl1EXRgsRskU4jOcsIwWSRWL/MhN/G3xs03LoqUMebYgixlaL1QJLVEnSx3OTEJMo8AjAuisSUmeUZK5B5yxdqiz9rARxWRFdRsEemrxlDogv5YJmLkbkkhYPk0ex+IrUh1Vjk4SN2kZ7SAAfK3Iu/2Ak2Hh/QGZdf4oaI7GbvY68jG64mfal3RuhpMZtIEg6RHKTBhBhSCAg== x-ms-exchange-antispam-messagedata: KsWmiX8CphVHGPAH/sHHvM85+4MpTMLa+8/RxAf7HEQdSBp9l7tfxVy9nOnkJsKRXSl0qpECSu0jcQzBju1ptFYwdVNQ9xP+3RPcWlASGspqewDZYYWXHiJpOq0XwAqKqj7VUwS3HTUSp3UJjCD0Qg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96d49462-ccca-47a3-86be-08d7b5ae80b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 02:42:18.3793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AA/ScvgRk2U3exzGcuFCoUqSOVldyf/xisyXVjSXzm5QpWAia5pcE2eA99sjb8Qw/NQB1In4NUy+IDgVI6OlVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0152 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB07438CEF4CF8186F93C45417EF130CY4PR21MB0743namp_" --_000_CY4PR21MB07438CEF4CF8186F93C45417EF130CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret ________________________________ From: devel@edk2.groups.io on behalf of GuoMinJ via= Groups.Io Sent: Tuesday, February 18, 2020 6:34:49 PM To: devel@edk2.groups.io Cc: GuoMinJ Subject: [EXTERNAL] [edk2-devel] [PATCH] UnitTestFrameworkPkg: Suspicious = check for pointer Suite REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fb= ugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2530&data=3D02%7C01%7Cbret.= barkelew%40microsoft.com%7Cc3d0da979cc14c97e3ab08d7b4e4b9d0%7C72f988bf86f14= 1af91ab2d7cd011db47%7C1%7C0%7C637176766775311376&sdata=3DeRhhSwb6DcYF9%= 2B%2BTnCe0wzBPvRHTgl0Ue%2BRZ7LCYtxU%3D&reserved=3D0 The Suite pointer is used before check if it is valid, correct it to check the validation before use. Signed-off-by: GuoMinJ --- UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c b/UnitTes= tFrameworkPkg/Library/UnitTestLib/RunTests.c index fb247c59e7..b053e04959 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c @@ -33,13 +33,13 @@ RunTestSuite ( UNIT_TEST *Test; UNIT_TEST_FRAMEWORK *ParentFramework; - TestEntry =3D NULL; - ParentFramework =3D (UNIT_TEST_FRAMEWORK *)Suite->ParentFramework; - if (Suite =3D=3D NULL) { return EFI_INVALID_PARAMETER; } + TestEntry =3D NULL; + ParentFramework =3D (UNIT_TEST_FRAMEWORK *)Suite->ParentFramework; + DEBUG ((DEBUG_VERBOSE, "-----------------------------------------------= ----------\n")); DEBUG ((DEBUG_VERBOSE, "RUNNING TEST SUITE: %a\n", Suite->Title)); DEBUG ((DEBUG_VERBOSE, "-----------------------------------------------= ----------\n")); -- 2.17.1 --_000_CY4PR21MB07438CEF4CF8186F93C45417EF130CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@micros= oft.com>

 

- Bret

 

From: devel@edk2.groups.io= <devel@edk2.groups.io> on behalf of GuoMinJ via Groups.Io <newexp= lorerj=3Dgmail.com@groups.io>
Sent: Tuesday, February 18, 2020 6:34:49 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: GuoMinJ <newexplorerj@gmail.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH] UnitTestFrameworkPkg: Susp= icious check for pointer Suite
 
REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2530&amp;data=3D02%7C01%7Cbret.b= arkelew%40microsoft.com%7Cc3d0da979cc14c97e3ab08d7b4e4b9d0%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637176766775311376&amp;sdata=3DeRhhSwb6DcY= F9%2B%2BTnCe0wzBPvRHTgl0Ue%2BRZ7LCYtxU%3D&amp;reserved=3D0

The Suite pointer is used before check if it is valid,
correct it to check the validation before use.

Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
 UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c | 6 ++&#= 43;---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c b/UnitTes= tFrameworkPkg/Library/UnitTestLib/RunTests.c
index fb247c59e7..b053e04959 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/RunTests.c
@@ -33,13 +33,13 @@ RunTestSuite (
   UNIT_TEST        &nbs= p;    *Test;
   UNIT_TEST_FRAMEWORK   *ParentFramework;
 
-  TestEntry       =3D NULL;
-  ParentFramework =3D (UNIT_TEST_FRAMEWORK *)Suite->ParentFramewo= rk;
-
   if (Suite =3D=3D NULL) {
     return EFI_INVALID_PARAMETER;
   }
 
+  TestEntry       =3D NULL;
+  ParentFramework =3D (UNIT_TEST_FRAMEWORK *)Suite->ParentFra= mework;
+
   DEBUG ((DEBUG_VERBOSE, "--------------------------------= -------------------------\n"));
   DEBUG ((DEBUG_VERBOSE, "RUNNING TEST SUITE: %a\n", = Suite->Title));
   DEBUG ((DEBUG_VERBOSE, "--------------------------------= -------------------------\n"));
--
2.17.1




--_000_CY4PR21MB07438CEF4CF8186F93C45417EF130CY4PR21MB0743namp_--