From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.130]) by mx.groups.io with SMTP id smtpd.web10.205.1594785965611275137 for ; Tue, 14 Jul 2020 21:06:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=acoGWOVt; spf=pass (domain: microsoft.com, ip: 40.107.243.130, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bp3OFb/9Pxb3XBS8lhsM3yPacWiP8Q2qMpbWn+SZSz5CJk+FcZCAxMefHPkjuDa5cc7LLWIuoo3R2N4jBjJpkRW1IvxPgtM4iwmZLl8ez16Id2VnaYnudOZcMDQPov/gkSx3HImS1VImK1OsmjBV+D0/jQs9RQF/ECQFInS4IGeq/r+SQ5kew3RoWlZDN50FThKfZu+EkwrQpMduz8pnpSF66kyCu2exn1E3L83Ed4sw60FrKb3I4GKGiL8Bb9X4h1vGl8gZdTvUJjp5fdJx3z5YjR8/wxV3iwvj7YqTzIEXSxItQ6++QnRRkpweeuhehw1wQZ0QGbw/Qhf1fZnnoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qQDK/uU2HutS6nHTS8UTPySw48UgUbc/R3kccC1tD8w=; b=NA8eBHFcy/zLJuQt+J4WDdy9FpvzW614Ia/TNRIaTVyNRrNJd9voOmZWtr7+XpeNTPVK37sru+o3OaST4i+9vByFvmvko2W3OwYE0SHgKmTeT6AZdqPBxyYz/6DxqigkC7t8Bo5j8KU8hWyTL/On7EaezOXj3ObAkjO0qa45vHfUDrh2FDCV7XMZWj/bS/szqK1tGk340wVen/ToF0BbRmr1fwEWUq/mCX4SpkAbAcJYgJqtmsC7mUoc281dqr6qlECcon17dzf3DDN4xlTNzF/8t6GgUYNpuMJd4JshZj+Io4lfWiohYsOg/rgQBOLfFtlD0QoFgR/zrJTA/q0fdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qQDK/uU2HutS6nHTS8UTPySw48UgUbc/R3kccC1tD8w=; b=acoGWOVtotGsgTBYP3h1DH+HCu/opFJ3rTQGueFtdlnbZQc9rICcyqONP4sFJivv/9WmVTQNXmbAPik5WHReUf070CBw9ZWsGeRdURohCqNxJXRmg4g0G9PUH4mJ60WcQuE2W9KD3I2gFKW8kXzTtsMSjFoqiVi7QZP5wPctfYM= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0504.namprd21.prod.outlook.com (2603:10b6:903:dc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.7; Wed, 15 Jul 2020 04:06:04 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::f112:82fb:d4fd:f7dd]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::f112:82fb:d4fd:f7dd%10]) with mapi id 15.20.3216.008; Wed, 15 Jul 2020 04:06:04 +0000 From: "Bret Barkelew" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sean Brogan , "Yao, Jiewen" Subject: Re: [EXTERNAL] [Patch v3 08/16] UnitTestFrameworkPkg: Set host application stack size to 256KB Thread-Topic: [EXTERNAL] [Patch v3 08/16] UnitTestFrameworkPkg: Set host application stack size to 256KB Thread-Index: AQHWVyhJeXdhAcmcSUWrQDz0tzzZ9qkIDBpz Date: Wed, 15 Jul 2020 04:06:03 +0000 Message-ID: References: <20200711020904.24116-1-michael.d.kinney@intel.com>,<20200711020904.24116-9-michael.d.kinney@intel.com> In-Reply-To: <20200711020904.24116-9-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-07-15T04:05:43.1091984Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.66.92] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d2f0e546-43b6-4718-150f-08d82874648f x-ms-traffictypediagnostic: CY4PR21MB0504: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eYoVvMnVmL4LtrfnM8uCUkZ3KVExFKEHo8Bepw+vbZ4f9oEfxLZ/jYSfoqnmosog1Ow0u5SOrnaIG6WJnTUk/OnS32PlSDJo8QmfoNwBnYGVWhqymvqXOajkg/aT6mUNSyH8I1oULmFxJK62CgkvIsxA0yjlm1BVK4WnyN0pk8vY4dm/Vh6uTVqh2+WnPG0ZwTtk+a4fgETIePby8nPMnFNPAjVJ3Fg1C7PlgrrFY+GUO6NZqpGOoNy+/njkoLIqyOez271SgRbO9DXIuHSx5/NB4/dk4GeGbJBNCmv0bVZWQiiBp80qKfQxG2Ksu1CZKWKlgp8Wy/D6YbsMvjPpHjahyGLe1Yzt0kZwrnsz+q2hNbduVAvlsaGVnWuerR/PuRdmDduCOLvbV2n9ewd0p/ruh5pZTLGoTJzgnDuQFwPa3gJpMIqa5MgfssOI6A8+mGDqdGGQPTppZv4FVYNB1w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(186003)(4326008)(91956017)(316002)(66476007)(82950400001)(6506007)(82960400001)(76116006)(52536014)(66556008)(2906002)(64756008)(110136005)(54906003)(66946007)(8990500004)(166002)(55016002)(53546011)(9686003)(7696005)(86362001)(8676002)(5660300002)(966005)(26005)(83380400001)(10290500003)(71200400001)(478600001)(66446008)(33656002)(8936002)(460985005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: /qimH7i3wktGyNU9/RBlbugIY0yU9NpWQYmAtqYOXvTwVE1w2w1AvsuBfb9uXAWsg3GpMFWv3PNc02djcYdparIoZaC+JlZZhIfm1/0D9t9f5YFhE0OHbQgXSSXO8lG5Mq0sxXYeLqdGbvXoEcqBh3t3RBUtWTzjxDoQnjrptV9kgasVXOVJvEgPbnxSJLFGn4jIP577kI9/wIJRSEGGqJ2b5jVnY+BQcfpBEIJerVN7gwUmjDhAqNH0CGP8cNLSz1V8Y4l00GX/qdkjmVOun2Kr0Xn8A3JBYjUMz5RqMA9/JQer3QsVYujVC5xXrTUiXfu/fpEn9nYFkWOxhw/x+88276BcuBKg/tgavPo+KQz7Q+Nwa8PEtoOpbk4waavxPyU5pzVcKFA+3QYxXMRH5iAcq9YdE34DUhr/NlL87ZbJhO3unwr/EJrBRCZYupZNQCiAGqg+2g8UFb4Jop114iaXDfoiPMA791V8D7pub+M= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR21MB0743.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2f0e546-43b6-4718-150f-08d82874648f X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2020 04:06:03.9292 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uuaSUen0gqu2RAggYyv77WQBQ5H5PH+BKbjIEch9xhmu5Lmnd3RboUnWXORKGK7YLQNOOebcubLCqfU37Yq68A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0504 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB07438EAB4D9610F23845F46FEF7E0CY4PR21MB0743namp_" --_000_CY4PR21MB07438EAB4D9610F23845F46FEF7E0CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney Sent: Friday, July 10, 2020 7:09 PM To: devel@edk2.groups.io Cc: Sean Brogan; Bret Barkelew; Yao, Jiewen Subject: [EXTERNAL] [Patch v3 08/16] UnitTestFrameworkPkg: Set host applica= tion stack size to 256KB REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2803&data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7C6d34207455e9401311c408d8253f6805%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637300301542442718&sdata=3DIhFDMIx%2FIz4DQ= AMJjDmGZo%2FBBZfUFzeYvCbAxbnNTzo%3D&reserved=3D0 The UEFI Specification defines the minimum stack size before ExitBootServices() to be 128KB. When running a host based unit test, there may be additional stack overhead from the host application environment and cmocka. Update the build flags to set the size of the stack to 256KB which is double the UEFI Specification requirement. Cc: Sean Brogan Cc: Bret Barkelew Cc: Jiewen Yao Signed-off-by: Michael D Kinney --- UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTe= stFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc index c4e6e0e0a6..4dd8d4ac67 100644 --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc @@ -30,7 +30,7 @@ [BuildOptions.common.EDKII.HOST_APPLICATION] # # MSFT # - MSFT:*_*_*_DLINK_FLAGS =3D=3D /out:"$(BIN_DIR)\$(BASE_NAME).e= xe" /pdb:"$(BIN_DIR)\$(BASE_NAME).pdb" /IGNORE:4001 /NOLOGO /SUBSYSTEM:CONS= OLE /DEBUG /NODEFAULTLIB:libcmt.lib libcmtd.lib + MSFT:*_*_*_DLINK_FLAGS =3D=3D /out:"$(BIN_DIR)\$(BASE_NAME).e= xe" /pdb:"$(BIN_DIR)\$(BASE_NAME).pdb" /IGNORE:4001 /NOLOGO /SUBSYSTEM:CONS= OLE /DEBUG /STACK:0x40000,0x40000 /NODEFAULTLIB:libcmt.lib libcmtd.lib MSFT:*_*_IA32_DLINK_FLAGS =3D /MACHINE:I386 MSFT:*_*_X64_DLINK_FLAGS =3D /MACHINE:AMD64 -- 2.21.0.windows.1 --_000_CY4PR21MB07438EAB4D9610F23845F46FEF7E0CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@microso= ft.com>

 

- Bret

 

From: Michael D Kinney
Sent: Friday, July 10, 2020 7:09 PM
To: devel@edk2.groups.io=
Cc: Sean Brogan; Bret Barkelew; Yao, Jiewen<= br> Subject: [EXTERNAL] [Patch v3 08/16] UnitTestFrameworkPkg: Set host = application stack size to 256KB

 

REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2803&amp;data=3D02%7C01%7CBret.Ba= rkelew%40microsoft.com%7C6d34207455e9401311c408d8253f6805%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637300301542442718&amp;sdata=3DIhFDMIx%2FIz= 4DQAMJjDmGZo%2FBBZfUFzeYvCbAxbnNTzo%3D&amp;reserved=3D0

The UEFI Specification defines the minimum stack size before
ExitBootServices() to be 128KB.  When running a host based unit
test, there may be additional stack overhead from the host
application environment and cmocka.

Update the build flags to set the size of the stack to 256KB
which is double the UEFI Specification requirement.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTe= stFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
index c4e6e0e0a6..4dd8d4ac67 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
@@ -30,7 +30,7 @@ [BuildOptions.common.EDKII.HOST_APPLICATION]
   #
   # MSFT
   #
-  MSFT:*_*_*_DLINK_FLAGS       &nb= sp;    =3D=3D /out:"$(BIN_DIR)\$(BASE_NAME).exe" /= pdb:"$(BIN_DIR)\$(BASE_NAME).pdb" /IGNORE:4001 /NOLOGO /SUBSYSTEM= :CONSOLE /DEBUG /NODEFAULTLIB:libcmt.lib libcmtd.lib
+  MSFT:*_*_*_DLINK_FLAGS       &nb= sp;    =3D=3D /out:"$(BIN_DIR)\$(BASE_NAME).exe" /= pdb:"$(BIN_DIR)\$(BASE_NAME).pdb" /IGNORE:4001 /NOLOGO /SUBSYSTEM= :CONSOLE /DEBUG /STACK:0x40000,0x40000 /NODEFAULTLIB:libcmt.lib libcmtd.lib=
   MSFT:*_*_IA32_DLINK_FLAGS      &= nbsp;  =3D /MACHINE:I386
   MSFT:*_*_X64_DLINK_FLAGS      &n= bsp;   =3D /MACHINE:AMD64
 
--
2.21.0.windows.1

 

--_000_CY4PR21MB07438EAB4D9610F23845F46FEF7E0CY4PR21MB0743namp_--