From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.91]) by mx.groups.io with SMTP id smtpd.web11.234.1594786040007653089 for ; Tue, 14 Jul 2020 21:07:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=CClxwYf7; spf=pass (domain: microsoft.com, ip: 40.107.243.91, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WbVazqCja1ioKh42OdOXAehIZg7msvQ/RXd0ZUo93/lRzkbnkpsEPpQBb2m4P3Lbdp3I2DYbhXZwOZYN6Yydna9ywV9aVgxmp7kZsu+REzPB+hknoDyxxCBKRBpSzu2uWIXXLsUoqFokLTcpzphoFcXm5CqnJChHcHbya/4nVpk8/et37FBmAg/axnuIHsc4AKvrc6DXg53sKujQVSD0orQyk3IQtrqrcxM83V7CMaiRjEVkuPjco8ON1AJqxrp8lH6g5Fw67V6FjiOqSO75vy9KdnnxPV97V1mB9ZVOPGfuqHe66UtnCQ3LT5iPB0FZc9oKaw3QGkUTAbL1Oj39Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3QzA8F508UezYYdGBQ4oCvQ6R5cF9dHRcx1VzHFPEZg=; b=cPj6zcvpg2ko/i+5rj6w5FJYf5bfQ2wpDp+FkdVADQn+GNDMh4+GyNbBuh0KdMgZ69XfiXbRVZ6fiNawcCnsjdf2+hNv7THL+eRk4jtRH8sNKPUy3QAMokIpNAQKjyp4n0K83Y1LDN1vmQNQ3X9FBsIWMlwQk2lOLEsS5yjNRtuaNt3eSGEeyoGuQSuIJ/4DzydcvELZIIQgHynW/utTRYkhtlxpXadXWmFMD9KOpbjDu3HYWNJiNI1snC+tHzfoG6Shike79td6QZLKPgCGy+RrMIIrooJfVVTT6/T0Tw2o8F6C//a4KxXegWlQgO1vCPISiU6plYuR5faU4b6Dxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3QzA8F508UezYYdGBQ4oCvQ6R5cF9dHRcx1VzHFPEZg=; b=CClxwYf7JYbnO5yytVLQk5apP02nW14VWLdgOomBcIA7FqYdnGYv/jfBOqeuJ+OaXXt99QOE6G0p8ymuelEcMuwWMneKwGOb7CF7lkhfsPwIsG14t/9I4l20CNrdo+PRlQK4GlUPuGsc1fY2sDvJ2L2Kot9MzUonP449OAOe3I8= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0504.namprd21.prod.outlook.com (2603:10b6:903:dc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.7; Wed, 15 Jul 2020 04:07:18 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::f112:82fb:d4fd:f7dd]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::f112:82fb:d4fd:f7dd%10]) with mapi id 15.20.3216.008; Wed, 15 Jul 2020 04:07:18 +0000 From: "Bret Barkelew" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sean Brogan , "Yao, Jiewen" Subject: Re: [EXTERNAL] [Patch v3 06/16] UnitTestFrameworkPkg: Use host libraries from MdePkg Thread-Topic: [EXTERNAL] [Patch v3 06/16] UnitTestFrameworkPkg: Use host libraries from MdePkg Thread-Index: AQHWVyhI4u2/c8LL1kO8J6w/eKHmVKkIDIea Date: Wed, 15 Jul 2020 04:07:18 +0000 Message-ID: References: <20200711020904.24116-1-michael.d.kinney@intel.com>,<20200711020904.24116-7-michael.d.kinney@intel.com> In-Reply-To: <20200711020904.24116-7-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-07-15T04:07:14.1048113Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [174.21.66.92] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: dfc8b114-c388-4e07-3f6a-08d8287490e2 x-ms-traffictypediagnostic: CY4PR21MB0504: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uZtQFAn7RSXc6YDwl6ijKClBWQ566GPZwysF2DHHF3igTYQY5hsk2ys5gJ9cmDACB1JBh5HhobFuqz99ADfWuZb3SXryjCwHTpQ7Y+w70lTPXsfR76fEF9w3RbNrE2IPsHYuesUaHjXYAsQHA2LN6j/XvKYuHJehhsiuFR16IwjnbCi3Qt3RABD/DD+6piE9swG3YgQjpLPJsA8z0OcUXkIeI8NUkNAkW2let/lANyLfRzIoQjPXe7oiOd1g0wAUwi2Uob6+yeqeevIN0KgpKDrsf5UCZYTbkUdhOEcxGamAeOln9H29QUAf7TtNeMSHqHAsI80zdC+bE3HON5OfJW0DznkMZ9UksM6uZQVGuZiHL/az3mcVRjHZEdQ7nmmQrj2RnrKJzGdZ5x9PzmPwmw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR21MB0743.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(186003)(4326008)(91956017)(316002)(66476007)(82950400001)(6506007)(82960400001)(76116006)(52536014)(66556008)(2906002)(64756008)(110136005)(54906003)(66946007)(8990500004)(166002)(55016002)(53546011)(9686003)(7696005)(86362001)(8676002)(5660300002)(966005)(26005)(83380400001)(10290500003)(71200400001)(478600001)(66446008)(33656002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: sIbLXo0Usj7fH9DOeGOj5lo/vSZ8Y0cwL2NqCVekeI0DlB7bZKudn1Dh8cL4CJMwvVOXOjt1yDfejxltMdFWINxQLDCRhhiKODvhu2REEsAXcWBIs00AyuuF9c8GspbW2UGtGoWTRJ2P23JD2KKWr6/iq1S9g+zgMDh6BAeP4vogV8lvG9ZGM7SAEDTTaMpIWRuG+HADV/IWgTKsNnYwUYCICAAblHKMSBNoSWuke86kiy2XrKNZflTyra+2/v8jsLpaVrgly6wE2ocQp4hLmltJWUnElS7PJR+zAGvuHs5ttltnIZz8JUSmG3NOinlaUbOpIQGvgK8UKiKgZAzICR4vC4zCqywbHNilfSCAZBASqkBCrE7sObR13sSHTJ+sI4XJoq4p2XBHfowRA7hjCtJEryxfnZ65tw9tz+xl+i9aS/NU8rf2E/o1cfGsr9QeazCgPrfjxwiXnj514U6jxWfpQZ7ZVfECZkvu8eB1lL8= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR21MB0743.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfc8b114-c388-4e07-3f6a-08d8287490e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2020 04:07:18.3199 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +m1m05wXIMB12H90iZiroZJaBWkFx/MFQRoVr2Ck6zVn5HHb6iWte2D/3wyuouGEyKQXsTC3HZW6zNfI0YreLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0504 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB0743A0253FD9D043FE778E63EF7E0CY4PR21MB0743namp_" --_000_CY4PR21MB0743A0253FD9D043FE778E63EF7E0CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret ________________________________ From: Michael D Kinney Sent: Friday, July 10, 2020 7:08:54 PM To: devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Yao, Jiewen Subject: [EXTERNAL] [Patch v3 06/16] UnitTestFrameworkPkg: Use host librari= es from MdePkg REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2800&data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7C12c2ebe65a74457d0b0508d8253f675b%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637300301533729524&sdata=3DRu4QTYif83gqk%2= BWkzmCxTXm0N4Uyh3T%2BPrTh3vr0cCE%3D&reserved=3D0 REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2799&data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7C12c2ebe65a74457d0b0508d8253f675b%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637300301533729524&sdata=3DeZtAdXCBsixYVZ6= CrZ66vDEmDgZ2Dpuh4NwN1jGjgQI%3D&reserved=3D0 REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbu= gzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2798&data=3D02%7C01%7CBret.B= arkelew%40microsoft.com%7C12c2ebe65a74457d0b0508d8253f675b%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637300301533729524&sdata=3D48f8BlgozfDlnYB= iR1G2ng610xRQhsMjHdH4VZs3njs%3D&reserved=3D0 Update the default unit test library mappings to use the library instances from the MdePkg that are safe for host based unit tests. Cc: Sean Brogan Cc: Bret Barkelew Cc: Jiewen Yao Signed-off-by: Michael D Kinney --- UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTe= stFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc index e954968efc..c22085fae1 100644 --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc @@ -9,6 +9,10 @@ !include UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc [LibraryClasses.common.HOST_APPLICATION] + BaseLib|MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf + UnitTestHostBaseLib|MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf + CpuLib|MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.inf + CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLibNull/BaseCache= MaintenanceLibNull.inf CmockaLib|UnitTestFrameworkPkg/Library/CmockaLib/CmockaLib.inf UnitTestLib|UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestLibCmocka.i= nf DebugLib|UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.= inf -- 2.21.0.windows.1 --_000_CY4PR21MB0743A0253FD9D043FE778E63EF7E0CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@microso= ft.com>

 

 

- Bret

 

From: Michael D Kinney <= michael.d.kinney@intel.com>
Sent: Friday, July 10, 2020 7:08:54 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <= ;Bret.Barkelew@microsoft.com>; Yao, Jiewen <jiewen.yao@intel.com><= br> Subject: [EXTERNAL] [Patch v3 06/16] UnitTestFrameworkPkg: Use host = libraries from MdePkg
 
REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2800&amp;data=3D02%7C01%7CBret.Ba= rkelew%40microsoft.com%7C12c2ebe65a74457d0b0508d8253f675b%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637300301533729524&amp;sdata=3DRu4QTYif83gq= k%2BWkzmCxTXm0N4Uyh3T%2BPrTh3vr0cCE%3D&amp;reserved=3D0
REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2799&amp;data=3D02%7C01%7CBret.Ba= rkelew%40microsoft.com%7C12c2ebe65a74457d0b0508d8253f675b%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637300301533729524&amp;sdata=3DeZtAdXCBsixY= VZ6CrZ66vDEmDgZ2Dpuh4NwN1jGjgQI%3D&amp;reserved=3D0
REF: https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2798&amp;data=3D02%7C01%7CBret.Ba= rkelew%40microsoft.com%7C12c2ebe65a74457d0b0508d8253f675b%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637300301533729524&amp;sdata=3D48f8BlgozfDl= nYBiR1G2ng610xRQhsMjHdH4VZs3njs%3D&amp;reserved=3D0

Update the default unit test library mappings to use the
library instances from the MdePkg that are safe for host
based unit tests.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTe= stFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
index e954968efc..c22085fae1 100644
--- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
+++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
@@ -9,6 +9,10 @@
 !include UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc
 
 [LibraryClasses.common.HOST_APPLICATION]
+  BaseLib|MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf
+  UnitTestHostBaseLib|MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf<= br> +  CpuLib|MdePkg/Library/BaseCpuLibNull/BaseCpuLibNull.inf
+  CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLibNull/Base= CacheMaintenanceLibNull.inf
   CmockaLib|UnitTestFrameworkPkg/Library/CmockaLib/CmockaLib.inf=
   UnitTestLib|UnitTestFrameworkPkg/Library/UnitTestLib/UnitTestL= ibCmocka.inf
   DebugLib|UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/Debu= gLibPosix.inf
--
2.21.0.windows.1

--_000_CY4PR21MB0743A0253FD9D043FE778E63EF7E0CY4PR21MB0743namp_--