public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: Bret Barkelew <bret@corthon.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	liming.gao <liming.gao@intel.com>
Subject: Re: [EXTERNAL] [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests
Date: Tue, 4 Aug 2020 00:22:38 +0000	[thread overview]
Message-ID: <CY4PR21MB0743A62B9B4F74CDD3DC1445EF4A0@CY4PR21MB0743.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200803225002.1235-1-brbarkel@microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 2175 bytes --]

Second version (ignore the title) of this coming soon to update the regular builds and collect the artifacts.

- Bret

From: Bret Barkelew<mailto:bret@corthon.com>
Sent: Monday, August 3, 2020 3:50 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; liming.gao<mailto:liming.gao@intel.com>
Subject: [EXTERNAL] [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests

Update the CI invocable that builds host-based unit tests to make
sure that BUILDREPORT is built for all tests. This is useful for
determining which libraries were consumed in the build.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 .pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py b/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
index f21b40caf291..43abd1f4795b 100644
--- a/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
+++ b/.pytool/Plugin/HostUnitTestCompilerPlugin/HostUnitTestCompilerPlugin.py
@@ -86,6 +86,8 @@ class HostUnitTestCompilerPlugin(ICiBuildPlugin):
     def RunBuildPlugin(self, packagename, Edk2pathObj, pkgconfig, environment, PLM, PLMHelper, tc, output_stream=None):

         self._env = environment

         environment.SetValue("CI_BUILD_TYPE", "host_unit_test", "Set in HostUnitTestCompilerPlugin")

+        environment.SetValue("BUILDREPORTING", "TRUE", "Set in HostUnitTestCompilerPlugin")

+        environment.SetValue("BUILDREPORT_TYPES", "PCD DEPEX LIBRARY BUILD_FLAGS", "Set in HostUnitTestCompilerPlugin")



         # Parse the config for required DscPath element

         if "DscPath" not in pkgconfig:

--
2.27.0.windows.1


[-- Attachment #2: Type: text/html, Size: 4514 bytes --]

      reply	other threads:[~2020-08-04  0:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 22:50 [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests Bret Barkelew
2020-08-04  0:22 ` Bret Barkelew [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR21MB0743A62B9B4F74CDD3DC1445EF4A0@CY4PR21MB0743.namprd21.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox