From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.110]) by mx.groups.io with SMTP id smtpd.web11.298.1582166504501816890 for ; Wed, 19 Feb 2020 18:41:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@microsoft.com header.s=selector2 header.b=T7A+wf2M; spf=pass (domain: microsoft.com, ip: 40.107.220.110, mailfrom: bret.barkelew@microsoft.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8KPDhNE+HTCntnWEa2YOiCdXebkO1xyW/ib4eoTQwobrwgZWhQof0M8uZAL6KXEV3MHZsFK36+HpRoIbLPccml+SwcGH+wjz5MiY9pa6OBzfBQgrlxSV0/uOlSZHbV+vZUCXhXC/aZ19lRIBdfotqDH0o4ythjTdjLCF2Jp0WD6BfE8/LQgOp8JRu/Z2jTbzxtZqA0nmYCxwQucRIY8GQti1OwBfvMHwVwubio8s8UxbTiUsKHSslUa0QeiRuxMfcqohxzZzxrwVvvcOYsnEBtGJuKYiRvIYVAzlWvyAWIhmzqJmpIVEsYFj/UvQXfgNOsC+omi6IszQT8z5SU5uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SFseQcDRiJcuYWz443wEmvgr0I+M+8sDSPiSPtbvRjU=; b=DQFfqYDfCPRdF/x1h+NAN1VEBSv6dfdkCn1KA0tLDsYDispsc9PLHl8MxbvyuSOU5zd9JNZAYK7ViTgxXh67C1ACf0f1bq6SHFqdLRJ30/rHQBMbbV0THtLd9NcNLyjGGN9LvUILBpFzV+b8RX+v704S0YYTTQ7l9GQuuVbZ7S+JqkJxfE8/Slm4tgCwFyYHSkXeuz/rcBf82mOc3Lclavx1VE0fXwJJs4UvKarCXg/xI3h49FsNAiIdSPgCybVJOvI+O/d+uwGKSzOe8IoLbq0eYiuYeQ7iQ92QC4JYTVuUbATj1qeOoVz+J0p9Hy+dOZAff1y5gW/Z3MFkwvIEJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SFseQcDRiJcuYWz443wEmvgr0I+M+8sDSPiSPtbvRjU=; b=T7A+wf2MeDUs/t/0y9nq+6TZYoesE77tSiJuWOWCuIWUZsGeKODrrJR0On1EimmeXi5wQujOXsXI/cicnDNfI/jDssHW37qKv+n0+P3NXpq0DlbaVU5n/lSuCbTx+17xTpVcgyJiIdCisTU3LAYeXTnkn6TVXT3PkToEIDH+/Ww= Received: from CY4PR21MB0743.namprd21.prod.outlook.com (2603:10b6:903:b2::9) by CY4PR21MB0152.namprd21.prod.outlook.com (2603:10b6:903:b2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.3; Thu, 20 Feb 2020 02:41:43 +0000 Received: from CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9118:22ef:23c:d0ab]) by CY4PR21MB0743.namprd21.prod.outlook.com ([fe80::9118:22ef:23c:d0ab%9]) with mapi id 15.20.2772.006; Thu, 20 Feb 2020 02:41:43 +0000 From: "Bret Barkelew" To: Laszlo Ersek , "devel@edk2.groups.io" , "Kinney, Michael D" CC: Sean Brogan Subject: Re: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file Thread-Topic: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disable EBC in DSC file Thread-Index: AQHV4LoBwUVsjIfvZkqLTLBt4QW/GKgjbRPc Date: Thu, 20 Feb 2020 02:41:43 +0000 Message-ID: References: <20200210202441.10608-1-michael.d.kinney@intel.com> <20200210202441.10608-2-michael.d.kinney@intel.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-02-20T02:41:33.9520128Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Privileged authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bret.Barkelew@microsoft.com; x-originating-ip: [174.21.64.62] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 691d9a9b-ee18-4d41-fb0f-08d7b5ae6bce x-ms-traffictypediagnostic: CY4PR21MB0152:|CY4PR21MB0152:|CY4PR21MB0152: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-forefront-prvs: 031996B7EF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(346002)(39860400002)(136003)(376002)(396003)(366004)(199004)(189003)(5660300002)(8676002)(316002)(81166006)(8990500004)(4326008)(110136005)(9686003)(55016002)(71200400001)(107886003)(81156014)(33656002)(8936002)(86362001)(26005)(52536014)(53546011)(6506007)(186003)(478600001)(7696005)(2906002)(76116006)(66946007)(66556008)(64756008)(66446008)(66476007)(10290500003)(966005);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR21MB0152;H:CY4PR21MB0743.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fHf9b3WKyCtPNKIb0L0x3648bS1a+XXuqqo6S4QZcXxU0o9jkyFS1FXGb5KMaVqCDwzoFp3wE1ToC/2jOMFWxCVDsUJxk8ct8R+eF88KIclx8GgaybXunPNfjfVZbx3fAI9Jb+NWbFVQiTpvrl5coCJ5/pse2842LpYudob4UdGdeAMruJc3HxDmsTsKx6TEVqy234pAavQC9VEQRTwVyw5yNkGy5K5phf/eeeGp2ANn0mN2J26dig1wPD3l/ssCTo9nIXDF3auoXedeTLuInQiC/XP5OM38GYGOnmhnJMfS3n9dnvcrt7ue8g2SzW9NWpQ9EHcjY9IeNRD8t5eAFJ7e4ikaAdSDVUrIV1mkNDavi/shHYj1bZe1U/ofUATXsNZ88PyjRMXyrOJGSrBv45kp37JROfm1gG/vaUabvRNZx1OHfk3VK/kK9e3x8c2zbUhRFTEuknk0hVpkIWpm5nN0GmJ8kgAzcrTFra8dxIOT6I/cVS1JIxEh18hkEzWh/n/X3C7UYiMw1l01jgNoMQ== x-ms-exchange-antispam-messagedata: 3LpiyYlYOTHMPoZ6Lm+4V77ghczzuFqTk+X3Z9PUrA5VviTXmUJLa7twJOon850AWMGzwiRpXVpuhVfWmZO8hl9he0RdPfN1J3nlun/mRSs/Lzy3wm4e28p2MxdVaat/enR5joX/2OsPjqf1J7FGZg== MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 691d9a9b-ee18-4d41-fb0f-08d7b5ae6bce X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2020 02:41:43.3138 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ss0ewiU7VR4NGAXgsddBWcwAuz26q4oYdH5lbXATd/aS8kCsJ3oFq5EnMlFMlQMWytn0zSHWwmH5WFKcvboi9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0152 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_CY4PR21MB0743A83516B8769152EC9BF4EF130CY4PR21MB0743namp_" --_000_CY4PR21MB0743A83516B8769152EC9BF4EF130CY4PR21MB0743namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bret Barkelew - Bret ________________________________ From: Laszlo Ersek Sent: Tuesday, February 11, 2020 1:02:17 AM To: devel@edk2.groups.io ; Kinney, Michael D Cc: Sean Brogan ; Bret Barkelew Subject: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPkg: Disa= ble EBC in DSC file On 02/10/20 21:24, Michael D Kinney wrote: > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzi= lla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2514&data=3D02%7C01%7Cbret.bark= elew%40microsoft.com%7Cabce6dc4e8984e69faae08d7aed12330%7C72f988bf86f141af9= 1ab2d7cd011db47%7C1%7C0%7C637170085571112419&sdata=3DJ40%2BxMF1CTlCdsZM= K4%2Fjtp2jKkSdunF1b07tU34BIk4%3D&reserved=3D0 > > Remove EBC as one of the supported architectures > in the UnitTestFrameworkPkg DSC file. The EBC > compiler does not support cararg macros and the small typo: s/cararg/vararg/ Thanks Laszlo > UnitTestLib class uses this feature. > > Cc: Sean Brogan > Cc: Bret Barkelew > Signed-off-by: Michael D Kinney > --- > UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestFram= eworkPkg/UnitTestFrameworkPkg.dsc > index 0ad4482273..53d8f52754 100644 > --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc > +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc > @@ -13,7 +13,7 @@ [Defines] > PLATFORM_VERSION =3D 1.00 > DSC_SPECIFICATION =3D 0x00010005 > OUTPUT_DIRECTORY =3D Build/UnitTestFrameworkPkg > - SUPPORTED_ARCHITECTURES =3D IA32|X64|EBC|ARM|AARCH64 > + SUPPORTED_ARCHITECTURES =3D IA32|X64|ARM|AARCH64 > BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT > SKUID_IDENTIFIER =3D DEFAULT > > --_000_CY4PR21MB0743A83516B8769152EC9BF4EF130CY4PR21MB0743namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bret Barkelew <bret.barkelew@microso= ft.com>

 

- Bret

 


From: Laszlo Ersek <lers= ek@redhat.com>
Sent: Tuesday, February 11, 2020 1:02:17 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Kinney, Micha= el D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <= ;Bret.Barkelew@microsoft.com>
Subject: [EXTERNAL] Re: [edk2-devel] [Patch 1/2] UnitTestFrameworkPk= g: Disable EBC in DSC file
 
On 02/10/20 21:24, Michael D Kinney wrote:
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzill= a.tianocore.org%2Fshow_bug.cgi%3Fid%3D2514&amp;data=3D02%7C01%7Cbret.ba= rkelew%40microsoft.com%7Cabce6dc4e8984e69faae08d7aed12330%7C72f988bf86f141a= f91ab2d7cd011db47%7C1%7C0%7C637170085571112419&amp;sdata=3DJ40%2BxMF1CT= lCdsZMK4%2Fjtp2jKkSdunF1b07tU34BIk4%3D&amp;reserved=3D0
>
> Remove EBC as one of the supported architectures
> in the UnitTestFrameworkPkg DSC file.  The EBC
> compiler does not support cararg macros and the

small typo: s/cararg/vararg/

Thanks
Laszlo

> UnitTestLib class uses this feature.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/UnitTestF= rameworkPkg/UnitTestFrameworkPkg.dsc
> index 0ad4482273..53d8f52754 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc
> @@ -13,7 +13,7 @@ [Defines]
>    PLATFORM_VERSION      =   =3D 1.00
>    DSC_SPECIFICATION      = ; =3D 0x00010005
>    OUTPUT_DIRECTORY      =   =3D Build/UnitTestFrameworkPkg
> -  SUPPORTED_ARCHITECTURES =3D IA32|X64|EBC|ARM|AARCH64
> +  SUPPORTED_ARCHITECTURES =3D IA32|X64|ARM|AARCH64
>    BUILD_TARGETS      &nb= sp;    =3D DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER      =   =3D DEFAULT

>

--_000_CY4PR21MB0743A83516B8769152EC9BF4EF130CY4PR21MB0743namp_--