public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bret Barkelew" <bret.barkelew@microsoft.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: Re: [EXTERNAL] [PATCH] .pytool: Add two keys in cspell.base.yaml
Date: Thu, 19 Mar 2020 15:10:27 +0000	[thread overview]
Message-ID: <CY4PR21MB0743B7019E4E358ED0A811D6EFF40@CY4PR21MB0743.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200319093754.18900-1-shenglei.zhang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]

Reviewed-by: Bret Barkelew <Bret.barkelew@microsoft.com>

- Bret
________________________________
From: Shenglei Zhang <shenglei.zhang@intel.com>
Sent: Thursday, March 19, 2020 2:37:54 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <liming.gao@intel.com>
Subject: [EXTERNAL] [PATCH] .pytool: Add two keys in cspell.base.yaml

In order to catch as many issues as possible in a single
pass (to allow devs to fix test failures in one commit rather than
 several), recommend increasing the max failure count and max
duplicate count in SpellCheck plugin.
REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2593&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7Cfc576b01311c475fe39008d7cbe93a55%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637202074886021018&amp;sdata=jWldOGRLBGli6KGd0D86FvWXRxHJek6nIyXTXytxgF4%3D&amp;reserved=0

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 .pytool/Plugin/SpellCheck/cspell.base.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.pytool/Plugin/SpellCheck/cspell.base.yaml b/.pytool/Plugin/SpellCheck/cspell.base.yaml
index 53000fc38141..7620dff3ceb2 100644
--- a/.pytool/Plugin/SpellCheck/cspell.base.yaml
+++ b/.pytool/Plugin/SpellCheck/cspell.base.yaml
@@ -21,6 +21,8 @@
         "*.jpg"
     ],
     "minWordLength": 5,
+    "maxNumberOfProblems": 200,
+    "maxDuplicateProblems": 200,
     "allowCompoundWords": false,
     "ignoreWords": [
         "muchange"
--
2.18.0.windows.1


[-- Attachment #2: Type: text/html, Size: 3371 bytes --]

      reply	other threads:[~2020-03-19 15:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  9:37 [PATCH] .pytool: Add two keys in cspell.base.yaml Zhang, Shenglei
2020-03-19 15:10 ` Bret Barkelew [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR21MB0743B7019E4E358ED0A811D6EFF40@CY4PR21MB0743.namprd21.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox